Reviewers: iposva, William Hesse,
Description:
Simplify the way that we compile slow-case switch statements. Compile
all the reachable tests first, and then all the reachable bodies.
Please review this at http://codereview.chromium.org/28296
SVN Base: http://v8.googlecode.com/svn/branches/blee
I think this will also need USE(rv); to avoid unused-variable warnings
in release builds.
http://codereview.chromium.org/27305
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~-
Reviewers: Mads Ager,
Description:
Check the return value of fwrite.
Newer versions of glib stdio mark fwrite() with warn_unused_result
Please review this at http://codereview.chromium.org/27305
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/log.cc
Index: src/lo
> This may cause runtime problems with W32 sockets"
> In file included from src/v8.h:55,
> from src/platform-win32.cc:84:
> src/../include/v8.h:44: error: conflicting declaration 'typedef int
> int32_t'
> src/../include/v8.h:45: error: conflicting declaration 'typedef
> unsig
Hi, all!
i'm new to v8 and i'm looking to help improve the API docs. i'm not
much interested in hacking on the engine, but i'm a madman when it
comes to writing API docs (e.g. http://s11n.net/download/#api) and i'm
finding that my biggest problem in really getting enthused about v8 is
the relativ
On Feb 27, 3:33 am, Søren Gjesse wrote:
> I guess that you are missing including stdarg.h. If you look at platform.h
> you will see that for MinGW stdarg.h is included directly in platform.h.
> If you want to use gcc on Windows I suggest that you try out MinGW as this
> should work now. Support w
Author: erik.co...@gmail.com
Date: Fri Feb 27 06:02:00 2009
New Revision: 1391
Modified:
branches/bleeding_edge/src/regexp-delay.js
branches/bleeding_edge/test/mjsunit/regexp-static.js
Log:
Fix regression in regexp-caching.html
Review URL: http://codereview.chromium.org/27273
Modified:
Author: kmilli...@chromium.org
Date: Fri Feb 27 05:49:47 2009
New Revision: 1390
Modified:
branches/bleeding_edge/test/mjsunit/mjsunit.status
Log:
Mark a flaky ARM test as flaky.
Review URL: http://codereview.chromium.org/28257
Modified: branches/bleeding_edge/test/mjsunit/mjsunit.status
=
Author: kasp...@chromium.org
Date: Fri Feb 27 03:16:43 2009
New Revision: 1385
Removed:
changes/
Log:
Get rid of the obsolete changes/ directory used by gvn.
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-
LGTM
http://codereview.chromium.org/27273
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Fix regression in regexp-caching.html
Please review this at http://codereview.chromium.org/27273
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/regexp-delay.js
M test/mjsunit/regexp-static.js
Index: test/m
Lgtm!
http://codereview.chromium.org/28257
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: plesner,
Description:
Mark a flaky ARM test as flaky.
Please review this at http://codereview.chromium.org/28257
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/mjsunit/mjsunit.status
Index: test/mjsunit/mjsunit.status
Closing this since it was fixed in the merge with toiger.
http://codereview.chromium.org/27271
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: kasp...@chromium.org
Date: Fri Feb 27 03:55:57 2009
New Revision: 1387
Modified:
branches/bleeding_edge/ChangeLog
branches/bleeding_edge/src/api.cc
Log:
Prepare push to trunk. Now working on version 1.0.4.
Review URL: http://codereview.chromium.org/31015
Modified: branches/bleed
LGTM
http://codereview.chromium.org/31015
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Prepare push to trunk. Now working on version 1.0.4.
Please review this at http://codereview.chromium.org/31015
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/api.cc
Index: src/api.cc
=
Author: kmilli...@chromium.org
Date: Fri Feb 27 01:47:27 2009
New Revision: 1382
Modified:
branches/experimental/toiger/src/codegen-arm.cc
Log:
Experimental: fix compilation error on ARM.
tbr=a...@chromium.org
Review URL: http://codereview.chromium.org/28254
Modified: branches/experimenta
Author: ipo...@chromium.org
Date: Fri Feb 27 03:19:31 2009
New Revision: 1386
Modified:
branches/bleeding_edge/src/heap.cc
branches/bleeding_edge/src/objects-debug.cc
branches/bleeding_edge/src/objects-inl.h
branches/bleeding_edge/src/objects.h
Log:
Align code entry points to 32
It look OK, but you can hold off submitting since we should pick these
changes up from the compiler branch anyway.
On Fri, Feb 27, 2009 at 12:11 PM, wrote:
>
> LGTM
>
> http://codereview.chromium.org/27271
>
> >
>
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@
LGTM
http://codereview.chromium.org/27271
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
A cosmetic change in CodeGenerator::VisitAssignment.
Please review this at http://codereview.chromium.org/27271
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/codegen-ia32.cc
Index: src/codegen-ia32.cc
==
http://codereview.chromium.org/27269/diff/1/2
File src/heap.cc (right):
http://codereview.chromium.org/27269/diff/1/2#newcode1634
Line 1634: ASSERT((obj_size % Code::kCodeAlignment) == 0);
On 2009/02/27 10:32:11, Kasper Lund wrote:
> IsAligned(obj_size, Code::kCodeAlignment) would be easier to r
Author: erik.co...@gmail.com
Date: Fri Feb 27 02:04:34 2009
New Revision: 1383
Added:
branches/bleeding_edge/test/mjsunit/regexp-string-methods.js
Modified:
branches/bleeding_edge/src/jsregexp.cc
branches/bleeding_edge/src/jsregexp.h
branches/bleeding_edge/src/macros.py
branch
LGTM.
http://codereview.chromium.org/27269/diff/1/2
File src/heap.cc (right):
http://codereview.chromium.org/27269/diff/1/2#newcode1634
Line 1634: ASSERT((obj_size % Code::kCodeAlignment) == 0);
IsAligned(obj_size, Code::kCodeAlignment) would be easier to read.
http://codereview.chromium.org/2
Author: erik.co...@gmail.com
Date: Fri Feb 27 02:16:31 2009
New Revision: 1384
Modified:
branches/bleeding_edge/test/mjsunit/regexp-string-methods.js
Log:
Add missing copyright boilerplate.
Review URL: http://codereview.chromium.org/27268
Modified: branches/bleeding_edge/test/mjsunit/regexp
Reviewers: Kasper Lund,
Description:
Align code entry points to 32 bytes.
Please review this at http://codereview.chromium.org/27269
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/heap.cc
M src/objects-inl.h
M src/objects.h
Index: s
Tusind millliarder gange tak.
http://codereview.chromium.org/27268
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
http://codereview.chromium.org/27268
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Kevin Millikin,
Description:
Add missing copyright boilerplate.
Please review this at http://codereview.chromium.org/27268
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/mjsunit/regexp-string-methods.js
Index: test/mjsunit/regexp-strin
http://codereview.chromium.org/28254
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: ,
Description:
Experimental: fix compilation error on ARM.
tbr=a...@chromium.org
Please review this at http://codereview.chromium.org/28254
SVN Base: http://v8.googlecode.com/svn/branches/experimental/toiger/
Affected files:
M src/codegen-arm.cc
Index: src/codegen-arm.cc
Comment #2 on issue 238 by kmilli...@chromium.org: Fast-case switches with
no default case can fail
http://code.google.com/p/v8/issues/detail?id=238
Fast case switches are currently disabled while I am working on a fix for
this issue.
--
You received this message because you are listed in t
Updates:
Status: Fixed
Comment #1 on issue 241 by kmilli...@chromium.org: Crash regression in
switch statements
http://code.google.com/p/v8/issues/detail?id=241
Fixed on the code generator branch in revision 1379.
--
You received this message because you are listed in the owner
or CC
LGTM for the global slot loads.
http://codereview.chromium.org/27267
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager, olehougaard,
Message:
Merge from SVN. I had to port changes in codegen-ia32.cc, functions
VisitAssignment and LoadFromGlobalSlotCheckExtensions, which you should
take a quick look at.
Description:
Experimental: periodic merge from the bleeding edge branch to the code
gener
I guess that you are missing including stdarg.h. If you look at platform.h
you will see that for MinGW stdarg.h is included directly in platform.h.
If you want to use gcc on Windows I suggest that you try out MinGW as this
should work now. Support was added with http://codereview.chromium.org/20177
37 matches
Mail list logo
