On Sun, Mar 22, 2009 at 18:43, Christian Plesner Hansen
wrote:
>
> Ivan,
> The way this is expressed in the api it effectively removes the
> distinction between externals and integers, which I would say is a Bad
> Thing(TM). As the code is now it no longer holds that
> External::Cast(x) succeeds
Updates:
Summary: Multiple crashes in test-api under debug gc-greedy
Comment #1 on issue 282 by christian.plesner.hansen: Multiple crashes in
test-api under debug gc-greedy
http://code.google.com/p/v8/issues/detail?id=282
Crashes also occur in PropertyHandler, DescriptorInheritance,
Status: Accepted
Owner:
Labels: Type-Bug Priority-Medium
New issue 282 by christian.plesner.hansen: PropertyHandler test in test-api
crashes under debug gc-greedy
http://code.google.com/p/v8/issues/detail?id=282
Reason: KERN_INVALID_ADDRESS at address: 0x0beefdac
0x001cb43c in v8::interna
Author: christian.plesner.hansen
Date: Sun Mar 22 19:25:40 2009
New Revision: 1570
Modified:
branches/bleeding_edge/test/cctest/test-api.cc
Log:
Fixed windows build.
Review URL: http://codereview.chromium.org/52004
Modified: branches/bleeding_edge/test/cctest/test-api.cc
==
Reviewers: iposva,
Message:
Post facto review - I'm submitting the code right away.
Description:
Fixed windows build.
Please review this at http://codereview.chromium.org/52004
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/cctest/test-api.cc
I
Ivan,
The way this is expressed in the api it effectively removes the
distinction between externals and integers, which I would say is a Bad
Thing(TM). As the code is now it no longer holds that
External::Cast(x) succeeds iff x->IsExternal(). This may just be an
oversight but if we change IsExte
This change seems to have caused a fairly big performance regression
on arm. Before this change the longest running test took just over a
minute, after this change 48 tests time out because they take over two
minutes.
On Sat, Mar 21, 2009 at 12:26 AM, wrote:
>
> Addressed issues except:
>
>
>
