[v8-dev] réponse aux demandes

2009-04-17 Thread Antoine LAURENT
Bonjour, Enfin à votre disposition, la production vidéo d'entreprise Low Cost. Pour répondre aux nombreuses demandes d'entreprises, commerces ou associations n'ayant pas le budget ou les moyens de faire une vidéo (présentation, diffusion sur internet, salle d'attente, magasin, dvd, publicita

[v8-dev] If an external string enters the symbol table, make sure to set the...

2009-04-17 Thread ager
Reviewers: Kasper Lund, Description: If an external string enters the symbol table, make sure to set the resource to NULL when removing it from the symbol table. This makes sure that the debugger can recognize the external string as being "deleted". Now, whenever an external resource is deleted

[v8-dev] Re: If an external string enters the symbol table, make sure to set the...

2009-04-17 Thread kasperl
LGTM. We should push this to trunk (1.1.10.2) as soon as we're confident it works well. http://codereview.chromium.org/69029 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~

[v8-dev] [v8 commit] r1735 - Push bleeding_edge revision 1734 to trunk.

2009-04-17 Thread codesite-noreply
Author: a...@chromium.org Date: Fri Apr 17 03:24:24 2009 New Revision: 1735 Modified: trunk/src/api.cc trunk/src/mark-compact.cc trunk/src/objects-inl.h trunk/src/objects.cc trunk/src/runtime.cc Log: Push bleeding_edge revision 1734 to trunk. Modified: trunk/src/api.cc =

[v8-dev] [v8 commit] r1734 - If an external string enters the symbol table, make sure to set the

2009-04-17 Thread codesite-noreply
Author: a...@chromium.org Date: Fri Apr 17 02:17:04 2009 New Revision: 1734 Modified: branches/bleeding_edge/src/mark-compact.cc branches/bleeding_edge/src/objects-inl.h branches/bleeding_edge/src/objects.cc branches/bleeding_edge/src/runtime.cc Log: If an external string enters

[v8-dev] * Remove unused code from codegen-arm.cc...

2009-04-17 Thread erik . corry
Reviewers: Kevin Millikin, Description: * Remove unused code from codegen-arm.cc * Fix fp ops on pre-EABI ARM targets. * Fix missing TIMEVAL_TO_TIMESPEC on Android. Please review this at http://codereview.chromium.org/77025 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affecte

[v8-dev] Re: * Remove unused code from codegen-arm.cc...

2009-04-17 Thread kmillikin
LGTM. Do we have a way of testing on all the different ARM processors we plan to support? http://codereview.chromium.org/77025 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~

[v8-dev] Re: * Remove unused code from codegen-arm.cc...

2009-04-17 Thread Erik Corry
2009/4/17 > LGTM. > > Do we have a way of testing on all the different ARM processors we plan > to support? > Yes. :-) -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~

[v8-dev] [v8 commit] r1736 - * Remove unused code from codegen-arm.cc

2009-04-17 Thread codesite-noreply
Author: erik.co...@gmail.com Date: Fri Apr 17 06:27:36 2009 New Revision: 1736 Modified: branches/bleeding_edge/src/codegen-arm.cc branches/bleeding_edge/src/platform-linux.cc Log: * Remove unused code from codegen-arm.cc * Fix fp ops on pre-EABI ARM targets. * Fix missing TIMEVAL_TO_TIM

[v8-dev] Lint.

2009-04-17 Thread erik . corry
Reviewers: Kevin Millikin, Description: Lint. Please review this at http://codereview.chromium.org/77026 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M src/platform-linux.cc Index: src/platform-linux.cc

[v8-dev] Re: Lint.

2009-04-17 Thread Kevin Millikin
That would look good to me. On Fri, Apr 17, 2009 at 3:35 PM, wrote: > > Reviewers: Kevin Millikin, > > Description: > Lint. > > Please review this at http://codereview.chromium.org/77026 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: > M src/platform

[v8-dev] Improve coverage of line 619 in stub-cache-arm.cc

2009-04-17 Thread erik . corry
Reviewers: Kevin Millikin, Description: Improve coverage of line 619 in stub-cache-arm.cc Please review this at http://codereview.chromium.org/77028 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/mjsunit/constant-folding.js Index: test/mjsunit/co

[v8-dev] Re: Improve coverage of line 619 in stub-cache-arm.cc

2009-04-17 Thread Kevin Millikin
LGTM. On Fri, Apr 17, 2009 at 4:07 PM, wrote: > Reviewers: Kevin Millikin, > > Description: > Improve coverage of line 619 in stub-cache-arm.cc > > Please review this at http://codereview.chromium.org/77028 > > SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ > > Affected files: >

[v8-dev] [v8 commit] r1737 - Lint.

2009-04-17 Thread codesite-noreply
Author: erik.co...@gmail.com Date: Fri Apr 17 06:57:15 2009 New Revision: 1737 Modified: branches/bleeding_edge/src/platform-linux.cc Log: Lint. Review URL: http://codereview.chromium.org/77026 Modified: branches/bleeding_edge/src/platform-linux.cc ==

[v8-dev] [v8 commit] r1738 - Improve coverage of line 619 in stub-cache-arm.cc

2009-04-17 Thread codesite-noreply
Author: erik.co...@gmail.com Date: Fri Apr 17 07:34:35 2009 New Revision: 1738 Modified: branches/bleeding_edge/test/mjsunit/constant-folding.js Log: Improve coverage of line 619 in stub-cache-arm.cc Review URL: http://codereview.chromium.org/77028 Modified: branches/bleeding_edge/test/mjsu

[v8-dev] Re: Implemented Profile object that processes profiling events and calculates profiling data.

2009-04-17 Thread sgjesse
LGTM! http://codereview.chromium.org/77014/diff/1/2 File test/mjsunit/tools/profile.js (right): http://codereview.chromium.org/77014/diff/1/2#newcode87 Line 87: ProfileTestDriver.prototype.enter = function(funcName) { Please add a comment about TOS being in stack_[0] therefore unshith/shits is

[v8-dev] Re: If an external string enters the symbol table, make sure to set the...

2009-04-17 Thread Søren Gjesse
Thank you for taking care of this. I will find a better solution for finding scripts. As a start making the debugger keep weak references to all scripts should work. This will also make the retreival of scripts much faster, and provide the debugger with the ability to give notifications when script

[v8-dev] Implemented a CSV parser in JavaScript.

2009-04-17 Thread mikhail . naganov
Reviewers: Søren Gjesse, Description: Implemented a CSV parser in JavaScript. Please review this at http://codereview.chromium.org/67253 Affected files: A test/mjsunit/tools/csvparser.js A tools/csvparser.js --~--~-~--~~~---~--~~ v8-dev mailing list v8-de

[v8-dev] Re: Implemented Profile object that processes profiling events and calculates profiling data.

2009-04-17 Thread mikhail . naganov
http://codereview.chromium.org/77014/diff/1/2 File test/mjsunit/tools/profile.js (right): http://codereview.chromium.org/77014/diff/1/2#newcode87 Line 87: ProfileTestDriver.prototype.enter = function(funcName) { On 2009/04/17 16:27:25, Søren Gjesse wrote: > Please add a comment about TOS being in

[v8-dev] Re: Implemented a CSV parser in JavaScript.

2009-04-17 Thread sgjesse
LGTM http://codereview.chromium.org/67253 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] [v8 commit] r1739 - Implemented Profile object that processes profiling events and calculates profiling data.

2009-04-17 Thread codesite-noreply
Author: mikhail.naga...@gmail.com Date: Fri Apr 17 10:40:52 2009 New Revision: 1739 Added: branches/bleeding_edge/test/mjsunit/tools/profile.js branches/bleeding_edge/tools/profile.js Modified: branches/bleeding_edge/tools/codemap.js Log: Implemented Profile object that processes pro

[v8-dev] [v8 commit] r1740 - Implemented a CSV parser in JavaScript.

2009-04-17 Thread codesite-noreply
Author: mikhail.naga...@gmail.com Date: Fri Apr 17 10:58:14 2009 New Revision: 1740 Added: branches/bleeding_edge/test/mjsunit/tools/csvparser.js branches/bleeding_edge/tools/csvparser.js Log: Implemented a CSV parser in JavaScript. Review URL: http://codereview.chromium.org/67253 Adde

[v8-dev] Add a "read" extension to the shell programs. This global function...

2009-04-17 Thread iposva
Reviewers: Søren Gjesse, Description: Add a "read" extension to the shell programs. This global function reads the contents of a file into a string and returns it. Please review this at http://codereview.chromium.org/67262 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected

[v8-dev] Re: Add a "read" extension to the shell programs. This global function...

2009-04-17 Thread mikhail . naganov
LGTM Thanks for doing this! I'll use it immediately for my tickprocessor rewrite. http://codereview.chromium.org/67262/diff/1/2 File samples/shell.cc (right): http://codereview.chromium.org/67262/diff/1/2#newcode142 Line 142: // function is called. Loadsits argument file into a JavaScript str

[v8-dev] Re: Add a "read" extension to the shell programs. This global function...

2009-04-17 Thread iposva
http://codereview.chromium.org/67262/diff/1/2 File samples/shell.cc (right): http://codereview.chromium.org/67262/diff/1/2#newcode142 Line 142: // function is called. Loadsits argument file into a JavaScript string. On 2009/04/17 20:46:17, Mikhail Naganov wrote: > Nit: missing space in "Loadsit

[v8-dev] [v8 commit] r1741 - Add a "read" extension to the shell programs. This global function

2009-04-17 Thread codesite-noreply
Author: ipo...@chromium.org Date: Fri Apr 17 14:04:34 2009 New Revision: 1741 Modified: branches/bleeding_edge/samples/shell.cc branches/bleeding_edge/src/d8.cc branches/bleeding_edge/src/d8.h Log: Add a "read" extension to the shell programs. This global function reads the contents

[v8-dev] Accompany debugger commands with senders data

2009-04-17 Thread yurys
Reviewers: Søren Gjesse, Description: As long as all debugger messages are handled by a single static method we need a way to identify request sender to route the response to the right handler. To accomplish this clients can send some additional data along with command text and debugger will later

[v8-dev] Re: Accompany debugger commands with senders data

2009-04-17 Thread sgjesse
LGTM Thank you for cleaning this up. You will need to look at the tests in test-debug.cc though. http://codereview.chromium.org/67266/diff/1/2 File include/v8-debug.h (right): http://codereview.chromium.org/67266/diff/1/2#newcode81 Line 81: class Deletable { How about another name like Client

[v8-dev] Re: Add SCons build option to control Microsoft Visual C++ link-time code generation

2009-04-17 Thread iposva
Makes sense to me. -ip http://codereview.chromium.org/69026 --~--~-~--~~~---~--~~ v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev -~--~~~~--~~--~--~---

[v8-dev] Add ENABLE_DEBUGGER_SUPPORT macro....

2009-04-17 Thread feng
Reviewers: Søren Gjesse, Description: Add ENABLE_DEBUGGER_SUPPORT macro. ENABLE_DEBUGGER_SUPPORT is enabled by default unless it is on Android platform. On Android platform, it can also enabled by passing -DENABLE_DEBUGGER_SUPPORT flag to the compiler. This should not affect any existing build (

[v8-dev] Re: Add ENABLE_DEBUGGER_SUPPORT macro....

2009-04-17 Thread sgjesse
LGTM It is nasty with all these #ifdef's, but they are somewhat grouped together. I will refactor to get rid of them going forward. You should remember to exclude debug-delay.js and mirror-delay.js when building without debugger enabled. http://codereview.chromium.org/77035/diff/1/32 File src/

[v8-dev] [v8 commit] r1742 - Add an option to the SCons build to control Microsoft Visual C++ link-time code generation.

2009-04-17 Thread codesite-noreply
Author: sgje...@chromium.org Date: Fri Apr 17 17:03:15 2009 New Revision: 1742 Modified: branches/bleeding_edge/SConstruct Log: Add an option to the SCons build to control Microsoft Visual C++ link-time code generation. Turning off Microsoft Visual C++ link-time code generation makes link