LGTM
http://codereview.chromium.org/112066/diff/1/4
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/112066/diff/1/4#newcode74
Line 74: // REX.W is set.
For completeness, you might write that REX.X is clear.
http://codereview.chromium.org/112066/diff/1/4#newcode84
Line
LGTM
http://codereview.chromium.org/115262/diff/22/24
File src/debug.h (right):
http://codereview.chromium.org/115262/diff/22/24#newcode291
Line 291: static void set_interrupt_pending(InterruptFlag what) {
Plural-singular discrepancy between comment and function name.
http://codereview.chromiu
Reviewers: Søren Gjesse,
Description:
fix embedded vector copy constructor and assignment.
Thanks to Tobias Kaes, an issue with default copy constructor and
assignment operator is found and fixed.
BUG=http://code.google.com/p/v8/issues/detail?id=358
Please review this at http://codereview.chrom
http://codereview.chromium.org/115262/diff/22/24
File src/debug.h (right):
http://codereview.chromium.org/115262/diff/22/24#newcode291
Line 291: static void set_interrupt_pending(InterruptFlag what) {
On 2009/05/29 08:10:28, Erik Corry wrote:
> Plural-singular discrepancy between comment and fun
http://codereview.chromium.org/112066/diff/1/4
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/112066/diff/1/4#newcode74
Line 74: // REX.W is set.
On 2009/05/29 07:41:55, Lasse Reichstein wrote:
> For completeness, you might write that REX.X is clear.
Done.
http://code
Author: sgje...@chromium.org
Date: Fri May 29 01:42:02 2009
New Revision: 2074
Modified:
branches/bleeding_edge/src/debug.cc
branches/bleeding_edge/src/debug.h
branches/bleeding_edge/src/execution.cc
branches/bleeding_edge/src/ia32/regexp-macro-assembler-ia32.cc
branches/bleed
Author: sgje...@chromium.org
Date: Fri May 29 01:50:05 2009
New Revision: 2075
Modified:
branches/bleeding_edge/src/execution.cc
Log:
Removed unused variable to fix Linux build.
tbr=erik.co...@gmail.com
Review URL: http://codereview.chromium.org/115917
Modified: branches/bleeding_edge/src/
Reviewers: Erik Corry,
Description:
Removed unused variable to fix Linux build.
tbr=erik.co...@gmail.com
Committed: http://code.google.com/p/v8/source/detail?r=2075
Please review this at http://codereview.chromium.org/115917
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affe
Author: whe...@chromium.org
Date: Fri May 29 01:56:31 2009
New Revision: 2076
Modified:
branches/bleeding_edge/src/x64/assembler-x64-inl.h
branches/bleeding_edge/src/x64/assembler-x64.cc
branches/bleeding_edge/src/x64/assembler-x64.h
Log:
Add test, neg, and not instructions to x64 as
yesh yesh
2009/5/29 :
> Reviewers: Erik Corry,
>
> Description:
> Removed unused variable to fix Linux build.
>
> tbr=erik.co...@gmail.com
>
> Committed: http://code.google.com/p/v8/source/detail?r=2075
>
> Please review this at http://codereview.chromium.org/115917
>
> SVN Base: http://v8.googl
LGTM!
Great to get this fixed!
http://codereview.chromium.org/113992
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: mikhail.naga...@gmail.com
Date: Fri May 29 02:00:39 2009
New Revision: 2077
Modified:
branches/bleeding_edge/src/utils.h
branches/bleeding_edge/test/cctest/test-utils.cc
Log:
fix embedded vector copy constructor and assignment.
Thanks to Tobias Kaes, an issue with default copy c
Updates:
Status: Fixed
Comment #6 on issue 358 by mikhail.naganov: Irregular crash in profiler test
http://code.google.com/p/v8/issues/detail?id=358
Excellent work Tobias! Sorry I was lazy and yesterday ran the test only
about 5
times. When I ran it for a 1000 times, I got crashes too.
Reviewers: Søren Gjesse,
Description:
Use uint in ProfLazyMode test when measuring time delta.
While testing ProfLazyMode stability I encountered a situation when the
cycle supposed to run for 200 ms started to run "infinitely" because
delta between two int64_t values became negative.
Please rev
LGTM
http://codereview.chromium.org/115918
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Kasper Lund,
Description:
Prepare for push to trunk. We are now working on 1.2.7.
Please review this at http://codereview.chromium.org/113994
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: src/versio
Author: mikhail.naga...@gmail.com
Date: Fri May 29 02:33:53 2009
New Revision: 2078
Modified:
branches/bleeding_edge/test/cctest/test-log.cc
Log:
Use uint in ProfLazyMode test when measuring time delta.
While testing ProfLazyMode stability I encountered a situation when the
cycle supposed
There are several levels of GC that are possible.
I would look at the --expose-gc flag, which is implemented in
GCExtension::GC (calling Heap::CollectAllGarbage()). But there are
other relevant GC functions, see heap.h.
On Fri, May 29, 2009 at 2:15 AM, meryl wrote:
>
> I understand V8 has it ow
LGTM.
http://codereview.chromium.org/115860/diff/10/12
File src/assembler.cc (right):
http://codereview.chromium.org/115860/diff/10/12#newcode186
Line 186: data_delta = data_delta >> kBitsPerByte;
On 2009/05/28 13:16:09, William Hesse wrote:
> ArithmeticShiftRight is defined for ints, not intpt
This looks good to me. Can I get you to complete the formalities listed
on the contributor's page?:
http://code.google.com/p/v8/wiki/Contributing
http://codereview.chromium.org/113897
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups
Reviewers: William Hesse,
Message:
Small review.
Description:
X64: Added jmp and call and nop(n) to X64 assembler.
Please review this at http://codereview.chromium.org/115920
Affected files:
M src/ia32/assembler-ia32.cc
M src/x64/assembler-x64-inl.h
M src/x64/assembler-x64.h
M src
LGTM.
http://codereview.chromium.org/113994
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: sgje...@chromium.org
Date: Fri May 29 03:52:00 2009
New Revision: 2079
Modified:
branches/bleeding_edge/ChangeLog
branches/bleeding_edge/src/version.cc
Log:
Prepare for push to trunk. We are now working on 1.2.7.
Review URL: http://codereview.chromium.org/113994
Modified: branch
http://codereview.chromium.org/115920/diff/1/2
File src/ia32/assembler-ia32.cc (right):
http://codereview.chromium.org/115920/diff/1/2#newcode1491
Line 1491: emit_rex_64(adr);
I don't think this belongs in the ia32 compiler.
http://codereview.chromium.org/115920/diff/1/3
File src/x64/assembler-
Added test to test-utils.cc
http://codereview.chromium.org/115860/diff/10/12
File src/assembler.cc (right):
http://codereview.chromium.org/115860/diff/10/12#newcode186
Line 186: data_delta = data_delta >> kBitsPerByte;
On 2009/05/29 09:43:37, Kevin Millikin wrote:
> On 2009/05/28 13:16:09, Will
okay, I've signed the "Google Individual Contributor License Agreement"
http://codereview.chromium.org/113897
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~
Reviewers: ,
Message:
Oops - remove ia32 changes from this changelist, or else define
V8_INT64_C for all platforms, not just 64-bit platforms.
Description:
Add miscellaneous operations to x64 assembler.
Please review this at http://codereview.chromium.org/113997
SVN Base: http://v8.googlecode.
Fast progress on the assembler. Some drive-by comments.
http://codereview.chromium.org/115920/diff/1/4
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/115920/diff/1/4#newcode600
Line 600: void Assembler::nop(int n) {
It is unclear how you are implemenenting nops of variou
Updates:
Status: WorkingAsIntended
Comment #1 on issue 230 by sgje...@chromium.org: Latest debugger changes
break Chromium debugger tests
http://code.google.com/p/v8/issues/detail?id=230
These debugger tests in Chromium are now invalid as the debugger console is
replaced
by the new d
Author: whe...@chromium.org
Date: Fri May 29 05:14:54 2009
New Revision: 2081
Modified:
branches/bleeding_edge/src/assembler.cc
branches/bleeding_edge/src/assembler.h
branches/bleeding_edge/src/globals.h
branches/bleeding_edge/test/cctest/test-utils.cc
Log:
Change RelocInfo to wr
http://codereview.chromium.org/115918/diff/1/2
File test/cctest/test-log.cc (right):
http://codereview.chromium.org/115918/diff/1/2#newcode173
Line 173: while ((delta = i::OS::Ticks() - started_us) < 200 * 1000) {
The condition should really be
(ended_us = ticks()) < started_us + 200 * 1000)
del
http://codereview.chromium.org/115920/diff/1/3
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/115920/diff/1/3#newcode76
Line 76: emit(0x48 | (reg.code() >> 3));
I agree that there should be only one implementation.
I would prefer it to be the one taking a numeric argume
Reviewers: Erik Corry,
Description:
Activate the debugger in the developer shell earlier.
This will support breaking in debugger statements in JavaScript files
read from the command line.
Please review this at http://codereview.chromium.org/113998
SVN Base: http://v8.googlecode.com/svn/branche
http://codereview.chromium.org/115918/diff/1/2
File test/cctest/test-log.cc (right):
http://codereview.chromium.org/115918/diff/1/2#newcode173
Line 173: while ((delta = i::OS::Ticks() - started_us) < 200 * 1000) {
On 2009/05/29 12:19:49, William Hesse wrote:
> The condition should really be
> (e
LGTM. Comments are optional changes.
http://codereview.chromium.org/115920/diff/1008/1010
File src/x64/assembler-x64-inl.h (right):
http://codereview.chromium.org/115920/diff/1008/1010#newcode77
Line 77: emit(0x48 | (rm_reg.code() >> 3));
There was never a good reason for putting these in -inl
I don't think either is really correct. The implementation of OS::Tick
can wrap around ways before reaching the int64 or uint64 limit because
its implementation eg. on windows has a max value of uint32*1000 and
then starts over with zero
So when started_us is before and ended_us after an OS::Tick
http://codereview.chromium.org/115920/diff/1008/1011
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/115920/diff/1008/1011#newcode275
Line 275: ASSERT_EQ(rm & 0x07, rm);
I'd rather fail than silently correct errors. The caller should know
that the argument is valid.
http:/
OK, I see now why the cast to unsigned worked. OS::Tick is non-monotonic on
Windows
(wraps every 50 days), and so you want to end if either 200 ms is up or the
timer has wrapped.
This is the case diff > 200 or diff < 0. Casting to unsigned makes the diff
< 0 case wrap to diff > 200. This is tric
What I am saying is that the int version should take any int, and mask off
all but 3 bits.
Then it is safer, and can take the register code directly when implementing
the register version.
On Fri, May 29, 2009 at 3:13 PM, wrote:
>
> http://codereview.chromium.org/115920/diff/1008/1011
> File sr
Or I can use OS::TimeCurrentMillis which returns milliseconds as
'double', avoiding these int64_t traps.
On Fri, May 29, 2009 at 5:29 PM, William Hesse wrote:
> OK, I see now why the cast to unsigned worked. OS::Tick is non-monotonic on
> Windows
> (wraps every 50 days), and so you want to end
Reviewers: William Hesse,
Description:
Fix wait interval calculation in ProfLazyMode test.
Also, add a small delay to be sure that all ticks are logged prior to
leaving CheckThatProfilerWorks function.
Please review this at http://codereview.chromium.org/114062
Affected files:
M test/cctest
LGTM. Sticks the landing.
http://codereview.chromium.org/114062
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Author: mikhail.naga...@gmail.com
Date: Fri May 29 08:33:02 2009
New Revision: 2082
Modified:
branches/bleeding_edge/test/cctest/test-log.cc
Log:
Fix wait interval calculation in ProfLazyMode test.
Also, add a small delay to be sure that all ticks are logged prior to
leaving CheckThatProf
Actually it wraps around every 70 minutes ... which explains why you've hit
the infinite loop bug (the chance of hitting the 200ms timeframe once in 50
days sounded too low!)
OS::Tick (win32) performs the multiplication as uint32 and only afterwards
does the cast to int64 (verified on VS2008, don'
Status: New
Owner:
New issue 364 by streametch: Fail to Compiling V8 in chromium
http://code.google.com/p/v8/issues/detail?id=364
Detailed description of the issue.
I trying to build chromium from last svn at this moment. I use Debian
squeeze i386. All requisites packages for build are inst
Updates:
Status: Assigned
Owner: a...@chromium.org
Comment #1 on issue 364 by a...@chromium.org: Fail to Compiling V8 in
chromium
http://code.google.com/p/v8/issues/detail?id=364
I'll add a couple of parenthesis.
--
You received this message because you are listed in the owner
Author: a...@chromium.org
Date: Fri May 29 12:17:48 2009
New Revision: 2083
Modified:
branches/bleeding_edge/src/debug.cc
Log:
Add a couple of parenthesis to improve readability and please certain
GCC version.
BUG=364
tbr=sgje...@chromium.org
Review URL: http://codereview.chromium.org/11801
Author: a...@chromium.org
Date: Fri May 29 12:20:16 2009
New Revision: 2084
Modified:
trunk/src/debug.cc
trunk/src/version.cc
Log:
Push bleeding_edge r2083 to trunk. The only change is the addition of
a couple of parenthesis to please certain versions of GCC.
tbr=sgje...@chromium.org
R
Comment #2 on issue 364 by a...@chromium.org: Fail to Compiling V8 in
chromium
http://code.google.com/p/v8/issues/detail?id=364
I have added a couple of parenthesis in v8 revision 2083 and will update
the version
of v8 in Chromium ASAP.
--
You received this message because you are listed in
LGTM
Sorry about missing that.
http://codereview.chromium.org/118016
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Comment #3 on issue 364 by streametch: Fail to Compiling V8 in chromium
http://code.google.com/p/v8/issues/detail?id=364
So I add in report gcc version:
k...@hfwdima:~/home/chrome-svn/tarball/chromium/src/build$ gcc --version
gcc (Debian 4.3.3-10) 4.3.3
--
You received this message because you
Updates:
Status: Fixed
Comment #4 on issue 364 by a...@chromium.org: Fail to Compiling V8 in
chromium
http://code.google.com/p/v8/issues/detail?id=364
Fix landed in Chromium revision 17252.
--
You received this message because you are listed in the owner
or CC fields of this issue, or
Comment #5 on issue 364 by streametch: Fail to Compiling V8 in chromium
http://code.google.com/p/v8/issues/detail?id=364
Thanks a lot, now it's works fine for me. You fix this issue very
quickly :) Good job
--
You received this message because you are listed in the owner
or CC fields of this
Hi,
How to compile V8 source under MacOS? And how can I pass a test
javascript file for it to execute?
Thank you.
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~-
54 matches
Mail list logo
