Updates:
Status: Duplicate
Mergedinto: 164
Comment #2 on issue 422 by sgje...@chromium.org: Order of object properties
in a for..in loop is not in insertion order
http://code.google.com/p/v8/issues/detail?id=422
(No comment was entered for this change.)
--
You received this me
Comment #5 on issue 164 by sgje...@chromium.org: Wrong order in Object
properties interation
http://code.google.com/p/v8/issues/detail?id=164
Issue 422 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you
Comment #1 on issue 422 by kasp...@chromium.org: Order of object properties
in a for..in loop is not in insertion order
http://code.google.com/p/v8/issues/detail?id=422
Just a quick comment: The latest V8 doesn't have the behavior you mention.
It sorts
the properties with array-index keys be
On 2009/08/12 15:07:10, tfarina wrote:
> On 2009/08/12 07:04:23, Christian Plesner Hansen wrote:
> > I'm unclear on why all the operator*s should return const types.
> >
> > http://codereview.chromium.org/165208/diff/1/2
> > File include/v8.h (right):
> >
> > http://codereview.chromium.org/165208/
Status: New
Owner:
New issue 422 by d...@google.com: Order of object properties in a for..in
loop is not in insertion order
http://code.google.com/p/v8/issues/detail?id=422
In v8, the order of iteration of javascript properties in a for..in loop is
not the insertion order of object proper
Revision: 2686
Author: f...@chromium.org
Date: Thu Aug 13 15:13:45 2009
Log: Revert http://code.google.com/p/v8/source/detail?r=2670
Now we can pass '--expose_gc' to V8 in the layout test controller. This is
probably a better option.
Review URL: http://codereview.chromium.org/164520
http://cod
LGTMA -ip
http://codereview.chromium.org/164520
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
In case you feel like digging, the aliasing rules are 3.10 paragraph 15
of the C++ (n1905) spec.
On 2009/08/13 18:49:06, Dean McNamee wrote:
http://codereview.chromium.org/164498
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.g
Reviewers: Mads Ager, agl,
Description:
Fix strict aliasing crash on x64.
Please review this at http://codereview.chromium.org/164498
Affected files:
M SConstruct
M src/handles-inl.h
M src/handles.h
Index: SConstruct
diff --git a/SConstruct b/SConstruct
index
c981ef91398778d152e920
On Wed, Aug 12, 2009 at 11:32 AM, Kevin Millikin wrote:
> There's also an API call to change those parameters. A few months ago
> (probably about 6 I guess) it was working, from the command line, with and
> without snapshots.
OK - good to know.
>
> What doesn't work and probably crashes is if
Revision: 2685
Author: b...@chromium.org
Date: Thu Aug 13 07:58:35 2009
Log: Changed Heap::Shrink to free as many pages as possible.
As a benefit, this eliminates an ifdef ARDROID.
Review URL: http://codereview.chromium.org/165453
http://code.google.com/p/v8/source/detail?r=2685
Modified:
/bra
LGTM
http://codereview.chromium.org/165453
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2684
Author: whe...@chromium.org
Date: Thu Aug 13 07:04:49 2009
Log: erikcorry: Remember to put objects back in fast case after adding
functions.
P.S. for reasons unknown the original change (2681), also by erikcorry,
was attributed to Bill.
Review URL: http://codereview.chromium.org/1
Revision: 2683
Author: mikhail.naga...@gmail.com
Date: Thu Aug 13 07:03:12 2009
Log: Fix mac-nm script to support filenames w/spaces
Review URL: http://codereview.chromium.org/164476
http://code.google.com/p/v8/source/detail?r=2683
Modified:
/branches/bleeding_edge/tools/mac-nm
=
LGTM
http://codereview.chromium.org/164476
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Changed Heap::Shrink to free as many pages as possible.
As a benefit, this eliminates an ifdef ARDROID.
Please review this at http://codereview.chromium.org/165453
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/sp
LGTM
http://codereview.chromium.org/164479
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Erik Corry,
Description:
X64: Do not use an AllocateWithoutSpill register if it is invalid.
Please review this at http://codereview.chromium.org/164480
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/codegen-x64.cc
Index: src/x64/cod
http://codereview.chromium.org/164472/diff/1/2
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/164472/diff/1/2#newcode1611
Line 1611: EnsureSpace ensure_space(this);
On 2009/08/13 12:12:27, Lasse Reichstein wrote:
> Move ensure_space below the call to testb, which has its o
LGTM
http://codereview.chromium.org/165443/diff/42/1004
File src/ia32/regexp-macro-assembler-ia32.cc (right):
http://codereview.chromium.org/165443/diff/42/1004#newcode1165
Line 1165: Address new_stack_top = RegExpStack::EnsureCapacity(size *
2);
Shouldn't new_stack_top be new_stack_base?
http
Reviewers: Mads Ager,
Description:
erikcorry: Remember to put objects back in fast case after adding
functions.
P.S. for reasons unknown the original change (2681), also by erikcorry,
was attributed to Bill.
Please review this at http://codereview.chromium.org/164479
SVN Base: http://v8.googlec
Addressed comments
http://codereview.chromium.org/165443/diff/42/1014
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/165443/diff/42/1014#newcode449
Line 449: void Assembler::arithmetic_op_16(byte opcode, Register dst,
Register src) {
Done
http://codereview.chromium.org/1
Reviewers: Søren Gjesse,
Description:
fix nm script
Please review this at http://codereview.chromium.org/164476
Affected files:
M tools/mac-nm
Index: tools/mac-nm
diff --git a/tools/mac-nm b/tools/mac-nm
index
9c181779780bef5454cd06e4d4ee74dbfd20005d..07efb07bae8eb5cd276340f8265e7c3a87348
Revision: 2682
Author: a...@chromium.org
Date: Thu Aug 13 05:44:13 2009
Log: Push version 1.3.4 to trunk.
Added a readline() command to the d8 shell.
Fixed bug in json parsing.
Added idle notification to the API and reduced memory on idle notifications.
Review URL: http://codereview.chromium.o
Revision: 2681
Author: whe...@chromium.org
Date: Thu Aug 13 05:35:59 2009
Log: Avoid map transitions and multiple backing arrays for builtin
prototypes
while adding functions and other properties. This gives around 2% on
context-create, more if we don't GC on every new context. Also fix
accoun
Lgtm
http://codereview.chromium.org/164475
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2680
Author: whe...@chromium.org
Date: Thu Aug 13 05:35:09 2009
Log: X64: Change testl to testb if mask fits in 1 byte. Shortens smi test.
Review URL: http://codereview.chromium.org/164472
http://code.google.com/p/v8/source/detail?r=2680
Modified:
/branches/bleeding_edge/src/x64/asse
Updates:
Labels: -Type-Bug -Priority-Medium Type-FeatureRequest Priority-Low
Area-Irregexp
Comment #1 on issue 421 by l...@chromium.org: Native regexp string comparison
http://code.google.com/p/v8/issues/detail?id=421
(No comment was entered for this change.)
--
You received this mess
Status: Accepted
Owner: l...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 421 by l...@chromium.org: Native regexp string comparison
http://code.google.com/p/v8/issues/detail?id=421
Combine character compares to do 4 or 8 at a time for a long literal,
instead
of checking one characte
Reviewers: Christian Plesner Hansen,
Description:
Push version 1.3.4 to trunk.
Added a readline() command to the d8 shell.
Fixed bug in json parsing.
Added idle notification to the API and reduced memory on idle
notifications.
Please review this at http://codereview.chromium.org/164475
SVN
Status: Accepted
Owner: mikhail.naganov
Labels: Type-Bug Priority-Medium OS-All
New issue 420 by mikhail.naganov: JS tick processor script fails on
incomplete log files
http://code.google.com/p/v8/issues/detail?id=420
Log files can finish abruptly with log event cut in the middle. This breaks
Revision: 2679
Author: a...@chromium.org
Date: Thu Aug 13 05:21:11 2009
Log: Prepare push to trunk to get JSON parser fix into Chromium.
Now working on version 1.3.5.
Review URL: http://codereview.chromium.org/164474
http://code.google.com/p/v8/source/detail?r=2679
Modified:
/branches/bleeding
Lgtm
http://codereview.chromium.org/164474/diff/1/3
File ChangeLog (right):
http://codereview.chromium.org/164474/diff/1/3#newcode10
Line 10: Implemented more arithmetic operation optimizations on x64.
I wouldn't mention this.
http://codereview.chromium.org/164474
--~--~-~--~~
Reviewers: Christian Plesner Hansen,
Description:
Prepare push to trunk to get JSON parser fix into Chromium.
Now working on version 1.3.5.
Please review this at http://codereview.chromium.org/164474
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M Chang
LGTM
http://codereview.chromium.org/164472/diff/1/2
File src/x64/assembler-x64.cc (right):
http://codereview.chromium.org/164472/diff/1/2#newcode1611
Line 1611: EnsureSpace ensure_space(this);
Move ensure_space below the call to testb, which has its own
ensure_space.
http://codereview.chromium
Revision: 2678
Author: b...@chromium.org
Date: Thu Aug 13 05:13:50 2009
Log: Changed semi space Grow to be rounded to OS page size.
Review URL: http://codereview.chromium.org/164469
http://code.google.com/p/v8/source/detail?r=2678
Modified:
/branches/bleeding_edge/src/spaces.cc
==
LGTM
http://codereview.chromium.org/165449
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2677
Author: b...@chromium.org
Date: Thu Aug 13 05:03:42 2009
Log: - Added simple memory reduction behavior for IdleNotification.
- This also include a one line change approved by lrh.
http://codereview.chromium.org/164469
Review URL: http://codereview.chromium.org/165448
http://c
LGTM
http://codereview.chromium.org/165448/diff/1/3
File src/spaces.h (right):
http://codereview.chromium.org/165448/diff/1/3#newcode372
Line 372: // start is not NULL, the size is greater than zero, and that
the
and that the -> and the
http://codereview.chromium.org/165448
--~--~-~--
Reviewers: Mads Ager,
Description:
Avoid map transitions and multiple backing arrays for builtin prototypes
while adding functions and other properties. This gives around 2% on
context-create, more if we don't GC on every new context. Also fix
accounting bug in cell space.
Please review this a
Reviewers: Mads Ager,
Description:
- Added simple memory reduction behavior for IdleNotification.
- This also include a one line change approved by lrh.
http://codereview.chromium.org/164469
Please review this at http://codereview.chromium.org/165448
SVN Base: http://v8.googlecode.com/sv
Reviewers: Lasse Reichstein,
Description:
X64: Change testl to testb if mask fits in 1 byte. Shortens smi test.
Please review this at http://codereview.chromium.org/164472
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/x64/assembler-x64.cc
Index:
LGTM
On Thu, Aug 13, 2009 at 11:37, wrote:
> Reviewers: Lasse Reichstein,
>
> Description:
> Changed semi space Grow to be rounded to OS page size.
>
>
> Please review this at http://codereview.chromium.org/164469
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected fi
Revision: 2676
Author: a...@chromium.org
Date: Thu Aug 13 04:16:12 2009
Log: Merge JSON fix to 1.2 branch.
Review URL: http://codereview.chromium.org/164470
http://code.google.com/p/v8/source/detail?r=2676
Modified:
/branches/1.2/src/compiler.cc
/branches/1.2/src/compiler.h
/branches/1.2/sr
LGTM.
http://codereview.chromium.org/165443/diff/42/1016
File src/x64/regexp-macro-assembler-x64.cc (right):
http://codereview.chromium.org/165443/diff/42/1016#newcode68
Line 68: *- stack_area_top(High end of the memory area to
use as
I don't like "top" here. high_end, or backtrack
Lgtm
http://codereview.chromium.org/164470
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Christian Plesner Hansen,
Description:
Merge JSON fix to 1.2 branch.
Please review this at http://codereview.chromium.org/164470
SVN Base: http://v8.googlecode.com/svn/branches/1.2/
Affected files:
M src/compiler.h
M src/compiler.cc
M src/runtime.cc
M tes
Revision: 2675
Author: christian.plesner.han...@gmail.com
Date: Thu Aug 13 03:25:35 2009
Log: Fixed issue 19212
Fixed a bug in json parsing. Refactored compilation code a bit to
make it more obvious what's going on.
Review URL: http://codereview.chromium.org/165446
http://code.google.com/p/v8/s
LGTM!
http://codereview.chromium.org/165446
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Reviewers: Mads Ager,
Description:
Fixed issue 19212
Fixed a bug in json parsing. Refactored compilation code a bit to
make it more obvious what's going on.
Please review this at http://codereview.chromium.org/165446
Affected files:
M src/compiler.h
M src/compiler.cc
M src/runtime.cc
Reviewers: Lasse Reichstein,
Description:
Changed semi space Grow to be rounded to OS page size.
Please review this at http://codereview.chromium.org/164469
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/spaces.cc
Index: src/spaces.cc
===
Revision: 2674
Author: b...@chromium.org
Date: Thu Aug 13 02:35:51 2009
Log: Added idle notification to the API.
The implementation is still empty.
Review URL: http://codereview.chromium.org/165445
http://code.google.com/p/v8/source/detail?r=2674
Modified:
/branches/bleeding_edge/include/v8.h
http://codereview.chromium.org/165445
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
LGTM
http://codereview.chromium.org/165445
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
All files except the two new x64 ones reviewed. Will send their review
later.
http://codereview.chromium.org/165443/diff/42/1006
File src/jsregexp.cc (right):
http://codereview.chromium.org/165443/diff/42/1006#newcode469
Line 469: // If result is RETRY, the string have changed representation,
Makes sense. I'll update the code.
On Thu, Aug 13, 2009 at 10:45 AM, wrote:
> Drive-by comment.
>
>
> http://codereview.chromium.org/164397/diff/1/4
> File src/spaces.cc (right):
>
> http://codereview.chromium.org/164397/diff/1/4#newcode1079
> Line 1079: int extra = capacity_/2;
> Just a thought
Reviewers: Mads Ager,
Description:
Added idle notification to the API.
The implementation is still empty.
Please review this at http://codereview.chromium.org/165445
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M include/v8.h
M src/api.cc
M
Drive-by comment.
http://codereview.chromium.org/164397/diff/1/4
File src/spaces.cc (right):
http://codereview.chromium.org/164397/diff/1/4#newcode1079
Line 1079: int extra = capacity_/2;
Just a thought: Would it be safer to round this up to a whole number of
(OS) pages?
http://codereview.chro
Reviewers: William Hesse, Erik Corry,
Message:
Please review RegExp conversion.
I removed the unused "dispatch" functions in regexp-macro-assembler.h
and implementations, but otherwise the changes should be contained in
the x64 directory and jsregexp.cc.
Description:
X64: Implement RegExp nativ
Revision: 2673
Author: whe...@chromium.org
Date: Thu Aug 13 01:00:04 2009
Log: X64: Add an SHL optimization, fix a floating-point bug, fix xchg
rax,r8 and printing of test ?ax, imm in disassembler.
Review URL: http://codereview.chromium.org/164399
http://code.google.com/p/v8/source/detail?r=2673
Issue 353: Add readline method to d8
http://code.google.com/p/v8/issues/detail?id=353
This issue is no longer blocking issue 352.
See http://code.google.com/p/v8/issues/detail?id=352
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starre
Updates:
Blockedon: -353 -354
Comment #5 on issue 352 by christian.plesner.hansen: V8 Fails on the
Language Shootout
http://code.google.com/p/v8/issues/detail?id=352
This should have been fixed but I'm leaving it open until we can verify
that the
shootout code works as expected.
--
Issue 354: Print without newline in d8 shell
http://code.google.com/p/v8/issues/detail?id=354
This issue is no longer blocking issue 352.
See http://code.google.com/p/v8/issues/detail?id=352
--
You received this message because you are listed in the owner
or CC fields of this issue, or because yo
Comment #2 on issue 419 by whe...@chromium.org: Two handles are equal even
when they refer to different objects
http://code.google.com/p/v8/issues/detail?id=419
The handles are equal because they refer to the same object. A and B are
classes with
no members, so their instances have zero siz
http://codereview.chromium.org/164399/diff/1/2
File src/x64/disasm-x64.cc (left):
http://codereview.chromium.org/164399/diff/1/2#oldcode108
Line 108: { 0x90, UNSET_OP_ORDER, "nop" },
On 2009/08/12 20:03:37, Erik Corry wrote:
> Was this deliberate?
Yes. This instruction is handled by code, becau
Updates:
Status: Fixed
Comment #4 on issue 353 by christian.plesner.hansen: Add readline method to
d8
http://code.google.com/p/v8/issues/detail?id=353
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC fields of this issue,
Updates:
Status: Fixed
Comment #6 on issue 354 by christian.plesner.hansen: Print without newline
in d8 shell
http://code.google.com/p/v8/issues/detail?id=354
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC fields of thi
Updates:
Status: WorkingAsIntended
Comment #1 on issue 419 by christian.plesner.hansen: Two handles are equal
even when they refer to different objects
http://code.google.com/p/v8/issues/detail?id=419
You can only use handle equality to compare objects in the v8 heap. For
heap objec
Revision: 2672
Author: whe...@chromium.org
Date: Thu Aug 13 00:36:28 2009
Log: Move some arrays into functions so they don't get cloned on each new
context.
Review URL: http://codereview.chromium.org/164396
http://code.google.com/p/v8/source/detail?r=2672
Modified:
/branches/bleeding_edge/src
Status: New
Owner:
New issue 419 by piiguu: Two handles are equal even when they refer to
different objects
http://code.google.com/p/v8/issues/detail?id=419
The function below in Handle class always returns true even two handles
refer to different objects
/**
* Checks whether two
On 2009/08/13 07:00:47, Christian Plesner Hansen wrote:
> What happened to the previous code review, 115747?
> Anyway, LGTM.
Sorry, it was the same thing that happened to the last, I lost my
workspace.
http://codereview.chromium.org/162004
--~--~-~--~~~---~--~~
Landed in http://code.google.com/p/v8/source/detail?r=2671.
http://codereview.chromium.org/162004
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
Revision: 2671
Author: christian.plesner.han...@gmail.com
Date: Thu Aug 13 00:07:41 2009
Log: Add a readline() command to d8. This reads a single line, stripping
the new-line at the end. This is the other half of what is required to
make the Debian Language Shootout code work correctly:
http://cod
What happened to the previous code review, 115747?
Anyway, LGTM.
http://codereview.chromium.org/162004
--~--~-~--~~~---~--~~
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
-~--~~~~--~~--~--~---
74 matches
Mail list logo
