LGTM
http://codereview.chromium.org/471009
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Whoops. Will fix.
http://codereview.chromium.org/475003
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
apart from the extra slash in the first line
http://codereview.chromium.org/475003
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/475003
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: sgjesse,
Message:
Hi Soren
I'm preparing sample for standalone V8 application. For this sample I'd
like 2
features from Debugger Agent:
- wait until remote has connected
- flush debugger messages callback
I think I implemented the first one and I'm adding API for the second
featu
Revision: 3443
Author: ipo...@chromium.org
Date: Wed Dec 9 09:20:51 2009
Log: - Drop the executable bit of SConstruct.
Review URL: http://codereview.chromium.org/467057
http://code.google.com/p/v8/source/detail?r=3443
Modified:
/branches/bleeding_edge/SConstruct
--
v8-dev mailing list
v8-dev
Revision: 3442
Author: l...@chromium.org
Date: Wed Dec 9 08:40:54 2009
Log: Fix Win64 build problem.
Review URL: http://codereview.chromium.org/475003
http://code.google.com/p/v8/source/detail?r=3442
Modified:
/branches/bleeding_edge/src/serialize.cc
===
-
Reviewers: Erik Corry,
Message:
TBR: Erik.
Description:
Fix Win64 build problem.
Please review this at http://codereview.chromium.org/475003
Affected files:
M src/serialize.cc
Index: src/serialize.cc
diff --git a/src/serialize.cc b/src/serialize.cc
index
899e2e7a599f167dec01791a716ee1962
Updates:
Status: Fixed
Comment #1 on issue 545 by l...@chromium.org: Fast compiler crash when
using "this" in different contexts.
http://code.google.com/p/v8/issues/detail?id=545
Fixed in revision 3432.
--
You received this message because you are listed in the owner
or CC fields of th
Reviewers: Christian Plesner Hansen,
Description:
Modified SConstruct to enable building of shared library with hidden
visibility
on Mac OS X.
Please review this at http://codereview.chromium.org/475002
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M SC
Revision: 3441
Author: kmilli...@chromium.org
Date: Wed Dec 9 07:34:57 2009
Log: Fix arm and x64 build.
The ApiGetterEntryStub is not implemented on arm or x64, but the
platform-specific implementations need to change to match the change
to the platform-independent signatures.
tbr=a...@chromium.
Reviewers: Mads Ager,
Description:
Fix arm and x64 build.
The ApiGetterEntryStub is not implemented on arm or x64, but the
platform-specific implementations need to change to match the change
to the platform-independent signatures.
tbr=a...@chromium.org
Please review this at http://codereview.
Revision: 3440
Author: kmilli...@chromium.org
Date: Wed Dec 9 06:54:34 2009
Log: Fix a crash caused by garbage collection during generation of a
callback load (or keyed load) IC.
The problem was that the IC code calls a stub, which can allocate and
thus trigger a GC if the stub is not already gen
The ApiGetterEntryStub stub is not implemented on x64 or arm.
http://codereview.chromium.org/472002/diff/1/3
File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/472002/diff/1/3#newcode1444
src/ia32/stub-cache-ia32.cc:1444: Failure* failure;
On 2009/12/09 13:21:30, Mads Ager
Revision: 3439
Author: vita...@chromium.org
Date: Wed Dec 9 06:32:45 2009
Log: External string table.
Instead of weak handles external strings use a separate table. This
table uses 5 times less memory than weak handles. Moreover, since we
don't have to follow the weak handle callback protocol w
Thanks! Submitted.
-- Vitaly
http://codereview.chromium.org/467037/diff/1/7
File src/heap.cc (right):
http://codereview.chromium.org/467037/diff/1/7#newcode4060
src/heap.cc:4060: List& target = new_to_old ?
old_space_strings_ : new_space_strings_;
On 2009/12/08 16:18:40, Mads Ager wrote:
> Use
Revision: 3438
Author: erik.co...@gmail.com
Date: Wed Dec 9 05:56:58 2009
Log: Add Object.create from ECMAScript5. Supports value, writable,
enumerable, get
and set. Doesn't support configurable yet. See
http://code.google.com/p/v8/issues/detail?id=460
Review URL: http://codereview.chromium.o
LGTM. Are these not implemented in the 64-bit version or the ARM version?
http://codereview.chromium.org/472002/diff/1/3
File src/ia32/stub-cache-ia32.cc (right):
http://codereview.chromium.org/472002/diff/1/3#newcode1444
src/ia32/stub-cache-ia32.cc:1444: Failure* failure;
Initialize to interna
Revision: 3437
Author: fschnei...@chromium.org
Date: Wed Dec 9 05:06:08 2009
Log: Create literal boilerplate as part of cloning in the top-level
compiler.
When generating code for object and array literals we performed
the check if the a boilerplate already exists in generated code.
In the top
Thanks.
Comments addressed (also on x64/arm).
http://codereview.chromium.org/465148/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):
http://codereview.chromium.org/465148/diff/1/2#newcode659
src/ia32/fast-codegen-ia32.cc:659: // Registers will be used as follows:
On 2009/12/09 12:50:07, Ke
Reviewers: Mads Ager, Kasper Lund,
Description:
Fix a crash caused by garbage collection during generation of a
callback load (or keyed load) IC.
The problem was that the IC code calls a stub, which can allocate and
thus trigger a GC if the stub is not already generated. Problem is
solved by add
LGTM.
You should use the checked (in DEBUG builds) cast operator.
http://codereview.chromium.org/465148/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):
http://codereview.chromium.org/465148/diff/1/2#newcode659
src/ia32/fast-codegen-ia32.cc:659: // Registers will be used as follows:
This co
Reviewers: Kevin Millikin,
Description:
Create literal boilerplate as part of cloning in the top-level compiler.
When generating code for object and array literals we performed
the check if the a boilerplate already exists in generated code.
In the top-level compiler we now do this check in a ne
Revision: 3435
Author: erik.co...@gmail.com
Date: Wed Dec 9 03:14:45 2009
Log: Fix for bug 512 from Subrato De, CodeAurora.
Review URL: http://codereview.chromium.org/464016
http://code.google.com/p/v8/source/detail?r=3435
Modified:
/branches/bleeding_edge/AUTHORS
/branches/bleeding_edge/src/
LGTM.
The comments for the 32 bit version mostly apply to the 64 bit version too.
I don't see a performance bot run of the 64 bit version, which would have
provided a nice verification that the optimization was working there.
http://codereview.chromium.org/460142/diff/1/8
File src/heap.h (right
Addressed comments, please re-review.
http://codereview.chromium.org/466033/diff/1/2
File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/466033/diff/1/2#newcode41
src/arm/fast-codegen-arm.cc:41: // TODO(lrn) - set the constant when
implementing finally.
Premature optimizatio
We should consider reflecting the SCons changes in the v8.gyp file as well.
/Søren
On Wed, Dec 9, 2009 at 10:55, wrote:
> Reviewers: Erik Corry, andreip_google.com,
>
> Description:
> Create the framework for adding a thumb2 backend for ARM. So far, it
> is exactly the same as the ARM one. The
http://codereview.chromium.org/460109/diff/3001/3006
File src/x64/codegen-x64.cc (right):
http://codereview.chromium.org/460109/diff/3001/3006#newcode7953
src/x64/codegen-x64.cc:7953: ASSERT((String::kMaxLength & 0x8000) ==
0);
It's definitly true that kMaxLength isn't negative.
Whether it's
Reviewers: Erik Corry, andreip_google.com,
Description:
Create the framework for adding a thumb2 backend for ARM. So far, it
is exactly the same as the ARM one. The plan is that it will slowly start
generating THUMB2 for some instructions, until eventually it generates pure
thumb2.
BUG=none
TEST=n
Revision: 3434
Author: sgje...@chromium.org
Date: Wed Dec 9 01:35:41 2009
Log: Perform string add in generated code on X64 platform
This is a port of the IA-32 version from r3400
(http://code.google.com/p/v8/source/detail?r=3400). In the X64 version the
additional registers are used to avoid
http://codereview.chromium.org/460109/diff/3001/3005
File src/x64/assembler-x64.h (right):
http://codereview.chromium.org/460109/diff/3001/3005#newcode537
src/x64/assembler-x64.h:537: void movw(Register src, const Operand&
dst);
On 2009/12/08 14:16:11, Lasse Reichstein wrote:
> I would use movzxw
Issue 524: Creating a million live slow-case objects exhausts map space.
http://code.google.com/p/v8/issues/detail?id=524
This issue is now blocking issue chromium:29428.
See http://code.google.com/p/chromium/issues/detail?id=29428
--
You received this message because you are listed in the owner
32 matches
Mail list logo
