Hi all V8-ers...
Recently I have become aware of a awesome little project named
"node.js" ( http://nodejs.com/ ) which is powered by the amazing V8
Javascript VM. An idea has been tossed around recently, which is to
manipulate DOM structure within server-side code. This would enable
lots of new po
LGTM, except for the counter updating.
http://codereview.chromium.org/565047/diff/1/4
File src/api.cc (right):
http://codereview.chromium.org/565047/diff/1/4#newcode2775
src/api.cc:2775: i::Counters::contexts_created_by_snapshot.Increment();
This context is not created from the snapshot, right?
http://codereview.chromium.org/569015/diff/5006/4006
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/569015/diff/5006/4006#newcode5827
src/arm/codegen-arm.cc:5827: void
GenericBinaryOpStub::GetShiftCountLeastBits(MacroAssembler* masm,
Please add register parameters source and
LGTM
http://codereview.chromium.org/569028
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
* Add the partial context snapshot to the VM executable if
running with snapshots.
* Create contexts from partial snapshot if they contain no
extensions or global object templates. Add counters to track
when this happens.
* Remove debugging (logging code).
* So
Thank you for the good points and comments. I revised the code according to
the
reviews except one that is due to our testing limitation. If there are other
questions or conserns, please let me know.
http://codereview.chromium.org/569015/diff/3008/20
File src/arm/assembler-arm.cc (right):
htt
Reviewers: Erik Corry, Søren Gjesse,
Message:
Thank you for all of the good comments and suggestions. constants-arm.h and
platform-linux.cc are updated with CAN_USE_ARMV7_INSTRUCTIONS since our
testing
infrastruction limits the ubfx change to ARMv7.
Please review this at http://codereview
LGTM
http://codereview.chromium.org/561049/diff/1/24
File src/heap.h (right):
http://codereview.chromium.org/561049/diff/1/24#newcode104
src/heap.h:104: V(Code, debugger_statement_code, DebuggerStatementCode)
\
You should be able to remove this root as well.
http://coderevi
Revision: 3791
Author: erik.co...@gmail.com
Date: Wed Feb 3 12:39:34 2010
Log: Revert last change (temporarily using only the full compiler).
TBR=ager
http://code.google.com/p/v8/source/detail?r=3791
Modified:
/branches/bleeding_edge/src/flag-definitions.h
=
Revision: 3790
Author: erik.co...@gmail.com
Date: Wed Feb 3 12:31:49 2010
Log: Activate full compiler. This is a test which will be reverted.
TBR=ager
http://code.google.com/p/v8/source/detail?r=3790
Modified:
/branches/bleeding_edge/src/flag-definitions.h
Reviewers: Søren Gjesse,
Please review this at http://codereview.chromium.org/561049
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.cc
M src/arm/macro-assembler-arm.h
M src/arm/macro-assembler-arm.cc
M src/arm/virtu
Reviewers: Mads Ager,
Description:
Don't inline full VMState's constructor/destructor.
Please review this at http://codereview.chromium.org/569028
Affected files:
M src/log-inl.h
M src/log.h
M src/log.cc
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-de
On Wed, Feb 3, 2010 at 6:00 PM, wrote:
> I'm not sure about the map check vs. identity check. Can there be a map
> transition on the global object? In that case I have to check the map,
> right?
It has to be a map check - if nothing else then because of "forced"
deletes of properties (even DontD
Addressed comments + Merged with Kevin's change.
http://codereview.chromium.org/565034/diff/4001/4020
File src/arm/fast-codegen-arm.cc (right):
http://codereview.chromium.org/565034/diff/4001/4020#newcode64
src/arm/fast-codegen-arm.cc:64: void
FastCodeGenerator::EmitGlobalMapCheck() {
On 201
LGTM
http://codereview.chromium.org/552186/diff/9001/10003
File src/arm/codegen-arm.cc (right):
http://codereview.chromium.org/552186/diff/9001/10003#newcode6858
src/arm/codegen-arm.cc:6858: __ ldrb(scratch, MemOperand(src, count),
pl);
Maybe add a comment on why ldrb is before b. Maybe before
I don't think the global object of the caller is the one you want to
specialize
for. I think you should be able to make this change without changing the
call
ICs at all.
There is some overlap with my change to add the closure to the
CompilationInfo
structure which was done exactly to enab
LGMT
http://codereview.chromium.org/560032
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Transfer of reviewer. You're it.
http://codereview.chromium.org/552186
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, Kevin Millikin,
Description:
Fast compiler: Load globals variables directly from property cells.
This is a first step towards loading globals directly from property cells
instead
of going through a load IC.
This change supports only properties with the DontDelete attribute
Revision: 3788
Author: l...@chromium.org
Date: Wed Feb 3 05:29:42 2010
Log: Bad newline snuck in before commit.
Review URL: http://codereview.chromium.org/560032
http://code.google.com/p/v8/source/detail?r=3788
Modified:
/branches/bleeding_edge/test/mjsunit/json.js
===
Revision: 3787
Author: l...@chromium.org
Date: Wed Feb 3 05:17:39 2010
Log: Updated JSON.stringify to newest version of ES5.
Review URL: http://codereview.chromium.org/562034
http://code.google.com/p/v8/source/detail?r=3787
Modified:
/branches/bleeding_edge/src/json-delay.js
/branches/bleedin
http://codereview.chromium.org/562034/diff/1/3
File test/mjsunit/json.js (right):
http://codereview.chromium.org/562034/diff/1/3#newcode298
test/mjsunit/json.js:298:
Check added for behavior of undefined and functions in both arrays and
objects.
http://codereview.chromium.org/562034/diff/1/3#ne
Revision: 3786
Author: ri...@chromium.org
Date: Wed Feb 3 05:10:03 2010
Log: Added Object.defineProperty + needed internal functionality:
DefineOwnProperty (changed to allow for redefinition of existing property)
SameValue
Extra info on propertydescriptor
GetProperty
HasProperty
Curren
Revision: 3785
Author: erik.co...@gmail.com
Date: Wed Feb 3 04:58:31 2010
Log: Create a test that serializes and deserializes a context. Fix
minor related bugs.
Review URL: http://codereview.chromium.org/560031
http://code.google.com/p/v8/source/detail?r=3785
Modified:
/branches/experimental/p
LGMT
http://codereview.chromium.org/562034/diff/1/3
File test/mjsunit/json.js (right):
http://codereview.chromium.org/562034/diff/1/3#newcode298
test/mjsunit/json.js:298:
Maybe check for stringify on an array with undefined in it (to validate
that we do as 15.12.3-note 5)
http://codereview.chr
LGTM
http://codereview.chromium.org/560031
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Create a test that serializes and deserializes a context. Fix
minor related bugs.
Please review this at http://codereview.chromium.org/560031
SVN Base:
http://v8.googlecode.com/svn/branches/experimental/partial_snapshots/
Affected files:
M src/seria
Updates:
Owner: l...@chromium.org
Comment #2 on issue 563 by l...@chromium.org: Port fast string add code to
ARM.
http://code.google.com/p/v8/issues/detail?id=563
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC fields o
LGTM
http://codereview.chromium.org/555149
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Rico,
Message:
Small tweak in JSON.stringify.
Description:
Updated JSON.stringify to newest version of ES5.
Please review this at http://codereview.chromium.org/562034
Affected files:
M src/json-delay.js
M test/mjsunit/json.js
--
v8-dev mailing list
v8-dev@googlegroups.com
htt
Changed DefineOrRedefineAccessor to also delete CONSTANT_FUNCTION properties
before redefining it as an accessor (in case we have internal functions
that are
readonly but can be overridden - users cannot define readonly
CONSTANT_FUNCTION
properties using Object.defineProperty)
http://coderev
Revision: 3784
Author: leoncla...@gmail.com
Date: Wed Feb 3 03:54:57 2010
Log: DebugBreak shouldn't be used when ENABLE_DEBUGGER_SUPPORT isn't
defined.
Review URL: http://codereview.chromium.org/568017
http://code.google.com/p/v8/source/detail?r=3784
Modified:
/branches/bleeding_edge/src/cod
Revision: 3783
Author: a...@chromium.org
Date: Wed Feb 3 03:43:54 2010
Log: Use MemOperand directly to load argv on arm.
Review URL: http://codereview.chromium.org/570003
http://code.google.com/p/v8/source/detail?r=3783
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.cc
=
LGTM
http://codereview.chromium.org/570003
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/568017
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Erik Corry,
Description:
Use MemOperand directly to load argv on arm.
Please review this at http://codereview.chromium.org/570003
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.cc
Index: src/arm/codegen-arm.cc
===
Revision: 3782
Author: sgje...@chromium.org
Date: Wed Feb 3 03:30:29 2010
Log: Tagging version 2.1.0
http://code.google.com/p/v8/source/detail?r=3782
Added:
/tags/2.1.0
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I already fixed this, in version 3778. Sorry.
On Wed, Feb 3, 2010 at 11:50 AM, wrote:
> Reviewers: William Hesse,
>
>
> http://codereview.chromium.org/570002/diff/1/2
> File src/codegen.cc (right):
>
> http://codereview.chromium.org/570002/diff/1/2#newcode485
> src/codegen.cc:485: const bool in
I think looking at performance is the right thing to do. Please try to use
the GetMirror API in the code in V8Proxy.cpp, before adding devtools
specific functions to the V8 debugger API. Remember that you can compile the
JavaScript function taking the FunctionMirror object once. If using the
mirror
Reviewers: William Hesse,
http://codereview.chromium.org/570002/diff/1/2
File src/codegen.cc (right):
http://codereview.chromium.org/570002/diff/1/2#newcode485
src/codegen.cc:485: const bool indirect_result = result_size_ > 1;
On 2010/02/03 06:18:35, William Hesse wrote:
This seems really wron
LGTM for the branch. Let's make sure to give everything a full review when
merging back to bleeding_edge.
http://codereview.chromium.org/564035
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Another thing. You should update constants-arm.h so it defines a macro
CAN_USE_ARMV6T2_INSTRUCTIONS which is analogous to the
CAN_USE_ARMVx_INSTRUCTIONS that is already there. Then you should modify
OS::CpuFeaturesImpliedByPlatform in platform-linux.cc so it makes use of the
flag to set the bit
http://codereview.chromium.org/565007/diff/4002/3002
File include/v8-debug.h (right):
http://codereview.chromium.org/565007/diff/4002/3002#newcode274
include/v8-debug.h:274: v8::Local* file_name,
nit: bad arguments alignment
http://codereview.chromium.org/565007/diff/4002/3003
File src/api.cc (
Reviewers: Mads Ager,
Description:
Remove lazy loading of natives files and the natives cache.
This patch also contains some printf debug lines that should
be removed before the branch is merged back in.
Known bugs:
* The call to the API test fuzzer was removed from
call_as_function in test-api.c
Updates:
Status: WorkingAsIntended
Comment #4 on issue 594 by sgje...@chromium.org: Better handling of SONAME
http://code.google.com/p/v8/issues/detail?id=594
The current handling of SONAME is from the SCons build is maybe not optimal
but the
safest taking the concerns raised into con
Thanks for the patch. Some comments are below. Can we find a name for the
feature that isn't ARMv7 since ARMV6T2 has the instruction too?
http://codereview.chromium.org/569015/diff/3008/20
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/569015/diff/3008/20#newcode866
src
Revision: 3779
Author: sgje...@chromium.org
Date: Wed Feb 3 01:15:58 2010
Log: Prepare to push to trunk. We are now vorking on version 2.1.1.
Review URL: http://codereview.chromium.org/564033
http://code.google.com/p/v8/source/detail?r=3779
Modified:
/branches/bleeding_edge/ChangeLog
/branches
LGTM
http://codereview.chromium.org/564033
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Prepare to push to trunk. We are now vorking on version 2.1.1.
Please review this at http://codereview.chromium.org/564033
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: src/ver
Revision: 3778
Author: whe...@chromium.org
Date: Wed Feb 3 00:33:19 2010
Log: Fix build error on Win32, fix spelling of DebugerStatementStub.
Review URL: http://codereview.chromium.org/570001
http://code.google.com/p/v8/source/detail?r=3778
Modified:
/branches/bleeding_edge/src/arm/codegen-arm.
Revision: 3777
Author: erik.co...@gmail.com
Date: Wed Feb 3 00:11:50 2010
Log: Branch for experimental partial snapshots.
http://code.google.com/p/v8/source/detail?r=3777
Added:
/branches/experimental/partial_snapshots
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
51 matches
Mail list logo
