Revision: 5334
Author: l...@chromium.org
Date: Tue Aug 24 23:46:53 2010
Log: Use collector for preparse data.
This is in preparation of adding more data to the preparse record.
Using a collector instead of a list avoids copying data when the backing
store grows.
Review URL: http://codereview.chr
Reviewers: Kasper Lund,
Description:
Prepare push of version 2.3.11 to trunk. Now working on versin 2.3.12
This includes the ChangeLog part from the last push to trunk, since
the "prepare push to trunk" cl for that push was never committed.
Please review this at http://codereview.chromium.org
Updates:
Status: Assigned
Owner: ri...@chromium.org
Comment #1 on issue 842 by ri...@chromium.org: Object.freeze() throws
exception is Object or Array has been extended
http://code.google.com/p/v8/issues/detail?id=842
I will take a look
--
v8-dev mailing list
v8-dev@googlegro
Revision: 5333
Author: sgje...@chromium.org
Date: Tue Aug 24 22:57:02 2010
Log: Fix a bug in the handling of debug break in CallIC
The change of calling convention in the CallIC was not reflected in the
debug break code. Without the change to the debug break code the added test
crashed.
Revi
LGTM also for merging to the 2.2 branch.
http://codereview.chromium.org/3167037/diff/1/5
File test/cctest/test-debug.cc (right):
http://codereview.chromium.org/3167037/diff/1/5#newcode872
test/cctest/test-debug.cc:872: // Mark sweep (and perhaps compact).
Maybe update comment. It always compact
Status: New
Owner:
New issue 842 by polarjs: Object.freeze() throws exception is Object or
Array has been extended
http://code.google.com/p/v8/issues/detail?id=842
Here's a simple test case:
=== BEGIN ===
//Object.prototype.myfunc = function() {}
//Array.prototype.myfunc = function() {}
Reviewers: Kasper Lund,
Message:
This is a candidate for merging to the 2.2 branch!
Description:
Fix a bug in the handling of debug break in CallIC
The change of calling convention in the CallIC was not reflected in the
debug
break code. Without the change to the debug break code the added te
Reviewers: Lasse Reichstein,
Message:
This change only moves functions and declarations to new files, and adds
#includes, in order to remove the code stubs from the virtual-frame code
generator.
The new files are added to the build systems. Xcode build is not yet
modified -
it will be fixed b
LGTM
http://codereview.chromium.org/3153037/diff/1/2
File src/parser.cc (right):
http://codereview.chromium.org/3153037/diff/1/2#newcode965
src/parser.cc:965: : has_error_(false),
store_(ScriptDataImpl::kHeaderSize) {
Four space indent.
http://codereview.chromium.org/3153037/show
--
v8-dev ma
Revision: 5332
Author: kasp...@chromium.org
Date: Tue Aug 24 06:51:23 2010
Log: Add position information for compares, binary ops, and count
operations.
Review URL: http://codereview.chromium.org/3120027
http://code.google.com/p/v8/source/detail?r=5332
Modified:
/branches/bleeding_edge/src/arm/f
LGTM.
http://codereview.chromium.org/3120027/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5331
Author: vita...@chromium.org
Date: Tue Aug 24 06:45:53 2010
Log: Ported string call IC-s to arm.
Review URL: http://codereview.chromium.org/3143038
http://code.google.com/p/v8/source/detail?r=5331
Modified:
/branches/bleeding_edge/src/arm/stub-cache-arm.cc
==
Revision: 5330
Author: vita...@chromium.org
Date: Tue Aug 24 06:39:29 2010
Log: Ported string call IC-s to x64.
Review URL: http://codereview.chromium.org/3156045
http://code.google.com/p/v8/source/detail?r=5330
Modified:
/branches/bleeding_edge/src/x64/stub-cache-x64.cc
==
Revision: 5329
Author: ri...@chromium.org
Date: Tue Aug 24 06:34:59 2010
Log: Refactor the tools/test.py script and related testcfg.py files.
This makes it possible to run several variants of the tests (with different
flags that is) by adding extra lists to the VARIANT_FLAGS list. In
addition
LGTM.
http://codereview.chromium.org/3164023/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: fschneider,
Description:
Add position information for compares, binary ops, and count
operations.
Please review this at http://codereview.chromium.org/3120027/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/full-codegen-arm.cc
M
Reviewers: Mads Ager,
Description:
Use collector for preparse data.
This is in preparation of adding more data to the preparse record.
Using a collector instead of a list avoids copying data when the backing
store grows.
Please review this at http://codereview.chromium.org/3153037/show
Affecte
http://codereview.chromium.org/3134027/diff/1/9
File src/objects-debug.cc (right):
http://codereview.chromium.org/3134027/diff/1/9#newcode654
src/objects-debug.cc:654: ASSERT(instance_descriptors() ==
Heap::empty_descriptor_array());
On 2010/08/24 12:36:20, antonm wrote:
minor cosmetic: maybe A
Revision: 5328
Author: kasp...@chromium.org
Date: Tue Aug 24 05:56:45 2010
Log: Introduce a new intermediate AST node for encapsulating the
increment part of a count operation.
Review URL: http://codereview.chromium.org/3150032
http://code.google.com/p/v8/source/detail?r=5328
Modified:
/branches
LGTM.
http://codereview.chromium.org/3150032/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: fschneider,
Description:
Introduce a new intermediate AST node for encapsulating the
increment part of a count operation.
Please review this at http://codereview.chromium.org/3150032/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/ast.
LGTM
http://codereview.chromium.org/3134027/diff/1/9
File src/objects-debug.cc (right):
http://codereview.chromium.org/3134027/diff/1/9#newcode654
src/objects-debug.cc:654: ASSERT(instance_descriptors() ==
Heap::empty_descriptor_array());
minor cosmetic: maybe ASSERT_EQ is better.
http://coder
Revision: 5327
Author: l...@chromium.org
Date: Tue Aug 24 05:29:50 2010
Log: Ensure that scanner state is correctly reset when an error is
encountered.
Add a scope object to ensure that leaving a literal scanning prematurely
will clean up after itself.
Also reset the literal buffer if a scanne
http://codereview.chromium.org/3137037/diff/1/3
File src/scanner.h (right):
http://codereview.chromium.org/3137037/diff/1/3#newcode280
src/scanner.h:280: private:
Done.
http://codereview.chromium.org/3137037/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-
LGTM
http://codereview.chromium.org/3137037/diff/1/3
File src/scanner.h (right):
http://codereview.chromium.org/3137037/diff/1/3#newcode280
src/scanner.h:280: private:
Strange spacing going on here. Please add blank line before private: and
consider removing the blanks between the function decl
Reviewers: Mads Ager,
Description:
Ensure that scanner state is correctly reset when an error is encountered.
Add a scope object to ensure that leaving a literal scanning prematurely
will clean up after itself.
Also reset the literal buffer if a scanner is reinitialized with a new
source code.
Status: Accepted
Owner: sgje...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 841 by sgje...@chromium.org: RUNTIME_ASSERT requires allocation
http://code.google.com/p/v8/issues/detail?id=841
The RUNTIME_ASSERT macro used in runtime.cc requires heap heap allocation.
There might be sit
Revision: 5326
Author: kasp...@chromium.org
Date: Tue Aug 24 04:41:26 2010
Log: Optimize 'typeof == ' in the full codegen.
Review URL: http://codereview.chromium.org/3110034
http://code.google.com/p/v8/source/detail?r=5326
Modified:
/branches/bleeding_edge/src/arm/full-codegen-arm.cc
/branches
LGTM
http://codereview.chromium.org/3110034/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5325
Author: l...@chromium.org
Date: Tue Aug 24 03:53:44 2010
Log: Created collector class and used it to collect identifiers during
scanning.
The collector class automatically expands to hold the values added to it,
like a List, but doesn't ensure that the backing store is contiguou
Reviewers: Mads Ager,
Description:
Optimize 'typeof == ' in the full codegen.
Please review this at http://codereview.chromium.org/3110034/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/full-codegen-arm.cc
M src/full-codegen.h
M
Reviewers: Mads Ager, antonm,
Description:
Reapplying r5147 (caching maps for slow case objects).
r5147 wrongly assumed that a code cache for a slow case map is always empty.
This patch solves this: whenever we attempt to add a stub to a map's code
cache
we check that this map is cached. If i
The same optimization added to ParseInt and PartseFloat (v8natives.js).
http://codereview.chromium.org/3141022/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM if you move most of the method bodies to utils.cc.
http://codereview.chromium.org/3181036/diff/1/9
File src/utils.h (right):
http://codereview.chromium.org/3181036/diff/1/9#newcode541
src/utils.h:541: Vector ToVector() {
You should move some of these methods to utils.cc and only keep the o
Reviewers: Mads Ager,
Description:
Created collector class and used it to collect identifiers during scanning.
The collector class automatically expands to hold the values added to it,
like a List, but doesn't ensure that the backing store is contiguous, which
allows it to avoid copying back and
Revision: 5324
Author: kasp...@chromium.org
Date: Tue Aug 24 02:04:17 2010
Log: Remove the full codegen syntax checker completely but be
careful to avoid making code with loops run too slowly.
Review URL: http://codereview.chromium.org/3107033
http://code.google.com/p/v8/source/detail?r=5324
Modi
Reviewers: Søren Gjesse,
Description:
Remove the full codegen syntax checker completely but be
careful to avoid making code with loops run too slowly.
Please review this at http://codereview.chromium.org/3107033/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files
Added flag and HasPreciousOutput to TestOutput
Please take another look
http://codereview.chromium.org/3164023/diff/1/5
File test/mjsunit/testcfg.py (right):
http://codereview.chromium.org/3164023/diff/1/5#newcode94
test/mjsunit/testcfg.py:94: if self.self_script and (not
result.UnexpectedOutpu
LGTM
http://codereview.chromium.org/3143038/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
STV!
http://codereview.chromium.org/3146037/diff/1/21
File src/x64/full-codegen-x64.cc (right):
http://codereview.chromium.org/3146037/diff/1/21#newcode3019
src/x64/full-codegen-x64.cc:3019: Label materialize_true,
materialize_false;
Indentation.
http://codereview.chromium.org/3146037/show
--
Reviewers: Mads Ager,
Description:
Cleanup the AST code by removing unused parts and get rid of the
flow graph code completely. Add new AST node for null compares
and use it to make the full codegens better at generating code
for null comparisons.
Please review this at http://codereview.chromium
41 matches
Mail list logo
