If the seed is random by default, but there is a command line to use a
specific seed, and the seed is part of a crash-dump, we can debug using the
exact same code as the one that crashed.
It's the same thing we do with Math.random when running benchmarks - we use
a random seed by default but can o
http://codereview.chromium.org/3141047/diff/1/10
File src/debug.h (right):
http://codereview.chromium.org/3141047/diff/1/10#newcode332
src/debug.h:332: k_after_break_target_address,
On 2010/08/26 13:31:04, Kasper Lund wrote:
Weird naming. Should all be kAfterBreak... right? Feel free to keep it
Reviewers: Kasper Lund,
Description:
Add file missing from last commit.
tbr=kasp...@chromium.org
Please review this at http://codereview.chromium.org/3248001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/globals.h
Index: src/globals.h
==
LGTM.
http://codereview.chromium.org/3248001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Kasper Lund,
Description:
Fix presumbit errors in previous commit
tbr=kasp...@chromium.org
Please review this at http://codereview.chromium.org/3249001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/debug.h
M src/x64/debug-x64.
Fantastic. LGTM.
http://codereview.chromium.org/3249001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Found bug. Please re-review.
http://codereview.chromium.org/3185026/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3185026/diff/9001/10001
File src/parser.cc (right):
http://codereview.chromium.org/3185026/diff/9001/10001#newcode948
src/parser.cc:948: if (index_ + FunctionEntry::kSize <= store_.length()
A couple of extra parenthesis would help me read this. :)
http://cod
Forwarding, subscribed to v8-dev :)
-- Forwarded message --
From:
Date: Fri, Aug 27, 2010 at 10:27 AM
Subject: Re: Remove dependence of code-stubs on codegen, the virtual frame
code generator (issue3169049)
To: whe...@chromium.org
Cc: v8-dev@googlegroups.com
My concern is ma
LGTM
http://codereview.chromium.org/3141022/diff/28006/34008
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3141022/diff/28006/34008#newcode1340
src/arm/macro-assembler-arm.cc:1340: void
MacroAssembler::IndexFromHash(Register key, Register hash) {
makes sense to ren
http://codereview.chromium.org/3141022/diff/28006/34008
File src/arm/macro-assembler-arm.cc (right):
http://codereview.chromium.org/3141022/diff/28006/34008#newcode1340
src/arm/macro-assembler-arm.cc:1340: void
MacroAssembler::IndexFromHash(Register key, Register hash) {
On 2010/08/27 08:57:59,
Reviewers: Kevin Millikin,
Description:
Improve header file inclusions. Drop some unneeded includes, and add some
needed ones.
Please review this at http://codereview.chromium.org/3253001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/contexts.
Nice. LGTM.
http://codereview.chromium.org/3253001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Message:
To fix build error (missing files).
Description:
Reverting r5362.
Please review this at http://codereview.chromium.org/3217003/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/codegen-arm.h
M src/a
LGTM
http://codereview.chromium.org/3217003/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Description:
Fixing build error r5362 (adding missing files).
Please review this at http://codereview.chromium.org/3258001/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/objects.h
M src/objects.cc
Index: sr
LGTM
http://codereview.chromium.org/3258001/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov,
Message:
Slava,
may you have a look?
Maybe newly added function should be rather named EnsureInChunkOrder.
And maybe we should deallocate functions out of mark compactor and into
spaces:
after all it is a space who knows how to deallocate a stuff from it.
Desc
Reviewers: Mads Ager,
Message:
Mads,
tiny review for you if you please.
Description:
Add os_error stat to oom_dump utility.
Please review this at http://codereview.chromium.org/3150028/show
Affected files:
M tools/oom_dump/oom_dump.cc
Index: tools/oom_dump/oom_dump.cc
diff --git a/tools/o
Reviewers: antonm,
Description:
Check result of JSObject::NormalizeProperties() in
JSObject::PreventExtensions().
Normalization requires allocation so Failure object can be returned.
BUG=http://code.google.com/p/v8/issues/detail?id=851
TEST=test/mjsunit/regress/regress-851.js
Please review th
LGTM!
http://codereview.chromium.org/3262001/diff/1/3
File test/mjsunit/regress/regress-851.js (right):
http://codereview.chromium.org/3262001/diff/1/3#newcode1
test/mjsunit/regress/regress-851.js:1: // Copyright 2008 the V8 project
authors. All rights reserved.
nit: 2008 -> 2010
http://codere
Reviewers: antonm,
Description:
Fix regress-851.js to use assertNull instead of assertFalse.
Please review this at http://codereview.chromium.org/3232002/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M test/mjsunit/regress/regress-851.js
Index: tes
LGTM
On Fri, Aug 27, 2010 at 5:19 PM, wrote:
> Reviewers: antonm,
>
> Description:
> Fix regress-851.js to use assertNull instead of assertFalse.
>
> Please review this at http://codereview.chromium.org/3232002/show
>
> SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
>
> Affected
LGTM with comment addressed.
Thanks for cleaning debris left after me!
http://codereview.chromium.org/3260001/diff/1/4
File src/mark-compact.h (right):
http://codereview.chromium.org/3260001/diff/1/4#newcode122
src/mark-compact.h:122: static void DeallocateOldPointerBlock(Address
start,
Maybe
http://codereview.chromium.org/3260001/diff/1/2
File src/heap.cc (right):
http://codereview.chromium.org/3260001/diff/1/2#newcode544
src/heap.cc:544: Heap::old_pointer_space()->RelinkPageListInChunkOrder(
After turning block deallocation into virtual method. This might be
turned into simple loop
Oh, interesting. Do you have a pointer to those tests? I'd like to take a
look to see if they're doing something similar.
I'm fully aware that this can't be made to work for 100% of cases, but my
hope is that it will be sufficiently stable for a large subset.
Ojan
On Thu, Aug 26, 2010 at 11:15 P
26 matches
Mail list logo
