I've made more changes, perhaps it's better if one of you guys took another
look:
On 2010/09/22 08:54:23, Yury Semikhatsky wrote:
http://codereview.chromium.org/3397021/diff/1/5#newcode677
src/mark-compact.cc:677: RootMarkingVisitor(Heap* heap)
Should be "explicit".
Done.
http://codereview.c
Comment #9 on issue 686 by vego...@chromium.org: "With" and function scope
http://code.google.com/p/v8/issues/detail?id=686
Issue 875 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Duplicate
Labels: -Type-Bug -Priority-Medium
Mergedinto: 686
Comment #1 on issue 875 by vego...@chromium.org: Closure problems with the
Javascript "with" statement.
http://code.google.com/p/v8/issues/detail?id=875
(No comment was entered for this chang
Status: New
Owner:
Labels: Type-Bug Priority-Medium
New issue 875 by asarg...@chromium.org: Closure problems with the
Javascript "with" statement.
http://code.google.com/p/v8/issues/detail?id=875
From original report in the Chromium bug tracker:
http://code.google.com/p/chromium/issues/
Comment #46 on issue 164 by phistuck: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
Everyone, for your information - Internet Explorer 9 treats the property
order of objects the same was as V8.
So you better stop hanging onto the old implementa
Comment #45 on issue 164 by atcrabtree: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
Just a small folow up FWIW, per @jdunck and some obvious realization &
agreement on my part, "Maintaining order raises insertion to O(log(n)) &
higher const
Comment #44 on issue 164 by atcrabtree: Wrong order in Object properties
interation
http://code.google.com/p/v8/issues/detail?id=164
After stumbling upon what is clearly evolved into a somewhat ridiculous
standoff, I think it's pretty obvious the bias each side is arguing from.
Those in f
Or can you only build with python 2.x?
I have tried 2to3.py but it still freaks out!
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Slava,
I am not a 100% clear on which cases we could hit with interceptors and
what the
semantics should be. But other than that LGTM
http://codereview.chromium.org/3462005/diff/1/2
File src/objects.cc (right):
http://codereview.chromium.org/3462005/diff/1/2#newcode5962
src/objects.cc:5962:
LGTM with a few extra comments.
http://codereview.chromium.org/3329019/diff/40001/39007
File src/ia32/assembler-ia32.h (right):
http://codereview.chromium.org/3329019/diff/40001/39007#newcode598
src/ia32/assembler-ia32.h:598: void dec_b(const Operand& dst);
Does the disassembler support this al
Good catch! LGTM
http://codereview.chromium.org/3405022/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/3405022/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vitaly, antonm,
Description:
Unuse labels when bailing out of StubCompiler methods.
There are 3 methods where early return happen before the
miss label is bound. This is harmless in Release mode,
in Debug an assertion fails.
Please review this at http://codereview.chromium.org/34050
Thanks for comments Anton!
Of course we can use an interceptor query (if it is present) to
determine specific properties of intercepted properties.
But mapping from this properties to property descriptor (especially if
interceptor query is not defined) is somewhat unclear to me. Because
intercept
Revision: 5507
Author: ant...@chromium.org
Date: Wed Sep 22 06:57:00 2010
Log: Fix a build for Win64 with VS2008.
It complaints of type conversions.
Review URL: http://codereview.chromium.org/3396015
http://code.google.com/p/v8/source/detail?r=5507
Modified:
/branches/bleeding_edge/test/cctest
On 2010/09/22 12:18:45, antonm wrote:
Misha, may you have a look?
LGTM, thanks!
http://codereview.chromium.org/3396015/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I'm not very keen on this one. The idea of having an array with constants
to
define what the various offsets mean seems like a second best solution
compared
with just having a set of different classes and virtual functions. Instead
of
the array you would have objects of the correct instanc
Drive-bys
http://codereview.chromium.org/3462005/diff/1/4
File src/runtime.cc (right):
http://codereview.chromium.org/3462005/diff/1/4#newcode671
src/runtime.cc:671: elms->set(ENUMERABLE_INDEX, Heap::true_value());
I am not sure all intercepted elements are enumerable. You might prefer
to use
Revision: 5506
Author: ant...@chromium.org
Date: Wed Sep 22 06:24:14 2010
Log: Fix Win64 build with VS2008.
strlen returns size_t and VS2008 is now pretty picky about that.
Review URL: http://codereview.chromium.org/3384019
http://code.google.com/p/v8/source/detail?r=5506
Modified:
/branches/b
Reviewers: Rico,
Description:
Fix getOwnPropertyDescriptor() support for index properties.
Add support for index properties with getters, setters or indexed
interceptors.
BUG=http://code.google.com/p/v8/issues/detail?id=874
Please review this at http://codereview.chromium.org/3462005/show
Reviewers: Erik Corry,
Description:
Refactored string search code.
Made string search state explicit for repreated calls (a StringSearch
class).
Please review this at http://codereview.chromium.org/3467010/show
Affected files:
M src/SConscript
M src/runtime.cc
M src/string-search.h
M
Sigh, I've grepped for \, if only I omit the last word boundary.
Thanks a lot for pointing StrLength out. Fixing and submitting.
yours,
anton.
On Wed, Sep 22, 2010 at 4:56 PM, wrote:
> LGTM
>
>
> http://codereview.chromium.org/3384019/diff/1/2
> File test/cctest/test-parsing.cc (right):
>
> h
Revision: 5505
Author: l...@chromium.org
Date: Wed Sep 22 05:59:55 2010
Log: Merge r5504 into 2.3 branch.
Fix bug in RegExp cache handling of lastIndex (issue 52801).
Review URL: http://codereview.chromium.org/3381017
http://code.google.com/p/v8/source/detail?r=5505
Added:
/branches/2.3/test/mj
LGTM
http://codereview.chromium.org/3381017/show
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/3384019/diff/1/2
File test/cctest/test-parsing.cc (right):
http://codereview.chromium.org/3384019/diff/1/2#newcode159
test/cctest/test-parsing.cc:159: tests[i],
static_cast(strlen(tests[i])));
Could we use StrLength instead (which returns int)? (everywhere).
Reviewers: Erik Corry,
Description:
Merge r5504 into 2.3 branch.
Fix bug in RegExp cache handling of lastIndex (issue 52801).
Please review this at http://codereview.chromium.org/3381017/show
Affected files:
M src/regexp.js
M src/version.cc
A test/mjsunit/regress/regress-52801.js
--
v8-
Reviewers: Lasse Reichstein,
Message:
Lasse, may have a look?
Description:
Fix Win64 build with VS2008.
strlen returns size_t and VS2008 is now pretty picky about that.
Please review this at http://codereview.chromium.org/3384019/show
Affected files:
M test/cctest/test-parsing.cc
Index: t
Reviewers: Michail Naganov,
Message:
Misha, may you have a look?
Description:
Fix a build for Win64 with VS2008.
It complaints of type conversions.
Please review this at http://codereview.chromium.org/3396015/show
Affected files:
M test/cctest/test-log-stack-tracer.cc
Index: test/cctest/t
Addressed comments, waiting for Vitaly's LGTM.
http://codereview.chromium.org/3329019/diff/15001/16007
File src/ia32/builtins-ia32.cc (right):
http://codereview.chromium.org/3329019/diff/15001/16007#newcode193
src/ia32/builtins-ia32.cc:193: __ mov(edx,
Factory::one_pointer_filler_map());
Is the
Revision: 5504
Author: l...@chromium.org
Date: Wed Sep 22 04:22:57 2010
Log: RegExp: Fix caching to correctly set lastIndex.
BUG: 52801
Review URL: http://codereview.chromium.org/3389022
http://code.google.com/p/v8/source/detail?r=5504
Added:
/branches/bleeding_edge/test/mjsunit/regress/regres
Revision: 5503
Author: fschnei...@chromium.org
Date: Wed Sep 22 02:46:09 2010
Log: Tagging version 2.4.5
http://code.google.com/p/v8/source/detail?r=5503
Added:
/tags/2.4.5
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 5501
Author: fschnei...@chromium.org
Date: Wed Sep 22 02:35:56 2010
Log: Prepare push to trunk. Now working on version 2.4.6.
Review URL: http://codereview.chromium.org/3466009
http://code.google.com/p/v8/source/detail?r=5501
Modified:
/branches/bleeding_edge/ChangeLog
/branches/blee
LGTM with small fixes.
http://codereview.chromium.org/3466009/diff/1/2
File ChangeLog (right):
http://codereview.chromium.org/3466009/diff/1/2#newcode2
ChangeLog:2: Performance improvements on all platforms.
Blank line after version line.
Line about performance is usually last.
http://coderev
LGTM
http://codereview.chromium.org/3389022/diff/2001/3001
File src/regexp.js (right):
http://codereview.chromium.org/3389022/diff/2001/3001#newcode286
src/regexp.js:286: if (this.global) this.lastIndex =
lastMatchInfo[CAPTURE1];
We need a little comment here to explain why we only have to do t
Reviewers: Vyacheslav Egorov,
Description:
Prepare push to trunk. Now working on version 2.4.6.
Please review this at http://codereview.chromium.org/3466009/show
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: Ch
LGTM with comments.
http://codereview.chromium.org/3397021/diff/1/5
File src/mark-compact.cc (right):
http://codereview.chromium.org/3397021/diff/1/5#newcode677
src/mark-compact.cc:677: RootMarkingVisitor(Heap* heap)
Should be "explicit".
http://codereview.chromium.org/3397021/diff/1/5#newcode
Reviewers: Erik Corry,
Description:
RegExp: Fix caching to correctly set lastIndex.
BUG: 52801
Please review this at http://codereview.chromium.org/3389022/show
Affected files:
M src/regexp.js
A test/mjsunit/regress/regress-52801.js
Index: src/regexp.js
diff --git a/src/regexp.js b/src/r
37 matches
Mail list logo
