[v8-dev] Re: Clear JS function result caches in all global contexts. (issue4200009)

LGTM Please port to branches. http://codereview.chromium.org/429/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5734 committed - Landing for Justin Schuh....

Revision: 5734 Author: a...@chromium.org Date: Thu Oct 28 23:15:34 2010 Log: Landing for Justin Schuh. This switches out the existing constant splitting with masking that works like this: 1. Generate a random 32-bit value at compilation time. 2. XOR the 32-bit constant with the random value.

[v8-dev] Re: Switche out the constant splitting with cookies (issue3973002)

Committed as revision 5734. On 2010/10/29 06:06:17, Mads Ager wrote: LGTM I'll take care of these nits and land it for you. Thanks! http://codereview.chromium.org/3973002/diff/17001/18001 File src/flag-definitions.h (right): http://codereview.chromium.org/3973002/diff/17001/18001#newcod

[v8-dev] Re: Switche out the constant splitting with cookies (issue3973002)

LGTM I'll take care of these nits and land it for you. Thanks! http://codereview.chromium.org/3973002/diff/17001/18001 File src/flag-definitions.h (right): http://codereview.chromium.org/3973002/diff/17001/18001#newcode143 src/flag-definitions.h:143: DEFINE_bool(mask_constants_with_cookie, fal

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #64 on issue 164 by carl...@4sconsult.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 @timdown: From your knowledge, has been this issue discussed on ecmascript.org? It will be good to put the efforts on a open and on-going discuss

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #63 on issue 164 by carl...@4sconsult.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 @pcxunlimited: I totally agree on this one. Since when IE has been the flag to follow. As developer we make sure our code works first on the "other

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #62 on issue 164 by charles.kendrick: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 Thanks for clarifying Tim. If I may restate, you do not actually prefer the current behavior as such, rather, you want an ECMA standard and you want

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #61 on issue 164 by timdown: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 OK, I possibly deserved that for not at least restating my basic position. I want there to be a standard and I want browsers to implement it. I'd like it to be

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #60 on issue 164 by charles.kendrick: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 Really Tim?? In your comment #36 you say: --- 1. I agree that it would be preferable for there to be a standard in place for the iteration order of ob

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #59 on issue 164 by timdown: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 I've starred this because I'm interested in the subject. I'd actively prefer it if the current behaviour was retained. I've argued the case on here before so I

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #58 on issue 164 by charles.kendrick: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 While a number of people have chimed in saying that they don't think this is a bug, not one person has said please don't fix it. Because of course fix

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #57 on issue 164 by wander...@gmail.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 just to make clear to charles.kendrick, not everyone who stars disagrees with the current behavior i have this starred because i want to know if so

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #56 on issue 164 by charles.kendrick: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 Would just like to point out that this issue has by far more stars than the most-starred Feature Request (E4X support), more than double the stars of

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #55 on issue 164 by mendesjuan: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 This is not a 'let's follow IE' issue. It's a 'let's follow all other major browsers' issue. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.go

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #54 on issue 164 by pcxunlimited: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 @phistuck: On the contrary... there are many things that IE supports that other browsers do not. We should not do things just because Internet Explorer do

[v8-dev] Re: Switche out the constant splitting with cookies (issue3973002)

I uploaded the changes (style and variable names) and ran new benchmarks here: http://golem.spb:9013/golem/compare?vmname=v8-jschuh-const-cookies&vmrev=5720&ref_vmname=v8-jschuh-base&ref_vmrev=5720

[v8-dev] Clear JS function result caches in all global contexts. (issue4200009)

Reviewers: Mads Ager, Description: Clear JS function result caches in all global contexts. Original patch by Mark Lam from Hewlett-Packard Development Company, LP. (http://codereview.chromium.org/4187007) Fix memory corruption in JSFunctionResultCache::Clear caused by out of bounds write

[v8-dev] This patch fixes Heap::ClearJSFunctionResultCaches() the same way... (issue4187007)

Reviewers: Vyacheslav Egorov, Description: This patch fixes Heap::ClearJSFunctionResultCaches() the same way that Heap::ClearNormalizedMapCache() was implemented in r5654. The existing code effectively does not clear the JSFunctionResultCaches at all. With this patch, the caches are now cleared

[v8-dev] [v8] r5733 committed - Tagging version 2.4.9.6

Revision: 5733 Author: vego...@chromium.org Date: Thu Oct 28 10:45:40 2010 Log: Tagging version 2.4.9.6 http://code.google.com/p/v8/source/detail?r=5733 Added: /tags/2.4.9.6 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5732 committed - Delete incorrectly created tag for version 2.4.9.6 (again)

Revision: 5732 Author: vego...@chromium.org Date: Thu Oct 28 10:44:15 2010 Log: Delete incorrectly created tag for version 2.4.9.6 (again) http://code.google.com/p/v8/source/detail?r=5732 Deleted: /tags/2.4.9.6 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5731 committed - Tagging version 2.4.9.6

Revision: 5731 Author: vego...@chromium.org Date: Thu Oct 28 10:42:52 2010 Log: Tagging version 2.4.9.6 http://code.google.com/p/v8/source/detail?r=5731 Added: /tags/2.4.9.6 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5730 committed - Delete incorrectly created tag for version 2.4.9.6

Revision: 5730 Author: vego...@chromium.org Date: Thu Oct 28 10:42:07 2010 Log: Delete incorrectly created tag for version 2.4.9.6 http://code.google.com/p/v8/source/detail?r=5730 Deleted: /tags/2.4.9.6 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5729 committed - Tagging version 2.4.9.6

Revision: 5729 Author: vego...@chromium.org Date: Thu Oct 28 10:40:29 2010 Log: Tagging version 2.4.9.6 http://code.google.com/p/v8/source/detail?r=5729 Added: /tags/2.4.9.6/trunk -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5728 committed - Tagging version 2.4.9.6

Revision: 5728 Author: vego...@chromium.org Date: Thu Oct 28 10:34:12 2010 Log: Tagging version 2.4.9.6 http://code.google.com/p/v8/source/detail?r=5728 Added: /tags/2.4.9.6 -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 916 in v8: Overloaded method in an Element are overridden by the Element.prototype one

Updates: Status: PendingFurtherInfo Comment #1 on issue 916 by ant...@chromium.org: Overloaded method in an Element are overridden by the Element.prototype one http://code.google.com/p/v8/issues/detail?id=916 dmerenne, do you have a repro HTML? The snippet above works fine for me in

[v8-dev] Issue 916 in v8: Overloaded method in an Element are overridden by the Element.prototype one

Status: New Owner: New issue 916 by dmerenne: Overloaded method in an Element are overridden by the Element.prototype one http://code.google.com/p/v8/issues/detail?id=916 Chrome Version: Google Chrome 7.0.517.41 (Official Build 62167) beta WebKit 534.7 V8 2.3.11.17 User Agent Moz

[v8-dev] [v8] r5727 committed - ll_prof: minor fixes to the issues found while running with chromium....

Revision: 5727 Author: vita...@chromium.org Date: Thu Oct 28 09:48:10 2010 Log: ll_prof: minor fixes to the issues found while running with chromium. Review URL: http://codereview.chromium.org/4097011 http://code.google.com/p/v8/source/detail?r=5727 Modified: /branches/bleeding_edge/tools/ll_pr

[v8-dev] Re: ll_prof: minor fixes to the issues found while running with chromium. (issue4097011)

On 2010/10/28 16:36:44, Vitaly wrote: LGTM http://codereview.chromium.org/4097011/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] ll_prof: minor fixes to the issues found while running with chromium. (issue4097011)

Reviewers: Michail Naganov, Description: ll_prof: minor fixes to the issues found while running with chromium. Please review this at http://codereview.chromium.org/4097011/show Affected files: M tools/ll_prof.py Index: tools/ll_prof.py diff --git a/tools/ll_prof.py b/tools/ll_prof.py index

[v8-dev] Re: Issue 915 in v8: liveedit iterates incorrectly over the pointers in the stack

Comment #1 on issue 915 by peter.rybin: liveedit iterates incorrectly over the pointers in the stack http://code.google.com/p/v8/issues/detail?id=915 Oh yeah, that's bad. Thanks a lot for catching this. Unfortunately I've forgot why I first collected all references and then changed them all

[v8-dev] Re: Stop running some liveedit tests (see issue 915).... (issue4161005)

LGTM http://codereview.chromium.org/4161005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Stop running some liveedit tests (see issue 915).... (issue4161005)

Reviewers: Søren Gjesse, Description: Stop running some liveedit tests (see issue 915). Plug tiny memory leaks in test-lock.cc. Please review this at http://codereview.chromium.org/4161005/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/t

[v8-dev] Re: Fix some memory leaks in the serialization tests. (issue4095009)

LGTM http://codereview.chromium.org/4095009/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Fix some memory leaks in the serialization tests. (issue4095009)

Reviewers: Søren Gjesse, Description: Fix some memory leaks in the serialization tests. Please review this at http://codereview.chromium.org/4095009/show SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M test/cctest/test-serialize.cc Index: test/cctest/te

[v8-dev] [v8] r5726 committed - Remove the patching of the debug break stub...

Revision: 5726 Author: sgje...@chromium.org Date: Thu Oct 28 04:50:50 2010 Log: Remove the patching of the debug break stub This is no longer required to break at the function entry. Actually has not been required since the inlined stack check was introduced long time ago. Review URL: http://c

[v8-dev] Re: Remove the patching of the debug break stub... (issue4106005)

LGTM http://codereview.chromium.org/4106005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Remove the patching of the debug break stub... (issue4106005)

Reviewers: Vyacheslav Egorov, Description: Remove the patching of the debug break stub This is no longer required to break at the function entry. Actually has not been required since the inlined stack check was introduced long time ago. Please review this at http://codereview.chromium.org/41

[v8-dev] Re: Issue 907 in v8: Duplicate keys in object literals are handled inconsistently

Updates: Status: Fixed Comment #2 on issue 907 by karlkl...@chromium.org: Duplicate keys in object literals are handled inconsistently http://code.google.com/p/v8/issues/detail?id=907 (No comment was entered for this change.) -- v8-dev mailing list v8-dev@googlegroups.com http://grou

[v8-dev] [v8] r5725 committed - Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in...

Revision: 5725 Author: mikhail.naga...@gmail.com Date: Thu Oct 28 04:34:57 2010 Log: Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU profiler. Review URL: http://codereview.chromium.org/4172006 http://code.google.com/p/v8/source/detail?r=5725 Modified: /branches/2.

[v8-dev] Re: Add bignum fall-back when the fast dtoa doesn't succeed. This removes Gay's d... (issue3468003)

Updated bignum-implementation. It is now the same as for the pending strtod CL. http://codereview.chromium.org/3468003/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU pr... (issue4172006)

LGTM http://codereview.chromium.org/4172006/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU pr... (issue4172006)

Reviewers: Søren Gjesse, Description: Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU profiler. Please review this at http://codereview.chromium.org/4172006/show SVN Base: http://v8.googlecode.com/svn/branches/2.4/ Affected files: M src/log.cc M src/vers

[v8-dev] [v8] r5724 committed - Add gc() calls to some tests to please valgrind....

Revision: 5724 Author: erik.co...@gmail.com Date: Thu Oct 28 01:43:47 2010 Log: Add gc() calls to some tests to please valgrind. Review URL: http://codereview.chromium.org/4116005 http://code.google.com/p/v8/source/detail?r=5724 Modified: /branches/bleeding_edge/src/execution.cc /branches/bleed

[v8-dev] Issue 915 in v8: liveedit iterates incorrectly over the pointers in the stack

Status: Accepted Owner: peter.rybin Labels: Type-Bug Priority-Medium New issue 915 by erik.corry: liveedit iterates incorrectly over the pointers in the stack http://code.google.com/p/v8/issues/detail?id=915 In VisitPointers in liveedit.cc we iterate over the heap and collect pointers to th

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

Comment #53 on issue 164 by phistuck: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 @carlosh - Sorry, you are right about Safari and FireFox, I did not read the results from comment 12 correctly. Still, Internet Explorer 9 exhibits the same beh

[v8-dev] [v8] r5723 committed - Landing for Rodolph Perfetta....

Revision: 5723 Author: a...@chromium.org Date: Thu Oct 28 00:35:07 2010 Log: Landing for Rodolph Perfetta. Fix the ARM simulator, the ARM disassembler and extend the stop feature. The stop feature in the simulator now support enabling, disabling and counting. BUG=None TEST=None http://code.googl

[v8-dev] Re: Fix the last USE_SIMULATOR mips issue introduced with my last arm... (issue4151005)

LGTM http://codereview.chromium.org/4151005/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Fix the ARM simulator, the ARM disassmebler and extend the stop feature.... (issue3606009)

Landed in revision 5723. Closing issue. http://codereview.chromium.org/3606009/show -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r5722 committed - Fix the last USE_SIMULATOR mips issue introduced with my last arm...

Revision: 5722 Author: a...@chromium.org Date: Thu Oct 28 00:33:51 2010 Log: Fix the last USE_SIMULATOR mips issue introduced with my last arm simulator change. Review URL: http://codereview.chromium.org/4151005 http://code.google.com/p/v8/source/detail?r=5722 Modified: /branches/bleeding_edge/