Reviewers: Karl Klose,
Description:
Remove semicolons from tools/test.py
Please review this at http://codereview.chromium.org/6822046/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M tools/test.py
Index: tools/test.py
===
Revision: 7582
Author: karlkl...@chromium.org
Date: Mon Apr 11 23:44:15 2011
Log: ARM: Add optimization for constant RHS in DoMulI.
Patch by ARM Ltd.
Review URL: http://codereview.chromium.org/6756033
http://code.google.com/p/v8/source/detail?r=7582
Modified:
/branches/bleeding_edge
Revision: 7581
Author: ri...@chromium.org
Date: Mon Apr 11 23:26:38 2011
Log: Fix tools/test.py to allow CTRL+C to work correctly again.
This also changes the AfterRun functions to allow None as the passed in
parameter.
Review URL: http://codereview.chromium.org/6824040
http://code.
Revision: 7580
Author: sgje...@chromium.org
Date: Mon Apr 11 23:12:45 2011
Log: ARM: Always enable ARMv7 when VFPv3 is enabled.
R=vego...@chromium.org, rodolph.perfe...@gmail.com
BUG=v8:1317
TEST=
Review URL: http://codereview.chromium.org//6825037
http://code.google.com/p/v8/source/
Revision: 7579
Author: ri...@chromium.org
Date: Mon Apr 11 22:56:07 2011
Log: Merge r7578 "Fix retained object info leak." to trunk
Review URL: http://codereview.chromium.org/6813104
http://code.google.com/p/v8/source/detail?r=7579
Modified:
/trunk/src/global-handles.h
/trunk/src/ver
Reviewers: Kasper Lund,
Description:
Merge r7578 "Fix retained object info leak." to trunk
Please review this at http://codereview.chromium.org/6813104/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/global-handles.h
M src/version.cc
Index: src/global-handles
LGTM.
On Tue, Apr 12, 2011 at 7:51 AM, wrote:
> Reviewers: Kasper Lund,
>
> Description:
> Merge r7578 "Fix retained object info leak." to trunk
>
> Please review this at http://codereview.chromium.org/6813104/
>
> SVN Base: http://v8.googlecode.com/svn/trunk/
>
> Affected files:
> M src/gl
Revision: 7578
Author: vita...@chromium.org
Date: Mon Apr 11 22:08:13 2011
Log: Fix retained object info leak.
Review URL: http://codereview.chromium.org/6813101
http://code.google.com/p/v8/source/detail?r=7578
Modified:
/branches/bleeding_edge/src/global-handles.h
=
LGTM, but consider guarding against repeated ObjectGroup::Dispose
invocations in debug mode (maybe this also applies to other Dispose
methods). Feel free to *not* do this as part of this CL.
On Tue, Apr 12, 2011 at 6:51 AM, wrote:
> Reviewers: Mads Ager,
>
> Description:
> Fix retained object in
Reviewers: Mads Ager,
Description:
Fix retained object info leak.
Please review this at http://codereview.chromium.org/6813101/
Affected files:
M src/global-handles.h
Index: src/global-handles.h
diff --git a/src/global-handles.h b/src/global-handles.h
index
3b6b7b3a7e28c783bab14dc2f463bd7
Indeed - I'll add that.
On Mon, Apr 11, 2011 at 7:40 PM, wrote:
>
> http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc
> File src/platform-win32.cc (right):
>
>
> http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc#newcode1531
> src/platform-win32.cc:1531: _begin
http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc
File src/platform-win32.cc (right):
http://codereview.chromium.org/6825061/diff/1/src/platform-win32.cc#newcode1531
src/platform-win32.cc:1531: _beginthreadex(NULL,
Shouldn't we still assert thread creation succeeded?
http://co
LGTM
http://codereview.chromium.org/6822042/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7577
Author: dim...@chromium.org
Date: Mon Apr 11 17:49:30 2011
Log: Another attempt to fix Win build.
Review URL: http://codereview.chromium.org/6825061
http://code.google.com/p/v8/source/detail?r=7577
Modified:
/branches/bleeding_edge/src/platform-win32.cc
===
Reviewers: Vitaly Repeshko,
Message:
TBR=vitalyr
Description:
Another attempt to fix Win build.
Please review this at http://codereview.chromium.org/6825061/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/platform-win32.cc
Index: src/platform-win3
Revision: 7576
Author: dim...@chromium.org
Date: Mon Apr 11 17:42:27 2011
Log: Fix build borkage due to r7575
(landing for Dmitry Lomov)
Review URL: http://codereview.chromium.org/6823065
http://code.google.com/p/v8/source/detail?r=7576
Modified:
/branches/bleeding_edge/src/platform-w
Reviewers: Vitaly Repeshko,
Message:
TBR=vitalyr
Original patch: http://codereview.chromium.org/6822042/
Description:
Fix build borkage due to r7575
(landing for Dmitry Lomov)
Please review this at http://codereview.chromium.org/6823065/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding
Comment #17 on issue 1244 by coldredl...@gmail.com:
v8::internal::Runtime_SetProperty comparison always false due to limited
range of data type
http://code.google.com/p/v8/issues/detail?id=1244
can this fix be merged back into 3.1?
--
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
Fix for Win32 build - I need help landing this as I do not have
presmissions.
http://codereview.chromium.org/6816038/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7575
Author: vita...@chromium.org
Date: Mon Apr 11 16:46:22 2011
Log: Do not rely on uniqueness of pthread_t
Patch by Dmitry Lomov.
pthreads implementations are free to reuse pthread_t (thread id) after
the thread has died. This change gets rid of ThreadHandle class and
repl
http://codereview.chromium.org/6673011/diff/17002/src/extensions/experimental/collator.cc
File src/extensions/experimental/collator.cc (right):
http://codereview.chromium.org/6673011/diff/17002/src/extensions/experimental/collator.cc#newcode69
src/extensions/experimental/collator.cc:69: static v
I left alone the binding part as was done initially. So, directly passing
'collator.compare' wouldn't work because 'compare' is not bound to a
Collator.
We can sort that out once the ECMAScript committee has an agreement. For
internal use in ChromeOS, it should not matter.
http://codereview
Reviewers: Mads Ager,
Description:
Add global setup for runtime profiler.
Whether it's enabled or not must not change while we're running. Let's
not waste time recomputing it. This also makes the VM state tracking
code slightly more lightweight.
Please review this at http://codereview.chromium.
Status: New
Owner:
New issue 1321 by a...@chromium.org: ToObject should throw when called with
null or undefined.
http://code.google.com/p/v8/issues/detail?id=1321
The spec has plenty of places where ToObject is being used and it should
throw a TypeError if called in undefined or null
Still LGTM
http://codereview.chromium.org/6816038/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Style issues fixed + use atomic for highest_thread_id_
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc#newcode57
src/isolate.cc:57: Mutex* ThreadId::thread_id_process_wide_mutex_ =
OS::C
Reviewers: Mads Ager,
Message:
We have to move JavaScript code from cc file since it's becoming
increasingly
harder to edit without errors.
In case you don't like me adding I18N enum to natives.h, I could change
js2c.py
to generate different files depending on TYPE (CORE, D8, I18N) and then
Reviewers: fschneider,
Description:
Fit Representation and HType in one word to make HValue smaller.
Please review this at http://codereview.chromium.org/6813091/
Affected files:
M src/hydrogen-instructions.h
Index: src/hydrogen-instructions.h
diff --git a/src/hydrogen-instructions.h b/src/
Thanks for the review - I'll fix the style issues.
I have two comments on your comments.
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc#newcode57
src/isolate.cc:57: Mutex* ThreadId::th
http://codereview.chromium.org/6826026/diff/1/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):
http://codereview.chromium.org/6826026/diff/1/src/runtime-profiler.cc#newcode135
src/runtime-profiler.cc:135: state_counts_[IN_NON_JS_STATE] =
kStateWindowSize;
On 2011/04/11 06:10:06, Kas
LGTM
http://codereview.chromium.org/6820003/diff/6/src/messages.cc
File src/messages.cc (right):
http://codereview.chromium.org/6820003/diff/6/src/messages.cc#newcode134
src/messages.cc:134: v8::TryCatch tryCatch;
nit: noCamelCase
http://codereview.chromium.org/6820003/diff/6/test/cctest/test-
LGTM with a few style nits and one real comment.
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc
File src/isolate.cc (right):
http://codereview.chromium.org/6816038/diff/5001/src/isolate.cc#newcode57
src/isolate.cc:57: Mutex* ThreadId::thread_id_process_wide_mutex_ =
OS::CreateM
thanks a lot for review, guys. Landed.
http://codereview.chromium.org/6820003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
http://codereview.chromium.org/6820003/diff/1/test/cctest/test-api.cc#oldcode8680
test/cctest/test-api.cc:8680: CompileRun("throw 'ThrowInJS';");
On
Revision: 7574
Author: ant...@chromium.org
Date: Mon Apr 11 09:16:52 2011
Log: Allow recursive messages reporting as it is already used.
Instead discard unhandled exceptions thown while running
message listeners.
Review URL: http://codereview.chromium.org/6820003
http://code.google.co
Status: Accepted
Owner: peter.ry...@gmail.com
Labels: Type-Bug Priority-Medium
New issue 1320 by peter.ry...@gmail.com: LiveEdit: text differencer fails
with out of memory on large files
http://code.google.com/p/v8/issues/detail?id=1320
If you try to edit file with many lines, text difference
Reviewers: Kevin Millikin, Kasper Lund,
Description:
Change the list of statements that are inlineable into a black-list.
Before we had a white-list of things that we allow inside inlined functions.
This way we can enable new constructs one-by-one.
Please review this at http://codereview.chrom
LGTM, to the limit of my Python readability.
http://codereview.chromium.org/6824040/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Yep.
On Mon, Apr 11, 2011 at 3:39 PM, wrote:
> OK, LGTM
>
> This takes it roughly back to what it was for this part, right?
>
> http://codereview.chromium.org/6820003/
>
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I have checked and currently there is no way to tell which vfp version is
specified using gcc defines.
so LGTM.
On 11 April 2011 15:10, wrote:
>
> http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc
> File src/arm/assembler-arm.cc (right):
>
>
> http://codereview.chromium.
Reviewers: Lasse Reichstein,
Description:
Fix tools/test.py to allow CTRL+C to work correctly again.
This also changes the AfterRun functions to allow None as the passed in
parameter.
Please review this at http://codereview.chromium.org/6824040/
SVN Base: http://v8.googlecode.com/svn/branches/
http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#newcode63
src/arm/assembler-arm.cc:63: #if defined(__VFP_FP__) &&
!defined(__SOFTFP__)
On 2011/04/11 12:48:55
Revision: 7573
Author: mm...@chromium.org
Date: Mon Apr 11 06:54:30 2011
Log: Bring test262 expectations up-to-date.
Add missing *.js files into Xcode project.
BUG=
TEST=
Review URL: http://codereview.chromium.org/6826036
http://code.google.com/p/v8/source/detail?r=7573
Modified:
/b
Thanks, landed after making the change.
http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js
File test/test262/harness-adapt.js (right):
http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js#newcode55
test/test262/harness-adapt.js:55: res = 'fail'; e
...and landed.
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js
File test/mjsunit/compiler/regress-max.js (right):
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js#newcode34
test/mjsunit/compiler/regress-max.js:34:
%OptimizeFun
Revision: 7572
Author: jkumme...@chromium.org
Date: Mon Apr 11 06:24:50 2011
Log: Introduce runtime function %OptimizeFunctionOnNextCall to
manually trigger optimization.
TEST=existing unit tests still pass
Review URL: http://codereview.chromium.org/6821009
http://code.google.com/p
LGTM
http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js
File test/test262/harness-adapt.js (right):
http://codereview.chromium.org/6826036/diff/1/test/test262/harness-adapt.js#newcode55
test/test262/harness-adapt.js:55: res = 'fail'; error = e;
Not from this cl, but put
LGTM
http://codereview.chromium.org/6826036/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager, Rico,
Description:
Bring test262 expectations up-to-date.
Add missing *.js files into Xcode project.
BUG=
TEST=
Please review this at http://codereview.chromium.org/6826036/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/test262/
LGTM
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js
File test/mjsunit/compiler/regress-max.js (right):
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/regress-max.js#newcode34
test/mjsunit/compiler/regress-max.js:34:
%OptimizeFunctionOnNex
I agree with most of your comments, but a few of the methods do not get
inlined.
Of course I can still remove their optimization triggers if you want me to.
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/optimized-function-calls.js
File test/mjsunit/compiler/optimized-func
http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
http://codereview.chromium.org/6825037/diff/2001/src/arm/assembler-arm.cc#newcode63
src/arm/assembler-arm.cc:63: #if defined(__VFP_FP__) &&
!defined(__SOFTFP__)
This would be true for
Revision: 7571
Author: karlkl...@chromium.org
Date: Mon Apr 11 05:36:56 2011
Log: Tagging version 3.2.9
http://code.google.com/p/v8/source/detail?r=7571
Added:
/tags/3.2.9
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 7569
Author: karlkl...@chromium.org
Date: Mon Apr 11 05:14:53 2011
Log: Prepare push to trunk. Now working on version 3.2.10.
Review URL: http://codereview.chromium.org/6820029
http://code.google.com/p/v8/source/detail?r=7569
Modified:
/branches/bleeding_edge/ChangeLog
/bra
LGTM with that.
http://codereview.chromium.org/6820029/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Could you put in a line about the sampler thread suspension fix. That one is
important.
http://codereview.chromium.org/6820029/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: Accepted
Owner: sgje...@chromium.org
CC: fschnei...@chromium.org
Labels: Type-FeatureRequest Priority-Low
New issue 1319 by fschnei...@chromium.org: Consider reintroducing
IntegerModStub code on ARM
http://code.google.com/p/v8/issues/detail?id=1319
In the process of removing unused co
Revision: 7568
Author: mikhail.naga...@gmail.com
Date: Mon Apr 11 04:49:55 2011
Log: Fix x64 build after r7567
http://code.google.com/p/v8/source/detail?r=7568
Modified:
/branches/bleeding_edge/src/x64/lithium-codegen-x64.cc
===
--- /branches/bleed
Updates:
Status: Fixed
Comment #1 on issue 1304 by mikhail@gmail.com: [Cleanup] Brush
up 'explicit' usage
http://code.google.com/p/v8/issues/detail?id=1304
There is a bug in cpplint, which prevents it from detecting non-explicit
single-arg constructors marked as inline. I fixed
Reviewers: Mads Ager,
Description:
Prepare push to trunk. Now working on version 3.2.10.
Please review this at http://codereview.chromium.org/6820029/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: ChangeLog
Updates:
Labels: HW-ARM
Comment #3 on issue 1301 by sgje...@chromium.org: tests fail & dysfunction
on armv7a-hardfloat-linux-gnueabi
http://code.google.com/p/v8/issues/detail?id=1301
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://group
Revision: 7567
Author: mikhail.naga...@gmail.com
Date: Mon Apr 11 04:38:34 2011
Log: Mark single-argument inline constructors as 'explicit'.
There is currently a bug in cpplint.py hiding this problem.
R=sgje...@chromium.org
BUG=1304
TEST=none
Review URL: http://codereview.chromium.or
OK, LGTM
This takes it roughly back to what it was for this part, right?
http://codereview.chromium.org/6820003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
Reenable ctrl-c on tools/test by removing intialization of result in Run.
The initialization of result was introduced in 7452 in addition to
enabling the preparser.
Please review this at http://codereview.chromium.org/6824038/
SVN Base: http://v8.googl
Status: Accepted
Owner: mm...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1318 by mm...@chromium.org: Exception location incorrect when
using ? : within exception constructor argument list
http://code.google.com/p/v8/issues/detail?id=1318
function f(a) {
throw new SyntaxError(
Looks great.
One suggestion for replacing the contents of a test.
A number of explicit optimizations of something that should be inlined. I
think
they can be removed.
http://codereview.chromium.org/6821009/diff/1/test/mjsunit/compiler/optimized-function-calls.js
File test/mjsunit/compiler/o
LGTM - how about the bug in cpplint.py?
http://codereview.chromium.org/6820028/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/6825037/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Vyacheslav Egorov, Rodolph Perfetta,
Description:
ARM: Always enable ARMv7 when VFPv3 is enabled.
R=vego...@chromium.org, rodolph.perfe...@gmail.com
BUG=v8:1317
TEST=
Please review this at http://codereview.chromium.org/6825037/
SVN Base: https://v8.googlecode.com/svn/branches/ble
Reviewers: Søren Gjesse,
Description:
Mark single-argument inline constructors as 'explicit'.
There is currently a bug in cpplint.py hiding this problem.
R=sgje...@chromium.org
BUG=1304
TEST=none
Please review this at http://codereview.chromium.org/6820028/
SVN Base: https://v8.googlecode.co
Updates:
Status: Fixed
Comment #3 on issue 1316 by sgje...@chromium.org: Builtin ARM disassembler
does not support coprocessor instructions
http://code.google.com/p/v8/issues/detail?id=1316
With r7565 the support for ABI prior to EABI was removed. Together with
that the instructions
LGTM
http://codereview.chromium.org/6826032/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Søren Gjesse,
Description:
Remove code from the deprecated GenericBinaryOpStub.
All platforms are now using the TypeRecordingBinaryOpStub.
I also removed the ARM IntegerModStub which was called from
the GenericBinaryOpStub.
Please review this at http://codereview.chromium.org/682603
Revision: 7564
Author: sgje...@chromium.org
Date: Mon Apr 11 01:59:29 2011
Log: ARM: Fix wrong fall through handling
Looks like a copy/paste mistake.
R=kmilli...@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org//6826031
http://code.google.com/p/v8/source/detail?r=7
Revision: 7565
Author: sgje...@chromium.org
Date: Mon Apr 11 02:04:30 2011
Log: ARM: Remove support for ABI prior to EABI
The support for the old ABI is known to be broken and has been deprecated
for some time now. Removed the instructions for loading and storing
co-processor regis
http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newcode951
src/arm/code-stubs-arm.cc:951: // registers 0 and 1.
On 2011/04/11 08:48:02, Karl Klose wrote:
r0
LGTM.
http://codereview.chromium.org/6826031/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Kevin Millikin,
Description:
ARM: Fix wrong fall through handling
Looks like a copy/paste mistake.
R=kmilli...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/6826031/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M
LGTM.
http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6822025/diff/14/src/arm/code-stubs-arm.cc#newcode951
src/arm/code-stubs-arm.cc:951: // registers 0 and 1.
r0 and r1 instead of registers 0 and 1?
Reviewers: Karl Klose,
Description:
ARM: Remove support for ABI prior to EABI
The support for the old ABI is known to be broken and has been deprecated
for
some time now. Removed the instructions for loading and storing co-processor
registers as they where only used to support the old ABI.
R
http://codereview.chromium.org/6820003/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
http://codereview.chromium.org/6820003/diff/1/test/cctest/test-api.cc#oldcode8680
test/cctest/test-api.cc:8680: CompileRun("throw 'ThrowInJS';");
Can we rewrite this listener to make it ree
80 matches
Mail list logo
