[v8-dev] Re: Prepare push to trunk. Now working on version 3.4.1. (issue7087025)

2011-05-29 Thread ager
LGTM with one line removed from the ChangeLog. http://codereview.chromium.org/7087025/diff/1/ChangeLog File ChangeLog (right): http://codereview.chromium.org/7087025/diff/1/ChangeLog#newcode7 ChangeLog:7: Made calls to JS builtins pass undefined when called with implicit This was reverted. I wi

[v8-dev] Re: Heap profiler: fetch document.URL of global objects. (issue7082012)

2011-05-29 Thread sgjesse
LGTM http://codereview.chromium.org/7082012/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Removed all references to v8/src from i18n extension code. (issue7077012)

2011-05-29 Thread ager
LGTM, thanks for doing this Nebojša! http://codereview.chromium.org/7077012/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r8090 committed - linux: extend the ifdefs in shell.cc to cover V8_SHARED too...

2011-05-29 Thread codesite-noreply
Revision: 8090 Author: a...@chromium.org Date: Sun May 29 23:10:41 2011 Log: linux: extend the ifdefs in shell.cc to cover V8_SHARED too Review URL: http://codereview.chromium.org/7076030 http://code.google.com/p/v8/source/detail?r=8090 Modified: /branches/bleeding_edge/samples/shell

[v8-dev] Prepare push to trunk. Now working on version 3.4.1. (issue7087025)

2011-05-29 Thread ricow
Reviewers: ager, Description: Prepare push to trunk. Now working on version 3.4.1. Please review this at http://codereview.chromium.org/7087025/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M ChangeLog M src/version.cc Index: ChangeLog

[v8-dev] Re: linux: extend the ifdefs in shell.cc to cover V8_SHARED too (issue7076030)

2011-05-29 Thread ager
LGTM http://codereview.chromium.org/7076030/ -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] [v8] r8089 committed - Correctly set the length of string before creating filler object in th...

2011-05-29 Thread codesite-noreply
Revision: 8089 Author: ri...@chromium.org Date: Sun May 29 23:04:36 2011 Log: Correctly set the length of string before creating filler object in the json parser (fixes crbug 84186). Testcase created based on the supplied test case from the bug report, but using json parse directl

[v8-dev] Re: Correctly set the length of string before creating filler object in the json parser (fixes crbug ... (issue7084023)

2011-05-29 Thread ager
LGTM http://codereview.chromium.org/7084023/diff/1/test/mjsunit/regress/regress-crbug-84186.js File test/mjsunit/regress/regress-crbug-84186.js (right): http://codereview.chromium.org/7084023/diff/1/test/mjsunit/regress/regress-crbug-84186.js#newcode28 test/mjsunit/regress/regress-crbug-84186.j

[v8-dev] Re: Heap profiler: fetch document.URL of global objects. (issue7082012)

2011-05-29 Thread vitalyr
LGTM with comments addressed. http://codereview.chromium.org/7082012/diff/2001/src/profile-generator.cc File src/profile-generator.cc (right): http://codereview.chromium.org/7082012/diff/2001/src/profile-generator.cc#newcode1668 src/profile-generator.cc:1668: JSObject::cast(object))); nit: Fits

[v8-dev] Correctly set the length of string before creating filler object in the json parser (fixes crbug ... (issue7084023)

2011-05-29 Thread ricow
Reviewers: Mads Ager, Description: Correctly set the length of string before creating filler object in the json parser (fixes crbug 84186). Testcase created based on the supplied test case from the bug report, but using json parse directly instead of through the chrome javascript console. Pl