On 2011/07/26 05:56:36, Rico wrote:
TBR: yangguo
LGTM
http://codereview.chromium.org/7495033/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 8740
Author: ri...@chromium.org
Date: Mon Jul 25 23:03:36 2011
Log: Update oom_dump README to indicate that people should build the
correct V8 version.
Review URL: http://codereview.chromium.org/7198021
http://code.google.com/p/v8/source/detail?r=8740
Modified:
/branches/
Revision: 8739
Author: ri...@chromium.org
Date: Mon Jul 25 22:56:45 2011
Log: Switch from sample shell to d8 for unit test
Landing for yangguo to coordinate with buildbot update.
Original codereview: http://codereview.chromium.org/7282008/
Review URL: http://codereview.chromium.org/74
Reviewers: yangguo,
Message:
TBR: yangguo
Description:
Switch from sample shell to d8 for unit test
Landing for yangguo to coordinate with buildbot update.
Original codereview: http://codereview.chromium.org/7282008/
Please review this at http://codereview.chromium.org/7495033/
SVN Base: htt
webkit enable web workers with JSC engine by lock/unlock function in
multi-threads, and I sample it with V8 engine, it's OK when I test
with the page http://www.whatwg.org/demos/workers/primes/page.html,
but if I transfer to other test web page, for example, SunSpider test
case, Webkit will crash i
Added the test snippet from Vitaly to cctest. I decided to completely
overload
Dictionary::FindEntry and Dictionary::Add, because the base implementation
should not be called for object dictionaries anyways.
http://codereview.chromium.org/7385006/
--
v8-dev mailing list
v8-dev@googlegroups.com
Yes, ObjectDictionary::AddChecked (suggestions for a better name
appreciated)
makes sure each object added to the dictionary has a hash attached to it.
You
are right, lookups of objects not in the table trigger the assertion. I
will fix
that. Thanks!
On 2011/07/25 17:45:17, Vitaly Repeshko
I guess the intent was to rely on the fact that objects without allocated
hash
codes can't possibly be already present as keys in a dictionary. In this
case
the lookup logic should probably use a dummy hash code.
On 2011/07/25 17:37:17, Vitaly Repeshko wrote:
I'd be happy to review this, but
I'd be happy to review this, but I don't understand how it's supposed to
work
when a hash allocation fails on lookup? E.g., if I add this code to the
provided
test
for (int i = 0; i < 10; i++) {
Handle o = FACTORY->NewJSArray(100);
dict->FindEntry(*o);
}
it triggers the asser
Updates:
Status: Fixed
Comment #3 on issue 1539 by jkumme...@chromium.org:
FunctionTemplate::SetPrototypeProperties breaks property lookup on the
prototype object
http://code.google.com/p/v8/issues/detail?id=1539
Fixed in r8737, will probably be rolled into Chromium on Wednesday. So
Since Slava is on vacation I thought it would be great if someone else could
review this. Is it OK to pass this on to you Mads?
http://codereview.chromium.org/7385006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
I addressed the feedback and I changed the heuristic to be more clearly
expressed in terms of backing storage memory usage. Please take another
look.
Thanks,
Vitaly
http://codereview.chromium.org/7464032/diff/1001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/7
Revision: 8738
Author: da...@chromium.org
Date: Mon Jul 25 08:43:41 2011
Log: remove dead code in fast double elements
* src/x64/lithium-codegen-x64.cc (DoLoadKeyedFastDoubleElement)
(DoStoreKeyedFastDoubleElement): Remove set but unused variables.
BUG=
TEST=Fixes a build with gcc-4
Revision: 8737
Author: jkumme...@chromium.org
Date: Mon Jul 25 08:01:45 2011
Log: Fix: FunctionTemplate::SetPrototypeAttributes broke prototype
object
BUG=v8:1539
TEST=cctest test-api/SetPrototypeAttributes
Review URL: http://codereview.chromium.org/7324027
http://code.google.com/p
Thanks for the review, comments addressed, landing.
http://codereview.chromium.org/7324027/diff/6001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/7324027/diff/6001/src/objects.cc#newcode2439
src/objects.cc:2439: // will silently fail).
On 2011/07/25 13:05:42, Rico
Revision: 8736
Author: svenpa...@chromium.org
Date: Mon Jul 25 07:08:36 2011
Log: Record ToBoolean's type information in Hydrogen's HBranch
instruction, so we can use it in LCodeGen::DoBranch later.
Review URL: http://codereview.chromium.org/7491043
http://code.google.com/p/v8/source
http://codereview.chromium.org/7461026/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/7461026/diff/1/src/hydrogen-instructions.h#newcode939
src/hydrogen-instructions.h:939: ToBooleanStub::Types
expected_input_types = ToBooleanStub::Typ
Updates:
Status: Fixed
Comment #4 on issue 1510 by fschnei...@chromium.org: Missing range analysis
for logical shift >>>
http://code.google.com/p/v8/issues/detail?id=1510
Improved range analysis for >>> in r8735.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.c
Revision: 8735
Author: fschnei...@chromium.org
Date: Mon Jul 25 06:28:35 2011
Log: Better range information for logical shift right >>>.
If the input range is positive and the shift count is constant
we can replace >>> with >> to compute the output range.
For negative inputs, we can o
LGTM.
http://codereview.chromium.org/7489043/diff/3004/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/7489043/diff/3004/src/hydrogen-instructions.h#newcode255
src/hydrogen-instructions.h:255: void Shr(int32_t value);
Unimplemented.
http://c
Reviewers: Mads Ager,
Description:
ARM: Fast path for compare against constant.
BUG=none
TEST=none
Please review this at http://codereview.chromium.org/7489045/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/constants-arm.h
M src/arm/lithi
Status: Accepted
Owner: svenpa...@chromium.org
Labels: Type-Bug Priority-Low
New issue 1571 by svenpa...@chromium.org: Improve TypeInfo::ToBooleanType's
return type
http://code.google.com/p/v8/issues/detail?id=1571
Because of several evil cycles in our v8 headers, we can't use
ToBooleanStub
Reviewers: William Hesse,
Description:
Better range information for logical shift right >>>.
If the input range is positive and the shift count is constant
we can replace >>> with >> to compute the output range.
For negative inputs, we can only compute a range if the
result always fits into a s
LGTM, are there some chromium guys that needs to change some bindings code?
http://codereview.chromium.org/7324027/diff/6001/src/objects.cc
File src/objects.cc (right):
http://codereview.chromium.org/7324027/diff/6001/src/objects.cc#newcode2439
src/objects.cc:2439: // will silently fail).
I can
On 2011/07/25 11:41:08, danno wrote:
Analogous dead code also exists on ia32. Can you please expand the patch
to
include those as well so that the platforms remain in sync?
Done. It looks fine, but I still need to set up a 32-bit build machine, so
please make sure it compiles before pushing.
LGTM.
http://codereview.chromium.org/7097011/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/7097011/diff/16001/src/mips/full-codegen-mips.cc
File src/mips/full-codegen-mips.cc (right):
http://codereview.chromium.org/7097011/diff/16001/src/mips/full-codegen-mips.cc#newcode374
src/mips/full-codegen-mips.cc:374: void
FullCodeGenerator::verify_stack_height()
LGTM.
http://codereview.chromium.org/7461026/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/7461026/diff/1/src/hydrogen-instructions.h#newcode939
src/hydrogen-instructions.h:939: ToBooleanStub::Types
expected_input_types = ToBooleanSt
Analogous dead code also exists on ia32. Can you please expand the patch to
include those as well so that the platforms remain in sync?
http://codereview.chromium.org/7491041/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM. I'll land this for you.
http://codereview.chromium.org/7491041/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 8734
Author: ri...@chromium.org
Date: Mon Jul 25 04:14:42 2011
Log: Tagging version 3.5.0
http://code.google.com/p/v8/source/detail?r=8734
Added:
/tags/3.5.0
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
[Mads to CC since he's on vacation.]
Rico: PTAL. I've discussed this new approach with Mads, but he hasn't seen
the
final result yet. The key idea is that since the ReadOnly flag is the only
prototype attribute we can safely modify without breaking assumptions
elsewhere,
we should provide a
Reviewers: danno,
Description:
remove dead code in fast double elements
* src/x64/lithium-codegen-x64.cc (DoLoadKeyedFastDoubleElement)
(DoStoreKeyedFastDoubleElement): Remove set but unused variables.
BUG=
TEST=Fixes a build with gcc-4.6.
Please review this at http://codereview.chromium.or
Revision: 8732
Author: ri...@chromium.org
Date: Mon Jul 25 03:51:46 2011
Log: Prepare push to trunk. Now working on 3.5.1.
Review URL: http://codereview.chromium.org/7493055
http://code.google.com/p/v8/source/detail?r=8732
Modified:
/branches/bleeding_edge/ChangeLog
/branches/bleedin
LGTM.
http://codereview.chromium.org/7493055/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Prepare push to trunk. Now working on 3.5.1.
Please review this at http://codereview.chromium.org/7493055/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: ChangeLog
=
Revision: 8731
Author: ri...@chromium.org
Date: Mon Jul 25 03:24:14 2011
Log: Revert r8719 - Enable unboxed double arrays by default.
It causes relibility bot crashes
Review URL: http://codereview.chromium.org/7461061
http://code.google.com/p/v8/source/detail?r=8731
Modified:
/branch
Looks good to me. Sad.
http://codereview.chromium.org/7461061/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: William Hesse,
Description:
Revert r8719 - Enable unboxed double arrays by default.
It causes relibility bot crashes
Please review this at http://codereview.chromium.org/7461061/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/flag-definit
LGTM.
http://codereview.chromium.org/7488016/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 8730
Author: svenpa...@chromium.org
Date: Mon Jul 25 00:49:36 2011
Log: Removed forgotten debugging code.
Review URL: http://codereview.chromium.org/7492042
http://code.google.com/p/v8/source/detail?r=8730
Modified:
/branches/bleeding_edge/src/runtime.cc
===
lgtm
http://codereview.chromium.org/7492042/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: danno,
Description:
Removed forgotten debugging code.
Please review this at http://codereview.chromium.org/7492042/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/runtime.cc
Index: src/runtime.cc
=
Updates:
Status: Fixed
Comment #2 on issue 285 by svenpa...@chromium.org: Newer SCons versions
(1.x+?) repeats compilation flags
http://code.google.com/p/v8/issues/detail?id=285
This has been fixed a few weeks ago, see
http://code.google.com/p/v8/source/detail?r=8505
--
v8-dev mai
44 matches
Mail list logo
