Reviewers: Yang,
Description:
MIPS: Fix implementation of string slices.
Bug on mips using at register innapropriately, use different reg as temp.
BUG=
TEST=
Please review this at http://codereview.chromium.org/7794020/
Affected files:
M src/mips/code-stubs-mips.cc
Index: src/mips/code-s
LGTM.
http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-crankshaft.js
File test/mjsunit/harmony/block-let-crankshaft.js (right):
http://codereview.chromium.org/7671042/diff/11001/test/mjsunit/harmony/block-let-crankshaft.js#newcode55
test/mjsunit/harmony/block-let
Status: New
Owner:
New issue 1645 by erig...@google.com: parseInt still parsing octal
http://code.google.com/p/v8/issues/detail?id=1645
As Annex E of ES5.1 says:
15.1.2.2: The specification of the function parseInt no longer allows
implementations to treat Strings beginning with a
LGTM
http://codereview.chromium.org/7744052/diff/9001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/7744052/diff/9001/src/ia32/code-stubs-ia32.cc#newcode5756
src/ia32/code-stubs-ia32.cc:5756: // Allocate new sliced string. At
this point we
This need more work.
Even if we stop simplifying sliced strings when running out of memory
during GC,
it can hurt other object types that can't tolerate allocation failures.
Whatever scheme we come up with should be memory efficient. In other words,
simplifying slices should not increase tota
No regression test, but good idea. We should make one.
We need to handle the calls to apply too.
Generally, we shouldn't call any function on a user provided object,
or one inherited from a user accessible prototype. That'll be fun:
Javascript without methods :)
/L
On Mon, Aug 29, 2011 at 22:22,
Is there a regression test for this?
http://codereview.chromium.org/7776008/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
This change worries me. This can cause a space explosion during GC for
pathological cases. It also adds a new case where strings can change shape,
which has historically been a source of nasty bugs (the cons string
short-circuiting). Do we have benchmark figures that support the change?
http:/
For data and pointer space we have a small number of buckets and discard the
very small free areas. This is done for speed and in the hope that we will
get
larger contiguous areas later if we don't fill the gaps with new objects.
To
get rid of long lived small free areas we rely on compacti
Revision: 9062
Author: ri...@chromium.org
Date: Mon Aug 29 10:54:12 2011
Log: Tagging version 3.5.9.1
http://code.google.com/p/v8/source/detail?r=9062
Added:
/tags/3.5.9.1
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9061
Author: ri...@chromium.org
Date: Mon Aug 29 10:44:42 2011
Log: Merge revision 9060 to trunk (removal of bogus assert)
Review URL: http://codereview.chromium.org/7796001
http://code.google.com/p/v8/source/detail?r=9061
Modified:
/trunk/src/jsregexp.cc
/trunk/src/version
LGTM
http://codereview.chromium.org/7796001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Mads Ager,
Description:
Merge revision 9060 to trunk (removal of bogus assert)
Please review this at http://codereview.chromium.org/7796001/
SVN Base: http://v8.googlecode.com/svn/trunk/
Affected files:
M src/jsregexp.cc
M src/version.cc
Index: src/jsregexp.cc
Thanks!
http://codereview.chromium.org/7745053/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Still LGTM, but feel free to wait for Vitlay's review as well.
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5728
src/ia32/code-stubs-ia32.cc:57
LGTM
http://codereview.chromium.org/7781013/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Added new patch set.
http://codereview.chromium.org/7784001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #3 on issue 1314 by yang...@chromium.org: Improve modulo operation
in lithium on IA32
http://code.google.com/p/v8/issues/detail?id=1314
Has already been committed.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
Please add a line "BUG=v8:1644" to the CL description to get auto-linking
goodness :-)
http://codereview.chromium.org/7786001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Description:
Fixed issue v8:1644 (bug in the chaining of fixup position)
The ARM and MIPS assemblers had a bug where they did not handle the last
element
in the list of code positions correctly during the fixup of offsets for
forward
jumps. This happened when the first inst
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5707
src/ia32/code-stubs-ia32.cc:5707: __ SmiTag(edx); // Make edx a smi
again.
On 2011/08/29 14:5
Reviewers: Vyacheslav Egorov,
Description:
Add specialized sweeper for cell and map space.
R=vego...@chromium.org
BUG=v8:1613
Please review this at http://codereview.chromium.org/7784001/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/gc
Affected files:
M src/mark-compact.h
Reviewers: Mikhail Naganov (Chromium),
Description:
Return v8::True or v8::False instead of using Boolean::New.
BUG=None
TEST=None
R=mnaga...@chromium.org
Signed-off-by: Thiago Farina
Please review this at http://codereview.chromium.org/7785001/
SVN Base: git://github.com/v8/v8.git@master
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5707
src/ia32/code-stubs-ia32.cc:5707: __ SmiTag(edx); // Make edx a smi
again.
On 2011/08/29 12:5
Added bailouts to hydrogen in case LET bindings are encountered and ported
the
code to x64 and arm.
On 2011/08/24 08:38:43, fschneider wrote:
One more comment: If the plan is to support this flag only on ia32, then
you
need to disable it for the other platforms (x64, arm, ...)
On 2011/08/
Reviewers: Michael Starzinger, Erik Corry,
Message:
Please take a look.
Description:
Convert sliced strings into sequential strings when promoting into old
space.
TEST=cctest test-strings/SliceConversion
Please review this at http://codereview.chromium.org/7736020/
SVN Base: https://v8.goo
Revision: 9060
Author: yang...@chromium.org
Date: Mon Aug 29 07:04:01 2011
Log: Removing bogus check introduced in r9027.
Review URL: http://codereview.chromium.org/7781013
http://code.google.com/p/v8/source/detail?r=9060
Modified:
/branches/bleeding_edge/src/jsregexp.cc
===
Reviewers: Rico,
Message:
I assume this looks good to you since we already discussed this change on
IM.
Description:
Removing bogus check introduced in r9027.
Please review this at http://codereview.chromium.org/7781013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affec
Reviewers: Kevin Millikin,
Description:
Make functions on the built-in object non-writable.
Please review this at http://codereview.chromium.org/7736018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
src/bootstrapper.cc
M sr
Revision: 9059
Author: yang...@chromium.org
Date: Mon Aug 29 06:29:55 2011
Log: MIPS: Fix an invalid stack-check in the simulator.
This fixes mjsunit regress-1132.
BUG=
TEST=
Review URL: http://codereview.chromium.org/7781002
http://code.google.com/p/v8/source/detail?r=9059
Modified
On 2011/08/29 06:22:10, Paul Lind wrote:
LGTM. I'll land.
http://codereview.chromium.org/7781002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9058
Author: yang...@chromium.org
Date: Mon Aug 29 06:04:33 2011
Log: Fix for a possible bug in RegExp stack guard.
Review URL: http://codereview.chromium.org/7744051
http://code.google.com/p/v8/source/detail?r=9058
Modified:
/branches/bleeding_edge/src/arm/regexp-macro-ass
Revision: 9057
Author: jkumme...@chromium.org
Date: Mon Aug 29 06:02:35 2011
Log: Convert a bunch of ASSERTs to STATIC_ASSERTs
making our debug binaries ever so slightly faster
Review URL: http://codereview.chromium.org/7776010
http://code.google.com/p/v8/source/detail?r=9057
Modifie
On 2011/08/29 12:47:33, Jakob wrote:
PTAL.
LGTM.
http://codereview.chromium.org/7776010/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Maybe Vitaly wants to have a look as well?
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
http://codereview.chromium.org/7744052/diff/1/src/ia32/code-stubs-ia32.cc#newcode5707
src/ia32/code-stubs-ia32.cc:5707: __ SmiTag(edx);
Reviewers: Yang,
Message:
PTAL.
Description:
Convert a bunch of ASSERTs to STATIC_ASSERTs
making our debug binaries ever so slightly faster
Please review this at http://codereview.chromium.org/7776010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ar
Revision: 9055
Author: fschnei...@chromium.org
Date: Mon Aug 29 05:19:43 2011
Log: Revert r9047 to fix broken build.
I need some more time to properly fix the problem.
TBR=kmilli...@chromium.org
Review URL: http://codereview.chromium.org/7781008
http://code.google.com/p/v8/source/deta
Reviewers: Kevin Millikin,
Description:
Revert r9047 to fix broken build.
I need some more time to properly fix the problem.
TBR=kmilli...@chromium.org
Committed: http://code.google.com/p/v8/source/detail?r=9055
Please review this at http://codereview.chromium.org/7781008/
SVN Base: http://v8
Revision: 9054
Author: yang...@chromium.org
Date: Mon Aug 29 04:56:48 2011
Log: MIPS: Fixed a RecordWrite call in the FullCodeGenerator.
This caused an occasional failure in the Threading2 cctest running in debug
mode with --always-opt.
BUG=
TEST=
Review URL: http://codereview.chr
On 2011/08/29 06:21:27, Paul Lind wrote:
Sven, sorry for the drive-by here, Søren suggested I submit to people who
"seem
to be around" until Danno gets back thanks in advance.
LGTM. I'll land.
http://codereview.chromium.org/7779007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
Reviewers: Kevin Millikin,
Description:
Fix broken debug build: Emit code for declarations later into the body block
(and not into the start block).
We hit asserts when trying to insert code into block 0 (start block), so
this
change moves the stack check and the declarations into the first b
Revision: 9053
Author: l...@chromium.org
Date: Mon Aug 29 04:44:54 2011
Log: Make built-in functions not rely on callback functions .call
method.
In builtin code, we can't rely on Function.prototype.call being unmolested.
Review URL: http://codereview.chromium.org/7776008
http://co
On 2011/08/26 22:29:05, Vitaly Repeshko wrote:
LGTM
http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/7477045/diff/62001/src/arm/code-stubs-arm.cc#newcode5444
src/arm/code-stubs-arm.cc:5444: __
Revision: 9052
Author: yang...@chromium.org
Date: Mon Aug 29 04:41:23 2011
Log: Small fix for STATIC_ASSERT.
Review URL: http://codereview.chromium.org/7776007
http://code.google.com/p/v8/source/detail?r=9052
Modified:
/branches/bleeding_edge/src/arm/code-stubs-arm.cc
/branches/blee
rubberstamp LGTM
http://codereview.chromium.org/7778013/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #2 on issue 1642 by jkumme...@chromium.org: Build failure due to
redundant code on Mac OSX 10.5.*
http://code.google.com/p/v8/issues/detail?id=1642
Fixed in r9043. Thanks for the report.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Reviewers: jkummerov_chromium.org,
Description:
NewGC: Merge bleeding edge up to 9009.
Please review this at http://codereview.chromium.org/7778013/
SVN Base: http://v8.googlecode.com/svn/branches/experimental/gc/
Affected files:
M .gitignore
M ChangeLog
M MERGE
M Makef
Revision: 9051
Author: l...@chromium.org
Date: Mon Aug 29 04:01:48 2011
Log: Create tag 3.3.10.31
http://code.google.com/p/v8/source/detail?r=9051
Added:
/tags/3.3.10.31
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9050
Author: l...@chromium.org
Date: Mon Aug 29 03:59:36 2011
Log: Create tag 3.3.10.32
http://code.google.com/p/v8/source/detail?r=9050
Added:
/tags/3.3.10.32
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9049
Author: l...@chromium.org
Date: Mon Aug 29 03:58:49 2011
Log: Create tag 3.3.10.33
http://code.google.com/p/v8/source/detail?r=9049
Added:
/tags/3.3.10.33
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9048
Author: l...@chromium.org
Date: Mon Aug 29 03:56:29 2011
Log: Create tag 3.4.14.14
http://code.google.com/p/v8/source/detail?r=9048
Added:
/tags/3.4.14.14
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9047
Author: fschnei...@chromium.org
Date: Mon Aug 29 03:50:47 2011
Log: Introduce support for local function declarations in Hydrogen.
Review URL: http://codereview.chromium.org/7782001
http://code.google.com/p/v8/source/detail?r=9047
Modified:
/branches/bleeding_edge/src/h
Revision: 9046
Author: l...@chromium.org
Date: Mon Aug 29 03:50:36 2011
Log: Create tag 3.4.14.15
http://code.google.com/p/v8/source/detail?r=9046
Added:
/tags/3.4.14.15
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9045
Author: l...@chromium.org
Date: Mon Aug 29 03:49:44 2011
Log: Create tag 3.4.14.16
http://code.google.com/p/v8/source/detail?r=9045
Added:
/tags/3.4.14.16
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9044
Author: l...@chromium.org
Date: Mon Aug 29 03:48:45 2011
Log: Create tag 3.4.14.17
http://code.google.com/p/v8/source/detail?r=9044
Added:
/tags/3.4.14.17
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9043
Author: jkumme...@chromium.org
Date: Mon Aug 29 03:47:00 2011
Log: Remove unnecessary break-after-return in switch statement
BUG=v8:1642
Review URL: http://codereview.chromium.org/7781007
http://code.google.com/p/v8/source/detail?r=9043
Modified:
/branches/bleeding_ed
LGTM, after error is fixed.
http://codereview.chromium.org/7776008/diff/1/src/array.js
File src/array.js (right):
http://codereview.chromium.org/7776008/diff/1/src/array.js#newcode1268
src/array.js:1268: var receiver = %GetDefaultReceiver(f);
This should be "callback", not f.
http://codereview
LGTM.
http://codereview.chromium.org/7782001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9042
Author: ri...@chromium.org
Date: Mon Aug 29 03:46:17 2011
Log: Tagging version 3.5.9
http://code.google.com/p/v8/source/detail?r=9042
Added:
/tags/3.5.9
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
http://codereview.chromium.org/7781007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Sven,
Message:
PTAL.
Description:
Remove unnecessary break-after-return in switch statement
BUG=v8:1642
Please review this at http://codereview.chromium.org/7781007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/elements.cc
Index: src/el
Reviewers: William Hesse,
Description:
Make built-in functions not rely on callback functions .call method.
In builtin code, we can't rely on Function.prototype.call being unmolested.
Please review this at http://codereview.chromium.org/7776008/
SVN Base: https://v8.googlecode.com/svn/branche
Revision: 9040
Author: l...@chromium.org
Date: Mon Aug 29 03:40:31 2011
Log: Port r9030 and part of r9016 to 3.3 branch.
Made FromPropertyDescriptor not hit inherited setters.
Changed computation of func.caller to skip some built-in functions.
Now skips built-in functions called from
http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc
File src/accessors.cc (right):
http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc#newcode690
src/accessors.cc:690: }
Whitespace, schmitespace!
Added.
http://codereview.chromium.org/7736011/
--
v8-dev mailing list
LGTM
http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc
File src/accessors.cc (right):
http://codereview.chromium.org/7736011/diff/1004/src/accessors.cc#newcode690
src/accessors.cc:690: }
Why no space between functions here?
http://codereview.chromium.org/7736011/
--
v8-dev mai
Reviewers: Rico,
Description:
Port r9030 and part of r9016 to 3.4 branch.
Made FromPropertyDescriptor not hit inherited setters.
Changed computation of func.caller to skip some built-in functions.
Now skips built-in functions called from other built-in functions,
so only the initally called bui
Revision: 9039
Author: ri...@chromium.org
Date: Mon Aug 29 03:15:47 2011
Log: Prepare push to trunk. Now working on version 3.5.10.
Review URL: http://codereview.chromium.org/7782002
http://code.google.com/p/v8/source/detail?r=9039
Modified:
/branches/bleeding_edge/ChangeLog
/branche
LGTM
http://codereview.chromium.org/7782002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Description:
Prepare push to trunk. Now working on version 3.5.10.
Please review this at http://codereview.chromium.org/7782002/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M ChangeLog
M src/version.cc
Index: ChangeL
Reviewers: Kevin Millikin,
Description:
Introduce support for local function declarations in Hydrogen.
Please review this at http://codereview.chromium.org/7782001/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/hydrogen.cc
Index: src/hydrogen.cc
=
LGTM
http://codereview.chromium.org/7776007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: jkummerow,
Message:
A valid static assert in the form STATIC_ASSERT( a < b ) would result in
compile failures similar to this:
../src/ia32/code-stubs-ia32.cc: In member function ‘virtual void
v8::internal::RegExpExecStub::Generate(v8::internal::MacroAssembler*)’:
../src/ia32/code-stu
Revision: 9038
Author: yang...@chromium.org
Date: Mon Aug 29 02:36:58 2011
Log: MIPS: port Tentative implementation of string slices (hidden
under the flag --string-slices).
Ported r9027 (e9a3514)
BUG=
TEST=
Review URL: http://codereview.chromium.org/7736010
http://code.google.com
Revision: 9037
Author: jkumme...@chromium.org
Date: Mon Aug 29 02:14:59 2011
Log: Fix warnings reported by MSVS for shared library build
TEST=compiles without warnings (esp. the shared-lib build with Visual
Studio)
Review URL: http://codereview.chromium.org/7745053
http://code.goog
Revision: 9036
Author: l...@chromium.org
Date: Mon Aug 29 02:12:40 2011
Log: Port r9018 and r9030 to the 3.4 branch.
Changed computation of func.caller to skip some built-in functions.
Now skips built-in functions called from other built-in functions,
so only the initally called built-
Revision: 9035
Author: vego...@chromium.org
Date: Mon Aug 29 02:10:27 2011
Log: MIPS: Fix KeyedStoreStubCompiler::GenerateStoreFastDoubleElement()
Test regress-91013.js (to ensure that the stored value was returned) passed
on mips
without this fix, since the input value (in value_reg
On 2011/08/29 06:06:25, Paul Lind wrote:
LGTM. I'll land this.
http://codereview.chromium.org/7736010/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM
Thanks Paul! I'll land.
http://codereview.chromium.org/7779006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
http://codereview.chromium.org/7774008/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Assigned
Owner: jkumme...@chromium.org
Comment #1 on issue 1642 by jkumme...@chromium.org: Build failure due to
redundant code on Mac OSX 10.5.*
http://code.google.com/p/v8/issues/detail?id=1642
I'll fix this.
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Revision: 9034
Author: fschnei...@chromium.org
Date: Mon Aug 29 01:46:35 2011
Log: Adjust unit test to avoid flakyness when running with the ARM
simulator.
In some cases the assert that the test function is not optimized fails
because the function may be optimized already after the
LGTM.
http://codereview.chromium.org/7745053/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9033
Author: yang...@chromium.org
Date: Mon Aug 29 01:41:39 2011
Log: Commenting register usage in MIPS.
Review URL: http://codereview.chromium.org/7775007
http://code.google.com/p/v8/source/detail?r=9033
Modified:
/branches/bleeding_edge/src/mips/assembler-mips.h
LGTM.
http://codereview.chromium.org/7775007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Message:
PTAL.
Description:
Commenting register usage in MIPS.
Please review this at http://codereview.chromium.org/7775007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/mips/assembler-mips.h
Index: src/mips/assembler
Updates:
Status: Assigned
Owner: svenpa...@chromium.org
Comment #1 on issue 1644 by yang...@chromium.org: Jumping as first
instruction in a stub in arm causes check to fail.
http://code.google.com/p/v8/issues/detail?id=1644
To see the failures (after removing the nop instructi
http://codereview.chromium.org/7774008/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Yang,
Message:
PTAL.
Darin: this is just FYI.
Description:
Fix warnings reported by MSVS for shared library build
TEST=compiles without warnings (esp. the shared-lib build with Visual
Studio)
Please review this at http://codereview.chromium.org/7745053/
SVN Base: https://v8.g
LGTM
http://codereview.chromium.org/7744051/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM.
We've previously reduced this loop from 5 to 2 iterations due to flakiness,
and
at first that seemed to be enough.
If the test is still flaky after this change, we should consider removing
the
following assertOptCount(f, 0) and assertIsOptimized(f). In theory they're
correct, but flak
Status: New
Owner:
New issue 1644 by yang...@google.com: Jumping as first instruction in a
stub in arm causes check to fail.
http://code.google.com/p/v8/issues/detail?id=1644
See code-stubs-arm.cc in SubStringStub::Generate, hidden under the
FLAG_string_slices condition. Removing nop r
Reviewers: jkummerow,
Description:
Adjust unit test to avoid flakyness when running with the ARM simulator.
In some cases the assert that the test function is not optimized fails
because the function may be optimized already after the second invocation.
(e.g. when running slow in debug mode)
Pl
Revision: 9032
Author: fschnei...@chromium.org
Date: Mon Aug 29 00:13:06 2011
Log: Landing: MIPS: Fixed a bug in a special case of
MacroAssembler::Ext.
Original code review: http://codereview.chromium.org/005/
Review URL: http://codereview.chromium.org/7778007
http://code.google
LGTM.
Will land it.
http://codereview.chromium.org/005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9031
Author: fschnei...@chromium.org
Date: Mon Aug 29 00:07:39 2011
Log: Remove code handling parameters rewritten to properties (aka
synthetic properties).
After merging the new arguments branch, there is no need for this code
anymore.
TEST=all tests pass
Review URL:
Reviewers: Erik Corry,
Description:
Port r9018 and r9030 to the 3.4 branch.
Changed computation of func.caller to skip some built-in functions.
Now skips built-in functions called from other built-in functions,
so only the initally called built-in function is exposed.
Make FromPropertyDescripto
96 matches
Mail list logo
