Status: New
Owner:
New issue 1776 by chineseo...@gmail.com: Uint32 type,some times not work(in
release mode,v8 version 3.1)
http://code.google.com/p/v8/issues/detail?id=1776
HI,can some one help me?
i met a case like this,in my js code,i write:
"
inline DWORD Cast(DWORD*, Local value)
Issue 1775: d8.gyp should allow building d8#host for
chrome/chrome_tests.gypi:browser_tests
http://code.google.com/p/v8/issues/detail?id=1775
This issue is now blocking issue chromium:99173.
See http://code.google.com/p/chromium/issues/detail?id=99173
--
You received this message because you a
Status: New
Owner:
New issue 1775 by s...@chromium.org: d8.gyp should allow building d8#host
for chrome/chrome_tests.gypi:browser_tests
http://code.google.com/p/v8/issues/detail?id=1775
Need to be able to build d8#host on platforms/trybots such as linux and
chromeos_linux_arm in order
Comment #2 on issue 1770 by l...@chromium.org: RegExp may hang v8
http://code.google.com/p/v8/issues/detail?id=1770
In particular, the offending part of the RegExp is likely to be "(.|\s)*?".
This tries first matching '.' and then, if continuing the match fails, then
matching a space and then
Comment #1 on issue 1772 by erig...@google.com: Updating property
attributes for elements does not work.
http://code.google.com/p/v8/issues/detail?id=1772
I failed to reproduce a similar problem for [[Configurable]]. Do you have
an example?
--
v8-dev mailing list
v8-dev@googlegroups.com
h
Status: New
Owner:
New issue 1774 by kalm...@homejinni.com: ARM/MIPS: mjsunit/function-bind.js
fails
http://code.google.com/p/v8/issues/detail?id=1774
The test fails in both debug and release mode on ARM and MIPS simulator. It
passes on x64 and ia32.
It appeared with r9659.
--
v8-de
Reviewers: Kevin Millikin,
Description:
Make _CallFunction proxy-aware.
R=kmilli...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/8318014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
M src/ia3
Status: New
Owner:
New issue 1773 by kalm...@homejinni.com: ARM/MIPS: mozilla
js1_5/extensions/regress-355497.js sometimes causes segmentation fault
http://code.google.com/p/v8/issues/detail?id=1773
This was tested on ARM and MIPS simulator in both release and debug mode.
The test does
Status: Accepted
Owner: mstarzin...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 1772 by mstarzin...@chromium.org: Updating property attributes
for elements does not work.
http://code.google.com/p/v8/issues/detail?id=1772
Currently updating either the [[Enumerable]] or the [[Config
Updates:
Status: WorkingAsIntended
Comment #1 on issue 1771 by vego...@chromium.org: Generalize the approach
of ExternalStringResource to any kind of Object
http://code.google.com/p/v8/issues/detail?id=1771
V8 delays WeakCallbacks invocations until full-collections to avoid looking
Revision: 9666
Author: keuc...@chromium.org
Date: Mon Oct 17 08:19:34 2011
Log: Replace calls_eval() by calls_non_strict_eval() where possible.
Review URL: http://codereview.chromium.org/8321002
http://code.google.com/p/v8/source/detail?r=9666
Modified:
/branches/bleeding_edge/src/ar
Rebased this to tip of tree. Please take a look again.
New are block scopes which are introduced for for-loops with let bound
iteration
variables, so you might want to look more carefully there.
http://codereview.chromium.org/7979001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Status: New
Owner:
New issue 1771 by enef...@gmail.com: Generalize the approach of
ExternalStringResource to any kind of Object
http://code.google.com/p/v8/issues/detail?id=1771
It would be a great improvement if there was a possibility to bind
JS objects and C++ objects so that the GC c
LGTM.
http://codereview.chromium.org/8321002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #5 on issue 893 by erig...@google.com: '.caller' and '.arguments'
not poisoned on bound functions
http://code.google.com/p/v8/issues/detail?id=893
On WebKit Nightly r97576,
(function foo() { alert(foo.caller); }).bind()()
alerts null. While this does not conform to the ES5.1 section
Updates:
Status: Duplicate
Mergedinto: 430
Comment #1 on issue 1770 by whe...@chromium.org: RegExp may hang v8
http://code.google.com/p/v8/issues/detail?id=1770
This looks like a case of exponential backtracking. See http://www.regular-
expressions.info/catastrophic.html
This i
Comment #7 on issue 430 by whe...@chromium.org: Regex hardlock
http://code.google.com/p/v8/issues/detail?id=430
Issue 1770 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Status: New
Owner:
New issue 1770 by kueb...@gmail.com: RegExp may hang v8
http://code.google.com/p/v8/issues/detail?id=1770
So I've found somekind of a bug, which lets you hang whole v8 vm.
I've used the second getting started code example from here:
http://code.google.com/intl/pl/apis/
Reviewers: Kevin Millikin,
Message:
PTAL.
Description:
Replace calls_eval() by calls_non_strict_eval() where possible.
Please review this at http://codereview.chromium.org/8321002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm.cc
Revision: 9665
Author: yang...@chromium.org
Date: Mon Oct 17 06:39:56 2011
Log: Rolling back r9662.
Review URL: http://codereview.chromium.org/8321001
http://code.google.com/p/v8/source/detail?r=9665
Modified:
/branches/bleeding_edge/src/extensions/externalize-string-extension.cc
/b
LGTM
http://codereview.chromium.org/8321001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Erik Corry,
Message:
please take a look.
Description:
Rolling back r9662.
Please review this at http://codereview.chromium.org/8321001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/extensions/externalize-string-extension.cc
M test/mjsuni
On 2011/10/17 13:22:44, Erik Corry wrote:
LGTM
http://codereview.chromium.org/8318003/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Accepted
Owner: l...@chromium.org
Labels: Type-Bug Priority-Low
Comment #4 on issue 893 by l...@chromium.org: '.caller' and '.arguments'
not poisoned on bound functions
http://code.google.com/p/v8/issues/detail?id=893
Making the bound function strict w
Revision: 9664
Author: erik.co...@gmail.com
Date: Mon Oct 17 06:27:57 2011
Log: Change to disable stupid gcc warning.
Review URL: http://codereview.chromium.org/8318003
http://code.google.com/p/v8/source/detail?r=9664
Modified:
/branches/bleeding_edge/src/api.cc
=
Reviewers: Yang,
Description:
Change to disable stupid gcc warning.
Please review this at http://codereview.chromium.org/8318003/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/api.cc
Index: src/api.cc
==
Rebased this to tip of tree. Could you please take a look.
http://codereview.chromium.org/7992005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9663
Author: mstarzin...@chromium.org
Date: Mon Oct 17 05:58:32 2011
Log: Mark Test262 test cases for known issue 893.
R=l...@chromium.org
BUG=v8:893
TEST=test262
Review URL: http://codereview.chromium.org/8320001
http://code.google.com/p/v8/source/detail?r=9663
Modified:
LGTM
http://codereview.chromium.org/8320001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9662
Author: yang...@chromium.org
Date: Mon Oct 17 05:49:34 2011
Log: Changes around ascii-check for strings wrt external strings.
Review URL: http://codereview.chromium.org/8312015
http://code.google.com/p/v8/source/detail?r=9662
Modified:
/branches/bleeding_edge/src/exten
Revision: 9661
Author: erikcorry
Date: Mon Oct 17 05:48:31 2011
Log: Improve speed of Utf8Write by always flattening the string first
and
detecting the ASCII case. Also rewrite Utf8Length to work on an
unflattened string. Bug: http://code.google.com/p/v8/issues/detail?id=1665
Revie
Revision: 9660
Author: l...@chromium.org
Date: Mon Oct 17 05:45:52 2011
Log: Make native syntax an early error in the preparser.
Previously the preparser always accepted natives syntax and let the
real parser throw the syntax error. In ES5, it should be an early error,
so the preparser
Revision: 9659
Author: l...@chromium.org
Date: Mon Oct 17 05:44:16 2011
Log: Reimplement Function.prototype.bind.
Make instanceof work correctly.
BUG=v8:893
Review URL: http://codereview.chromium.org/8199004
http://code.google.com/p/v8/source/detail?r=9659
Modified:
/branches/bleed
LGTM
http://codereview.chromium.org/8312015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
http://codereview.chromium.org/8306024/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Moved the enum, please check again.
http://codereview.chromium.org/8306024/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Fixed
Comment #3 on issue 1752 by mstarzin...@chromium.org: Operands of ">"
and "<=" should be evaluated left-to-right.
http://code.google.com/p/v8/issues/detail?id=1752
Fixed in r9641.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-
Added more tests, which also caught a bug!
http://codereview.chromium.org/8304021/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/8304021/diff/1/src/api.cc#newcode3638
src/api.cc:3638: if (str->IsAsciiRepresentation()) {
On 2011/10/17 09:40:51, Yang wrote:
IsAsciiRepr
http://codereview.chromium.org/8199004/diff/9001/test/mjsunit/function-bind.js
File test/mjsunit/function-bind.js (right):
http://codereview.chromium.org/8199004/diff/9001/test/mjsunit/function-bind.js#newcode107
test/mjsunit/function-bind.js:107: // Several parameters can be given,
and given in
First round of feedback ia32 stuff applies to other platforms whee
appropriate,
too.
http://codereview.chromium.org/8305001/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
http://codereview.chromium.org/8305001/diff/1/src/ia32/lithium-codegen-ia32.cc#new
Revision: 9658
Author: keuc...@chromium.org
Date: Mon Oct 17 05:19:06 2011
Log: Let bound iteration variables in for-loops
TEST=mjsunit/harmony/block-for.js
Review URL: http://codereview.chromium.org/7837028
http://code.google.com/p/v8/source/detail?r=9658
Added:
/branches/bleeding_
http://codereview.chromium.org/7837028/diff/6017/src/parser.cc
File src/parser.cc (right):
http://codereview.chromium.org/7837028/diff/6017/src/parser.cc#newcode2437
src/parser.cc:2437: // TODO(keuchel): move temporary variable to block
scope
This is an optimization. TEMPORARY variables are alwa
My bad. A cons string is flattened before a slice can be created from it.
http://codereview.chromium.org/8312015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
http://codereview.chromium.org/8312015/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
http://codereview.chromium.org/8312015/diff/1/src/objects-inl.h#newcode296
src/objects-inl.h:296: return
GetUnderlying()->IsAsciiRepresentationUnderneath();
Is it possible to make an arbitraryly deep
Revision: 9657
Author: keuc...@chromium.org
Date: Mon Oct 17 04:59:08 2011
Log: Disallow function declarations in statement positions in harmony
mode.
Review URL: http://codereview.chromium.org/8306025
http://code.google.com/p/v8/source/detail?r=9657
Modified:
/branches/bleeding_e
http://codereview.chromium.org/8306025/diff/1/src/parser.cc
File src/parser.cc (right):
http://codereview.chromium.org/8306025/diff/1/src/parser.cc#newcode1337
src/parser.cc:1337: if (top_scope_->is_strict_mode() ||
harmony_scoping_) {
Oops, indeed. Done.
On 2011/10/17 11:31:45, Lasse Reichstein
LGTM
http://codereview.chromium.org/7837028/diff/6017/src/parser.cc
File src/parser.cc (right):
http://codereview.chromium.org/7837028/diff/6017/src/parser.cc#newcode2437
src/parser.cc:2437: // TODO(keuchel): move temporary variable to block
scope
What does this mean? Is the current code not co
LGTM
Fixed the layout and added missing
semicolons while I was there (semicolons: it's not just a good idea, it's
the
law).
Hm, I would have preferred you not to do the latter at this point, since it
will
likely produce quite a few merge conflicts with my open CLs...
http://codereview.c
Revision: 9656
Author: yang...@chromium.org
Date: Mon Oct 17 04:41:34 2011
Log: Fixing compile error on win64.
R=jkumme...@chromium.org
BUG=
TEST=
Review URL: http://codereview.chromium.org/8317001
http://code.google.com/p/v8/source/detail?r=9656
Modified:
/branches/bleeding_edge/sr
lgtm
http://codereview.chromium.org/8317001/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Message:
please take a look.
Description:
Fixing compile error on win64.
R=jkumme...@chromium.org
BUG=
TEST=
Please review this at http://codereview.chromium.org/8317001/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/x64/macro-assem
The scanner doesn't have ot depend on the mode. It's just that it's
easier than having the parser conditionally convert keyword tokens to
identifiers.
I'll try to make a single enum, so that it doesn't have to duplicate the values.
/L
On Mon, Oct 17, 2011 at 13:13, wrote:
> Yes indeed, at the m
LGTM
http://codereview.chromium.org/8306025/diff/1/src/parser.cc
File src/parser.cc (right):
http://codereview.chromium.org/8306025/diff/1/src/parser.cc#newcode1337
src/parser.cc:1337: if (top_scope_->is_strict_mode() ||
harmony_scoping_) {
Ditto for the preparser?
http://codereview.chromium.o
Yes indeed, at the moment the preparser gets the information from the
scanner.
But this will need some cleanup soon. According to the draft the switching
between the modes will be more fine grained than one global switch, i.e. it
will
be possible to mix classic mode / strict mode / harmony mod
http://codereview.chromium.org/8306024/diff/1/src/parser.h
File src/parser.h (right):
http://codereview.chromium.org/8306024/diff/1/src/parser.h#newcode165
src/parser.h:165: kHarmonyScoping = kAllowNativesSyntax * 2
Not sure there is a reason. In the preparser, the parser gets the
harmony-scopin
I rebased this on
http://codereview.chromium.org/8306025/
to include all the recent changes. Could you please take a look.
http://codereview.chromium.org/7837028/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Lasse Reichstein,
Message:
Disallowing
for (..) function foo {}
in harmony mode. Please take a look. This is a prerequisite for
http://codereview.chromium.org/7837028
Description:
Disallow function declarations in statement positions in harmony mode.
Please review this at http://cod
I did upload it ... just not with the correct issue number *cough*.
Please look now :)
http://codereview.chromium.org/8199004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9655
Author: yang...@chromium.org
Date: Mon Oct 17 03:44:47 2011
Log: Porting r9605 to x64 (elements kind conversion in generated code).
Review URL: http://codereview.chromium.org/8271007
http://code.google.com/p/v8/source/detail?r=9655
Modified:
/branches/bleeding_edge/src
http://codereview.chromium.org/8306024/diff/1/src/parser.h
File src/parser.h (right):
http://codereview.chromium.org/8306024/diff/1/src/parser.h#newcode165
src/parser.h:165: kHarmonyScoping = kAllowNativesSyntax * 2
Why is there not harmony scoping flag in the preparser?
http://codereview.chrom
Reviewers: fschneider,
Description:
Make native syntax an early error in the preparser.
Previously the preparser always accepted natives syntax and let the
real parser throw the syntax error. In ES5, it should be an early error,
so the preparser must catch the error.
The perparser library does n
Revision: 9654
Author: l...@chromium.org
Date: Mon Oct 17 03:19:39 2011
Log: Create tag 3.7.0.1
http://code.google.com/p/v8/source/detail?r=9654
Added:
/tags/3.7.0.1
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9653
Author: l...@chromium.org
Date: Mon Oct 17 03:19:04 2011
Log: Port r9643 to 3.7 branch.
TBR: danno.
R=da...@chromium.org
Review URL: http://codereview.chromium.org/8314021
http://code.google.com/p/v8/source/detail?r=9653
Modified:
/trunk/src/compiler.cc
/trunk/src/c
Revision: 9652
Author: l...@chromium.org
Date: Mon Oct 17 02:37:35 2011
Log: Create tag 3.3.10.38
http://code.google.com/p/v8/source/detail?r=9652
Added:
/tags/3.3.10.38
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM with comments.
http://codereview.chromium.org/8304021/diff/1/src/api.cc
File src/api.cc (right):
http://codereview.chromium.org/8304021/diff/1/src/api.cc#newcode3638
src/api.cc:3638: if (str->IsAsciiRepresentation()) {
IsAsciiRepresentation() is not reliable for cons and slices with regard
Reviewers: Erik Corry,
Message:
Please take a look. Fixes some edge cases for ascii-ness checking.
Description:
Changes around ascii-check for strings wrt external strings.
Please review this at http://codereview.chromium.org/8312015/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_
Revision: 9651
Author: l...@chromium.org
Date: Mon Oct 17 02:37:00 2011
Log: Port r9643 to the 3.3 branch.
TBR: danno
R=da...@chromium.org
Review URL: http://codereview.chromium.org/8306023
http://code.google.com/p/v8/source/detail?r=9651
Modified:
/branches/3.3/src/compiler.cc
/br
Have you actually uploaded your latest changes? ;)
http://codereview.chromium.org/8199004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9650
Author: keuc...@chromium.org
Date: Mon Oct 17 02:29:37 2011
Log: Introduce with scope and rework variable resolution.
Review URL: http://codereview.chromium.org/7904008
http://code.google.com/p/v8/source/detail?r=9650
Modified:
/branches/bleeding_edge/src/arm/full-code
Revision: 9649
Author: l...@chromium.org
Date: Mon Oct 17 02:14:27 2011
Log: Create tag 3.6.6.4
http://code.google.com/p/v8/source/detail?r=9649
Added:
/tags/3.6.6.4
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9648
Author: l...@chromium.org
Date: Mon Oct 17 02:13:18 2011
Log: Create tag 3.5.10.21
http://code.google.com/p/v8/source/detail?r=9648
Added:
/tags/3.5.10.21
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9647
Author: l...@chromium.org
Date: Mon Oct 17 02:12:04 2011
Log: Create tag 3.4.14.32
http://code.google.com/p/v8/source/detail?r=9647
Added:
/tags/3.4.14.32
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9646
Author: l...@chromium.org
Date: Mon Oct 17 02:07:05 2011
Log: Port r9543 to the 3.4 branch.
TBR:danno
R=da...@chromium.org
Review URL: http://codereview.chromium.org/8311015
http://code.google.com/p/v8/source/detail?r=9646
Modified:
/branches/3.4/src/compiler.cc
/br
Revision: 9645
Author: l...@chromium.org
Date: Mon Oct 17 02:05:38 2011
Log: Port r9643 3.5 branch.
TBR:danno
R=da...@chromium.org
Review URL: http://codereview.chromium.org/8314019
http://code.google.com/p/v8/source/detail?r=9645
Modified:
/branches/3.5/src/compiler.cc
/branches/3
Revision: 9644
Author: l...@chromium.org
Date: Mon Oct 17 02:04:20 2011
Log: Port r9643 to 3.6 branch.
TBR danno.
R=da...@chromium.org
Review URL: http://codereview.chromium.org/8312014
http://code.google.com/p/v8/source/detail?r=9644
Modified:
/branches/3.6/src/compiler.cc
/branch
Revision: 9643
Author: l...@chromium.org
Date: Mon Oct 17 02:02:26 2011
Log: Remove redundant allow-natives flag from CompilationInfo.
Just use script being native and FLAG_allow_natives_syntax directly.
Review URL: http://codereview.chromium.org/8314018
http://code.google.com/p/v8/so
lgtm
http://codereview.chromium.org/8314018/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: danno,
Description:
Remove redundant allow-natives flag from CompilationInfo.
Just use script being native and FLAG_allow_natives_syntax directly.
Please review this at http://codereview.chromium.org/8314018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Updates:
Status: PendingFurtherInfo
Comment #2 on issue 1760 by jkumme...@chromium.org: gyp: fix windows build
http://code.google.com/p/v8/issues/detail?id=1760
I've just taken a look at this and I don't understand what the issue is.
standalone.gypi does #define WIN32, and is used by t
Updates:
Status: Fixed
Comment #2 on issue 1767 by jkumme...@chromium.org: numops-fuzz.js is
*very* slow when compiled with crankshaft in debug mode.
http://code.google.com/p/v8/issues/detail?id=1767
Fix landed in r9642.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.go
Revision: 9642
Author: jkumme...@chromium.org
Date: Mon Oct 17 00:52:20 2011
Log: Speedup HInstruction::Verify() for pathological cases
BUG=v8:1767
TEST=mjsunit/numops-fuzz doesn't timeout in debug mode
Review URL: http://codereview.chromium.org/8302023
http://code.google.com/p/v8/sou
Comment #1 on issue 1768 by erik.corry: "delete Math.sin" behavior is not
compatible with JSC
http://code.google.com/p/v8/issues/detail?id=1768
This is a deliberate spec violation on V8's part to be compatible with
JSC. It seems they have now fixed their implementation, which they
previo
lgtm
LGTM.
http://codereview.chromium.org/8302023/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 9641
Author: mstarzin...@chromium.org
Date: Mon Oct 17 00:43:40 2011
Log: Fix evaluation order of GT and LTE operators.
According to the ES5 spec all ">" and "<=" expressions should be be
evaluated left-to-right. This obsoletes old hacks for reversing the
order to be ES3 comp
LGTM
http://codereview.chromium.org/8271007/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
85 matches
Mail list logo
