On 2012/05/11 13:50:46, Jakob wrote:
On 2012/05/11 12:20:16, yongsheng.zhu wrote:
> okay, so you'll provide a patch for this issue?
Yes, I'm planning to, but it'll take a week or two.
If you want this fixed sooner, go ahead and do it yourself :-)
Also, in the future, please create CLs agains
Comment #1 on issue 2024 by s...@google.com: Instanceof doesn't work for
typed arrays
http://code.google.com/p/v8/issues/detail?id=2024
This is probably related to 1497, in that even though
typeof Float32Array === 'function',
it's also the case that
Float32Array instanceof Function ===
Comment #1 on issue 1992 by s...@google.com: Indexed properties should
throw in strict mode
http://code.google.com/p/v8/issues/detail?id=1992
This code illustrates the bug:
var x = [1,2,3];
Object.freeze(x);
(function () { "use strict"; x.reverse(); })(); // Should throw, but does
not.
--
Reviewers: Erik Corry,
Message:
Hi Erik
Do you think it looks like a fix for
http://code.google.com/p/v8/issues/detail?id=915
?
Peter
Description:
Fix for Issue 915
Please review this at http://codereview.chromium.org/10332101/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
lgtm
http://codereview.chromium.org/6765006/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: fschneider, Sven Panne, Vyacheslav Egorov,
Message:
Please review this patch. Thanks.
Zheng Liu
zheng.z@intel.com
Description:
Fix potential operand pointer aliasing in LGap after live range split.
BUG=v8:2124
Please review this at http://codereview.chromium.org/10332107/
SVN
Comment #1 on issue 877 by s...@google.com: Figure out how property
descriptors for intercepted properties (including indexes) should look like
http://code.google.com/p/v8/issues/detail?id=877
Please label this ES5. Also, do you have any plans to expose the ability
to define interceptors t
Revision: 11552
Author: jkumme...@chromium.org
Date: Fri May 11 08:03:32 2012
Log: Tagging version 3.11.0
http://code.google.com/p/v8/source/detail?r=11552
Added:
/tags/3.11.0
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 11550
Author: jkumme...@chromium.org
Date: Fri May 11 07:57:47 2012
Log: Prepare push to trunk. Now working on version 3.11.1.
R=yang...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10389094
http://code.google.com/p/v8/source/detail?r=11550
Modified:
/b
On 2012/05/11 14:53:51, Jakob wrote:
LGTM.
https://chromiumcodereview.appspot.com/10389094/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Yang,
Description:
Prepare push to trunk. Now working on version 3.11.1.
R=yang...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/10389094/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
https://chromiumcodereview.appspot.com/10386046/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):
https://chromiumcodereview.appspot.com/10386046/diff/1/src/incremental-marking.cc#newcode660
src/incremental-marking.cc:660: Map* map = obj->map();
On 2012/05/11 12:58:35, V
Revision: 11549
Author: jkumme...@chromium.org
Date: Fri May 11 07:00:10 2012
Log: Tagging version 3.9.24.23
http://code.google.com/p/v8/source/detail?r=11549
Added:
/tags/3.9.24.23
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Thanks for the patch! I was able to reproduce the crash and this seems to
fix
it. I am curious though where these definitions have come from?
http://codereview.chromium.org/10310116/diff/1/src/platform-linux.cc
File src/platform-linux.cc (right):
http://codereview.chromium.org/10310116/diff/1
Revision: 11548
Author: jkumme...@chromium.org
Date: Fri May 11 06:59:47 2012
Log: Merged r11518 into 3.9 branch.
Fix unsigned-Smi check in MappedArgumentsLookup
BUG=126414
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10388087
http://code.google.com/p/v8/s
rubber stamp LGTM
https://chromiumcodereview.appspot.com/10388087/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: danno,
Description:
Merged r11518 into 3.9 branch.
Fix unsigned-Smi check in MappedArgumentsLookup
BUG=126414
R=da...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/10388087/
SVN Base: https://v8.googlecode.com/svn/branches/3.9
Affected files:
M src/
Revision: 11547
Author: jkumme...@chromium.org
Date: Fri May 11 06:52:16 2012
Log: GYP build: Provide automatic host_arch detection on Mac
TEST="make x64.release" works fine on MacOS
Review URL: https://chromiumcodereview.appspot.com/10310123
http://code.google.com/p/v8/source/detail?
On 2012/05/11 13:45:07, Jakob wrote:
PTAQL.
LGTM.
https://chromiumcodereview.appspot.com/10310123/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2012/05/11 12:20:16, yongsheng.zhu wrote:
okay, so you'll provide a patch for this issue?
Yes, I'm planning to, but it'll take a week or two.
If you want this fixed sooner, go ahead and do it yourself :-)
Also, in the future, please create CLs against our bleeding_edge branch
rather
than
Reviewers: Yang,
Message:
PTAQL.
Description:
GYP build: Provide automatic host_arch detection on Mac
TEST="make x64.release" works fine on MacOS
Please review this at https://chromiumcodereview.appspot.com/10310123/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected f
Updates:
Status: Accepted
Owner: vego...@chromium.org
Labels: Type-Bug Priority-Medium
Comment #4 on issue 2124 by fschnei...@chromium.org: Register Allocator in
some condition doesn't handle FixedTemp correctly
http://code.google.com/p/v8/issues/detail?id=2124
I have
Round of comments.
https://chromiumcodereview.appspot.com/10386046/diff/1/src/incremental-marking.cc
File src/incremental-marking.cc (right):
https://chromiumcodereview.appspot.com/10386046/diff/1/src/incremental-marking.cc#newcode660
src/incremental-marking.cc:660: Map* map = obj->map();
Hurry
On 2012/05/11 09:22:56, Jakob wrote:
You did pick the right reviewers, I just didn't get around to commenting
earlier.
I don't think we should set V8_HOST_ARCH_IA32 from the gyp file. The -m32
flag
should be enough to let the preprocessor magic in globals.h figure that
out
automatically.
Revision: 11546
Author: jkumme...@chromium.org
Date: Fri May 11 05:18:09 2012
Log: Prepare for using GYP build on buildbots
Review URL: https://chromiumcodereview.appspot.com/10383128
http://code.google.com/p/v8/source/detail?r=11546
Added:
/branches/bleeding_edge/DEPS
Modified:
/br
https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):
https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
On 2012/05/11 12:07:00, Yang wrote:
Make sure the commit doesn't include the following lines.
Done.
https://chromiumcodereview.appsp
LGTM with two comments.
https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS
File DEPS (right):
https://chromiumcodereview.appspot.com/10383128/diff/1/DEPS#newcode27
DEPS:27: ]
Make sure the commit doesn't include the following lines.
https://chromiumcodereview.appspot.com/10383128/diff
As discussed offline, I still think my comments apply. But you already took
care
of that in the follow-up cleanup CL. So LGTM if combined with the following.
https://chromiumcodereview.appspot.com/10386089/
https://chromiumcodereview.appspot.com/10382102/
--
v8-dev mailing list
v8-dev@googleg
Same comments as in the original CL, but you already took care of that in
the
follow-up cleanup CL. So LGTM if combined with the following.
https://chromiumcodereview.appspot.com/10386089/
https://chromiumcodereview.appspot.com/10391061/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Comment #3 on issue 2124 by fschnei...@chromium.org: Register Allocator in
some condition doesn't handle FixedTemp correctly
http://code.google.com/p/v8/issues/detail?id=2124
There seem to be 2 problems here:
1. The unwanted sharing of LOperand which you described.
2. The splitting decision
Reviewers: Vyacheslav Egorov,
Description:
Implement map collection for incremental marking.
This causes map transitions to be treated weakly during incremental
marking and hence allows clearing of non-live transitions. The marking
code is now shared between incremental and non-incremental mode.
http://codereview.chromium.org/10386090/diff/1/src/ia32/regexp-macro-assembler-ia32.h
File src/ia32/regexp-macro-assembler-ia32.h (right):
http://codereview.chromium.org/10386090/diff/1/src/ia32/regexp-macro-assembler-ia32.h#newcode139
src/ia32/regexp-macro-assembler-ia32.h:139: // For the case
Reviewers: Yang,
Message:
Please take a look.
Happy to explain/discuss any of the changes.
Description:
Prepare for using GYP build on buildbots
Please review this at https://chromiumcodereview.appspot.com/10383128/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
Updates:
Cc: vego...@chromium.org fschnei...@chromium.org
Comment #2 on issue 2124 by fschnei...@chromium.org: Register Allocator in
some condition doesn't handle FixedTemp correctly
http://code.google.com/p/v8/issues/detail?id=2124
Thanks for the report! We'll have a look. Unwanted a
Reviewers: Erik Corry,
Message:
PTAL.
This CL is far from being completed since platform ports and tests are
missing.
I still want to get a second opinion on this before I continue.
I implemented the loop inside GetCode() that deals with setting up local
variables and returning results. I in
Revision: 11545
Author: da...@chromium.org
Date: Fri May 11 02:53:59 2012
Log: Tagging version 3.9.24.22
http://code.google.com/p/v8/source/detail?r=11545
Added:
/tags/3.9.24.22
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 11544
Author: da...@chromium.org
Date: Fri May 11 02:53:38 2012
Log: Merged r11459, r11523 into 3.9 branch.
MIPS: Removed unused variables (fixes for gcc-4.6)
MIPS: Fixed illegal instruction use on Loongson in code for Math.random().
R=mstarzin...@chromium.org
BUG=v8:2115
Updates:
Status: Assigned
Owner: u...@chromium.org
Cc: stefa...@chromium.org da...@chromium.org
Comment #1 on issue 2125 by stefa...@chromium.org: navier-stokes should
verify its result
http://code.google.com/p/v8/issues/detail?id=2125
(No comment was entered for this
Hi, Jakob, thanks for comments.
Yes, to setup toolchain for x86, we just need add --arch=x86 when executing
make-standalone-toolchain.sh. That's the only thing to add to the wiki.
When I made the patch, I also thought of use the unified android.gypi.
However I
noticed there exist armu.gypi and
Status: Accepted
Owner: stefa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2125 by fschnei...@chromium.org: navier-stokes should verify its
result
http://code.google.com/p/v8/issues/detail?id=2125
We should add some verification of navier-stokes results to the benchmark.
--
v8-
You did pick the right reviewers, I just didn't get around to commenting
earlier.
I don't think we should set V8_HOST_ARCH_IA32 from the gyp file. The -m32
flag
should be enough to let the preprocessor magic in globals.h figure that out
automatically.
As for passing -m32, I'd like to fix that
Revision: 11543
Author: erik.co...@gmail.com
Date: Fri May 11 02:13:02 2012
Log: Simplify DoLoadNamedFieldPolymorphic
Review URL: https://chromiumcodereview.appspot.com/10386089
http://code.google.com/p/v8/source/detail?r=11543
Modified:
/branches/bleeding_edge/src/arm/lithium-codegen
LGTM (rubber-stamp).
https://chromiumcodereview.appspot.com/10377103/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Description:
Merged r11459, r11523 into 3.9 branch.
MIPS: Removed unused variables (fixes for gcc-4.6)
MIPS: Fixed illegal instruction use on Loongson in code for Math.random().
R=mstarzin...@chromium.org
BUG=v8:2115
Please review this at https://chromiumcodere
LGTM. Much simpler, much better.
https://chromiumcodereview.appspot.com/10386089/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Tabs in the Makefile are fine, as they're required by standard Makefile
syntax.
Please use only one tab at the beginning of the line, then spaces as
necessary
for additional indentation.
However, I don't like all the duplication this CL introduces. Can you
refactor
the existing android.gypi
Reviewers: Michael Starzinger,
Description:
Simplify DoLoadNamedFieldPolymorphic
Please review this at https://chromiumcodereview.appspot.com/10386089/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/arm/lithium-codegen-arm.cc
M src/ia32/lithium
Revision: 11542
Author: da...@chromium.org
Date: Fri May 11 01:59:19 2012
Log: Tagging version 3.10.8.5
http://code.google.com/p/v8/source/detail?r=11542
Added:
/tags/3.10.8.5
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 11541
Author: da...@chromium.org
Date: Fri May 11 01:59:02 2012
Log: Merged r11523 into 3.10 branch.
MIPS: Fixed illegal instruction use on Loongson in code for Math.random().
R=mstarzin...@chromium.org
BUG=v8:2115
Review URL: https://chromiumcodereview.appspot.com/10382124
LGTM (rubber-stamp).
https://chromiumcodereview.appspot.com/10382124/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Description:
Merged r11523 into 3.10 branch.
MIPS: Fixed illegal instruction use on Loongson in code for Math.random().
R=mstarzin...@chromium.org
BUG=v8:2115
Please review this at https://chromiumcodereview.appspot.com/10382124/
SVN Base: https://v8.googlecode
Comment #6 on issue 1458 by u...@chromium.org: NewGC: Do meaningful work on
idle notifications.
http://code.google.com/p/v8/issues/detail?id=1458
It should work properly since r11469. If you encountered specific problems,
could you please report them? Otherwise, I am going to close this iss
Updates:
Summary: Won't compile with VS2010 unless documented prerequisites are
installed
Status: WorkingAsIntended
Comment #2 on issue 2099 by jkumme...@chromium.org: Won't compile with
VS2010 unless documented prerequisites are installed
http://code.google.com/p/v8/issues/detail?
Comment #5 on issue 1458 by jo...@ronomon.com: NewGC: Do meaningful work on
idle notifications.
http://code.google.com/p/v8/issues/detail?id=1458
Bumped into this today. Any progress?
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan, benm,
Message:
Hi, when I run d8 compiled for Android on x86 with "--prof", it will crash.
I
made a fix here. Would you please help review? Many thanks.
Description:
Fix ucontext structure for Android on x86
Please review this at http://codereview.chromium.org/10310116/
SVN
55 matches
Mail list logo
