[v8-dev] Re: Issue 1310 in v8: Object.getOwnPropertyDescriptor/defineProperty should work on __proto__

2012-05-30 Thread codesite-noreply
Comment #5 on issue 1310 by therealb...@gmail.com: Object.getOwnPropertyDescriptor/defineProperty should work on __proto__ http://code.google.com/p/v8/issues/detail?id=1310 Interestingly, FF4 also allows setting __proto__ to be an accessor rather than a property: var a = {}; //var d = Obj

[v8-dev] Re: Issue 459 in v8: localeCompare implementation differs from other browsers

2012-05-30 Thread codesite-noreply
Comment #28 on issue 459 by js...@chromium.org: localeCompare implementation differs from other browsers http://code.google.com/p/v8/issues/detail?id=459 Despite what I wrote in comment 15, we did take this to the ECMAScript standard group (ECMA TC39) and have made a significant progress.

[v8-dev] Issue 2160 in v8: Add support for default parameters

2012-05-30 Thread codesite-noreply
Status: New Owner: New issue 2160 by a...@chromium.org: Add support for default parameters http://code.google.com/p/v8/issues/detail?id=2160 SpiderMonkey just added support for default paramaters http://wiki.ecmascript.org/doku.php?id=harmony:parameter_default_values -- v8-dev mailing lis

[v8-dev] Issue 2159 in v8: Add support for rest parameters

2012-05-30 Thread codesite-noreply
Status: New Owner: New issue 2159 by a...@chromium.org: Add support for rest parameters http://code.google.com/p/v8/issues/detail?id=2159 SpiderMonkey now supports rest parameters http://wiki.ecmascript.org/doku.php?id=harmony:rest_parameters -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

2012-05-30 Thread codesite-noreply
Comment #124 on issue 164 by rowaas...@gmail.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 Whoever asked for people who don't want this fixed: here I am. When I want sorted map, I'll use sorted map. Until then, I don't want to be penalized

[v8-dev] Issue 2158 in v8: Add support for private names

2012-05-30 Thread codesite-noreply
Status: New Owner: New issue 2158 by a...@chromium.org: Add support for private names http://code.google.com/p/v8/issues/detail?id=2158 JSC just added basic support for private names. http://wiki.ecmascript.org/doku.php?id=harmony:private_name_objects https://bugs.webkit.org/show_bug.cgi?i

[v8-dev] Re: Issue 691 in v8: Sequencing of getter side effects wrong

2012-05-30 Thread codesite-noreply
Updates: Status: Assigned Owner: mstarzin...@chromium.org Labels: Type-Bug Priority-Medium Comment #4 on issue 691 by mstarzin...@chromium.org: Sequencing of getter side effects wrong http://code.google.com/p/v8/issues/detail?id=691 (No comment was entered for this cha

[v8-dev] Re: Keep track of which maps are associated with prototype objects (issue 10448011)

2012-05-30 Thread erik . corry
https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc#newcode1640 src/objects.cc:1640: object_function()->map()) { On 2012/05/30 14:08:03, Michael Starzinger wrote: Indenta

[v8-dev] Re: Issue 2152 in v8: can't build on solaris 11 1111 x86

2012-05-30 Thread codesite-noreply
Comment #6 on issue 2152 by psting...@gmail.com: can't build on solaris 11 x86 http://code.google.com/p/v8/issues/detail?id=2152 I installed system/header from the package repository also. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 2152 in v8: can't build on solaris 11 1111 x86

2012-05-30 Thread codesite-noreply
Comment #5 on issue 2152 by psting...@gmail.com: can't build on solaris 11 x86 http://code.google.com/p/v8/issues/detail?id=2152 I have also installed system/header from the package repository. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Issue 2152 in v8: can't build on solaris 11 1111 x86

2012-05-30 Thread codesite-noreply
Comment #4 on issue 2152 by psting...@gmail.com: can't build on solaris 11 x86 http://code.google.com/p/v8/issues/detail?id=2152 Sorry, I am not familiar with C++, Solaris also, just want to make V8 on it. Solaris is the latest version from Oracle, http://www.oracle.com/technetwork/se

[v8-dev] [v8] r11683 committed - Decoupling MarkDescriptorArray as much as possible from the ContentArr...

2012-05-30 Thread codesite-noreply
Revision: 11683 Author: verwa...@chromium.org Date: Wed May 30 08:15:17 2012 Log: Decoupling MarkDescriptorArray as much as possible from the ContentArray. Review URL: https://chromiumcodereview.appspot.com/10417030 http://code.google.com/p/v8/source/detail?r=11683 Modified: /bran

[v8-dev] Re: Decoupling MarkDescriptorArray as much as possible from the ContentArray. (issue 10417030)

2012-05-30 Thread mstarzinger
LGTM (with one nit). https://chromiumcodereview.appspot.com/10417030/diff/7001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10417030/diff/7001/src/objects.cc#newcode5842 src/objects.cc:5842: // descriptor array. If the descriptor array were to be were to be

[v8-dev] [v8] r11682 committed - TraversableMap only dependent on DescriptorArray...

2012-05-30 Thread codesite-noreply
Revision: 11682 Author: verwa...@chromium.org Date: Wed May 30 07:54:00 2012 Log: TraversableMap only dependent on DescriptorArray This is the first step towards merging the ContentArray into the DescriptorArray, (hence reclaiming 3 words per descriptor array). Review URL: https://c

[v8-dev] [v8] r11681 committed - Keep track of which maps are associated with prototype objects...

2012-05-30 Thread codesite-noreply
Revision: 11681 Author: erik.co...@gmail.com Date: Wed May 30 07:40:57 2012 Log: Keep track of which maps are associated with prototype objects so we can tune the fast-case vs. hash map heuristics accordingly. Review URL: https://chromiumcodereview.appspot.com/10448011 http://code.googl

[v8-dev] [v8] r11680 committed - Fix broken change to d8 typed arrays....

2012-05-30 Thread codesite-noreply
Revision: 11680 Author: rossb...@chromium.org Date: Wed May 30 07:26:34 2012 Log: Fix broken change to d8 typed arrays. R=mstarzin...@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10441091 http://code.google.com/p/v8/source/detail?r=11680 Modified: /bran

[v8-dev] Re: Fix broken change to d8 typed arrays. (issue 10441091)

2012-05-30 Thread mstarzinger
LGTM. Just one nit, but feel free to move that over to one of your follow-up CLs. https://chromiumcodereview.appspot.com/10441091/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10441091/diff/1/src/d8.cc#newcode378 src/d8.cc:378: String::New("byteOffset out of bo

[v8-dev] Fix broken change to d8 typed arrays. (issue 10441091)

2012-05-30 Thread rossberg
Reviewers: Michael Starzinger, Description: Fix broken change to d8 typed arrays. R=mstarzin...@chromium.org BUG= TEST= Please review this at https://chromiumcodereview.appspot.com/10441091/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M src/d8.cc Index:

[v8-dev] Report syntax errors in natives when building with mksnapshot. (issue 10443085)

2012-05-30 Thread erik . corry
Reviewers: ulan, Description: Report syntax errors in natives when building with mksnapshot. Please review this at http://codereview.chromium.org/10443085/ SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M include/v8.h M src/api.cc M src/factory

[v8-dev] Re: Keep track of which maps are associated with prototype objects (issue 10448011)

2012-05-30 Thread mstarzinger
LGTM (if one comment and a few nits are addressed). https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10448011/diff/12002/src/objects.cc#newcode1640 src/objects.cc:1640: object_function()->map()) { Inden

[v8-dev] Re: Issue 1914 in v8: Capture correct line numbers for Errors thrown in an eval.

2012-05-30 Thread codesite-noreply
Comment #4 on issue 1914 by compwiz...@gmail.com: Capture correct line numbers for Errors thrown in an eval. http://code.google.com/p/v8/issues/detail?id=1914 Any update on this issue? -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev

[v8-dev] Re: Some clean-up of typed array support in d8. (issue 10392130)

2012-05-30 Thread rossberg
https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc File src/d8.cc (right): https://chromiumcodereview.appspot.com/10392130/diff/1/src/d8.cc#newcode360 src/d8.cc:360: array->Set(String::New(kArrayBufferMarkerPropName), True(), ReadOnly); On 2012/05/18 12:10:40, Yang wrote: Is the p

[v8-dev] [v8] r11679 committed - Some clean-up of typed array support in d8....

2012-05-30 Thread codesite-noreply
Revision: 11679 Author: rossb...@chromium.org Date: Wed May 30 06:35:29 2012 Log: Some clean-up of typed array support in d8. R=yang...@chromium.org BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10392130 http://code.google.com/p/v8/source/detail?r=11679 Modified: /br

[v8-dev] Re: TraversableMap only dependent on DescriptorArray (issue 10455005)

2012-05-30 Thread mstarzinger
LGTM (if one nit is addressed). https://chromiumcodereview.appspot.com/10455005/diff/6001/src/objects.cc File src/objects.cc (right): https://chromiumcodereview.appspot.com/10455005/diff/6001/src/objects.cc#newcode5130 src/objects.cc:5130: *DescriptorArrayHeader() = Smi::FromInt(raw_index); Ind

[v8-dev] Re: Issue 2157 in v8: v8 uses target CFLAGS to build host files, and fails when they are run

2012-05-30 Thread codesite-noreply
Updates: Status: WorkingAsIntended Comment #1 on issue 2157 by jkumme...@chromium.org: v8 uses target CFLAGS to build host files, and fails when they are run http://code.google.com/p/v8/issues/detail?id=2157 V8 doesn't know or care about release_extra_cflags: $ grep -Inr release_extr

[v8-dev] Re: Implement grokdump annotations for well-known objects. (issue 10441088)

2012-05-30 Thread mstarzinger
Addressed comments. https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py#newcode465 tools/grokdump.py:465: print >>sys.stderr, "WARNING: This is NOT a full minidump!" On

[v8-dev] Re: Implement correct checking for inherited readonliness on assignment. (issue 10388047)

2012-05-30 Thread mstarzinger
In general this LGTM. Only a few nits to address. https://chromiumcodereview.appspot.com/10388047/diff/1015/src/hydrogen.cc File src/hydrogen.cc (right): https://chromiumcodereview.appspot.com/10388047/diff/1015/src/hydrogen.cc#newcode4278 src/hydrogen.cc:4278: CHECK_ALIVE({}); Can we rewrite t

[v8-dev] Re: Implement grokdump annotations for well-known objects. (issue 10441088)

2012-05-30 Thread erik . corry
https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py File tools/grokdump.py (right): https://chromiumcodereview.appspot.com/10441088/diff/1/tools/grokdump.py#newcode465 tools/grokdump.py:465: print >>sys.stderr, "WARNING: This is NOT a full minidump!" I prefer it if my tools

[v8-dev] Re: Issue 459 in v8: localeCompare implementation differs from other browsers

2012-05-30 Thread codesite-noreply
Comment #27 on issue 459 by bart.ver...@gmail.com: localeCompare implementation differs from other browsers http://code.google.com/p/v8/issues/detail?id=459 Please point out why this is a bug. You need to apply to the implementation requirement, not to "how other browser's" implement it.

[v8-dev] Re: Issue 2143 in v8: Crashes in CodeCache::LookupDefaultCache

2012-05-30 Thread codesite-noreply
Comment #1 on issue 2143 by mstarzin...@chromium.org: Crashes in CodeCache::LookupDefaultCache http://code.google.com/p/v8/issues/detail?id=2143 Should be fixed in r11678. Let's wait what Canary has to say before closing it. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.goo

[v8-dev] Re: Issue 1465 in v8: NewGC: Map collection with incremental marking

2012-05-30 Thread codesite-noreply
Comment #7 on issue 1465 by mstarzin...@chromium.org: NewGC: Map collection with incremental marking http://code.google.com/p/v8/issues/detail?id=1465 Also requires r11678 for correctness, hence related to issue 2143. -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/gr

[v8-dev] Implement grokdump annotations for well-known objects. (issue 10441088)

2012-05-30 Thread mstarzinger
Reviewers: ulan, Description: Implement grokdump annotations for well-known objects. R=u...@chromium.org TEST=tools/grokdump.py Please review this at https://chromiumcodereview.appspot.com/10441088/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files: M tools/grok

[v8-dev] Re: Issue 164 in v8: Wrong order in Object properties interation

2012-05-30 Thread codesite-noreply
Comment #123 on issue 164 by mn.medi...@gmail.com: Wrong order in Object properties interation http://code.google.com/p/v8/issues/detail?id=164 I'm surprised too see such discussion on that. Order is unspecified by a standard, and no one should expect it or foce it to be specified. If you