On 2012/09/17 07:40:14, Yang wrote:
On 2012/09/17 03:10:48, xqian wrote:
> Hi， Yang
>
> Thanks for your review. I refined the code according to your comments.
Please
> check the patch set 3.
>
> Thanks,
> -Xi
> On 2012/09/14 15:38:16, Yang wrote:
> > Thanks for this patch! I'll land this patch
Reviewers: Yang, Kasper Lund, yuqiang.xian, Vyacheslav Egorov,
Message:
Hi, Yang, Kasper, Yuqiang and Vyacheslav
This is a port for patch of issue 10916311. It can gain similar performance
improvement on x64. Would you please review it?
Thanks,
-Xi
Description:
Improve the assembly code for po
On 2012/09/17 22:12:02, Vyacheslav Egorov (Google) wrote:
DBC
https://codereview.chromium.org/10916311/diff/5002/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/10916311/diff/5002/src/ia32/code-stubs-ia32.cc#newcode3216
src/ia32/code-st
lppros...@oi.com.br
cargo æ¨å¥½ï¼è¯·cha æ¶ï¼å¹¶è½¬äº¤ç¸.å
³äººå!
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Ïú~ÊÛ¼¼~ÇÉÑÐ~ÌÖzlhn.xls
Description: MS-Excel spreadsheet
DBC
https://codereview.chromium.org/10916311/diff/5002/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/10916311/diff/5002/src/ia32/code-stubs-ia32.cc#newcode3216
src/ia32/code-stubs-ia32.cc:3216: Label no_neg, while_true, no_multiply,
while_
Comment #2 on issue 2338 by alysson...@gmail.com: V8 engine embedded in a
DLL doesn't work when using the V8/javascript debug system
http://code.google.com/p/v8/issues/detail?id=2338
Same for "Invalid Operation" bit parameter of FPU Control Word
--
v8-dev mailing list
v8-dev@googlegroups.com
Reviewers: Toon Verwaest, danno, Paul Lind, kisg,
Description:
MIPS: Do not go to slow mode and back to fast in initializer blocks.
Port r12534 (4acfb92e)
BUG=
TEST=
Please review this at https://chromiumcodereview.appspot.com/10905313/
SVN Base: https://v8.googlecode.com/svn/branches/bleedi
Reviewers: Toon Verwaest, danno, Paul Lind, kisg,
Description:
MIPS: Sharing of descriptor arrays.
Port r12492 (479be376)
Original commit message:
This CL adds multiple things:
Transition arrays do not directly point at their descriptor array anymore,
but
rather do so via an indirect pointer
Comment #2 on issue 2334 by programm...@hotmail.com: VS 2012: Unable to
start program "build\Debug\All"
http://code.google.com/p/v8/issues/detail?id=2334
It seems like this is only happening when I click on "Local Windows
Debugger" in order to compile.
If I use Build-->(Re)Build solution,
Comment #1 on issue 2338 by alysson...@gmail.com: V8 engine embedded in a
DLL doesn't work when using the V8/javascript debug system
http://code.google.com/p/v8/issues/detail?id=2338
I am testing/debugging more this issue and I discovered what exactly is the
problem and I bring a suggestion
Revision: 12534
Author: verwa...@chromium.org
Date: Mon Sep 17 10:18:27 2012
Log: Do not go to slow mode and back to fast in initializer blocks.
Review URL: https://chromiumcodereview.appspot.com/10905308
http://code.google.com/p/v8/source/detail?r=12534
Modified:
/branches/bleeding_
Updates:
Mergedinto: v8-i18n:1
Comment #5 on issue 1868 by c...@chromium.org: DateTimeFormat::Format runs
script to get Date value.
http://code.google.com/p/v8/issues/detail?id=1868
I've fixed v8-i18n:1 issue. You can close this one.
--
v8-dev mailing list
v8-dev@googlegroups.com
htt
Revision: 12533
Author: da...@chromium.org
Date: Mon Sep 17 08:51:35 2012
Log: Create V8 3.13 branch for Chrome 23
http://code.google.com/p/v8/source/detail?r=12533
Added:
/branches/3.13
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 12532
Author: mstarzin...@chromium.org
Date: Mon Sep 17 07:50:51 2012
Log: Add jsfunfuzz to gitignore file.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/10918273
http://code.google.com/p/v8/source/detail?r=12532
Modified:
/branches/bleeding_edge/.gi
lgtm
https://chromiumcodereview.appspot.com/10918273/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 12531
Author: mstarzin...@chromium.org
Date: Mon Sep 17 07:39:10 2012
Log: Fix casting error for receiver of interceptors.
This fixes a casting error that occured when the receiver of a missed
or uninitialized CallIC is a Smi and there is an interceptor installed
on the proto
On 2012/09/17 14:21:17, Michael Starzinger wrote:
LGTM.
https://chromiumcodereview.appspot.com/10914317/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Yang,
Description:
Fix casting error for receiver of interceptors.
This fixes a casting error that occured when the receiver of a missed
or uninitialized CallIC is a Smi and there is an interceptor installed
on the prototype chain.
R=yang...@chromium.org
BUG=chromium:144230
TEST=ccte
Revision: 12530
Author: yang...@chromium.org
Date: Mon Sep 17 07:19:11 2012
Log: Tentatively reenable previous failing test.
R=mstarzin...@chromium.org
BUG=v8:2261
Review URL: https://chromiumcodereview.appspot.com/10907254
http://code.google.com/p/v8/source/detail?r=12530
Modified:
LGTM (with one nit).
https://chromiumcodereview.appspot.com/10907254/diff/1/test/mjsunit/object-define-property.js
File test/mjsunit/object-define-property.js (left):
https://chromiumcodereview.appspot.com/10907254/diff/1/test/mjsunit/object-define-property.js#oldcode1059
test/mjsunit/object-de
Reviewers: Michael Starzinger,
Description:
Tentatively reenable previous failing test.
R=mstarzin...@chromium.org
BUG=v8:2261
Please review this at https://chromiumcodereview.appspot.com/10907254/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsun
Status: New
Owner:
New issue 2338 by alysson...@gmail.com: V8 engine embedded in a DLL doesn't
work when using the V8/javascript debug system
http://code.google.com/p/v8/issues/detail?id=2338
consider the following code:
-
HandleScope handle_scope;
Persistent context
Updates:
Status: Duplicate
Mergedinto: v8-i18n:1
Comment #4 on issue 1868 by yang...@chromium.org: DateTimeFormat::Format
runs script to get Date value.
http://code.google.com/p/v8/issues/detail?id=1868
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@g
Updates:
Status: Fixed
Comment #4 on issue 2112 by yang...@chromium.org: Stacktraces originating
from `JSON.parse()` contain random garbage (on nodejs)
http://code.google.com/p/v8/issues/detail?id=2112
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegrou
lgtm
https://chromiumcodereview.appspot.com/10905308/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Description:
Do 2 GCs on LowMemoryNotification instead of 7.
Please review this at https://chromiumcodereview.appspot.com/10933124/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/heap-inl.h
M src/heap.h
M src/heap.cc
M
Updates:
Status: Fixed
Comment #2 on issue 2336 by yang...@chromium.org: Assertion in GC fails
when running regress-2318.js in debug mode
http://code.google.com/p/v8/issues/detail?id=2336
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
Revision: 12529
Author: yang...@chromium.org
Date: Mon Sep 17 06:21:59 2012
Log: Change regress-2318 to trigger more quickly and reliably.
BUG=v8:2336
Review URL: https://chromiumcodereview.appspot.com/10913294
http://code.google.com/p/v8/source/detail?r=12529
Modified:
/branches/bl
Revision: 12528
Author: erik.co...@gmail.com
Date: Mon Sep 17 04:38:24 2012
Log: Fix misplaced assert in heap.cc.
Bug=2336
Review URL: https://chromiumcodereview.appspot.com/10911334
http://code.google.com/p/v8/source/detail?r=12528
Added:
/branches/bleeding_edge/test/mjsunit/bugs/bug
Still LGTM.
https://chromiumcodereview.appspot.com/10911334/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Owner: mstarzin...@chromium.org
Comment #1 on issue 2337 by erik.corry: ScriptCollected notirications can
be lost.
http://code.google.com/p/v8/issues/detail?id=2337
The failing test is called test/mjsunit/bugs/bug-2237.js
--
v8-dev mailing list
v8-dev@googlegroups.com
http:/
Status: Accepted
Owner: erik.corry
Labels: Type-Bug Priority-Medium
New issue 2337 by erik.corry: ScriptCollected notirications can be lost.
http://code.google.com/p/v8/issues/detail?id=2337
See the failing test.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
Reviewers: Sven Panne,
Message:
PTAL.
Description:
Do not go to slow mode and back to fast in initializer blocks.
Please review this at https://chromiumcodereview.appspot.com/10905308/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/full-codegen-arm
Reviewers: danno,
Message:
PTAL. The core of this CL is in src/objects.cc -> ShareDescriptor. This CL
will
allow us to remove the ToSlowProperties/ToFastProperties on initializer
blocks
in a subsequent CL.
Description:
Preallocate space in descriptor arrays.
Please review this at https://
LGTM.
https://chromiumcodereview.appspot.com/10907234/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
https://chromiumcodereview.appspot.com/10911334/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 12526
Author: mstarzin...@chromium.org
Date: Mon Sep 17 03:04:39 2012
Log: Integrate map marking into static marking visitor.
This refactors the specialized marking of map contents to be done by the
static marking visitor shared between full and incremental marking. This
also
Addressed comments. Landing.
https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc#newcode1084
src/mark-compact.cc:1084: }
On 2012/09/17 09:06:36, Toon Verwaest wrot
Revision: 12525
Author: u...@chromium.org
Date: Mon Sep 17 02:58:22 2012
Log: Throw a more descriptive exception when blocking 'eval' via CSP.
BUG=140191
R=svenpa...@chromium.org,mk...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10837358
http://code.google.com/p/v
lgtm
https://chromiumcodereview.appspot.com/10837358/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
On 2012/09/17 07:40:14, Yang wrote:
On 2012/09/17 03:10:48, xqian wrote:
> Hi， Yang
>
> Thanks for your review. I refined the code according to your comments.
Please
> check the patch set 3.
>
> Thanks,
> -Xi
> On 2012/09/14 15:38:16, Yang wrote:
> > Thanks for this patch! I'll land this patch
LGTM (with one idea, feel free to ignore).
https://chromiumcodereview.appspot.com/10911334/diff/1/src/heap.cc
File src/heap.cc (right):
https://chromiumcodereview.appspot.com/10911334/diff/1/src/heap.cc#newcode624
src/heap.cc:624: // This can do debug callbacks and restart incremental
marking.
Comment #7 on issue 811 by nat...@nathan7.eu: support destructuring
assignment
http://code.google.com/p/v8/issues/detail?id=811
@yangguo: Currently, we have to rely on ugly constructions using with() or
fiddling with array indices even though Mozilla's JS engines and Opera
support an exce
Reviewers: Michael Starzinger,
Description:
Fix misplaced assert in heap.cc.
Bug=2336
Please review this at https://chromiumcodereview.appspot.com/10911334/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
M src/heap.cc
Index: src/heap.cc
=
lgtm with minor comments.
https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://chromiumcodereview.appspot.com/10919294/diff/1/src/mark-compact.cc#newcode1084
src/mark-compact.cc:1084: }
This method seems exactly(?) the same as the
Updates:
Owner: erik.corry
Comment #1 on issue 2336 by erik.corry: Assertion in GC fails when running
regress-2318.js in debug mode
http://code.google.com/p/v8/issues/detail?id=2336
Stealing this
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #6 on issue 811 by yang...@chromium.org: support destructuring
assignment
http://code.google.com/p/v8/issues/detail?id=811
@nathan: Please elaborate. V8's primary use-case is Chromium, so we align
our features with the requirements of Chromium. It's great that node.js is
also rely
LGTM. Thanks!
http://codereview.chromium.org/10913294/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Message:
PTAL.
Description:
Change regress-2318 to trigger more quickly and reliably.
BUG=v8:2334
Please review this at http://codereview.chromium.org/10913294/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/regress/regress
Status: Accepted
Owner: mstarzin...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2336 by yang...@chromium.org: Assertion in GC fails when running
regress-2318.js in debug mode
http://code.google.com/p/v8/issues/detail?id=2336
The following assertion triggers
#
# Fatal error in ../
Comment #5 on issue 811 by nat...@nathan7.eu: support destructuring
assignment
http://code.google.com/p/v8/issues/detail?id=811
I consider the 'only stuff in Safari' argument void thanks to node.js, and
the non-ECMAScript is somewhat void too now.
--
v8-dev mailing list
v8-dev@googlegroup
Revision: 12524
Author: mstarzin...@chromium.org
Date: Mon Sep 17 01:14:27 2012
Log: Tagging version 3.12.19.10
http://code.google.com/p/v8/source/detail?r=12524
Added:
/tags/3.12.19.10
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 12523
Author: mstarzin...@chromium.org
Date: Mon Sep 17 01:14:05 2012
Log: Merged r12495 into 3.12 branch.
Fix API check for length of external arrays.
R=jkumme...@chromium.org
BUG=chromium:148896
TEST=cctest/test-api/ExternalArrayLimits
Review URL: https://codereview.chrom
lgtm
https://codereview.chromium.org/10911333/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Description:
Merged r12495 into 3.12 branch.
Fix API check for length of external arrays.
R=jkumme...@chromium.org
BUG=chromium:148896
TEST=cctest/test-api/ExternalArrayLimits
Please review this at https://codereview.chromium.org/10911333/
SVN Base: https://v8.googlecode.co
Updates:
Status: Assigned
Owner: u...@chromium.org
Comment #1 on issue 2333 by yang...@chromium.org: A "Floating-point invalid
operation" exception at "Update Survival Rate Trend"
http://code.google.com/p/v8/issues/detail?id=2333
(No comment was entered for this change.)
--
v
Updates:
Status: Fixed
Comment #4 on issue 1445 by yang...@chromium.org: AtomicWord definition on
OpenBSD/i386
http://code.google.com/p/v8/issues/detail?id=1445
Thanks for this patch! Usually we require contributors to follow the steps
in http://code.google.com/p/v8/wiki/Contributin
Revision: 12522
Author: yang...@chromium.org
Date: Mon Sep 17 00:56:15 2012
Log: Fix build on OpenBSD/i386.
BUG=v8:1445
Review URL: https://chromiumcodereview.appspot.com/10919314
http://code.google.com/p/v8/source/detail?r=12522
Modified:
/branches/bleeding_edge/src/atomicops.h
/b
Reviewers: ,
Message:
LGTM.
Description:
Fix build on OpenBSD/i386.
BUG=v8:1445
Please review this at http://codereview.chromium.org/10919314/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/atomicops.h
M src/platform.h
Index: src/atomicops.h
diff
Revision: 12521
Author: yang...@chromium.org
Date: Mon Sep 17 00:45:54 2012
Log: Improve the assembly code for power function with integer
exponential.
The change removes one unused multiply and reschedules
the shift, multiply and jump instructions to reduce
stall. Experiment shows
On 2012/09/17 03:10:48, xqian wrote:
Hi， Yang
Thanks for your review. I refined the code according to your comments.
Please
check the patch set 3.
Thanks,
-Xi
On 2012/09/14 15:38:16, Yang wrote:
> Thanks for this patch! I'll land this patch once the following two
comments
are
> address
Updates:
Status: Duplicate
Mergedinto: 811
Comment #2 on issue 2335 by jkumme...@chromium.org: Lack of destructuring
assignments
http://code.google.com/p/v8/issues/detail?id=2335
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
http://g
Comment #4 on issue 811 by jkumme...@chromium.org: support destructuring
assignment
http://code.google.com/p/v8/issues/detail?id=811
Issue 2335 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
63 matches
Mail list logo
