I took a look into the WebKit issue, and I think that your problems are
related
to the currently broken External class: Although it is declared as a
subclass of
Value (i.e. promises to return a JavaScript object), Wrap/New can currently
return an internal object (a Foreign), which in turn caus
Reviewers: danno,
Description:
Add an API to let the embedder associate arbitrary data with a v8::Context.
I had hoped that v8::Context::SetData would let the embedder associate a
void*
with a v8::Context, but it turns out we can't use that API because the
debugger
makes assumptions about th
A similar issue was raised and fixed here:
http://code.google.com/p/v8/issues/detail?id=2354
If you have the same issue it also means you were running on a CPU
which didn't support s/udiv.
Cheers,
Rodolph.
On 8 October 2012 23:16, wrote:
> On 2012/10/01 21:16:17, danno wrote:
>>
>> LGTM, I'll
On 2012/10/01 21:16:17, danno wrote:
LGTM, I'll land this for you
http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h
File src/v8globals.h (right):
http://codereview.chromium.org/10977051/diff/17002/src/v8globals.h#newcode441
src/v8globals.h:441: SUDIV = 5, // ARM
I changed
I've missed that one - I always thought of it returning only info about
'writable, configurable and enumerable' forgetting about the 'value' part...
Thanks for the pointer.
2012/10/8 Erik Arvidsson
> On Thu, Oct 4, 2012 at 7:52 PM, wrote:
> > 3. I couldn't save reference to the XXX.prototype
On Thu, Oct 4, 2012 at 7:52 PM, wrote:
> 3. I couldn't save reference to the XXX.prototype.(compare|format).
> Those are getters and I couldn't find a way to get to it without
> executing it, which then fails.
You should be able to do Object.getOwnPropertyDescriptor to get the
getter/setter func
LGTM with nits
https://codereview.appspot.com/6591072/diff/22001/src/overrides.js
File src/overrides.js (right):
https://codereview.appspot.com/6591072/diff/22001/src/overrides.js#newcode32
src/overrides.js:32: {value: function(that, locales, options) {
Please fix indentation
Object.definePro
Revision: 12678
Author: da...@chromium.org
Date: Mon Oct 8 06:49:57 2012
Log: Add PRESUBMIT script to V8
Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message
BUG=none
TEST=run git cl presubmit
Review URL: https://coderevie
lgtm, I'll land it for you
https://codereview.chromium.org/11092002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: danno,
Message:
plz review
Description:
Add PRESUBMIT script to V8
Currently, it executes the OWNERS check and tools/presubmit.py, as well as a
check for a non-empty commit message
BUG=none
TEST=run git cl presubmit
Please review this at https://codereview.chromium.org/11092002/
Revision: 12677
Author: svenpa...@chromium.org
Date: Mon Oct 8 05:58:46 2012
Log: Fixed Accessors::FunctionGetPrototype's proto chain traversal.
Actually it didn't traverse that far... ;-) Did some cleanup on the way.
R=rossb...@chromium.org
BUG=chrome:143967
TEST=regress/regress-143
Revision: 12676
Author: da...@chromium.org
Date: Mon Oct 8 05:50:15 2012
Log: ARM: Fast path for integer inputs to EmitVFPTruncate
BUG=none
TEST=none
Review URL: https://codereview.chromium.org/11049025
Patch from Martyn Capewell .
http://code.google.com/p/v8/source/detail?r=12676
M
lgtm
http://codereview.chromium.org/11049025/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
lgtm
https://codereview.chromium.org/11087004/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 12675
Author: jkumme...@chromium.org
Date: Mon Oct 8 04:59:40 2012
Log: Tagging version 3.12.19.16
http://code.google.com/p/v8/source/detail?r=12675
Added:
/tags/3.12.19.16
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: ulan,
Description:
Clarify that date parsing follows Safari.
R=u...@chromium.org
BUG=145198
Please review this at https://codereview.chromium.org/11085006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/dateparser-inl.h
Index: src/datepar
Revision: 12674
Author: da...@chromium.org
Date: Mon Oct 8 04:58:08 2012
Log: Add OWNERS file
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/11028073
http://code.google.com/p/v8/source/detail?r=12674
Added:
/branches/bleeding_edge/OWNERS
=
lgtm
https://codereview.chromium.org/11028073/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Description:
Add OWNERS file
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/11028073/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
A OWNERS
Index: OWNERS
diff --git a/OWNERS b/OWNERS
new file mode 100644
Comment #2 on issue 2357 by paul.hol...@gmail.com: Uint8Array codegen
errors with Chrome 22/Linux/x64
http://code.google.com/p/v8/issues/detail?id=2357
That's great - thanks for the update and apologies for the dupe.
In my case I have little control over the range of the values that are
us
Revision: 12673
Author: jkumme...@chromium.org
Date: Mon Oct 8 04:51:20 2012
Log: Merged r12362 into 3.12 branch.
Check that index and length are Smi in bounds check.
BUG=chromium:142218
Review URL: https://codereview.chromium.org/11085005
http://code.google.com/p/v8/source/detail?r
lgtm
https://codereview.chromium.org/11085005/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Merged r12362 into 3.12 branch.
Check that index and length are Smi in bounds check.
BUG=chromium:142218
Please review this at https://codereview.chromium.org/11085005/
SVN Base: https://v8.googlecode.com/svn/branches/3.12
Affected file
Revision: 12672
Author: rossb...@chromium.org
Date: Mon Oct 8 04:39:08 2012
Log: Use dot_for_symbol.
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/11087002
http://code.google.com/p/v8/source/detail?r=12672
Modified:
/branches/bleeding_edge/src/parser.cc
lgtm
http://codereview.chromium.org/11087002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Duplicate
Owner: verwa...@chromium.org
Mergedinto: chromium:142218
Comment #1 on issue 2357 by jkumme...@chromium.org: Uint8Array codegen
errors with Chrome 22/Linux/x64
http://code.google.com/p/v8/issues/detail?id=2357
Yes, this is indeed fixed by r12
Reviewers: Sven Panne,
Description:
Use dot_for_symbol.
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/11087002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/parser.cc
Index: src/parser.cc
diff --git a/src/parse
Revision: 12671
Author: u...@chromium.org
Date: Mon Oct 8 04:11:30 2012
Log: Change default ARCH version in android low-level profiler script
to 4.6
R=jkumme...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11086002
http://code.google.com/p/v8/source/detail?r=126
lgtm
https://chromiumcodereview.appspot.com/11086002/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Jakob,
Message:
PTAL
Description:
Change default ARCH version in android low-level profiler script to 4.6
R=jkumme...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/11086002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
Revision: 12670
Author: verwa...@chromium.org
Date: Mon Oct 8 01:57:16 2012
Log: Tagging version 3.14.1.3
http://code.google.com/p/v8/source/detail?r=12670
Added:
/tags/3.14.1.3
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM (reviewed version.cc, rubber-stamped the rest)
https://chromiumcodereview.appspot.com/11072014/diff/1/src/version.cc
File src/version.cc (right):
https://chromiumcodereview.appspot.com/11072014/diff/1/src/version.cc#newcode38
src/version.cc:38: #define PATCH_LEVEL 1
3
https://chromi
Reviewers: Jakob,
Message:
PTAL.
Description:
Reverting sharing of descriptor arrays:
- Sharing of descriptor arrays.
- Ensure correct enumeration indices in the dict.
- Clear the EnumLength fields of maps that lose their enumeration cache.
- Directly set the value in the descriptors pointer to
33 matches
Mail list logo
