Updates:
Status: Assigned
Owner: svenpa...@chromium.org
Comment #1 on issue 2486 by svenpa...@chromium.org: --print-ast and
--print-source segfault with throw statements
http://code.google.com/p/v8/issues/detail?id=2486
Bisecting shows r13123 as the culprit, I'll take a look i
LGTM.
https://codereview.chromium.org/11881017/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 13366
Author: svenpa...@chromium.org
Date: Mon Jan 14 00:36:38 2013
Log: We can't print the AST or the source for stubs.
BUG=v8:2486
Review URL: https://codereview.chromium.org/11881017
http://code.google.com/p/v8/source/detail?r=13366
Modified:
/branches/bleeding_edge/src
Updates:
Status: Fixed
Comment #2 on issue 2486 by svenpa...@chromium.org: --print-ast and
--print-source segfault with throw statements
http://code.google.com/p/v8/issues/detail?id=2486
Fixed in r13366, the bisection result was actually bogus: The bug was
caused by our Hydrogen-gen
Status: Accepted
Owner: svenpa...@chromium.org
Labels: Type-Bug Priority-High
New issue 2487 by svenpa...@chromium.org: Force the explicit use of
Isolates in v8's external API
http://code.google.com/p/v8/issues/detail?id=2487
The implicit use of Isolates in v8's external API has several drawb
Updates:
Status: Duplicate
Mergedinto: 2487
Comment #1 on issue 2485 by svenpa...@chromium.org: BooleanValue()
sub-optimal performance
http://code.google.com/p/v8/issues/detail?id=2485
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
ht
Comment #1 on issue 2487 by svenpa...@chromium.org: Force the explicit use
of Isolates in v8's external API
http://code.google.com/p/v8/issues/detail?id=2487
Issue 2485 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: Duplicate
Mergedinto: 2487
Comment #2 on issue 2484 by svenpa...@chromium.org: Add Isolate argument to
Number::New()
http://code.google.com/p/v8/issues/detail?id=2484
(No comment was entered for this change.)
--
v8-dev mailing list
v8-dev@googlegroups.com
htt
Comment #2 on issue 2487 by svenpa...@chromium.org: Force the explicit use
of Isolates in v8's external API
http://code.google.com/p/v8/issues/detail?id=2487
Issue 2484 has been merged into this issue.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Status: WorkingAsIntended
Comment #1 on issue 2483 by svenpa...@chromium.org: Creating large arrays
fails since r13237
http://code.google.com/p/v8/issues/detail?id=2483
What happens here is that you allocate an exponentially growing array of
doubles. We are even using an un
Reviewers: Sven Panne,
Description:
Fix unhandlified value in GetOwnProperty function.
R=svenpa...@chromium.org
BUG=chromium:169723
Please review this at https://codereview.chromium.org/11879017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.c
lgtm
https://codereview.chromium.org/11879017/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 13367
Author: mstarzin...@chromium.org
Date: Mon Jan 14 02:21:22 2013
Log: Fix unhandlified value in GetOwnProperty function.
R=svenpa...@chromium.org
BUG=chromium:169723
Review URL: https://codereview.chromium.org/11879017
http://code.google.com/p/v8/source/detail?r=13367
Reviewers: Sven Panne,
Message:
Our objects.h type hierarchy FTW. :)
Description:
Fix problem with NULL handle in r13367.
R=svenpa...@chromium.org
BUG=chromium:169723
Please review this at https://codereview.chromium.org/11881020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg
On 2013/01/14 10:54:27, Michael Starzinger wrote:
Our objects.h type hierarchy FTW. :)
LGTM.
https://codereview.chromium.org/11881020/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Reviewers: Michael Starzinger,
Message:
This set of CLs has been reverted previously because of WebKit failures.
Those
have been caused by side-effects when calling the "constructor" property,
causing access checks to WebKit, which leads to doom. This should not
happen and
is fixed by patch
Revision: 13368
Author: mstarzin...@chromium.org
Date: Mon Jan 14 02:59:00 2013
Log: Fix problem with NULL handle in r13367.
R=svenpa...@chromium.org
BUG=chromium:169723
Review URL: https://codereview.chromium.org/11881020
http://code.google.com/p/v8/source/detail?r=13368
Modified:
LGTM save for one small detail that I fixed. Landing.
https://codereview.chromium.org/11852019/diff/4001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/11852019/diff/4001/src/api.cc#newcode3898
src/api.cc:3898: if (IsDeadCheck(str->GetIsolate(),
"v8::String::MayContainNonAs
Revision: 13369
Author: yang...@chromium.org
Date: Mon Jan 14 03:22:05 2013
Log: Prepare API for webkit use of Latin-1
R=yang...@chromium.org
BUG=
Review URL: https://chromiumcodereview.appspot.com/11852019
Patch from Dan Carney .
http://code.google.com/p/v8/source/detail?r=13369
Mod
Updates:
Owner: da...@chromium.org
Cc: vego...@chromium.org yu...@chromium.org loi...@chromium.org
a...@chromium.org
Comment #3 on issue 2479 by yu...@chromium.org: Object is not being
collected when it was passed as an argument to a function that is still
alive (under unclear oth
Generally LGTM, but I do have a question before landing this.
https://chromiumcodereview.appspot.com/11642006/diff/5001/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):
https://chromiumcodereview.appspot.com/11642006/diff/5001/tools/gyp/v8.gyp#newcode1005
tools/gyp/v8.gyp:1005: 'variables': {
I
LGTM (rubber-stamped patch set 1 and reviewed patch set 2).
https://codereview.chromium.org/11880018/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Updates:
Owner: hpa...@chromium.org
Cc: mstarzin...@chromium.org da...@chromium.org
Comment #4 on issue 2479 by da...@chromium.org: Object is not being
collected when it was passed as an argument to a function that is still
alive (under unclear other circumstance)
http://code
Revision: 13370
Author: mstarzin...@chromium.org
Date: Mon Jan 14 04:59:41 2013
Log: The time spent in GCPrologue callbacks and GCEpilogue callbacks
should be measured as EXTERNAL time
BUG=
Review URL: https://codereview.chromium.org/11817044
Patch from Kentaro Hara .
http://code.g
Reviewers: Michael Starzinger,
Description:
Removed deprecated functions from v8's external API.
Removed the following deprecated functions:
* Object::GetPointerFromInternalField
* Object::SetPointerInInternalField
* External::Wrap
* External::Unwrap
* Context::GetData
* Conte
Revision: 13371
Author: yang...@chromium.org
Date: Mon Jan 14 05:19:27 2013
Log: Reland r13188, r13194, r13256 (Deferred formatting of error stack
trace during GC).
BUG=
Review URL: https://chromiumcodereview.appspot.com/11880018
http://code.google.com/p/v8/source/detail?r=13371
A
Updates:
Cc: loi...@chromium.org a...@chromium.org yu...@chromium.org
Comment #1 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
(No comment was entered for this change.)
--
v8-dev mailing lis
Updates:
Status: Invalid
Comment #7 on issue 2482 by jkumme...@chromium.org: Add build flags that
are needed for pyv8
http://code.google.com/p/v8/issues/detail?id=2482
Thanks for your contribution! Please follow the instructions at
http://code.google.com/p/v8/wiki/Contributing to ge
LGTM. Let's hope we are not breaking the world with this.
https://codereview.chromium.org/11885019/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 13372
Author: svenpa...@chromium.org
Date: Mon Jan 14 05:41:08 2013
Log: Removed deprecated functions from v8's external API.
Removed the following deprecated functions:
* Object::GetPointerFromInternalField
* Object::SetPointerInInternalField
* External::Wrap
*
Reviewers: Michael Starzinger,
Description:
Merged r13230, r13258 into 3.15 branch.
MIPS: Improve array to string conversion.
MIPS: ARM: fix a bug with saving lr register in GenerateSmiToDouble.
R=mstarzin...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/11878019/
LGTM (rubber-stamped).
https://chromiumcodereview.appspot.com/11878019/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Comment #2 on issue 2471 by a...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
Can't reproduce it on:
Chromium26.0.1384.0 (Developer Build 176660)
OS Linux
WebKit 537.26 (trunk@139415)
JavaScript V8 3.16
Revision: 13373
Author: da...@chromium.org
Date: Mon Jan 14 06:11:06 2013
Log: Merged r13230, r13258 into 3.15 branch.
MIPS: Improve array to string conversion.
MIPS: ARM: fix a bug with saving lr register in GenerateSmiToDouble.
R=mstarzin...@chromium.org
Review URL: https://chromi
Revision: 13374
Author: da...@chromium.org
Date: Mon Jan 14 06:11:25 2013
Log: Tagging version 3.15.11.8
http://code.google.com/p/v8/source/detail?r=13374
Added:
/tags/3.15.11.8
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
LGTM, with a suggestion.
https://codereview.chromium.org/11661008/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/11661008/diff/1/src/compiler.cc#newcode516
src/compiler.cc:516: !isolate->DebuggerHasBreakPoints()) {
To make this completely consistent with th
LGTM. Landing.
https://codereview.chromium.org/11857015/
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
Revision: 13375
Author: yang...@chromium.org
Date: Mon Jan 14 07:17:56 2013
Log: Remove move ascii data hint for one byte strings
This is mostly a rollback of r12966
[Make kAsciiDataHintTag have correct semantics for all both 1 and 2 byte
string types.]
R=yang...@chromium.org
BUG=
LGTM, but I got one comment.
https://codereview.chromium.org/11889007/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/11889007/diff/1/src/runtime.cc#newcode5910
src/runtime.cc:5910: if ((or_acc & kAsciiMask) != 0) {
Would it be noticeably more expensive to do
Comment #3 on issue 2471 by ma...@google.com: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
I can still reproduce it with Chromium trunk build.
Chromium 26.0.1384.0 (176670)
OS Ubuntu
WebKit r139589
V8 r13363
--
v8-dev mailing list
v
On 2013/01/14 15:56:51, Yang wrote:
LGTM, but I got one comment.
https://codereview.chromium.org/11889007/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/11889007/diff/1/src/runtime.cc#newcode5910
src/runtime.cc:5910: if ((or_acc & kAsciiMask) != 0) {
Woul
Comment #4 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
I changed the code a bit and inserted handle2.dispose():
var handle2 = creator.Create();
handle2.dispose();
handle2 = null;
as I understand
Comment #5 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
Array@7387 above must be FixedArray or something as when I attempt to print
it in the console using $0 the render process crashes.
--
v8-d
Updates:
Owner: da...@chromium.org
Cc: vego...@chromium.org
Comment #6 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
(No comment was entered for this change.)
--
v8-dev mailing list
Comment #7 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
My setup is:
Chromium26.0.1384.0 (Developer Build 176656)
OS Linux
WebKit 537.26 (trunk@139601)
JavaScript V8 3.16.4
--
v8
Comment #8 on issue 2471 by ma...@google.com: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
Glad that you can reproduce it (or at least a similar bug).
Indeed, with the handle2.dispose() call, the object should have no
retaining path
Comment #9 on issue 2471 by yu...@chromium.org: Regression: Bogus retaining
paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
I can reproduce it consistently, looks like a leak in v8.
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-de
Oh, thank you for catching possible issues. I've done more testing for
use_system_v8=1 case, and indeed I had to fix a few things. Done now.
I intend to de-deuplicate this nicely with some changes gyp-side, but
shipping
this to M26 if possible would be also cool.
https://codereview.chromium.o
Updates:
Cc: yang...@chromium.org
Comment #10 on issue 2471 by vego...@chromium.org: Regression: Bogus
retaining paths in a heap snapshot
http://code.google.com/p/v8/issues/detail?id=2471
My guess would be that this path is through raw_stack trace accumulated for
new Error().stack u
Reviewers: Jakob,
Message:
linux-tick-processor will show:
320.2%0.0% [vdso]
instead of:
320.2%0.0% f76ec000-f76ed000
Description:
Record vdso and vsyscall as shared libraries in
OS::LogSharedLibraryAddresses on
Linux
Please review this at https://codereview.chro
50 matches
Mail list logo
