Reviewers: Vyacheslav Egorov,
Message:
I built gdb 7.4 from http://ftp.gnu.org/gnu/gdb/ on Mac OSX 10.7.5.
With this CL, gdbjit compiles for both gyp and scons while currently it only
works for d8_g built from scons, not d8 from gyp. I know I should build with
GYP, but currently I did not figure
https://codereview.chromium.org/12983016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Paul Lind,
Description:
Merged r13798, r13802, r13803, r13804, r13805 into 3.17 branch.
MIPS: Refactor RegExpStub to check lazily.
MIPS: Compile FastCloneShallowObjectStub using Crankshaft.
MIPS: Fix materialization of arguments objects with unknown values.
MIPS: Currently this mos
Reviewers: danno, Sven Panne,
Message:
This was originally submitted here with the wrong account:
https://codereview.chromium.org/13018002/
Description:
linux: fix uClibc ifdeffery
Remove duplicate inclusion of execinfo.h and make OS::DumpBacktrace
a NOOP on uclibc.
Please review this at http
Reviewers: rossberg,
Message:
This is step 2 of N. I hoped to be able to clean this up more in step 2,
but the
use of %GetArrayKeys in ArraySort are problematic. I really wish
CopyFromPrototypes() and ShadowPrototypeElements() just weren't necessary...
Description:
Codify the assumption that
Reviewers: Paul Lind,
Description:
Merged r13798, r13802, r13803, r13804, r13805 into 3.17 branch.
MIPS: Refactor RegExpStub to check lazily.
MIPS: Compile FastCloneShallowObjectStub using Crankshaft.
MIPS: Fix materialization of arguments objects with unknown values.
MIPS: Currently this mos
Committed manually as r14073.
https://codereview.chromium.org/12855004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Revision: 14073
Author: plin...@gmail.com
Date: Mon Mar 25 12:01:36 2013
Log: MIPS: Generalizing remaining Allocate functions in the macro
assemblers used in pretenuring.
Port r14065 (f09e7e38)
BUG=
Review URL: https://codereview.chromium.org/12855004
Patch from Akos Palfi .
http:
lgtm, I'll commit this for you.
https://codereview.chromium.org/12855004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and sto
Issue 2595: Wrong inlining target
http://code.google.com/p/v8/issues/detail?id=2595
This issue is now blocking issue dart:9407.
See http://code.google.com/p/dart/issues/detail?id=9407
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you star
Issue 2595: Wrong inlining target
http://code.google.com/p/v8/issues/detail?id=2595
This issue is no longer blocking issue dart:7952.
See http://code.google.com/p/dart/issues/detail?id=7952
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you
Issue 2595: Wrong inlining target
http://code.google.com/p/v8/issues/detail?id=2595
This issue is now blocking issue dart:7952.
See http://code.google.com/p/dart/issues/detail?id=7952
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you star
Comment #5 on issue 2593 by stefan.p...@gmail.com: Object.create and
Object.hasOwnProperty optimizations
http://code.google.com/p/v8/issues/detail?id=2593
We are unable to replicate this in isolation. Likely do to the bug
occurring only in optimized code, and ensuring we hit the correct opt
Status: Accepted
Owner: da...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2595 by vego...@chromium.org: Wrong inlining target
http://code.google.com/p/v8/issues/detail?id=2595
Reproducing bug:
unzip repro.zip
cd repro
python -m SimpleHTTPServer
google-chrome
'http://localhost:8000/
Reviewers: Paul Lind, Hannes Payer, danno, kisg, kilvadyb,
Description:
MIPS: Generalizing remaining Allocate functions in the macro assemblers
used in
pretenuring.
Port r14065 (f09e7e38)
BUG=
Please review this at https://codereview.chromium.org/12855004/
SVN Base: https://v8.googlecode.
Reviewers: rossberg,
Message:
First steps towards V8 implementation of ArrayBuffers.
Just an ArrayBuffer constructor + byteLength property.
(under flag and with weird name __ArrayBuffer for now)
Description:
First steps towards implementing ArrayBuffer &co in V8
BUG=
Please review this at ht
Revision: 14072
Author: da...@chromium.org
Date: Mon Mar 25 10:59:15 2013
Log: Remove bogus test flags
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/12872007
http://code.google.com/p/v8/source/detail?r=14072
Added:
/branches/bleeding_edge/test/mjsunit/regress
Committed patchset #2 manually as r14072 (presubmit successful).
https://codereview.chromium.org/12872007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/12872007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Toon Verwaest,
Description:
Remove bogus test flags
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/12872007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M test/mjsunit/regress/external-and-normal-array-polymorphim
On 25 March 2013 18:35, Adam Klein wrote:
> Ah, sorry about that, I should have caught that myself (I believe I
> was emailed, but all other V8 build breakage emails I've gotten have
> been unrelated flakes). Good to know such a linter exists.
No worries, certainly happens to me, too. ;)
/Andrea
On Mon, Mar 25, 2013 at 10:31 AM, Andreas Rossberg wrote:
> On 25 March 2013 18:23, Adam Klein wrote:
>> Thanks for the fix, but can you explain why this is problematic? I'd
>> assumed that since FixedArray::set() doesn't cause a GC this was safe.
>
> It probably is in this instance, but GCMole,
Sorry, looks like i got linked to an old snapshot :)
This is all fine now.
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
On 25 March 2013 18:23, Adam Klein wrote:
> Thanks for the fix, but can you explain why this is problematic? I'd
> assumed that since FixedArray::set() doesn't cause a GC this was safe.
It probably is in this instance, but GCMole, which our build bots run,
can't tell and complained:
http://build
Revision: 14071
Author: da...@chromium.org
Date: Mon Mar 25 10:27:54 2013
Log: Use code_range()->exists() to determine the size of the first
code page when code range is used.
Review URL: https://codereview.chromium.org/12452012
Patch from Haitao Feng .
http://code.google.com/p/v8/s
Committed patchset #2 manually as r14071 (presubmit successful).
https://codereview.chromium.org/12452012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Thanks for the fix, but can you explain why this is problematic? I'd
assumed that since FixedArray::set() doesn't cause a GC this was safe.
On Mon, Mar 25, 2013 at 4:39 AM, wrote:
> LGTM. Style nit: NewSingleInterval should probably be moved to Factory.
>
> https://codereview.chromium.org/129130
We can't include this file with this license, but unless i'm missing
something,
i'd bet this license is an accident.
WE should use our intel contacts to see what's up :)
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/
lgtm
https://codereview.chromium.org/12452012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 14070
Author: pal...@homejinni.com
Date: Mon Mar 25 10:12:50 2013
Log: MIPS: Change LookupForWrite to always do a full lookup and check
the result.
Port r14061 (df49702a)
Original commit message:
If we find a property in the prototype-chain that we can overwrite, and
we h
Committed manually as r14070 (presubmit successful).
https://codereview.chromium.org/12924011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Revision: 14069
Author: verwa...@chromium.org
Date: Mon Mar 25 10:10:33 2013
Log: Create a new HandleScope for each JSON-parsed object to avoid
excessive growth
Review URL: https://chromiumcodereview.appspot.com/12880019
http://code.google.com/p/v8/source/detail?r=14069
Modified:
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp
File src/third_party/vtune/v8vtune.gyp (right):
https://codereview.chromium.org/11574031/diff/99001/src/third_party/vtune/v8vtune.gyp#newcode1
src/third_party/vtune/v8vtune.gyp:1: # Copyright 2012 the V8 projec
Committed patchset #1 manually as r14069 (presubmit successful).
https://chromiumcodereview.appspot.com/12880019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/12880019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/12924011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Paul Lind, Toon Verwaest, danno, kisg, kilvadyb,
Description:
MIPS: Change LookupForWrite to always do a full lookup and check the result.
Port r14061 (df49702a)
Original commit message:
If we find a property in the prototype-chain that we can overwrite, and
we have a transition, kee
Revision: 14068
Author: jkumme...@chromium.org
Date: Mon Mar 25 09:32:50 2013
Log: Tagging version 3.17.15.3
http://code.google.com/p/v8/source/detail?r=14068
Added:
/tags/3.17.15.3
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You recei
Revision: 14067
Author: jkumme...@chromium.org
Date: Mon Mar 25 09:32:26 2013
Log: Merged r14063, r14064 into trunk branch.
Fix crash involving zombie maps escaping from the JSON parser's underground
lab
Fix store_mode bug involving polymorphism with external and JS arrays.
R=verw
hello, Daniel &　Jakob.
Could you please review this patch?
Thanks.
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
T
Committed patchset #1 manually as r14067 (presubmit successful).
https://codereview.chromium.org/12843031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Jakob,
Message:
PTAL
Description:
Create a new HandleScope for each JSON-parsed object to avoid excessive
growth
Please review this at https://codereview.chromium.org/12880019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/json-parser.h
lgtm
https://codereview.chromium.org/12843031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Toon Verwaest,
Description:
Merged r14063, r14064 into trunk branch.
Fix crash involving zombie maps escaping from the JSON parser's underground
lab
Fix store_mode bug involving polymorphism with external and JS arrays.
R=verwa...@chromium.org
BUG=
Please review this at https:/
https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/12440041/diff/1/src/arm/code-stubs-arm.cc#newcode4959
src/arm/code-stubs-arm.cc:4959: __ Allocate(r1,
On 2013/03/20 22:11:09, danno wrote:
nit: can y
Revision: 14066
Author: verwa...@chromium.org
Date: Mon Mar 25 08:59:08 2013
Log: Add AssertNoAllocation to ensure TransitionArray* transitions is
safe.
Review URL: https://chromiumcodereview.appspot.com/12583013
http://code.google.com/p/v8/source/detail?r=14066
Modified:
/branche
Committed patchset #1 manually as r14066 (presubmit successful).
https://chromiumcodereview.appspot.com/12583013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://chromiumcodereview.appspot.com/12583013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: Jakob,
Message:
PTAL
Description:
Add AssertNoAllocation to ensure TransitionArray* transitions is safe.
Please review this at https://chromiumcodereview.appspot.com/12583013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects-inl.h
In
Revision: 14065
Author: hpa...@chromium.org
Date: Mon Mar 25 08:54:15 2013
Log: Generalizing remaining Allocate functions in the macro assemblers
used in pretenuring.
BUG=
Review URL: https://codereview.chromium.org/12440041
http://code.google.com/p/v8/source/detail?r=14065
Modifi
Committed patchset #2 manually as r14065 (presubmit successful).
https://codereview.chromium.org/12440041/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: danno, mvstanton, Michael Starzinger,
Description:
Build fast literals in hydrogen.
BUG=
Please review this at https://codereview.chromium.org/12880017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/lithium-arm.h
M src/arm/lithium-arm
Revision: 14064
Author: da...@chromium.org
Date: Mon Mar 25 08:19:22 2013
Log: Fix store_mode bug involving polymorphism with external and JS
arrays.
Review URL: https://codereview.chromium.org/12987014
http://code.google.com/p/v8/source/detail?r=14064
Added:
/branches/bleeding_
Committed patchset #1 manually as r14064 (presubmit successful).
https://codereview.chromium.org/12987014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14063
Author: jkumme...@chromium.org
Date: Mon Mar 25 08:18:52 2013
Log: Fix crash involving zombie maps escaping from the JSON parser's
underground lab
Zapping is required since transition arrays contain weak references to
maps: At the end of a GC cycle, ClearNonLiveTra
Committed patchset #2 manually as r14063 (presubmit successful).
https://codereview.chromium.org/12987013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/12987014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/12987013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Fix store_mode bug involving polymorphism with external and JS arrays.
Please review this at https://codereview.chromium.org/12987014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ic.cc
A + test/
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Fix crash involving zombie maps escaping from the JSON parser's underground
lab
Please review this at https://codereview.chromium.org/12987013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/obje
Comment #4 on issue 2591 by ma...@chromium.org:
v8::Isolate::GetHeapStatistics crashes
http://code.google.com/p/v8/issues/detail?id=2591
Not surprisingly, adding this initialization check makes the problem go
away:
https://codereview.chromium.org/12965013/diff/1/src/api.cc
--
You receive
Revision: 14062
Author: da...@chromium.org
Date: Mon Mar 25 06:09:33 2013
Log: Create V8 3.17 branch for Chrome 27
http://code.google.com/p/v8/source/detail?r=14062
Added:
/branches/3.17
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Yo
Revision: 14061
Author: verwa...@chromium.org
Date: Mon Mar 25 05:55:27 2013
Log: Change LookupForWrite to always do a full lookup and check the
result.
If we find a property in the prototype-chain that we can overwrite, and
we have a transition, keep the holder in the lookup-result
Committed patchset #5 manually as r14061 (presubmit successful).
https://chromiumcodereview.appspot.com/12810006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Addressed comments, landing.
https://chromiumcodereview.appspot.com/12810006/diff/10001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://chromiumcodereview.appspot.com/12810006/diff/10001/src/arm/stub-cache-arm.cc#newcode467
src/arm/stub-cache-arm.cc:467: // prototype c
LGTM with comments
https://codereview.chromium.org/12810006/diff/10001/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
https://codereview.chromium.org/12810006/diff/10001/src/arm/stub-cache-arm.cc#newcode467
src/arm/stub-cache-arm.cc:467: // prototype chain) is is slow mode, w
Addressed comments, PTAL again.
https://chromiumcodereview.appspot.com/12810006/diff/3001/src/ic.cc
File src/ic.cc (left):
https://chromiumcodereview.appspot.com/12810006/diff/3001/src/ic.cc#oldcode1591
src/ic.cc:1591: if (!holder.is_identical_to(receiver)) break;
On 2013/03/22 14:07:44, rossbe
Revision: 14060
Author: rossb...@chromium.org
Date: Mon Mar 25 04:40:14 2013
Log: Remove GC hazard (temporary handle object)
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/12913019
http://code.google.com/p/v8/source/detail?r=14060
Modified:
/branches/bleed
LGTM. Style nit: NewSingleInterval should probably be moved to Factory.
https://codereview.chromium.org/12913019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Reviewers: Sven Panne,
Description:
Remove GC hazard (temporary handle object)
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/12913019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/runtime
Revision: 14059
Author: yang...@chromium.org
Date: Mon Mar 25 03:01:53 2013
Log: Correctly materialize arguments object in Runtime_DebugEvaluate.
The problem was that if the # arguments specified in the function
declaration and the # arguments passed to the function are not
the same, w
Committed patchset #1 manually as r14059 (presubmit successful).
https://chromiumcodereview.appspot.com/12674027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
On 2013/03/23 04:17:41, Peter Rybin wrote:
LGTM
I also have couple of comments about apply
1. My patch utility failed to apply this patch correctly, as it thought
test
file was renamed, not new. http://chromiumcodereview.appspot.com site does
similar
mistake. Probably it's a usual behav
73 matches
Mail list logo
