Comment #5 on issue 435 by mar...@laverdet.com: The .length property of a
function always returns zero
http://code.google.com/p/v8/issues/detail?id=435
From ECMA-262:
15.3.5 Properties of Function Instances
[...]
15.3.5.1 length
The value of the length property is an integer that indicates th
Comment #26 on issue 1312 by richardf...@gmail.com: It's time to get iOS
supported!
http://code.google.com/p/v8/issues/detail?id=1312
Duong, do you think it would be possible to put the source on your github
site that is the simplest of a working iOS app, doing nothing more than
maybe dis
Comment #25 on issue 1312 by richardf...@gmail.com: It's time to get iOS
supported!
http://code.google.com/p/v8/issues/detail?id=1312
Duong, this is good work. Have you updated your code work to implement the
latest V8? If not, can you please review the issues if you had tried and it
fail
Comment #13 on issue 429 by epr...@muftor.com: x86_64 not detected (patch)
http://code.google.com/p/v8/issues/detail?id=429
landed, sort of. WARNING: x64 defaults to a 32-bit build.
http://code.google.com/p/v8/source/detail?r=4523&path=/branches/bleeding_edge/tools/utils.py
Use the scons option
Comment #6 on issue 1012 by danielhe...@gmail.com: Slow Float32Array,
Int32Array
http://code.google.com/p/v8/issues/detail?id=1012
Can be closed? It is fast now.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust
@Balazs Please close this CL
https://codereview.chromium.org/12413032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
Committed as r14099.
https://codereview.chromium.org/12413032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 14099
Author: pal...@homejinni.com
Date: Thu Mar 28 14:17:02 2013
Log: MIPS: Fix register usage in softfloat code path.
BUG=none
TEST=mjsunit/math-floor-part2.js
Review URL: https://codereview.chromium.org/12413032
Patch from Balazs Kilvady .
http://code.google.com/p/v8/sour
Comment #7 on issue 180 by js...@chromium.org: toLocaleDateString and
toLocaleTimeString do not honor the current locale
http://code.google.com/p/v8/issues/detail?id=180
toLocaleDateString, toLocaleTimeString, toLocaleCompare now behave
respecting the UI language of Chrome. That is, if you
Comment #8 on issue 608 by erik.corry: js2c looses significant spaces in
regexps
http://code.google.com/p/v8/issues/detail?id=608
Well it seems nobody trod on it in the last 3 years, but I do have one
written in Dart if that helps :-).
One rather nice property of the current one is that i
Comment #32 on issue 459 by abyss...@gmail.com: localeCompare
implementation differs from other browsers
http://code.google.com/p/v8/issues/detail?id=459
Confirmed v8-i18n does indeed correct the behavior.
--
You received this message because this project is configured to send all
issue no
LGTM, thanks for the fix!
https://codereview.chromium.org/12413032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
Updates:
Cc: dslo...@chromium.org
Comment #5 on issue 1012 by yang...@chromium.org: Slow Float32Array,
Int32Array
http://code.google.com/p/v8/issues/detail?id=1012
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
Updates:
Owner: yang...@chromium.org
Comment #4 on issue 896 by yang...@chromium.org: Invalid RegExp reports
SyntaxError as an early error.
http://code.google.com/p/v8/issues/detail?id=896
(No comment was entered for this change.)
--
You received this message because this project is
Updates:
Status: WorkingAsIntended
Comment #1 on issue 928 by yang...@chromium.org: v8 scons build does not
respect LDFLAGS
http://code.google.com/p/v8/issues/detail?id=928
Scons... psh.
https://code.google.com/p/v8/wiki/BuildingWithGYP
--
You received this message because this proj
Updates:
Status: Fixed
Comment #3 on issue 805 by yang...@chromium.org: Port manual heap
randomization to x64 and Linux
http://code.google.com/p/v8/issues/detail?id=805
long been done.
--
You received this message because this project is configured to send all
issue notifications t
On 2013/03/26 15:00:04, kilvadyb wrote:
It looks good to me, but someone else must approve.
https://codereview.chromium.org/12413032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google G
Updates:
Status: Fixed
Comment #2 on issue 856 by yang...@chromium.org: Port StringAddStub
improvements to other architectures
http://code.google.com/p/v8/issues/detail?id=856
This has already been ported to all supported platforms.
--
You received this message because this project i
Updates:
Owner: ---
Comment #7 on issue 608 by yang...@chromium.org: js2c looses significant
spaces in regexps
http://code.google.com/p/v8/issues/detail?id=608
This land mine has stroke a few more times. I wonder whether we could just
replace it with some general purpose minifier.
Updates:
Status: PendingFurtherInfo
Comment #1 on issue 550 by yang...@chromium.org: Allow object handles in
evaluate request
http://code.google.com/p/v8/issues/detail?id=550
What are the use cases for this?
--
You received this message because this project is configured to send all
Updates:
Status: WorkingAsIntended
Comment #1 on issue 841 by yang...@chromium.org: RUNTIME_ASSERT requires
allocation
http://code.google.com/p/v8/issues/detail?id=841
This has never been an issue. I guess what we could do is to use a
boilerplate illegal access error object, but the
Comment #5 on issue 105 by jkumme...@chromium.org: Implicit call to valueOf
has wrong caller
http://code.google.com/p/v8/issues/detail?id=105
@4: https://chromiumcodereview.appspot.com/13166002
--
You received this message because this project is configured to send all
issue notifications
Updates:
Status: Fixed
Comment #2 on issue 688 by yang...@chromium.org: Object.keys(window)
returns an empty array of properties
http://code.google.com/p/v8/issues/detail?id=688
Seems to work fine (now).
--
You received this message because this project is configured to send all
is
Updates:
Status: Fixed
Comment #3 on issue 695 by yang...@chromium.org: Can not build d8 target
for FreeBSD
http://code.google.com/p/v8/issues/detail?id=695
Fixed in r7200.
--
You received this message because this project is configured to send all
issue notifications to this addre
Updates:
Status: Duplicate
Mergedinto: chromium:60240
Comment #5 on issue 764 by yang...@chromium.org: Incorrect stack trace.
http://code.google.com/p/v8/issues/detail?id=764
The stack trace issue for rethrown Error objects has long been solved.
--
You received this message beca
Status: New
Owner:
New issue 2600 by lcampb...@ironclad.mobi: POSIX output buffering breaks
--trace-gc when stdout is not a terminal
http://code.google.com/p/v8/issues/detail?id=2600
On POSIX, one semantic difference between a pipe and a terminal stdout is
that the pipe is, by default,
Updates:
Status: WorkingAsIntended
Comment #31 on issue 459 by yang...@chromium.org: localeCompare
implementation differs from other browsers
http://code.google.com/p/v8/issues/detail?id=459
yes. refer to v8-i18n.
--
You received this message because this project is configured to sen
Updates:
Cc: verwa...@chromium.org
Comment #2 on issue 445 by yang...@chromium.org: Access to non-existing
object property is slow
http://code.google.com/p/v8/issues/detail?id=445
Without crankshaft, this is what I get
not existing constant: 7
not existing computed: 132
existing
Comment #4 on issue 435 by a...@chromium.org: The .length property of a
function always returns zero
http://code.google.com/p/v8/issues/detail?id=435
We need to set the length in the DOM bindings.
--
You received this message because this project is configured to send all
issue notificatio
Comment #3 on issue 435 by a...@chromium.org: The .length property of a
function always returns zero
http://code.google.com/p/v8/issues/detail?id=435
We need to set the length in the DOM bindings. I think FunctionTemplate
supports length?
--
You received this message because this project
Updates:
Status: PendingFurtherInfo
Comment #2 on issue 435 by yang...@chromium.org: The .length property of a
function always returns zero
http://code.google.com/p/v8/issues/detail?id=435
Not sure why this is an issue. Is it specified anywhere what the length of
a native function n
Updates:
Status: Fixed
Comment #8 on issue 352 by yang...@chromium.org: V8 Fails on the Language
Shootout
http://code.google.com/p/v8/issues/detail?id=352
I sure hope the days of non-standard JS are over. Sunspider has since
become less and less relevant. d8 no longer defaults to ha
Updates:
Status: Fixed
Comment #12 on issue 429 by yang...@chromium.org: x86_64 not detected
(patch)
http://code.google.com/p/v8/issues/detail?id=429
The patch has already been landed (years ago).
--
You received this message because this project is configured to send all
issue not
Updates:
Status: WorkingAsIntended
Comment #5 on issue 388 by yang...@chromium.org: Some code is much slower
when the debugger is running
http://code.google.com/p/v8/issues/detail?id=388
Seems like a non-issue to me. The original goal of making the code being
debugged just as fast a
Updates:
Status: Fixed
Comment #3 on issue 387 by yang...@chromium.org:
Debug::ClearAllBreakPoints() may create handles without a HandleScope
http://code.google.com/p/v8/issues/detail?id=387
This can no longer happen. There are no handle allocations in
v8::internal::Debug::ClearAllB
Updates:
Status: Fixed
Comment #2 on issue 382 by yang...@chromium.org: Test case
test-api/ApplyInterruption times out a lot
http://code.google.com/p/v8/issues/detail?id=382
I've never seen this time out in the last two years.
--
You received this message because this project is conf
Updates:
Status: Fixed
Comment #1 on issue 342 by yang...@chromium.org: ASSERTION
FAILED !map_.contains(obj) in bindings
http://code.google.com/p/v8/issues/detail?id=342
Stale issue. Probably not relevant anymore.
--
You received this message because this project is configured to sen
Switched to returning a number instead of a single interval for the interval
case. Also renamed "intervals" to "indices" everywhere. Let me know what you
think.
https://codereview.chromium.org/13071006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Updates:
Status: Fixed
Comment #2 on issue 333 by yang...@chromium.org: Avoid copying extension
source code when installing extensions
http://code.google.com/p/v8/issues/detail?id=333
We no longer do this, since we use external string instead.
--
You received this message because thi
lgtm
https://codereview.chromium.org/13008018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Updates:
Status: Fixed
Comment #7 on issue 332 by yang...@chromium.org: "Script used too much
memory" when leaving gmail open for days
http://code.google.com/p/v8/issues/detail?id=332
Should be fixed already.
--
You received this message because this project is configured to send all
Updates:
Status: WorkingAsIntended
Comment #1 on issue 329 by yang...@chromium.org: d8 asserts while printing
an outer function's paramter value
http://code.google.com/p/v8/issues/detail?id=329
Not reproducible (anymore).
--
You received this message because this project is configure
Revision: 14098
Author: ka...@chromium.org
Date: Thu Mar 28 09:31:11 2013
Log: Tagging version 3.17.6.1
http://code.google.com/p/v8/source/detail?r=14098
Added:
/tags/3.17.6.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received th
Updates:
Status: Fixed
Comment #3 on issue 277 by yang...@chromium.org: stack overflow in debug
mode LayoutTests/fast/js/large-expressions.html
http://code.google.com/p/v8/issues/detail?id=277
(No comment was entered for this change.)
--
You received this message because this project
Revision: 14097
Author: ka...@chromium.org
Date: Thu Mar 28 09:31:02 2013
Log: Merged r14010 into 3.17 branch.
Disable weak embedded maps because of crashes.
BUG=172489,217858
R=da...@chromium.org
Review URL: https://codereview.chromium.org/13157003
http://code.google.com/p/v8/sourc
Committed patchset #1 manually as r14097 (presubmit successful).
https://codereview.chromium.org/13157003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/03/28 16:29:55, danno wrote:
LGTM.
https://codereview.chromium.org/13192002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this g
lgtm
https://codereview.chromium.org/13157003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Yang,
Description:
Merged r14010 into 3.17 branch.
Disable weak embedded maps because of crashes.
BUG=172489,217858
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/13192002/
SVN Base: https://v8.googlecode.com/svn/branches/3.17
Affected files:
M sr
Reviewers: danno,
Description:
Merged r14010 into 3.17 branch.
Disable weak embedded maps because of crashes.
BUG=172489,217858
R=da...@chromium.org
Please review this at https://codereview.chromium.org/13157003/
SVN Base: https://v8.googlecode.com/svn/branches/3.17
Affected files:
M src
Updates:
Status: Fixed
Comment #13 on issue 270 by yang...@chromium.org: Add Blob type to api for
holding binary data
http://code.google.com/p/v8/issues/detail?id=270
seems like typed arrays solve this issue already.
--
You received this message because this project is configured to
Updates:
Status: Fixed
Comment #3 on issue 307 by yang...@chromium.org: Print stack trace to a
string instead of on a FILE.
http://code.google.com/p/v8/issues/detail?id=307
The current Message::GetStackTrace() already works as described in the
feature request.
--
You received this
Updates:
Status: WorkingAsIntended
Comment #1 on issue 229 by yang...@chromium.org: Consider removing
StringShape
http://code.google.com/p/v8/issues/detail?id=229
StringShape seems to work just fine up till now.
--
You received this message because this project is configured to send
Updates:
Status: WorkingAsIntended
Comment #2 on issue 216 by yang...@chromium.org: Link errors when linking
the v8 static lib with MFC application
http://code.google.com/p/v8/issues/detail?id=216
Seems to be out of date by now.
--
You received this message because this project is co
Updates:
Status: WorkingAsIntended
Comment #2 on issue 197 by yang...@chromium.org: Use different object
directories for all different build configurations
http://code.google.com/p/v8/issues/detail?id=197
We at least do that for different platforms now. Additional differentiation
se
Updates:
Status: WorkingAsIntended
Comment #6 on issue 180 by yang...@chromium.org: toLocaleDateString and
toLocaleTimeString do not honor the current locale
http://code.google.com/p/v8/issues/detail?id=180
refer to v8-i18n.
--
You received this message because this project is config
Updates:
Status: Fixed
Comment #3 on issue 175 by yang...@chromium.org: Null Pointer Read in
LayoutTests\fast\js\global-recursion-on-full-stack.html
http://code.google.com/p/v8/issues/detail?id=175
(No comment was entered for this change.)
--
You received this message because this pr
Updates:
Status: WorkingAsIntended
Comment #6 on issue 172 by yang...@chromium.org: There is a limit to the
size of the argument array passed to function.apply
http://code.google.com/p/v8/issues/detail?id=172
Function.apply puts the arguments onto the stack, one-by-one. Stack is not
Updates:
Cc: yang...@chromium.org
Comment #5 on issue 160 by yang...@chromium.org: Irregexp: Propagate start
set of capture to back reference
http://code.google.com/p/v8/issues/detail?id=160
(No comment was entered for this change.)
--
You received this message because this project i
Updates:
Status: Invalid
Comment #4 on issue 150 by yang...@chromium.org: scons install target
http://code.google.com/p/v8/issues/detail?id=150
Scons is going to die.
--
You received this message because this project is configured to send all
issue notifications to this address.
You
Updates:
Status: WorkingAsIntended
Comment #1 on issue 147 by yang...@chromium.org: class SaveContext missing
description
http://code.google.com/p/v8/issues/detail?id=147
It appears to be nothing more than a scope to keep a copy of the current
context and restore it in the destructo
Updates:
Status: WorkingAsIntended
Comment #22 on issue 144 by yang...@chromium.org: Easy C++ Wrapper for
Embedding
http://code.google.com/p/v8/issues/detail?id=144
No action items for V8 on this matter.
--
You received this message because this project is configured to send all
is
Updates:
Status: Fixed
Comment #19 on issue 129 by yang...@chromium.org: Memory consumption
hyperoscillations
http://code.google.com/p/v8/issues/detail?id=129
The "new" GC is more than a year old by now. This issue is not observable
anymore.
--
You received this message because th
Updates:
Status: WorkingAsIntended
Comment #5 on issue 126 by yang...@chromium.org: Dictionary::Allocate
should preserve 25% more space than asked
http://code.google.com/p/v8/issues/detail?id=126
We currently double the space and then round up to the next power of two
than what's re
Updates:
Owner: yang...@chromium.org
Labels: -Priority-Medium Priority-Low
Comment #2 on issue 119 by yang...@chromium.org: Remove push(holder_reg) in
CheckAccessGlobalProxy
http://code.google.com/p/v8/issues/detail?id=119
Proposed fix: https://codereview.chromium.org/13177002
Reviewers: Jakob,
Description:
Remove push(holder_reg) in CheckAccessGlobalProxy.
R=jkumme...@chromium.org
BUG=v8:119
Please review this at https://chromiumcodereview.appspot.com/13177002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/arm/macro-assem
Comment #4 on issue 105 by erights: Implicit call to valueOf has wrong
caller
http://code.google.com/p/v8/issues/detail?id=105
Could you post a link to or a copy of the test here? Thanks.
--
You received this message because this project is configured to send all
issue notifications to thi
On 2013/03/27 22:57:03, danno wrote:
It's my understanding that SVG uses NEON all the time, so it's already
powered
up anyway.
Shouldn't the platform's libc (bionic in the case of Android) already
provide a
NEON-based memcpy if the hardware supports it?
For bionic, it seems to be here:
ht
Updates:
Status: Fixed
Comment #3 on issue 105 by yang...@chromium.org: Implicit call to valueOf
has wrong caller
http://code.google.com/p/v8/issues/detail?id=105
Issue has been fixed long ago. New test has been added to make sure this
does not happen again.
--
You received this m
Revision: 14096
Author: yang...@chromium.org
Date: Thu Mar 28 07:31:48 2013
Log: Add test to check that Function.caller must not expose native
functions.
R=svenpa...@chromium.org
BUG=v8:105
Review URL: https://chromiumcodereview.appspot.com/13166002
http://code.google.com/p/v8/sour
Committed patchset #1 manually as r14096 (presubmit successful).
https://chromiumcodereview.appspot.com/13166002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/13166002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
ARM side looks good to me.
I'm not a proper reviewer though, so someone from the v8-team should
probably
still sign off.
https://codereview.chromium.org/12982008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because yo
On 28 Mar 2013 13:27, wrote:
>
> LGTM with comments
>
>
> https://codereview.chromium.org/13071006/diff/1/src/array.js
> File src/array.js (right):
>
> https://codereview.chromium.org/13071006/diff/1/src/array.js#newcode44
> src/array.js:44: if (length == 2 && intervals[0] == -1) {
> Nit: using ==
Updates:
Status: Fixed
Comment #8 on issue 2596 by dslo...@chromium.org: V8 is leaking holes
http://code.google.com/p/v8/issues/detail?id=2596
Fix committed as https://code.google.com/p/v8/source/detail?r=14094
--
You received this message because this project is configured to send all
Reviewers: Sven Panne,
Description:
Add test to check that Function.caller must not expose native functions.
R=svenpa...@chromium.org
BUG=v8:105
Please review this at https://chromiumcodereview.appspot.com/13166002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
PTAL
https://codereview.chromium.org/12491023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Updates:
Status: WorkingAsIntended
Comment #6 on issue 61 by yang...@chromium.org: CatchStackOverflow fails
with multiple threads on MacOSX
http://code.google.com/p/v8/issues/detail?id=61
Test does not even exist anymore. No idea what this refers to.
--
You received this message beca
Revision: 14095
Author: yang...@chromium.org
Date: Thu Mar 28 06:52:31 2013
Log: Always allocate symbols in old space.
Keys are expected to be tenured. This now not only includes internalized
strings, but also symbols.
R=rossb...@chromium.org
BUG=
Review URL: https://chromiumcoderevi
Committed patchset #2 manually as r14095 (presubmit successful).
https://chromiumcodereview.appspot.com/13158002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/13140009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM with comments
https://codereview.chromium.org/13158002/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/13158002/diff/1/src/heap.cc#newcode5434
src/heap.cc:5434: AllocationSpace space = OLD_POINTER_SPACE;
Nit: just inline this now trivial definition.
https://co
Revision: 14094
Author: dslo...@chromium.org
Date: Thu Mar 28 06:30:16 2013
Log: Canonicalize NaNs on store to Fast(Float|Double) arrays
Also treat holey NaN coming from external float/double arrays correctly
BUG=2596
Review URL: https://codereview.chromium.org/12918028
http://code.go
Committed patchset #3 manually as r14094 (presubmit successful).
https://codereview.chromium.org/12918028/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: rossberg,
Description:
Always allocate symbols in old space.
Keys are expected to be tenured. This now not only includes internalized
strings, but also symbols.
R=rossb...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/13158002/
SVN Base: https://v8
https://codereview.chromium.org/13140009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Revision: 14093
Author: dslo...@chromium.org
Date: Thu Mar 28 06:24:02 2013
Log: Win32 build fix
TBR=rossb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/13140009
http://code.google.com/p/v8/source/detail?r=14093
Modified:
/branches/bleeding_edge/src/runtime.cc
=
Reviewers: rossberg,
Message:
Committed patchset #1 manually as r14093 (presubmit successful).
Description:
Win32 build fix
TBR=rossb...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=14093
Please review this at https://codereview.chromium.org/13140009/
SVN Base:
Revision: 14092
Author: dslo...@chromium.org
Date: Thu Mar 28 06:07:41 2013
Log: Release buold fix
TBR=rossb...@chromium.org
http://code.google.com/p/v8/source/detail?r=14092
Modified:
/branches/bleeding_edge/src/runtime.cc
===
--- /branches/bleed
On 2013/03/28 12:30:39, danno wrote:
lgtm with a nit
https://codereview.chromium.org/12918028/diff/7002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/12918028/diff/7002/src/hydrogen-instructions.cc#newcode3060
src/hydrogen-instruct
Revision: 14091
Author: dslo...@chromium.org
Date: Thu Mar 28 05:50:18 2013
Log: First steps towards implementing ArrayBuffer &co in V8
BUG=
Review URL: https://codereview.chromium.org/13064003
http://code.google.com/p/v8/source/detail?r=14091
Added:
/branches/bleeding_edge/src/type
Committed patchset #8 manually as r14091 (presubmit successful).
https://codereview.chromium.org/13064003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14090
Author: dslo...@chromium.org
Date: Thu Mar 28 05:43:19 2013
Log: Replace ICStub for array.length with hydrogen stub
BUG=
Review URL: https://codereview.chromium.org/1276
http://code.google.com/p/v8/source/detail?r=14090
Modified:
/branches/bleeding_edge/src/arm/c
Committed patchset #11 manually as r14090 (presubmit successful).
https://codereview.chromium.org/1276/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM
On 2013/03/28 12:28:22, Dmitry Lomov (chromium) wrote:
As I said, OOM is not catchable by JavaScript, so I'd prefer a catch-able
exception here. and adding a new exception kind seems overkill. RangeError
feels
like the most adequate exception here. We can also raise this at TC-39
Yeah,
lgtm with a nit
https://codereview.chromium.org/12918028/diff/7002/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/12918028/diff/7002/src/hydrogen-instructions.cc#newcode3060
src/hydrogen-instructions.cc:3060: return load_elements_kind ==
PTAL (added forgotten tests)
https://codereview.chromium.org/13064003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
On 2013/03/28 09:45:15, rossberg wrote:
https://codereview.chromium.org/13064003/diff/11001/test/mjsunit/harmony/typedarrays.js
File test/mjsunit/harmony/typedarrays.js (right):
https://codereview.chromium.org/13064003/diff/11001/test/mjsunit/harmony/typedarrays.js#newcode40
test/mjsunit/har
LGTM with comments
https://codereview.chromium.org/13071006/diff/1/src/array.js
File src/array.js (right):
https://codereview.chromium.org/13071006/diff/1/src/array.js#newcode44
src/array.js:44: if (length == 2 && intervals[0] == -1) {
Nit: using === might be more accurate (and marginally more
PTAL
https://codereview.chromium.org/12918028/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/12918028/diff/1/src/hydrogen-instructions.cc#newcode3053
src/hydrogen-instructions.cc:3053: return
HLoadKeyed::cast(value())->can_load_hol
1 - 100 of 120 matches
Mail list logo
