Comment #4 on issue 1064 by oblivisc...@gmail.com: JavaScript errors are
not user friendly.
http://code.google.com/p/v8/issues/detail?id=1064
Also line number of onerror method is no meaning because I can not get
exact source code at that time.
--
You received this message because this pr
Comment #3 on issue 1064 by oblivisc...@gmail.com: JavaScript errors are
not user friendly.
http://code.google.com/p/v8/issues/detail?id=1064
And line number of onerror method is no meaning because I can not get exact
source code at that time.
--
You received this message because this pro
Comment #18 on issue 2355 by jkumme...@chromium.org: Implement generators
http://code.google.com/p/v8/issues/detail?id=2355
@17: Feature requests generally don't have ETAs other than "when it's done".
You can bet that none of the ES6 features will be enabled by default before
the ES6 spec has
Ignore my comments about kChangesInobjectFields, that should work
automatically.
However, calling BuildStoreMap is important to get the kChangesMaps flag.
https://codereview.chromium.org/12880017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
https://codereview.chromium.org/12880017/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/12880017/diff/1/src/hydrogen.cc#newcode9912
src/hydrogen.cc:9912: boilerplate_object, Representation::Tagged()));
Maybe I missed this, but where is the boilerplate copied
Revision: 14120
Author: pal...@homejinni.com
Date: Tue Apr 2 13:30:23 2013
Log: MIPS: Deoptimizer support for hydrogen stubs that accept a
variable number of arguments.
Port r14111 (29157ad7)
BUG=
Review URL: https://codereview.chromium.org/13461013
http://code.google.com/p/v8/so
Committed manually as r14120 (presubmit successful).
https://codereview.chromium.org/13461013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Reviewers: rossberg,
Message:
The upside here is that looking up the observers for an object no longer
requires a hash lookup. The downside is that observed objects now have a
different map than non-observed ones. I'm interested in hearing what y'all
think
about this tradeoff.
Description:
Us
lgtm
https://codereview.chromium.org/12697011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Comment #13 on issue 2590 by trev.nor...@gmail.com: Implement ES6
TypedArrays
http://code.google.com/p/v8/issues/detail?id=2590
I've updated https://code.google.com/p/chromium/issues/detail?id=225775#c2
with a brief analysis on why those operations are so slow. My conclusion is
that the m
Comment #12 on issue 2590 by k...@chromium.org: Implement ES6 TypedArrays
http://code.google.com/p/v8/issues/detail?id=2590
FYI: another microbenchmark from the MapsGL team highlighting poor
performance of DataView has been attached to tracking bug
https://code.google.com/p/chromium/issues/d
lgtm
https://codereview.chromium.org/13461013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/13461013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Paul Lind, mvstanton,
Description:
MIPS: Deoptimizer support for hydrogen stubs that accept a variable number
of
arguments.
Port r14111 (29157ad7)
BUG=
Please review this at https://codereview.chromium.org/13461013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Comment #17 on issue 2355 by brunomil...@gmail.com: Implement generators
http://code.google.com/p/v8/issues/detail?id=2355
Any ETA on this one :)?
--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification
Comment #7 on issue 2543 by rodolph@gmail.com: ARMv5 Illegal
Instruction vpush even with vfp2=off and vfp3=off
http://code.google.com/p/v8/issues/detail?id=2543
A patch addressing build issues will be available in the coming days.
--
You received this message because this project is conf
Revision: 14119
Author: rodolph.perfe...@gmail.com
Date: Tue Apr 2 11:25:09 2013
Log: Fix bugs in softfloat code path.
BUG=none
TEST=none
Review URL: https://chromiumcodereview.appspot.com/13008018
http://code.google.com/p/v8/source/detail?r=14119
Modified:
/branches/bleeding_edge/
On 2013/04/02 18:09:50, Michael Starzinger wrote:
Committed patchset #1 manually as r14118 (presubmit successful).
lgtm.
https://codereview.chromium.org/13465010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you
Comment #11 on issue 2590 by k...@chromium.org: Implement ES6 TypedArrays
http://code.google.com/p/v8/issues/detail?id=2590
FYI: a microbenchmark from the MapsGL team highlighting the slow allocation
performance of typed arrays (surely due to the call out through the DOM
bindings) has been a
Revision: 14118
Author: mstarzin...@chromium.org
Date: Tue Apr 2 11:09:40 2013
Log: Fix another set of build failures on Windows since r14116.
TBR=yang...@chromium.org
Review URL: https://codereview.chromium.org/13465010
http://code.google.com/p/v8/source/detail?r=14118
Modified:
/
Committed patchset #1 manually as r14118 (presubmit successful).
https://codereview.chromium.org/13465010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Yang,
Description:
Fix another set of build failures on Windows since r14116.
TBR=yang...@chromium.org
Please review this at https://codereview.chromium.org/13465010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/preparser.h
Index: src/pr
On 2013/04/02 18:00:21, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/13464010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
Revision: 14117
Author: mstarzin...@chromium.org
Date: Tue Apr 2 11:00:50 2013
Log: Fix build failure on Windows since r14116.
TBR=yang...@chromium.org
Review URL: https://codereview.chromium.org/13464010
http://code.google.com/p/v8/source/detail?r=14117
Modified:
/branches/bleedin
Committed patchset #1 manually as r14117 (presubmit successful).
https://codereview.chromium.org/13464010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Yang,
Description:
Fix build failure on Windows since r14116.
TBR=yang...@chromium.org
Please review this at https://codereview.chromium.org/13464010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ast.h
M src/d8.h
M src/d8.cc
Index: s
Comment #2 on issue 2273 by yang...@chromium.org: Built-in functions should
not coerce 'this' value in a strict mode function
http://code.google.com/p/v8/issues/detail?id=2273
Proposed fix: https://codereview.chromium.org/13473009/
--
You received this message because this project is configu
Reviewers: rossberg,
Description:
Do not implicitly convert non-object receivers for strict mode functions.
This was still the case for Array.prototype.* builtin functions.
R=rossb...@chromium.org
BUG=v8:2273
Please review this at https://chromiumcodereview.appspot.com/13473009/
SVN Base: ht
Updates:
Cc: verwa...@chromium.org jkumme...@chromium.org
Comment #10 on issue 2593 by u...@chromium.org: Object.create and
Object.hasOwnProperty optimizations
http://code.google.com/p/v8/issues/detail?id=2593
Got stable repro by disabling randomization of hashes and bisected to
https
Revision: 14116
Author: mstarzin...@chromium.org
Date: Tue Apr 2 10:34:59 2013
Log: Add parser support for generators.
This patchset begins by adding support for "yield", which is unlike other
tokens
in JS. In a generator, whether strict or classic, it is a syntactic keyword.
In cl
Comment #9 on issue 2593 by k...@yapp.us: Object.create and
Object.hasOwnProperty optimizations
http://code.google.com/p/v8/issues/detail?id=2593
Our app at yapp.us consistently failed with this problem, I tried launching
/Applications/Google\ Chrome\ Canary.app/Contents/MacOS/Google\ Chrom
Comment #8 on issue 2593 by stefan.p...@gmail.com: Object.create and
Object.hasOwnProperty optimizations
http://code.google.com/p/v8/issues/detail?id=2593
Ulan, I can confirm that this is the kind of error mentioned in #2.
--
You received this message because this project is configured to se
Comment #7 on issue 2593 by u...@chromium.org: Object.create and
Object.hasOwnProperty optimizations
http://code.google.com/p/v8/issues/detail?id=2593
I checked out ember.js at 93ccb694a26 [Move Ember.typeOf to metal] and
followed the instructions in readme.md
When running all tests with
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 2273 by yang...@chromium.org: Built-in functions should
not coerce 'this' value in a strict mode function
http://code.google.com/p/v8/issues/detail?id=2273
Quote from Annex C of ECMA-262 edition 5.1
If
Updates:
Labels: Harmony
Comment #1 on issue 2214 by yang...@chromium.org: Implement Harmony
iterators
http://code.google.com/p/v8/issues/detail?id=2214
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notif
Comment #10 on issue 1595 by erights: Error#message should be enumerable
http://code.google.com/p/v8/issues/detail?id=1595
Nevermind. I see that we do conform to the ES5 spec and that this bug was
asking us to do otherwise. My mistake.
--
You received this message because this project is con
Comment #9 on issue 1595 by erights: Error#message should be enumerable
http://code.google.com/p/v8/issues/detail?id=1595
Why do we intend to violate this part of the ES5 spec?
--
You received this message because this project is configured to send all
issue notifications to this address.
Yo
Revision: 14115
Author: dslo...@chromium.org
Date: Tue Apr 2 08:03:04 2013
Log: Fix Win64 build
BUG=
Review URL: https://codereview.chromium.org/13463004
http://code.google.com/p/v8/source/detail?r=14115
Modified:
/branches/bleeding_edge/src/runtime.cc
Committed patchset #1 manually as r14115 (presubmit successful).
https://codereview.chromium.org/13463004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM.
https://codereview.chromium.org/13463004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Updates:
Status: WorkingAsIntended
Comment #8 on issue 1595 by yang...@chromium.org: Error#message should be
enumerable
http://code.google.com/p/v8/issues/detail?id=1595
(No comment was entered for this change.)
--
You received this message because this project is configured to send
Comment #5 on issue 1289 by yang...@chromium.org: Overwriting toString
member of objects can lead to NULL pointers when object is used as argument
to a method
http://code.google.com/p/v8/issues/detail?id=1289
This seems to be a problem with exception not being caught by the embedder.
Does
Updates:
Status: Invalid
Comment #4 on issue 1066 by yang...@chromium.org: JSON special characters
are not escaped in JsonAstBuilder.
http://code.google.com/p/v8/issues/detail?id=1066
There is no JSON AST builder anymore.
--
You received this message because this project is configure
Updates:
Status: Invalid
Comment #2 on issue 1188 by yang...@chromium.org: Crashes in
v8::internal::StringReplaceRegExpWithEmptyString
http://code.google.com/p/v8/issues/detail?id=1188
(No comment was entered for this change.)
--
You received this message because this project is conf
Updates:
Status: Invalid
Comment #1 on issue 1089 by yang...@chromium.org: Problems build macos 10.5
http://code.google.com/p/v8/issues/detail?id=1089
Scons is no longer supported, GYP has this already.
--
You received this message because this project is configured to send all
issue
Updates:
Status: PendingFurtherInfo
Comment #7 on issue 836 by yang...@chromium.org: armv5tel compilation error
in macro-assembler-arm.cc "For thumb inter-working we require an
architecture which supports blx"
http://code.google.com/p/v8/issues/detail?id=836
probably not relevant an
Reviewers: Michael Starzinger, rossberg,
Description:
Fix Win64 build
BUG=
Please review this at https://codereview.chromium.org/13463004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/runtime.cc
Index: src/runtime.cc
diff --git a/src/runtime.cc b/
Updates:
Status: Fixed
Comment #1 on issue 996 by yang...@chromium.org: PrintF format string
mismatches in deoptimizer.cc
http://code.google.com/p/v8/issues/detail?id=996
Argument 3 has been changed to %d long ago.
--
You received this message because this project is configured to se
Updates:
Status: Invalid
Comment #3 on issue 1843 by yang...@chromium.org: does not compile on
freebsd 8.2 amd64
http://code.google.com/p/v8/issues/detail?id=1843
Scons is no longer supported, and last time somebody submitted a
FreeBSD-related change they did no complain about build
Updates:
Cc: stefa...@chromium.org
Comment #4 on issue 2599 by stefa...@chromium.org: Implement "use asm"
http://code.google.com/p/v8/issues/detail?id=2599
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notif
Updates:
Status: Invalid
Comment #3 on issue 1867 by yang...@chromium.org: Preparser library fails
to link when builded as shared library on Windows
http://code.google.com/p/v8/issues/detail?id=1867
Scons is no longer supported.
--
You received this message because this project is co
Updates:
Cc: stefa...@chromium.org
Comment #8 on issue 2424 by stefa...@chromium.org: Revert double additions
to truncating int32 additions where appropriate
http://code.google.com/p/v8/issues/detail?id=2424
(No comment was entered for this change.)
--
You received this message becau
Propagated the type, in course of that found a bug and fixed it, test
included
https://codereview.chromium.org/12491023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-de
Updates:
Status: Invalid
Comment #1 on issue 1778 by yang...@chromium.org: Can't get V8 to compile
on Fedora15
http://code.google.com/p/v8/issues/detail?id=1778
Scons is no longer supported. Please file a new bug if the GYP-based build
fails.
--
You received this message because t
Updates:
Status: Invalid
Comment #4 on issue 1747 by yang...@chromium.org: V8 shared build failed on
vs2008
http://code.google.com/p/v8/issues/detail?id=1747
scons is no longer supported.
--
You received this message because this project is configured to send all
issue notification
Updates:
Status: Invalid
Comment #2 on issue 1941 by yang...@chromium.org: Scons build fails bz2 not
found
http://code.google.com/p/v8/issues/detail?id=1941
Scons is no longer supported.
--
You received this message because this project is configured to send all
issue notifications
Updates:
Status: Invalid
Comment #10 on issue 631 by yang...@chromium.org: Build failure on Mac OS X
10.6.2
http://code.google.com/p/v8/issues/detail?id=631
doesn't seem to be relevant anymore.
--
You received this message because this project is configured to send all
issue notifi
Updates:
Status: Invalid
Comment #1 on issue 993 by yang...@chromium.org: SCons profiling-related
flags needs to be revised
http://code.google.com/p/v8/issues/detail?id=993
Scons is no longer supported.
--
You received this message because this project is configured to send all
iss
Updates:
Status: PendingFurtherInfo
Comment #1 on issue 952 by yang...@chromium.org: V8 does not properly
compile to shared lib on FreeBSD
http://code.google.com/p/v8/issues/detail?id=952
still an issue?
--
You received this message because this project is configured to send all
is
Comment #1 on issue 908 by yang...@chromium.org: Replace constant splitting
with constant cookies.
http://code.google.com/p/v8/issues/detail?id=908
The macro-assembly instructions SafePush, SafeMove and SafeSet exist on
ia32 and x64, but are rarely used. They don't exist at all on ARM and M
Updates:
Status: Fixed
Comment #1 on issue 906 by yang...@chromium.org: Runtime_GetCFrames should
be removed from the debugger
http://code.google.com/p/v8/issues/detail?id=906
(No comment was entered for this change.)
--
You received this message because this project is configured to
Updates:
Status: Fixed
Comment #2 on issue 902 by yang...@chromium.org: Compilation error on
OpenBSD box 4.7
http://code.google.com/p/v8/issues/detail?id=902
Scons is no longer supported, and given that we have accepted multiple
other patches for OpenBSD, this probably has been solv
Updates:
Status: Fixed
Comment #4 on issue 898 by yang...@chromium.org: error C2220: warning
treated as error - no object file generated
http://code.google.com/p/v8/issues/detail?id=898
Aside from the fact that Scons is no longer supported, this probably has
been solved long ago.
Updates:
Status: Fixed
Cc: -lrn%chro...@gtempaccount.com
Comment #7 on issue 865 by yang...@chromium.org: ES5: typeof for host
objects implementing [[Call]] should be function
http://code.google.com/p/v8/issues/detail?id=865
Seems to be working correctly by now.
--
You receiv
Updates:
Labels: Type-FeatureRequest
Comment #2 on issue 883 by yang...@chromium.org: Allow V8::DateParser usage
from C++ code
http://code.google.com/p/v8/issues/detail?id=883
(No comment was entered for this change.)
--
You received this message because this project is configured to
Updates:
Status: Fixed
Comment #4 on issue 888 by yang...@chromium.org: Debugger agent wait for
connection flag does not work
http://code.google.com/p/v8/issues/detail?id=888
Has been fixed.
--
You received this message because this project is configured to send all
issue notificat
Updates:
Status: WorkingAsIntended
Comment #1 on issue 724 by yang...@chromium.org: Debugger: scriptCollected
event always returns with "running=true"
http://code.google.com/p/v8/issues/detail?id=724
When a script is being collected, the VM is running by definition.
--
You received t
Revision: 14114
Author: dslo...@chromium.org
Date: Tue Apr 2 06:29:26 2013
Log: Fix CopyBytes to accept size_t for num_bytes
BUG=
Review URL: https://codereview.chromium.org/13470008
http://code.google.com/p/v8/source/detail?r=14114
Modified:
/branches/bleeding_edge/src/deoptimizer
Committed patchset #1 manually as r14114 (presubmit successful).
https://codereview.chromium.org/13470008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Updates:
Status: Fixed
Comment #8 on issue 706 by yang...@chromium.org: GYP/Xcode/Chromium build
support for x86_64 v8
http://code.google.com/p/v8/issues/detail?id=706
Seems to be fixed.
--
You received this message because this project is configured to send all
issue notifications
Updates:
Status: PendingFurtherInfo
Comment #2 on issue 872 by yang...@chromium.org: Port custom Math.floor IC
to other architectures
http://code.google.com/p/v8/issues/detail?id=872
In any case, this becomes unnecessary as soon as Crankshaft kicks in.
--
You received this message be
Updates:
Owner: ---
Cc: da...@chromium.org
Comment #1 on issue 872 by yang...@chromium.org: Port custom Math.floor IC
to other architectures
http://code.google.com/p/v8/issues/detail?id=872
I guess this is no longer necessary once we have
CallStubCompiler::CompileMath*Call r
LGTM with one comments.
https://codereview.chromium.org/13470008/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/13470008/diff/1/src/heap.cc#newcode3887
src/heap.cc:3887: CopyBytes(new_addr, old_addr,
static_cast(relocation_offset));
The "relocation_offset" is alrea
Updates:
Owner: yang...@chromium.org
Comment #2 on issue 581 by yang...@chromium.org: Concatenating arrays with
total length over 2^32-1 doesn't work correctly.
http://code.google.com/p/v8/issues/detail?id=581
Proposed fix: https://chromiumcodereview.appspot.com/13465008
--
You rece
Reviewers: Michael Starzinger,
Description:
Fix CopyBytes to accept size_t for num_bytes
BUG=
Please review this at https://codereview.chromium.org/13470008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/deoptimizer.cc
M src/heap.cc
M src/objects
Reviewers: Toon Verwaest,
Description:
Fix Array.prototype.concat when exceeding array size limit.
R=verwa...@chromium.org
BUG=v8:581
Please review this at https://chromiumcodereview.appspot.com/13465008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src
Revision: 14113
Author: u...@chromium.org
Date: Tue Apr 2 05:36:16 2013
Log: Cleanup: Rename Simulator::watched_stops to match style guide.
BUG=none
Review URL: https://chromiumcodereview.appspot.com/13469002
Patch from Hans Wennborg .
http://code.google.com/p/v8/source/detail?r=1411
Committed patchset #1 manually as r14113 (presubmit successful).
https://chromiumcodereview.appspot.com/13469002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
I've got some style nits mostly. I still haven't penetrated the actual copy
routine or the assembler for the NEON instructions.
https://codereview.chromium.org/12920009/diff/17001/src/arm/assembler-arm.cc
File src/arm/assembler-arm.cc (right):
https://codereview.chromium.org/12920009/diff/17001
For additional context:
http://build.chromium.org/p/client.v8/builders/V8%20GC%20Stress%20-%201/builds/241/steps/Check/logs/stdio
https://chromiumcodereview.appspot.com/13042005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messa
This test times out on the GC stress builders. It seems to run much longer
than
before. Is there any way we can get the same test coverage without
increasing
the runtime so heavily?
https://chromiumcodereview.appspot.com/13042005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://grou
LGTM, I will land it for you.
https://codereview.chromium.org/13469002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Revision: 14112
Author: u...@chromium.org
Date: Tue Apr 2 05:20:50 2013
Log: ARM: Log an error if /proc/cpuinfo cannot be opened
This will make it easier to see if the current CPU feature detection
starts breaking because of process sandboxing.
BUG=v8:2597
Review URL: https://chromi
Committed patchset #1 manually as r14112 (presubmit successful).
https://chromiumcodereview.appspot.com/13465003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Added tests for all modes, the test that uncovered a bug is commented out
for
now. Will be interesting to run this on all architecures
https://codereview.chromium.org/13470002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Are we sufficiently past the branch point to land this now?
https://codereview.chromium.org/12790011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
Revision: 14111
Author: mvstan...@chromium.org
Date: Tue Apr 2 04:28:01 2013
Log: Deoptimizer support for hydrogen stubs that accept a variable
number of arguments.
BUG=
Review URL: https://codereview.chromium.org/12490013
http://code.google.com/p/v8/source/detail?r=14111
Modifie
Committed patchset #6 manually as r14111 (presubmit successful).
https://codereview.chromium.org/12490013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Thanks, I addressed those points. Much appreciated!
--Michael
https://codereview.chromium.org/12490013/diff/16001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/12490013/diff/16001/src/code-stubs-hydrogen.cc#newcode143
src/code-stubs-hydrogen
(tracked by https://code.google.com/p/v8/issues/detail?id=2607)
On 2013/04/02 11:21:03, Dmitry Lomov (chromium) wrote:
Indeed, the following prints "true\false" (only for sNaN):
var bytes = new Uint32Array([1, 0x7FF0]);
var doubles = new Float64Array(bytes.buffer);
function f() {
pri
Status: Accepted
Owner: dslo...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2607 by dslo...@chromium.org: isNaN works incorrectly for sNaN
http://code.google.com/p/v8/issues/detail?id=2607
IC for isNaN works incorrectly for signaling NaN.
The following code:
var bytes = new Uint32A
Indeed, the following prints "true\false" (only for sNaN):
var bytes = new Uint32Array([1, 0x7FF0]);
var doubles = new Float64Array(bytes.buffer);
function f() {
print(isNaN(doubles[0]));
}
f(); f()
On 2013/04/02 11:12:08, Dmitry Lomov (chromium) wrote:
We do not crash because we someh
We do not crash because we somehow mask it:
Breakpoint 2, v8::Shell::Main (argc=2, argv=0xd104) at ../src/d8.cc:1937
1937if (options.stress_opt || options.stress_deopt) {
(gdb) p $mxcsr
$1 = [ IM DM ZM OM UM PM ]
(gdb)
Good point about all other execution regimes, will add tests
On
https://codereview.chromium.org/12491023/diff/5001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/12491023/diff/5001/src/hydrogen-instructions.h#newcode5171
src/hydrogen-instructions.h:5171:
result->SetGVNFlag(kDependsOnArrayLengths);
Clear
lgtm with comments
https://codereview.chromium.org/12490013/diff/16001/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/12490013/diff/16001/src/code-stubs-hydrogen.cc#newcode143
src/code-stubs-hydrogen.cc:143: HInstruction* stack_pop_count =
st
So, why don't we crash? Unless we mask the signal, I would assume we would.
Also, please add variants that test the runtime (first time called), ICs (2+
times), and Crankshaft (force the code to be optimized with
%OptimizeFunctionOnNextCall
https://codereview.chromium.org/13470002/
--
--
v8-dev
Revision: 14110
Author: u...@chromium.org
Date: Tue Apr 2 02:50:43 2013
Log: Tagging version 3.17.6.2
http://code.google.com/p/v8/source/detail?r=14110
Added:
/tags/3.17.6.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received thi
Revision: 14109
Author: u...@chromium.org
Date: Tue Apr 2 02:50:22 2013
Log: Merged r14074 into 3.17 branch.
ARM: fix dictionary negative lookup.
BUG=171975
R=da...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/13461003
http://code.google.com/p/v8/source/detail?r=
Committed patchset #1 manually as r14109 (presubmit successful).
https://chromiumcodereview.appspot.com/13461003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Reviewers: rossberg, danno,
Message:
Add test that makes sure that s/qNaNs do not crash V8
Description:
Test behavior of qNaN and sNaN
BUG=
Please review this at https://codereview.chromium.org/13470002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
A + t
1 - 100 of 121 matches
Mail list logo
