lgtm
https://codereview.chromium.org/14107004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Sven Panne,
Description:
Fix build failures on Win64 since r14215.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/14075006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/global-handles.cc
M src/heap-snapsho
lgtm
https://codereview.chromium.org/14075006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r14221 (presubmit successful).
https://codereview.chromium.org/14075006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14221
Author: mstarzin...@chromium.org
Date: Thu Apr 11 01:08:09 2013
Log: Fix build failures on Win64 since r14215.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/14075006
http://code.google.com/p/v8/source/detail?r=14221
Modified:
/branches/bleeding
Reviewers: Michael Starzinger,
Message:
ptal
Description:
Add tests for GlobalHandles::IterateObjectGroups.
BUG=none
Please review this at https://codereview.chromium.org/13952005/
SVN Base: git://github.com/v8/v8.git@master
Affected files:
M src/global-handles.h
M test/cctest/cctest.gy
Comment #4 on issue 2621 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile is failing or Arm simulator
http://code.google.com/p/v8/issues/detail?id=2621
To make the test pass we need to implement ProfilerSignalHandler in
src/platform-linux.cc for if defined(USE_SIMULATOR) ca
Comment #5 on issue 2621 by svenpa...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile is failing or Arm simulator
http://code.google.com/p/v8/issues/detail?id=2621
Just a quick notice: Not surprisingly, the test fails on the MIPS
simulator, too. I'll disable it there, too.
--
You
Looks like I've got a fix for simulators so this change should not be
needed:
https://codereview.chromium.org/13845014/
https://codereview.chromium.org/13995003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you a
Comment #6 on issue 2621 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile is failing or Arm simulator
http://code.google.com/p/v8/issues/detail?id=2621
No need to disable it there, I've just sent a fix for review:
https://codereview.chromium.org/13845014/
--
You received
Reviewers: ,
Message:
Committed patchset #1 manually as r14222 (presubmit successful).
Description:
Temporarily disable CollectCpuProfile on MIPS, it doesn't work in the
simulator
TBR=yu...@chromium.org
BUG=v8:2621
Committed: http://code.google.com/p/v8/source/detail?r=14222
Please review
Revision: 14222
Author: svenpa...@chromium.org
Date: Thu Apr 11 02:25:43 2013
Log: Temporarily disable CollectCpuProfile on MIPS, it doesn't work in
the simulator
TBR=yu...@chromium.org
BUG=v8:2621
Review URL: https://codereview.chromium.org/14009005
http://code.google.com/p/v8/sou
LGTM
https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h
File src/stub-cache.h (right):
https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h#newcode166
src/stub-cache.h:166: Handle ComputeStoreTransition(Handle
name,
Nit: space between function declaration
Addressed comments
https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h
File src/stub-cache.h (right):
https://chromiumcodereview.appspot.com/14063006/diff/1/src/stub-cache.h#newcode166
src/stub-cache.h:166: Handle ComputeStoreTransition(Handle
name,
On 2013/04/11 09:34:04, u
Committed patchset #2 manually as r14223 (presubmit successful).
https://chromiumcodereview.appspot.com/14063006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 14223
Author: verwa...@chromium.org
Date: Thu Apr 11 02:48:03 2013
Log: Disentangle field from transition stores.
Review URL: https://chromiumcodereview.appspot.com/14063006
http://code.google.com/p/v8/source/detail?r=14223
Modified:
/branches/bleeding_edge/src/arm/stub-cac
Revision: 14224
Author: yang...@chromium.org
Date: Thu Apr 11 02:53:00 2013
Log: Fix JSON.stringify's slow path wrt sliced strings.
R=mvstan...@chromium.org
BUG=229923
Review URL: https://chromiumcodereview.appspot.com/14107004
http://code.google.com/p/v8/source/detail?r=14224
Added:
Reviewers: mvstanton,
Message:
Committed patchset #2 manually as r14224 (presubmit successful).
Description:
Fix JSON.stringify's slow path wrt sliced strings.
R=mvstan...@chromium.org
BUG=229923
Committed: https://code.google.com/p/v8/source/detail?r=14224
Please review this at https://chro
Status: New
Owner:
New issue 2623 by nkosty...@chromium.org: Crash
v8::internal::Runtime_QuoteJSONString
http://code.google.com/p/v8/issues/detail?id=2623
Chrome: 28.0.1473.0
I've see this reproduced on Chrome OS and I see a lot crash reports on
crash server:
https://crash.corp.goog
On 2013/04/09 16:27:52, Yang wrote:
On 2013/04/02 06:44:21, Zheng Liu wrote:
> X64 already had it because I accidentally included it in a previous code
review
> http://code.google.com/p/v8/source/detail?r=13289
> (oops, sorry!)
>
> This change is that for some processor, sequence like:
> divsd XM
On 2013/04/11 10:38:30, Zheng Liu wrote:
On 2013/04/09 16:27:52, Yang wrote:
> On 2013/04/02 06:44:21, Zheng Liu wrote:
> > X64 already had it because I accidentally included it in a previous
code
> review
> > http://code.google.com/p/v8/source/detail?r=13289
> > (oops, sorry!)
> >
> > This ch
Updates:
Status: Duplicate
Mergedinto: chromium:229923
Comment #2 on issue 2623 by yang...@chromium.org: Crash
v8::internal::Runtime_QuoteJSONString
http://code.google.com/p/v8/issues/detail?id=2623
(No comment was entered for this change.)
--
You received this message becaus
Revision: 14225
Author: yang...@chromium.org
Date: Thu Apr 11 03:48:46 2013
Log: IA32: Small assembler tweak for divsd->mulsd sequence
Review URL: https://chromiumcodereview.appspot.com/13447003
Patch from Zheng Liu .
http://code.google.com/p/v8/source/detail?r=14225
Modified:
/bran
Committed patchset #2 manually as r14225.
https://chromiumcodereview.appspot.com/13447003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Reviewers: mvstanton,
Description:
Merged r14224 into trunk branch.
Fix JSON.stringify's slow path wrt sliced strings.
BUG=229923
R=mvstan...@chromium.org
Please review this at https://chromiumcodereview.appspot.com/14170004/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files:
M
lgtm
https://chromiumcodereview.appspot.com/14170004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Reviewers: danno,
Message:
PTAL. This simplifies/unifies CheckMaps, which is a prerequisite for generic
monomorphic/polymorphic ICs. Performance should be neutral after Michael's
work
to avoid transitions.
Description:
Always require exact maps.
Please review this at https://codereview.chro
Reviewers: rossberg,
Message:
This is a cleanup to prevent us from searching for
"$Object.constructor.prototype" assignments in global code for half a day
again.
:)
Description:
Move global code for builtins into setup functions.
R=rossb...@chromium.org
Please review this at https://codere
Reviewers: Michael Starzinger,
Message:
Fixing a minor issue where Object.defineProperty() incorrectly
updates .length
on Array objects.
Description:
Fix detection of indexed properties in Object.defineProperty()
When defining an indexed property on an Array object, the object's
length prope
Reviewers: Yang,
Message:
Fix so that you can run presubmit.py in Windows.
presubmit.py tried to execute cpplint.py directly, but in Windows it's the
shell
that connects that to the python binary so the execution (subprocess.Popen)
needs to be told how to find python. An alternative would be t
https://codereview.chromium.org/14125004/diff/1013/src/proxy.js
File src/proxy.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/proxy.js#newcode198
src/proxy.js:198: function SetUpProxy() {
I don't like separating this from the method definitions, I think it
should go before th
Committed patchset #1 manually as r14226 (presubmit successful).
https://chromiumcodereview.appspot.com/14170004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 14226
Author: yang...@chromium.org
Date: Thu Apr 11 05:00:57 2013
Log: Merged r14224 into trunk branch.
Fix JSON.stringify's slow path wrt sliced strings.
BUG=229923
R=mvstan...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/14170004
http://code.google.com/
Revision: 14227
Author: yang...@chromium.org
Date: Thu Apr 11 05:01:17 2013
Log: Tagging version 3.17.16.2
http://code.google.com/p/v8/source/detail?r=14227
Added:
/tags/3.17.16.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receive
https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
Actually, I think this should be split up into SetUpSet, SetUp
LGTM. I didn't get any presubmit errors. I will land after Jakob's review.
On my machine this CL seems to be performance neutral on Octane and
Sunspider:
benchmark:score | tot-oct | %
===+==+=
Comments addressed.
https://codereview.chromium.org/14125004/diff/1013/src/collection.js
File src/collection.js (right):
https://codereview.chromium.org/14125004/diff/1013/src/collection.js#newcode249
src/collection.js:249: function SetUpCollections() {
On 2013/04/11 12:02:29, rossberg wrote:
Reviewers: Michael Starzinger,
Description:
Fix set-up of intrinsic's 'constructor' properties
Looks so easy...
R=mstarzin...@chromium.org
BUG=229445
Please review this at https://codereview.chromium.org/13880007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
lgtm
https://codereview.chromium.org/14125004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #4 manually as r14228 (presubmit successful).
https://codereview.chromium.org/14125004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14228
Author: mstarzin...@chromium.org
Date: Thu Apr 11 05:15:25 2013
Log: Move global code for builtins into setup functions.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/14125004
http://code.google.com/p/v8/source/detail?r=14228
Modified:
/branches
LGTM. But it will need to be rebased.
https://codereview.chromium.org/13880007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group a
On 2013/04/11 11:48:10, bratell wrote:
Fix so that you can run presubmit.py in Windows.
presubmit.py tried to execute cpplint.py directly, but in Windows it's the
shell
that connects that to the python binary so the execution
(subprocess.Popen)
needs to be told how to find python. An alternat
Committed patchset #1 manually as r14229 (presubmit successful).
https://codereview.chromium.org/13880007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14229
Author: rossb...@chromium.org
Date: Thu Apr 11 05:27:55 2013
Log: Fix set-up of intrinsic's 'constructor' properties
Looks so easy...
R=mstarzin...@chromium.org
BUG=229445
Review URL: https://codereview.chromium.org/13880007
http://code.google.com/p/v8/source/detail?r
Reviewers: Yang,
Description:
Separate Math Lithium operations.
This makes the logic in the Hydrogen->Lithium translation much clearer,
avoids a
hand-written dispatch and even opened up opportunities for simpler register
constraints for some operations/platforms.
Doing the same for the Hydro
lgtm
https://codereview.chromium.org/13818012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #3 manually as r14230 (presubmit successful).
https://chromiumcodereview.appspot.com/13818012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Revision: 14230
Author: u...@chromium.org
Date: Thu Apr 11 05:40:37 2013
Log: Accurate function prototypes for native calls from ARM simulator.
Native method invocation from the arm/simulator-arm.cc previously made
non-portable assumptions about calling conventions. This was okay for 3
Committed patchset #1 manually as r14231 (presubmit successful).
https://codereview.chromium.org/14070005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14231
Author: jkumme...@chromium.org
Date: Thu Apr 11 05:41:31 2013
Log: Run style checks also when uploading.
The right moment for fixing style errors is when working on the CL, not when
committing it. And this makes non-committers bump into this check too when
uploading cha
Reviewers: danno, mvstanton,
Description:
Added non observable side effects scope and removed unnecessary calls to
AddSimulate.
BUG=
Please review this at https://codereview.chromium.org/14174002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/code-st
https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp
File src/third_party/vtune/v8vtune.gyp (right):
https://codereview.chromium.org/11574031/diff/127001/src/third_party/vtune/v8vtune.gyp#newcode34
src/third_party/vtune/v8vtune.gyp:34: 'dependencies': [
nit: ple
lgtm with comments
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h#newcode871
src/hydrogen.h:871: in_no_side_effects_scope_(0) {}
no_side_effects_scope_count_?
https://codereview.chromium
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h
File src/hydrogen.h (right):
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.h#newcode871
src/hydrogen.h:871: in_no_side_effects_scope_(0) {}
On 2013/04/11 12:55:51, danno wrote:
no_side_effects_scope_count_?
Done.
h
On 2013/04/11 12:29:32, Sven Panne wrote:
LGTM.
https://codereview.chromium.org/13841003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
LGTM with a comment. Thanks this is really helpful stuff too.
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/14174002/diff/1/src/hydrogen.cc#newcode900
src/hydrogen.cc:900: ASSERT(in_no_side_effects_scope_ == 0);
thi
Reviewers: rossberg,
Description:
Move creation of collection prototypes into JavaScript.
R=rossb...@chromium.org
Please review this at https://codereview.chromium.org/14165004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/bootstrapper.cc
M src/col
Committed patchset #2 manually as r14232 (presubmit successful).
https://codereview.chromium.org/14174002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14232
Author: hpa...@chromium.org
Date: Thu Apr 11 06:07:37 2013
Log: Added non observable side effects scope and removed unnecessary
calls to AddSimulate.
BUG=
Review URL: https://codereview.chromium.org/14174002
http://code.google.com/p/v8/source/detail?r=14232
Modifie
LGTM with comment
https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js#newcode257
test/mjsunit/harmony/collections.js:257: // Test
Comment #3 on issue 2606 by mstarzin...@chromium.org: Unable to change
writability and configurability of __proto__
http://code.google.com/p/v8/issues/detail?id=2606
If it is critical that this bug doesn't make it into Beta I would encourage
you to file a beta-blocker Chromium issue and loo
Committed patchset #7 manually as r14233 (presubmit successful).
https://codereview.chromium.org/13841003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Taking this to the list now that it's passing the tests.
https://codereview.chromium.org/13468016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
Addressed comments. Landing.
https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js
File test/mjsunit/harmony/collections.js (right):
https://codereview.chromium.org/14165004/diff/1/test/mjsunit/harmony/collections.js#newcode257
test/mjsunit/harmony/collections.js:2
Committed patchset #1 manually as r14234 (presubmit successful).
https://codereview.chromium.org/14165004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14234
Author: mstarzin...@chromium.org
Date: Thu Apr 11 06:31:51 2013
Log: Move creation of collection prototypes into JavaScript.
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/14165004
http://code.google.com/p/v8/source/detail?r=14234
Modified:
/bran
Sven: Can you please review the changes in v8.h?
https://codereview.chromium.org/11574031/diff/127001/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/11574031/diff/127001/src/api.cc#newcode1853
src/api.cc:1853:
nit: two empty lines here
https://codereview.chromium.org/11574
On 2013/04/11 10:49:54, Yang wrote:
Committed patchset #2 manually as r14225.
This patch seems to have regressed this small benchmark:
function benchmark() {
var fp = 1.5;
for (var i = 0; i < 1; i++) {
fp = -(fp * 2.1) / 2.1;
}
}
var elapsed = 0;
var start = new Date();
for (var
Reviewers: ulan,
Message:
PTAL
Depends on https://codereview.chromium.org/13923003/
Description:
Initial work towards polymorphic store ICs.
- Make a common superclass for Load and Store stub compiler.
- Split StoreField and StoreTransition into handler and IC.
Please review this at https://c
LGTM (v8.h and api.cc part)
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop re
If you address the remaining comments, I will land this for you.
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 14235
Author: yu...@chromium.org
Date: Thu Apr 11 07:22:04 2013
Log: Fix cctest/test-cpu-profiler/CollectCpuProfile test on Arm and
MIPS simulators
Signal handler on simulator now retrieve registers from the simulator not
from the host machine.
BUG=v8:2621
Review URL:
Reviewers: mvstanton,
Description:
Remove relocation lock from optimizing compiler.
R=mvstan...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/14029010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/code-stubs-hydrogen.c
This doesn't seem to work on on Linux workstation for some reason.
Paths... The code used subprocess.Popen's "search through the path" for the
first argument. Now when cpplint.py is the second argument the code needs to
locate it by hand (would have been a oneliner in Python 3.3 apparently).
Updates:
Status: Fixed
Comment #7 on issue 2621 by yu...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile is failing or Arm simulator
http://code.google.com/p/v8/issues/detail?id=2621
Fix landed http://code.google.com/p/v8/source/detail?r=14235
--
You received this message be
Revision: 14236
Author: rossb...@chromium.org
Date: Thu Apr 11 09:28:19 2013
Log: * src/generator.js: Add methods and intialization for generator
meta-objects.
* src/contexts.h:
* src/bootstrapper.cc (InitializeExperimentalGlobal): Make generator
meta-objects, and store maps for c
Reviewers: Sven Panne, Michael Starzinger,
Message:
This is the next step after the GC API changes for object groups.
mstarzinger, svenpanne: wdyt?
Previously, the implicit references are connected to an object, and for that
WebKit needed to keep track of a "representative object" for each grou
With 13818012 landed, this is (hopefully) my last change. It should enable
the
Native Client build targets and have no effect on other builds. Once this
has
landed, I will need help from Michael to set up NaCl builders for the V8
waterfall.
https://codereview.chromium.org/13841011/
--
--
v8-
Comment #4 on issue 2606 by erights: Unable to change writability and
configurability of __proto__
http://code.google.com/p/v8/issues/detail?id=2606
See https://code.google.com/p/chromium/issues/detail?id=230407
--
You received this message because this project is configured to send all
is
Reviewers: ulan, Hannes Payer,
Description:
Support full deoptimization during GC via stack guard.
This adds support to the stack guard to trigger a full deoptimization of
all optimized code when the GC kicks into high promotion mode. Global
pretenuring decisions in optimized code can then be ba
Reviewers: Hannes Payer,
Description:
Reduce verbosity of hydrogen instructions with OSEs.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/14091004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-instructions.cc
I
Reviewers: Paul Lind, Toon Verwaest, danno, kisg, kilvadyb,
Description:
MIPS: Disentangle field from transition stores.
Port r14223 (c6460cd6)
BUG=
Please review this at https://codereview.chromium.org/14005007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
Reviewers: Paul Lind, rossberg, danno, kisg, kilvadyb,
Description:
MIPS: * src/generator.js: Add methods and intialization for generator
meta-objects.
Port r14236 (7d56d7c5)
Original commit message:
* src/generator.js: Add methods and intialization for generator
meta-objects.
* src/context
LGTM. The inline comment does not need a change for today.
https://codereview.chromium.org/14005007/diff/1/src/mips/stub-cache-mips.cc
File src/mips/stub-cache-mips.cc (right):
https://codereview.chromium.org/14005007/diff/1/src/mips/stub-cache-mips.cc#newcode578
src/mips/stub-cache-mips.cc:578
lgtm
https://codereview.chromium.org/13988003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed manually as r14237 (presubmit successful).
https://codereview.chromium.org/14005007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Revision: 14237
Author: pal...@homejinni.com
Date: Thu Apr 11 16:22:08 2013
Log: MIPS: Disentangle field from transition stores.
Port r14223 (c6460cd6)
BUG=
Review URL: https://codereview.chromium.org/14005007
http://code.google.com/p/v8/source/detail?r=14237
Modified:
/branches/bl
Committed manually as r14238 (presubmit successful).
https://codereview.chromium.org/13988003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Revision: 14238
Author: pal...@homejinni.com
Date: Thu Apr 11 16:25:08 2013
Log: MIPS: * src/generator.js: Add methods and intialization for
generator meta-objects.
Port r14236 (7d56d7c5)
Original commit message:
* src/generator.js: Add methods and intialization for generator
met
Reviewers: Paul Lind, ulan, danno, kisg, kilvadyb,
Description:
MIPS: Accurate function prototypes for native calls from ARM simulator.
Port r14230 (76c22097)
Original commit message:
Native method invocation from the arm/simulator-arm.cc previously made
non-portable assumptions about calling c
lgtm
https://codereview.chromium.org/13989008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 14239
Author: plin...@gmail.com
Date: Thu Apr 11 19:01:52 2013
Log: MIPS: Accurate function prototypes for native calls from ARM
simulator.
Port r14230 (76c22097)
Original commit message:
Native method invocation from the arm/simulator-arm.cc previously made
non-portable
I mistakenly committed patchset #1 as r14239.
Sorry, Ákos, can you please upload your change in patchset 2 as a separate
CL.
https://codereview.chromium.org/13989008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message becaus
Hello, Daniel & Jakob.
Thanks a lot for your correction.
I updated the code. Please help to review it and land it if it's ok.
Thanks.
https://codereview.chromium.org/11574031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
LGTM!
https://codereview.chromium.org/14091004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
LGTM
https://codereview.chromium.org/14173007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
97 matches
Mail list logo
