fyi:
https://codereview.chromium.org/18516012/diff/19001/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/18516012/diff/19001/build/toolchain.gypi#newcode513
build/toolchain.gypi:513: 'GCC_STRICT_ALIASING': 'YES',
Note that strict aliasing is only done at
Reviewers: Hannes Payer,
Message:
gcc (version 4.2.1 (Based on Apple Inc. build 5658) (LLVM build
2336.11.00)) on
Mac 10.7.5 complains:
../src/mark-compact.h:991:16: error: private field 'chunk_' is not used
[-Werror,-Wunused-private-field]
MemoryChunk* chunk_;
when make [x64|ia32].r
Comment #2 on issue 2767 by je...@edagames.com: gcc 4.8
aggressive-loop-optimizations error in
test/cctest/test-macro-assembler-x64.cc
http://code.google.com/p/v8/issues/detail?id=2767
These are only workarounds, while waiting for the right fix :
http://anonscm.debian.org/gitweb/?p=collab-m
Reviewers: Michael Starzinger,
Description:
ES6: Implement WeakSet
WeakSets work similar to ordinary Sets but the value (which must be an
object) is held weakly.
This is implemented using a WeakMap internally.
This is available under --harmony-collections
BUG=v8:2785
Please review this at ht
Status: Accepted
Owner: a...@chromium.org
CC: rossb...@chromium.org
Labels: Type-Bug Priority-Medium Harmony
New issue 2785 by a...@chromium.org: ES6: Implement WeakSet
http://code.google.com/p/v8/issues/detail?id=2785
WeakSet is in the latest draft at
http://wiki.ecmascript.org/doku.php?id=ha
sgtm
https://codereview.chromium.org/19267023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
On 2013/07/16 19:31:20, Toon Verwaest wrote:
Can we have a test for this?
We already have tests for weaks, and some of them are failing with this
patch.
So I'm gonna update them.
https://codereview.chromium.org/19267023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.googl
Reviewers: danno, ulan, Vyacheslav Egorov,
Description:
Do not call reinterpret_cast when converting from NULL.
If NULL is a nullptr (such as on my FreeBSD system), it is not possible to
use reinterpret_cast to convert it to another pointer. Plus, just using NULL
directly achieves the same effec
Thanks Michael, PTAL.
--Michael
https://codereview.chromium.org/18173013/diff/11001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/18173013/diff/11001/src/heap.cc#newcode1789
src/heap.cc:1789: allocation_sites_list(),
On 2013/07/16 18:14:46, Michael Starzinger wrote:
nit
Can we have a test for this?
https://codereview.chromium.org/19267023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
lgtm
https://codereview.chromium.org/19256020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/19256020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/19267023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/19397002/diff/1/src/heap-snapshot-generator.cc#newcode898
src/heap-snapshot-generator.cc:898: Code* code =
Code::cast(Code::GetObjectFromEnt
Comment #1 on issue 2767 by tittiatc...@gmail.com: gcc 4.8
aggressive-loop-optimizations error in
test/cctest/test-macro-assembler-x64.cc
http://code.google.com/p/v8/issues/detail?id=2767
Would it be possible to indicated what needs to be changed ? openSUSE is
switching to gcc 4.8 at the
First round of comments. On a high level I don't particularly like the
hackery
with the virtual object visitor for the serializer. But I have to think
about
this some more to come up with a cleaner alternative. That's why a left a
first
round of comments about the other parts of this change.
Committed manually as r15695 (presubmit successful).
https://codereview.chromium.org/19381004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Reviewers: loislo, Yury Semikhatsky, Toon Verwaest,
Message:
Ilya, Toon, could you please take a look.
Description:
Do not report unessential weak references in heap snapshot.
Please review this at https://codereview.chromium.org/19267023/
SVN Base: https://v8.googlecode.com/svn/branches/bleed
Reviewers: loislo, Yury Semikhatsky, Toon Verwaest,
Message:
Ilya, Toon, could you please take a look.
Description:
Report initial_map field of JSFunction in heap snapshot.
Please review this at https://codereview.chromium.org/19256020/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding
On 2013/07/16 13:28:54, mvstanton wrote:
My previous comment is wrong in the specifics: we are careful in the code
to
ensure that an array with 0 capacity is always the empty fixed array, it
doesn't
matter if our map points to smi, double, or tagged elements kind. So the
code
will work as i
Revision: 15695
Author: pal...@homejinni.com
Date: Tue Jul 16 11:02:43 2013
Log: MIPS: Fix bug introduced by r15640.
This bug causes segfault in the octane benchmark,
because the deoptimization entries do not fit in the
deopt table.
This change increases the table entry size.
TEST=oct
lgtm
https://codereview.chromium.org/19397002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Yury Semikhatsky, loislo, Toon Verwaest,
Message:
Ilya, Toon, could you please take a look.
Description:
Provide named links to code objects in heap snapshot.
Please review this at https://codereview.chromium.org/19397002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_ed
LGTM.
https://codereview.chromium.org/19381004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Committed patchset #1 manually as r15694 (presubmit successful).
https://codereview.chromium.org/19368002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15694
Author: a...@chromium.org
Date: Tue Jul 16 10:47:35 2013
Log: Add missing links from GlobalPropertyCell to dependent_code
It produced orphan DependentCode nodes because links were not created
explicitly in ExtractPropertyCellReferences and IndexedReferencesExtractor
Reviewers: Paul Lind, kisg, danno, kilvadyb,
Message:
PTAL.
Description:
MIPS: Fix bug introduced by r15640.
This bug causes segfault in the octane benchmark,
because the deoptimization entries do not fit in the
deopt table.
This change increases the table entry size.
TEST=octane benchmark
BU
Reviewers: ulan,
Description:
Remove unnecessary hole NaN check.
BUG=none
TEST=none
Please review this at https://codereview.chromium.org/19374004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.h
M src/hydrogen.cc
Index: src/hydrogen.cc
d
PTAL
https://codereview.chromium.org/1932/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
with a reviewer this time.
https://codereview.chromium.org/19379003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rec
Reviewers: ,
Message:
Give a slight speed up on A15.
Description:
ARM: Improve code aging sequence.
The code aging sequence contains a load which is unecessary for optimised
function. This has been replaced by a nop.
BUG=none
TEST=none
Please review this at https://codereview.chromium.org/19
lgtm
https://codereview.chromium.org/19368002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM (if comments are addressed).
https://codereview.chromium.org/19383002/diff/1/src/flag-definitions.h
File src/flag-definitions.h (right):
https://codereview.chromium.org/19383002/diff/1/src/flag-definitions.h#newcode256
src/flag-definitions.h:256: DEFINE_bool(trace_deopt_stress, false,
"tra
Reviewers: Michael Starzinger, Dmitry Lomov (chromium), Hannes Payer,
Message:
Hi guys,
I worked with Michael the most on this, but it heavily uses code from
Dmitry,
and Hannes is the primary "customer." Maybe full review from Michael, drive
by
from Dmitry and driveby++ from Hannes?
I didn'
https://codereview.chromium.org/19383002/diff/1/src/ia32/lithium-codegen-ia32.cc
File src/ia32/lithium-codegen-ia32.cc (right):
https://codereview.chromium.org/19383002/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode935
src/ia32/lithium-codegen-ia32.cc:935: ExternalReference count =
ExternalRefe
Reviewers: Michael Starzinger, danno,
Message:
PTAL
Description:
Make deoptimization stress count global.
Store the deopt stress counter per isolate instead of per shared function
info.
The old field is removed.
Enable output of the counter value with a new flag.
Please review this at htt
On 2013/07/16 13:26:25, rossberg wrote:
Looks good, but should go behind a flag for now. I suggest
--harmony-literals.
I think --harmony-numeric-literal is better since there are changes to other
literals in ES6 (object literals for example)
https://codereview.chromium.org/1932/diff/1/sr
Revision: 15693
Author: verwa...@chromium.org
Date: Tue Jul 16 07:01:46 2013
Log: Try to remove invalidated stubs before falling back to checking
the constant state.
BUG=chromium:260585
R=hpa...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/19267019
http://code.go
Committed patchset #2 manually as r15693 (presubmit successful).
https://chromiumcodereview.appspot.com/19267019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
LGTM, one nit
https://chromiumcodereview.appspot.com/19267019/diff/1/src/ic.cc
File src/ic.cc (right):
https://chromiumcodereview.appspot.com/19267019/diff/1/src/ic.cc#newcode235
src/ic.cc:235: // the map cannot be deprecated and the stub invalidated.
The comment is now really disconnected from
Updates:
Owner: a...@chromium.org
Cc: -a...@chromium.org rossb...@chromium.org
Comment #2 on issue 2783 by a...@chromium.org: Implement
BinaryIntegerLiteral and OctalIntegerLiteral
http://code.google.com/p/v8/issues/detail?id=2783
Note that the spec draft grammar is wrong:
ht
Comment #1 on issue 2784 by sqrts...@gmail.com:
String::AsciiValue::AsciiValue fails ASSERT
http://code.google.com/p/v8/issues/detail?id=2784
https://code.google.com/p/v8/source/detail?r=14533
--
You received this message because this project is configured to send all
issue notifications t
My previous comment is wrong in the specifics: we are careful in the code to
ensure that an array with 0 capacity is always the empty fixed array, it
doesn't
matter if our map points to smi, double, or tagged elements kind. So the
code
will work as is, but its more direct and obvious to instea
Looks good, but should go behind a flag for now. I suggest
--harmony-literals.
https://codereview.chromium.org/1932/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/1932/diff/1/src/runtime.cc#newcode5958
src/runtime.cc:5958: StringToDouble(isolate->un
Reviewers: Toon Verwaest,
Description:
Removed unused HOptimizedGraphBuilder::BuildCallSetter method.
Please review this at https://codereview.chromium.org/19235011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen.h
M src/hydrogen.cc
Index: s
Reviewers: danno,
Message:
PTAL
Description:
Try to remove invalidated stubs before falling back to checking the constant
state.
BUG=chromium:260585
Please review this at https://chromiumcodereview.appspot.com/19267019/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Also, I think the regression test is in order.
https://codereview.chromium.org/19289009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
Hi Benedikt, I think there might be one issue, have a look.
thanks,
-Michael
https://codereview.chromium.org/19289009/diff/1/src/code-stubs-hydrogen.cc
File src/code-stubs-hydrogen.cc (right):
https://codereview.chromium.org/19289009/diff/1/src/code-stubs-hydrogen.cc#newcode553
src/code-stubs-h
Status: New
Owner:
New issue 2784 by sqrts...@gmail.com: String::AsciiValue::AsciiValue fails
ASSERT
http://code.google.com/p/v8/issues/detail?id=2784
String::AsciiValue::AsciiValue (defined in api.cc, ~line 7100) takes in a
object and converts it to an ASCII value. However, it would s
Revision: 15692
Author: a...@chromium.org
Date: Tue Jul 16 05:48:34 2013
Log: Make TransitionArray internal references originate from TA in
heap snapshot.
TransitionArray references were added to the TA's map object instead
of TA itself.
R=verwa...@chromium.org, yu...@chromium.org
Committed patchset #3 manually as r15692 (presubmit successful).
https://codereview.chromium.org/19265002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/19368002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: loislo, Yury Semikhatsky, danno,
Message:
It produced orphan DependentCode nodes because links were not created
explicitly
in ExtractPropertyCellReferences and IndexedReferencesExtractor was
disabled for
ProperyCells.
Description:
Add missing links from GlobalPropertyCell to depe
lgtm
https://codereview.chromium.org/19265002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 15691
Author: hpa...@chromium.org
Date: Tue Jul 16 05:14:16 2013
Log: Added mark bit cell iterator.
BUG=
R=mstarzin...@chromium.org, tit...@chromium.org
Review URL: https://codereview.chromium.org/19182002
http://code.google.com/p/v8/source/detail?r=15691
Modified:
/branch
Committed patchset #2 manually as r15691 (presubmit successful).
https://codereview.chromium.org/19182002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/19182002/diff/1/src/mark-compact.cc#newcode1942
src/mark-compact.cc:1942: Address cell_base;
On 2013/07/15 13:42:06, titzer wrote:
Can be in the loop, no? And al
Reviewers: danno, mvstanton, Dmitry Lomov (chromium),
Description:
Fix invalid array length check in TransitionElementsKindStub.
The stub used to check the length of the JS array to see if
there's a need to duplicate the elements backing store. This
way it will not duplicate the elements array w
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (left):
https://codereview.chromium.org/18503006/diff/8001/src/hydrogen-instructions.h#oldcode5802
src/hydrogen-instructions.h:5802: = Representation::Tagged())
nit: start the first pa
Cool, lgtm.
https://codereview.chromium.org/19265002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
Addressed comments. PTAL.
https://codereview.chromium.org/18774002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/18774002/diff/1/src/objects.cc#newcode716
src/objects.cc:716: Handle dictionary =
handle(object->property_dictionary());
On 2013/07/12 12:37:34,
On 2013/07/15 21:15:10, Toon Verwaest wrote:
I definitely support the content of this change; but be aware that
IsTransitionArray just implies IsFixedArray. This may very well bite you.
Is
there a better way to achieve the same?
Toon, thanks for review! PTAL.
https://codereview.chromium.org
Committed patchset #1 manually as r15690 (presubmit successful).
https://codereview.chromium.org/19299004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15690
Author: machenb...@chromium.org
Date: Tue Jul 16 04:21:48 2013
Log: Extend expectations for slow test cases on the V8/blink trunk
builder.
The second test has an existing expectation that is extended.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium
lgtm
https://codereview.chromium.org/19299004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Jakob,
Message:
PTAL
Description:
Extend expectations for slow test cases on the V8/blink trunk builder.
Please review this at https://codereview.chromium.org/19299004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M tools/blink_tests/TestExpectat
Revision: 15689
Author: bmeu...@chromium.org
Date: Tue Jul 16 03:31:24 2013
Log: Tagging version 3.20.5.3
http://code.google.com/p/v8/source/detail?r=15689
Added:
/tags/3.20.5.3
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
Revision: 15688
Author: bmeu...@chromium.org
Date: Tue Jul 16 03:31:11 2013
Log: Merged r15679 into trunk branch.
Disable compiled_transitions by default.
R=jkumme...@chromium.org
BUG=chromium:260585
Review URL: https://codereview.chromium.org/19266011
http://code.google.com/p/v8/sou
Committed patchset #1 manually as r15688 (presubmit successful).
https://codereview.chromium.org/19266011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/19266011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Yury Semikhatsky, alph,
Description:
HeapProfiler: unretained array in
test-heap-profiler/ManyLocalsInSharedContext
BUG=none
TEST=test-heap-profiler/ManyLocalsInSharedContext
Please review this at https://codereview.chromium.org/19360002/
SVN Base: https://v8.googlecode.com/svn/b
Reviewers: Jakob,
Description:
Merged r15679 into trunk branch.
Disable compiled_transitions by default.
R=jkumme...@chromium.org
BUG=chromium:260585
Please review this at https://codereview.chromium.org/19266011/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected files:
M src/flag-def
Updates:
Status: Fixed
Comment #1 on issue 2782 by yu...@chromium.org:
test-cpu-profiler/FunctionApplySample flakes on Arm simulator
http://code.google.com/p/v8/issues/detail?id=2782
Fixed landed: https://code.google.com/p/v8/source/detail?r=15687
--
You received this message because
Revision: 15687
Author: yu...@chromium.org
Date: Tue Jul 16 02:34:09 2013
Log: Fix cctest/test-cpu-profiler/FunctionApplySample fakiness on ARM
simulator
For STM and LDM instuctions with writeback update base register only after
all registers have been saved/loaded. This guarantee
Committed patchset #1 manually as r15687 (presubmit successful).
https://codereview.chromium.org/19243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/07/15 14:21:56, rossberg wrote:
https://codereview.chromium.org/18926004/diff/1/src/typing.cc
File src/typing.cc (right):
https://codereview.chromium.org/18926004/diff/1/src/typing.cc#newcode181
src/typing.cc:181: local_effects.Alt(clause_effects);
On 2013/07/15 13:30:42, titzer wrote:
On 2013/07/15 17:30:16, Yury Semikhatsky wrote:
LGTM.
https://codereview.chromium.org/19243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Committed patchset #3 manually as r15686 (presubmit successful).
https://codereview.chromium.org/19290008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15686
Author: hpa...@chromium.org
Date: Tue Jul 16 01:54:41 2013
Log: Added tracing information to the case when allocation folding
cannot be performed.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/19290008
http://code.google.com/p/v8/source
LGTM.
https://codereview.chromium.org/19290008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc#newcode3185
src/hydrogen-instructions.cc:3185: return;
On 2013/07/16 08:44:36, Michael Starzinger w
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/19290008/diff/1/src/hydrogen-instructions.cc#newcode3185
src/hydrogen-instructions.cc:3185: return;
nit: This early return should fit into one l
Reviewers: Michael Starzinger,
Description:
Added tracing information to the case when allocation folding cannot be
performed.
BUG=
Please review this at https://codereview.chromium.org/19290008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-i
Revision: 15685
Author: mstarzin...@chromium.org
Date: Tue Jul 16 01:37:49 2013
Log: Minor cleanup of GVN state pushing.
R=hpa...@chromium.org, hpa...@google.com
Review URL: https://codereview.chromium.org/19235010
http://code.google.com/p/v8/source/detail?r=15685
Modified:
/branche
Committed patchset #1 manually as r15685 (presubmit successful).
https://codereview.chromium.org/19235010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm
https://codereview.chromium.org/19235010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/19235010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Hannes Payer,
Description:
Minor cleanup of GVN state pushing.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/19235010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/hydrogen-gvn.cc
Index: src/hydrogen-gvn.cc
d
Committed patchset #1 manually as r15684 (presubmit successful).
https://codereview.chromium.org/19210002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 15684
Author: dslo...@chromium.org
Date: Tue Jul 16 01:11:30 2013
Log: Throw if first argument to TypedArray.set is a number.
Further refinement to semantics that I have missed in previous change.
Both Blink and Firefox are permissive with arguments to .set method.
However, w
Reviewers: Jakob, danno,
Message:
For X32, the return address size is 8 bytes (2 * kPointerSize). With this
abstraction in the macro assembler, for X32, we only need add kPointerSize
in
the disp field to access the right argument in the stack. This abstraction
could eliminate all the __a anno
Revision: 15683
Author: bmeu...@chromium.org
Date: Tue Jul 16 00:07:04 2013
Log: Use BitVector instead of handcrafted SparseSet.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/19272011
http://code.google.com/p/v8/source/detail?r=15683
Modified:
/branches/bleedi
lgtm
https://codereview.chromium.org/19272011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r15683 (presubmit successful).
https://codereview.chromium.org/19272011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
94 matches
Mail list logo
