Committed patchset #1 manually as r16211.
https://codereview.chromium.org/23190002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16211
Author: bmeu...@chromium.org
Date: Mon Aug 19 07:25:25 2013 UTC
Log: Drop broken and unnecessary RequiredInputRepresentation() in
HMathFloorOfDiv.
R=tit...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16190
Review URL: https://codereview.chr
Reviewers: Sven Panne, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Add FINAL and OVERRIDE macros for C++11 final/override.
We also use new the constant naming scheme for Yield::Kind values to avoid
clash with the FINAL macro.
Please review this at https://codereview.chromium.org/230980
Ok, first round of comments.
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683
src/arm/code-stubs-arm.cc:683: // with exponent because Bia
I don't want to introduce any more #ifdef's here. I think we should simply
import the base/time stuff from chromium instead, which already covers what
we
need.
https://codereview.chromium.org/23271003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Danno, here's the FINAL/OVERRIDE CL just mentioned.
https://codereview.chromium.org/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fro
On 2013/08/19 07:58:09, Benedikt Meurer wrote:
I don't want to introduce any more #ifdef's here. I think we should simply
import the base/time stuff from chromium instead, which already covers
what we
need.
Ho do you see it? Pulling src/base as a third-party library sounds like an
overkill.
On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> I don't want to introduce any more #ifdef's here. I think we should
simply
> import the base/time stuff from chromium instead, which already covers
what
we
> need.
Ho do you see it? Pulling s
On 2013/08/19 08:35:51, Benedikt Meurer wrote:
On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
> On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> > I don't want to introduce any more #ifdef's here. I think we should
simply
> > import the base/time stuff from chromium instead, which already cov
On 2013/08/19 08:50:25, Yury Semikhatsky wrote:
On 2013/08/19 08:35:51, Benedikt Meurer wrote:
> On 2013/08/19 08:32:40, Yury Semikhatsky wrote:
> > On 2013/08/19 07:58:09, Benedikt Meurer wrote:
> > > I don't want to introduce any more #ifdef's here. I think we should
simply
> > > import the ba
Updates:
Status: Fixed
Comment #1 on issue 2812 by dslo...@chromium.org: V8 roll to 3.20.9.1 broke
Google Maps
http://code.google.com/p/v8/issues/detail?id=2812
Fixed in subsequent rolls
--
You received this message because this project is configured to send all
issue notifications
Comment #3 on issue 2801 by dslo...@chromium.org:
ArrayBuffer::Allocator::Free doesn't pass the ArrayBuffer size
http://code.google.com/p/v8/issues/detail?id=2801
Sorry this has fallen through the cracks, this fucntionality is already
independently implmeneted
--
You received this message
This has already been implemented in similiar way. Closing this one
https://codereview.chromium.org/19959006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Updates:
Status: Fixed
Comment #4 on issue 2801 by dslo...@chromium.org:
ArrayBuffer::Allocator::Free doesn't pass the ArrayBuffer size
http://code.google.com/p/v8/issues/detail?id=2801
(No comment was entered for this change.)
--
You received this message because this project is con
On 2013/08/19 08:11:18, Benedikt Meurer wrote:
Danno, here's the FINAL/OVERRIDE CL just mentioned.
The FINAL/OVERRIDE macros expand to empty unless C++11 is enabled
explicitly,
i.e. using CXXFLAGS=-std=c++11 with clang++ or a recent GCC.
https://codereview.chromium.org/23098004/
--
--
v8-d
Reviewers: danno, Sven Panne,
Message:
This is a first baby-step towards platform cleanup, instead of trying to do
everything at once as I did last time. The OS_* defines are mostly
compatible
with what Chromium uses, which will allow for easier sharing/copying w/o
breakage on our side (i.e. t
Updates:
Status: Assigned
Owner: yang...@chromium.org
Comment #1 on issue 2848 by yang...@chromium.org: cctest:
TestJSONStringifyAccessCheck() fails with empty handle in r16208
http://code.google.com/p/v8/issues/detail?id=2848
(No comment was entered for this change.)
--
You
Reviewers: Jakob,
Description:
Prepare push to trunk. Now working on version 3.21.1.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/22856005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M ChangeLog
M src/version.cc
lgtm
https://codereview.chromium.org/22856005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r16212 (presubmit successful).
https://codereview.chromium.org/22856005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16212
Author: rossb...@chromium.org
Date: Mon Aug 19 09:34:18 2013 UTC
Log: Prepare push to trunk. Now working on version 3.21.1.
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/22856005
http://code.google.com/p/v8/source/detail?r=16212
Modified:
Revision: 16213
Author: rossb...@chromium.org
Date: Mon Aug 19 09:36:44 2013 UTC
Log: Version 3.21.0
Fixed GC-related crasher (Chromium issue 274438)
Reverted making Intl non-enumerable.
Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detai
Revision: 16214
Author: rossb...@chromium.org
Date: Mon Aug 19 09:37:59 2013 UTC
Log: Tagging version 3.21.0
http://code.google.com/p/v8/source/detail?r=16214
Added:
/tags/3.21.0
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received
On 2013/08/16 21:48:47, adamk wrote:
On 2013/08/16 13:51:54, rossberg wrote:
> This looks good so far, but unfortunately, I don't think it's enough to
just
> check GET access. For example, HAS or KEYS might be restricted, while
GET is
> allowed.
>
> I think the accurate semantics would be so
Revision: 16215
Author: mstarzin...@chromium.org
Date: Mon Aug 19 10:55:51 2013 UTC
Log: Clarify side effects of HTransitionElementsKind.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/22796011
http://code.google.com/p/v8/source/detail?r=16215
Modified:
/branche
Committed patchset #1 manually as r16215.
https://codereview.chromium.org/22796011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Jakob,
Description:
Merged r16150, r16174, r16175 into 3.19 branch.
Fix regressions triggered by map invalidation during graph creation.
Fix bug in HPhi::SimplifyConstantInput.
Use Cell instead of PropertyCell in DoCheckFunction (in case of new space
object).
R=jkumme...@chromium.o
lgtm
https://codereview.chromium.org/22984009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Hannes Payer,
Description:
Temporary workaround for GC stress builder.
R=hpa...@chromium.org
TEST=cctest/test-debug/ScriptCollectedEventContext --gc-interval=500
Please review this at https://codereview.chromium.org/22987004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding
lgtm
https://codereview.chromium.org/22987004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM
https://codereview.chromium.org/22987004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 16216
Author: mstarzin...@chromium.org
Date: Mon Aug 19 11:10:08 2013 UTC
Log: Temporary workaround for GC stress builder.
R=hpa...@chromium.org, hpa...@google.com
TEST=cctest/test-debug/ScriptCollectedEventContext --gc-interval=500
Review URL: https://codereview.chromium.or
Committed patchset #1 manually as r16216.
https://codereview.chromium.org/22987004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16217
Author: yang...@chromium.org
Date: Mon Aug 19 11:18:02 2013 UTC
Log: Merged r16150, r16174, r16175 into 3.19 branch.
Fix regressions triggered by map invalidation during graph creation.
Fix bug in HPhi::SimplifyConstantInput.
Use Cell instead of PropertyCell in DoChec
Committed patchset #1 manually as r16217 (presubmit successful).
https://codereview.chromium.org/22984009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Status: Assigned
Owner: bmeu...@chromium.org
CC: paul.l...@imgtec.com, da...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 2851 by bmeu...@chromium.org: Tricky bug in ARM Allocate()
http://code.google.com/p/v8/issues/detail?id=2851
There is small bug in ARM Allocate() which is never e
Reviewers: danno, Sven Panne, rossberg,
Message:
PTAL
Description:
ARM: Fix register misuse bug in Allocate().
The bug is triggered if flags contains DOUBLE_ALIGNMENT and the
object_size is not an ARM immediate value. In this case, the code
for DOUBLE_ALIGNMENT uses the scratch2 register, which
Revision: 16218
Author: yang...@chromium.org
Date: Mon Aug 19 11:22:25 2013 UTC
Log: Tagging version 3.19.18.20
http://code.google.com/p/v8/source/detail?r=16218
Added:
/tags/3.19.18.20
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Updates:
Status: Fixed
Comment #2 on issue 2182 by rossb...@chromium.org: Set trap not tripped on
proxies that are subject of with-block
http://code.google.com/p/v8/issues/detail?id=2182
(No comment was entered for this change.)
--
You received this message because this project is co
Reviewers: jochen,
Description:
Prevent empty handle dereference in Runtime_InternalNumberFormat.
R=joc...@chromium.org
BUG=chromium:275467
Please review this at https://codereview.chromium.org/22859025/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/ru
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Remove special case code for generalizing constants to fields.
Please review this at https://chromiumcodereview.appspot.com/22911018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files:
M src/objects-inl.h
M
Reviewers: alph, loislo, Benedikt Meurer, Sven Panne,
Description:
Do not start sampler thread when CpuProfiler is active
Now that CpuProfiler sends does sampling on the profile event processing
thread
there is no need to launch sampler thread. The latter is used only for
--prof
profiler.
Committed patchset #2 manually as r16219.
https://chromiumcodereview.appspot.com/23047002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from t
Revision: 16219
Author: verwa...@chromium.org
Date: Mon Aug 19 12:32:50 2013 UTC
Log: Improve generalization / migration tracing.
R=yang...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/23047002
http://code.google.com/p/v8/source/detail?r=16219
Modified:
/branches/
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):
https://codereview.chromium.org/23129003/diff/11001/src/arm/code-stubs-arm.cc#newcode683
src/arm/code-stubs-arm.cc:683: // with exponent because Bias + 1 = 1024
which is an *ARM*
https://codereview.chromium.org/23098004/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382
src/globals.h:382: #if __cplusplus >= 201103L
Looking at Chrome's base/compiler_specific.h, I think we can use it more
often: MSVC su
LGTM.
Same feelings here -- toolchain.gypi is getting messy, but when it's needed
to
fix the build, what choice do we have?
I'm looking forward to being able to remove this again :-)
https://codereview.chromium.org/23119004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.go
lgtm
https://codereview.chromium.org/23323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
lgtm
https://codereview.chromium.org/22859025/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #1 manually as r16220.
https://codereview.chromium.org/22859025/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16220
Author: mstarzin...@chromium.org
Date: Mon Aug 19 13:03:58 2013 UTC
Log: Prevent empty handle dereference in Runtime_InternalNumberFormat.
R=joc...@chromium.org
BUG=chromium:275467
Review URL: https://codereview.chromium.org/22859025
http://code.google.com/p/v8/source/
LGTM.
https://codereview.chromium.org/23283011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Comment #1 on issue 2849 by anydream...@gmail.com: ArrayBuffer::New cause
CHECK(object->IsJSFunction()) failed
http://code.google.com/p/v8/issues/detail?id=2849
It's my problem because I forgot to set the V8
parameter "--harmony_array_buffer".
So this problem has been solved :D
--
You rec
Committed patchset #1 manually as r16221.
https://codereview.chromium.org/23323002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16221
Author: bmeu...@chromium.org
Date: Mon Aug 19 13:37:57 2013 UTC
Log: ARM: Fix register misuse bug in Allocate().
The bug is triggered if flags contains DOUBLE_ALIGNMENT and the
object_size is not an ARM immediate value. In this case, the code
for DOUBLE_ALIGNMENT uses t
Updates:
Status: Assigned
Comment #3 on issue 2755 by yang...@chromium.org: memory leak in isolate new
http://code.google.com/p/v8/issues/detail?id=2755
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifica
LGTM, but perhaps Jakob might take a look, too...
https://codereview.chromium.org/23283010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
On 2013/08/19 12:44:47, Sven Panne wrote:
https://codereview.chromium.org/23098004/diff/1/src/globals.h
File src/globals.h (right):
https://codereview.chromium.org/23098004/diff/1/src/globals.h#newcode382
src/globals.h:382: #if __cplusplus >= 201103L
Looking at Chrome's base/compiler_specific.
PTAL
https://chromiumcodereview.appspot.com/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
lgtm
https://codereview.chromium.org/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Updates:
Status: Fixed
Comment #1 on issue 2851 by bmeu...@chromium.org: Tricky bug in ARM
Allocate()
http://code.google.com/p/v8/issues/detail?id=2851
Fixed with revision 16221.
--
You received this message because this project is configured to send all
issue notifications to this
Committed patchset #3 manually as r16222.
https://codereview.chromium.org/23098004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16222
Author: bmeu...@chromium.org
Date: Mon Aug 19 14:46:35 2013 UTC
Log: Add FINAL and OVERRIDE macros for C++11 final/override.
We also use new the constant naming scheme for Yield::Kind values to avoid
clash with the FINAL macro.
R=svenpa...@chromium.org
Review URL: htt
Reviewers: Sven Panne, Jakob, danno, Dmitry Lomov (chromium),
Message:
PTAL
Description:
Use FINAL and OVERRIDE in various places, fixing bugs revealed by them.
- Use FINAL and OVERRIDE in objects.
- Use FINAL and OVERRIDE in Ast classes.
- Use FINAL and OVERRIDE in Lithium mips backend.
- Use
Revision: 16223
Author: pal...@homejinni.com
Date: Mon Aug 19 16:02:50 2013 UTC
Log: MIPS: Remove wrong restriction in GenerateDeoptJumpTable.
* This Abort condition does not apply to MIPS, since the
assembler can also emit long Branches automatically, when
it is needed.
TEST=mjsu
Committed manually as r16223.
https://codereview.chromium.org/23020018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
LGTM!
I think we should make the use of FINAL and OVERRIDE mandatory in all new
code
(except additions to public API)
https://codereview.chromium.org/23064017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you ar
Reviewers: verwaest1,
Message:
This solves part of V8 issue 2848. However, running
out/ia32.debug/cctest test-api
crashes with a segfault a few test cases further. I'll address that once I
find
out what causes it.
Description:
Remove access-check-failed callback after test.
BUG=v8:2848
Pl
https://codereview.chromium.org/23190013/diff/1/test/mjsunit/function-names.js
File test/mjsunit/function-names.js (right):
https://codereview.chromium.org/23190013/diff/1/test/mjsunit/function-names.js#newcode138
test/mjsunit/function-names.js:138: print(boundFunction);
Those two print statemen
On 2013/08/16 17:51:01, Peter.Rybin wrote:
Hi Yang,
I'm not fully sure about this feature.
Bound functions are frequently used. However they look not very nice.
Adding them a human-friendly name could help.
Personally I don't see the need. I don't think the spec has anything to say
about
Reviewers: Hannes Payer,
Description:
Fix invalid out-of-bounds store in MacroAssembler::Allocate.
This fixes an out-of-bounds store in inlined allocations when double
alignment and pretenuring into old-data-space have been requested.
R=hpa...@chromium.org
BUG=chromium:263515
Please review thi
LGTM.
I'd appreciate it if MIPS people could double-check the MIPS changes.
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
On 2013/08/19 17:15:59, adamk wrote:
Do you know of any other embedders that use access checks, besides Blink?
I
would be surprised to learn that Node.js makes use of them. Basically I'm
asking: is this a theoretical concern (given that you don't know which
embedders
are out there) or is it c
On 2013/08/19 10:19:59, rossberg wrote:
On 2013/08/16 21:48:47, adamk wrote:
> On 2013/08/16 13:51:54, rossberg wrote:
> > This looks good so far, but unfortunately, I don't think it's enough
to
just
> > check GET access. For example, HAS or KEYS might be restricted, while
GET
is
> > allow
MIPS change LGTM, thanks for doing it! Just FYI, 'hs' is an alias for
'Ugreater_equal', either are fine, 'hs' makes it read a bit more like the
ARM
port.
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
patch set 2 LGTM
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
lgtm
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #2 manually as r16224.
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16224
Author: mstarzin...@chromium.org
Date: Mon Aug 19 17:46:43 2013 UTC
Log: Fix invalid out-of-bounds store in MacroAssembler::Allocate.
This fixes an out-of-bounds store in inlined allocations when double
alignment and pretenuring into old-data-space have been requested.
On 2013/08/19 17:15:59, adamk wrote:
On 2013/08/19 10:19:59, rossberg wrote:
> On 2013/08/16 21:48:47, adamk wrote:
> > On 2013/08/16 13:51:54, rossberg wrote:
> > > This looks good so far, but unfortunately, I don't think it's
enough to
just
> > > check GET access. For example, HAS or KEYS mi
Thanks Michael, sorry I missed that typo on first review, it's good now.
https://codereview.chromium.org/23242006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
Reviewers: Jakob,
Description:
Merged r16224 into trunk branch.
Fix invalid out-of-bounds store in MacroAssembler::Allocate.
R=jkumme...@chromium.org
BUG=chromium:263515
Please review this at https://codereview.chromium.org/22880021/
SVN Base: https://v8.googlecode.com/svn/trunk
Affected fil
lgtm
https://codereview.chromium.org/22880021/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16225
Author: mstarzin...@chromium.org
Date: Mon Aug 19 18:11:56 2013 UTC
Log: Merged r16224 into trunk branch.
Fix invalid out-of-bounds store in MacroAssembler::Allocate.
R=jkumme...@chromium.org
BUG=chromium:263515
Review URL: https://codereview.chromium.org/22880021
htt
Committed patchset #1 manually as r16225 (presubmit successful).
https://codereview.chromium.org/22880021/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16226
Author: mstarzin...@chromium.org
Date: Mon Aug 19 18:12:17 2013 UTC
Log: Tagging version 3.21.0.1
http://code.google.com/p/v8/source/detail?r=16226
Added:
/tags/3.21.0.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Reviewers: ulan, danno,
Description:
ARM: Improve Lithium register constraints.
* Mandate register for input (unless there is only one use.)
* Added macro instructions to use ip register implicitly.
* Updated some Lithium instructions not to corrupt their inputs.
* Reduce reliance on scr
On 2013/08/19 16:20:22, Dmitry Lomov (chromium) wrote:
LGTM!
I think we should make the use of FINAL and OVERRIDE mandatory in all new
code
(except additions to public API)
Hm, looking through the code again, we should probably use V8_FINAL and
V8_OVERRIDE to avoid collisions with other peop
On 2013/08/19 17:51:53, rossberg wrote:
On 2013/08/19 17:15:59, adamk wrote:
> On 2013/08/19 10:19:59, rossberg wrote:
> > On 2013/08/16 21:48:47, adamk wrote:
> > > On 2013/08/16 13:51:54, rossberg wrote:
> > > > This looks good so far, but unfortunately, I don't think it's
enough
to
> just
lgtm, but please wait to land until the tree is no longer throttled
https://chromiumcodereview.appspot.com/22350005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
passing on to svenpanne and bmeurer, since ulan is on vacation for a few
weeks.
https://chromiumcodereview.appspot.com/23156006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Group
On 2013/08/19 17:51:53, rossberg wrote:
There are several browsers and browser-like environments besides Chrome
that
embed either V8 or Blink+V8,
Of the ones you've mentioned, I don't know of any other than Blink that
turn on
access checks. It's a super odd-ball thing to do. Even Blink on
https://chromiumcodereview.appspot.com/22935005/diff/1/src/x64/full-codegen-x64.cc
File src/x64/full-codegen-x64.cc (right):
https://chromiumcodereview.appspot.com/22935005/diff/1/src/x64/full-codegen-x64.cc#newcode4425
src/x64/full-codegen-x64.cc:4425: if (expr->op() == Token::INC) {
I think th
Taking this one over from Michael Stanton, since he is on vacation.
https://codereview.chromium.org/22831010/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/22831010/diff/1/include/v8.h#newcode982
include/v8.h:982: enum CompilationType {
We try not to expose inter
On 2013/08/19 19:42:28, Michael Starzinger wrote:
Would it be possible to add a ScriptMirror.prototype.compiledThroughEval
(or
similar name) predicate to do the job? This predicate could then rely on
the
JavaScript constants that we have defined in macros.py for that purpose.
Also
note that
Comment #2 on issue 2844 by johnjbar...@chromium.org: Move enum
CompilationType from objects.h to include/v8.h to be avaliable for embedders
http://code.google.com/p/v8/issues/detail?id=2844
v8/src/debug-debugger.js is included in
blink's Debug context along with
WebKit/Source/bindings/v8/D
On 2013/08/19 20:40:31, johnjbarton wrote:
On 2013/08/19 19:42:28, Michael Starzinger wrote:
> Would it be possible to add a
ScriptMirror.prototype.compiledThroughEval (or
> similar name) predicate to do the job? This predicate could then rely
on the
> JavaScript constants that we have defin
Updates:
Status: WorkingAsIntended
Comment #3 on issue 2844 by mstarzin...@chromium.org: Move enum
CompilationType from objects.h to include/v8.h to be avaliable for embedders
http://code.google.com/p/v8/issues/detail?id=2844
Cleaner solution was found.
--
You received this message b
Thank you for the next patch, sorry it took so long to respond to it, but
it's
quite a tricky problem how to design a clear API for supporting both 31-
and 32-
bit smis and still keeping a clear, simple division of responsibilities.
In my review, I focused on your changes to the macro assembl
lgtm if you improve the comment as suggested, please wait to land until the
V8
tree is no longer throttled
https://chromiumcodereview.appspot.com/22348005/diff/7001/src/x64/macro-assembler-x64.h
File src/x64/macro-assembler-x64.h (right):
https://chromiumcodereview.appspot.com/22348005/diff/7
1 - 100 of 110 matches
Mail list logo
