On 2013/09/05 16:01:51, oliv wrote:
hey, ptal
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc
File src/x64/lithium-codegen-x64.cc (right):
https://codereview.chromium.org/23938003/diff/3001/src/x64/lithium-codegen-x64.cc#newcode4712
src/x64/lithium-codege
Reviewers: Michael Starzinger,
Message:
ptal
this is in no way a hack!
Description:
add context save for GenerateFastApiCall
R=mstarzin...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/23461039/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
LGTM (if comment in bootstrapper.cc is addressed).
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode2410
src/bootstrapper.cc:2410: // using the per-isolate rando
Having the string content appear as name seems valuable. How about setting a
certain limit so that we stringify only strings with lengths below that
limit?
That way, whether to show string content would not depend on the string
type.
https://codereview.chromium.org/23460027/
--
--
v8-dev ma
Reviewers: alph, Yury Semikhatsky, Yang,
Message:
On 2013/09/10 08:47:56, Yang wrote:
Having the string content appear as name seems valuable. How about
setting a
certain limit so that we stringify only strings with lengths below that
limit?
That way, whether to show string content would not
https://codereview.chromium.org/23609020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Sven Panne,
Description:
restore persistent dtor
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23581010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -1 lines):
M include/v8.h
M test/cctest/test-api.cc
On 2013/09/10 08:56:29, loislo wrote:
On 2013/09/10 08:47:56, Yang wrote:
> Having the string content appear as name seems valuable. How about
setting a
> certain limit so that we stringify only strings with lengths below that
limit?
> That way, whether to show string content would not depen
Reviewers: titzer,
Description:
Fix concurrent osr.
InstallOptimizedCode aquires ownership on the compilation info and deletes
it on return, tearing down the attached zone. The OptimizingCompiler
object is a zone object allocated in just that zone, so it also gets
deleted. Effectively, Install
On 2013/09/10 09:20:29, Yang wrote:
We could also solve this by not having InstallOptimizedCode delete the
OptimizingCompiler object, but delete it manually later on.
https://codereview.chromium.org/23769007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-de
lgtm
https://codereview.chromium.org/23581010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 16606
Author: dcar...@chromium.org
Date: Tue Sep 10 09:24:53 2013 UTC
Log: restore persistent dtor
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23581010
http://code.google.com/p/v8/source/detail?r=16606
Modified:
/branches/bleeding_edge/include
Committed patchset #1 manually as r16606 (presubmit successful).
https://codereview.chromium.org/23581010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Rebased. Please take a look.
https://codereview.chromium.org/23842004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
On 2013/09/10 09:16:44, Yang wrote:
On 2013/09/10 08:56:29, loislo wrote:
> On 2013/09/10 08:47:56, Yang wrote:
> > Having the string content appear as name seems valuable. How about
setting
a
> > certain limit so that we stringify only strings with lengths below
that
limit?
> > That way, w
On 2013/09/10 06:09:56, Sven Panne wrote:
LGTM with a nit.
https://codereview.chromium.org/23464022/diff/21001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/23464022/diff/21001/include/v8.h#newcode3816
include/v8.h:3816: Maybe is_memory_constrained() { return
is_me
lgtm
https://codereview.chromium.org/23938003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/23548024/diff/4001/src/bootstrapper.cc#newcode2410
src/bootstrapper.cc:2410: // using the per-isolate random number
generator.
On 2013/09/10 08:43:31, Michael
Reviewers: Benedikt Meurer, ulan,
Message:
RegExpCEntryStub and DirectCEntryStub provide the same functionality.
DirectCEntryStub has also been updated to be more friendly with branch
predictors.
Description:
ARM: replace RegExpCEntryStub with DirectCEntryStub.
RegExpCEntryStub is therefore re
Committed patchset #1 manually as r16607 (presubmit successful).
https://codereview.chromium.org/23767009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16607
Author: svenpa...@chromium.org
Date: Tue Sep 10 10:53:33 2013 UTC
Log: Move Maybe template into v8.h so it can be used by
SetResourceConstraints
BUG=
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/23767009
Patch from Ross McIlroy .
http://code
Committed patchset #6 manually as r16608 (presubmit successful).
https://codereview.chromium.org/23464022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16608
Author: svenpa...@chromium.org
Date: Tue Sep 10 10:57:00 2013 UTC
Log: Add a ResourceConstraint for the embedder to specify that V8 is
running on a memory constrained device.
This enables us to specialize certain operations such that we limit memory
usage on low-memo
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc#newcode1145
src/compiler.cc:1145: Deoptimizer::RevertInterruptCode(isolate,
*unoptimized);
Please move this reversion of the interru
lgtm
https://codereview.chromium.org/23769007/diff/1/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23769007/diff/1/src/compiler.cc#newcode1227
src/compiler.cc:1227: BailoutId ast_id = compiler->info()->osr_ast_id();
I'm not sure why you pulled this variable out
okay, ptal for real now
https://chromiumcodereview.appspot.com/23461039/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Benedikt Meurer,
Description:
Remove unused method HType::IsTagged().
BUG=
Please review this at https://codereview.chromium.org/24087004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -4 lines):
M src/hydrogen-instructions.h
Index: src/hydr
LGTM with nits.
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc
File src/arm/regexp-macro-assembler-arm.cc (right):
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc#newcode1067
src/arm/regexp-macro-assembler-arm.cc:1067:
Committed patchset #1 manually as r16609 (presubmit successful).
https://codereview.chromium.org/23769007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM.
https://codereview.chromium.org/24087004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 16609
Author: yang...@chromium.org
Date: Tue Sep 10 11:09:22 2013 UTC
Log: Fix concurrent osr.
InstallOptimizedCode aquires ownership on the compilation info and deletes
it on return, tearing down the attached zone. The OptimizingCompiler
object is a zone object allocated in
Committed patchset #1 manually as r16610 (presubmit successful).
https://codereview.chromium.org/24087004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16610
Author: tit...@chromium.org
Date: Tue Sep 10 11:11:26 2013 UTC
Log: Remove unused method HType::IsTagged().
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/24087004
http://code.google.com/p/v8/source/detail?r=16610
Modified:
/branches/bleeding
Revision: 16611
Author: loi...@chromium.org
Date: Tue Sep 10 11:12:35 2013 UTC
Log: HeapProfiler: very slow ~4min "take snapshot time" for 80MB gmail
heap.
The reason of that is a number of cons strings in the app.
The app constructs a json string and as a result v8 heap has
a very
Committed patchset #1 manually as r16611 (presubmit successful).
https://codereview.chromium.org/23460027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #6 manually as r16612 (presubmit successful).
https://codereview.chromium.org/23548024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16612
Author: bmeu...@chromium.org
Date: Tue Sep 10 11:13:55 2013 UTC
Log: Introduce a RandonNumberGenerator class. Refactor the
random/private_random uses in Isolate/Context.
The RandomNumberGenerator is a pseudorandom number generator
with 48-bit state. It is properly se
On 2013/09/10 11:00:46, titzer wrote:
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc
File src/compiler.cc (right):
https://codereview.chromium.org/23842004/diff/7010/src/compiler.cc#newcode1145
src/compiler.cc:1145: Deoptimizer::RevertInterruptCode(isolate,
*unoptimized);
Reviewers: Benedikt Meurer,
Description:
Initialize forgotten Isolate member.
Please review this at https://codereview.chromium.org/23769008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M src/isolate.cc
Index: src/isolate.cc
diff --git a/sr
lgtm
https://codereview.chromium.org/23769008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
https://codereview.chromium.org/23480027/diff/10001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/23480027/diff/10001/src/arm/macro-assembler-arm.cc#newcode3200
src/arm/macro-assembler-arm.cc:3200: sub(ip, length, Operand(4));
Hm, thi
Revision: 16613
Author: svenpa...@chromium.org
Date: Tue Sep 10 11:32:15 2013 UTC
Log: Initialize forgotten Isolate member.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/23769008
http://code.google.com/p/v8/source/detail?r=16613
Modified:
/branches/bleeding_edge
Committed patchset #1 manually as r16613.
https://codereview.chromium.org/23769008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r16614.
Description:
Fix MSVC compiler warning after commit r16612.
TBR=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16614
Please review this at https://codereview.chromium.org/235340
Revision: 16614
Author: bmeu...@chromium.org
Date: Tue Sep 10 11:33:14 2013 UTC
Log: Fix MSVC compiler warning after commit r16612.
TBR=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23534052
http://code.google.com/p/v8/source/detail?r=16614
Modified:
/branches
Reviewers: Sven Panne,
Description:
thread isolate for DebugMessage
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23904012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -1 lines):
M include/v8-debug.h
M src/debug
Reviewers: Michael Starzinger,
Message:
Please take a look.
Description:
Implement in-place rehashing of HashTable.
The algorithm puts elements into correct positions in multiple iterations.
On the first iteration it tries to put elements at entries specified by
their first hash probe. On the
lgtm
https://codereview.chromium.org/23620036/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Reviewers: Sven Panne,
Message:
Remove internalized strings that not referenced from either their factory
method, their root index, and don't have a const char* anywhere in the V8
code.
Description:
Remove dead strings from heap.h
BUG=
Please review this at https://codereview.chromium.org/23
Donation to you Contact cwp...@rogers.com ROGERS NOTIFICATION PIN: 772983
"Before acting on this email or opening any attachments you should read the
Manchester Metropolitan University email disclaimer available on its website
http://www.mmu.ac.uk/emaildisclaimer "
--
--
v8-dev mailing li
Reviewers: Sven Panne,
Description:
Get rid of most uses of 'Temporary macro' HEAP
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23708030/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+92, -72 lines):
M src/accessors.cc
Committed patchset #2 manually as r16615.
https://codereview.chromium.org/23938003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16615
Author: ol...@chromium.org
Date: Tue Sep 10 12:37:30 2013 UTC
Log: Move ToInt conversions to the MacroAssembler for x64
+ Prevent truncating TaggedToI from bailing out.
(This is a port of r16464)
BUG=
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/
On 2013/09/10 11:29:21, Benedikt Meurer wrote:
https://codereview.chromium.org/23480027/diff/10001/src/arm/macro-assembler-arm.cc
File src/arm/macro-assembler-arm.cc (right):
https://codereview.chromium.org/23480027/diff/10001/src/arm/macro-assembler-arm.cc#newcode3200
src/arm/macro-assemble
CC'ing danno and ulan for additional feedback.
I think we should really get this CopyBytes() thing right. Maybe you should
try
by investigating the following question first: How often is CopyBytes()
called
with compatible alignment of src and dst? And we should base our
optimizations
on th
lgtm
https://codereview.chromium.org/23904012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
LGTM with nits.
https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h
File src/heap-inl.h (right):
https://codereview.chromium.org/23708030/diff/1/src/heap-inl.h#newcode617
src/heap-inl.h:617: if (FLAG_gc_greedy)
ISOLATE->heap()->GarbageCollectionGreedyCheck()
Wrap argument in ()
http
Reviewers: danno,
Description:
Reload the descriptor after modifying the transition target.
R=da...@chromium.org
BUG=chromium:282736
Please review this at https://chromiumcodereview.appspot.com/23658033/
SVN Base: https://v8.googlecode.com/svn/branches/3.20
Affected files (+7, -7 lines):
M
lgtm
https://codereview.chromium.org/23600023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
I would feel more comfortable with the patch if it had a test. :-)
https://chromiumcodereview.appspot.com/23658033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" grou
Comment #3 on issue 2487 by a...@chromium.org: Force the explicit use of
Isolates in v8's external API
http://code.google.com/p/v8/issues/detail?id=2487
I've always wondered why we need an isolate for number, string, boolean,
undefined and null?
--
You received this message because this p
Reviewers: Michael Starzinger,
Description:
Revert TranscendentalCacheStub changes in r16615.
BUG=
Please review this at https://codereview.chromium.org/23889013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -1 lines):
M src/x64/code-stubs-x64.cc
Inde
LGTM (rubber-stamped).
https://codereview.chromium.org/23889013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Committed patchset #1 manually as r16616.
https://codereview.chromium.org/23889013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16616
Author: ol...@chromium.org
Date: Tue Sep 10 13:28:21 2013 UTC
Log: Revert TranscendentalCacheStub changes in r16615.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23889013
http://code.google.com/p/v8/source/detail?r=16616
Modified:
/bran
Reviewers: danno,
Description:
Use raw-to-handle trampoline in [Get/Set]HiddenPropertiesHashTable.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/23629040/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+67, -17 lines):
M src/facto
Added test, PTAL again.
https://chromiumcodereview.appspot.com/23658033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Toon Verwaest,
Message:
Hey Toon,
Here's the VirtualMemory refactoring, as promised. :-)
Mostly mechanical, PTAL.
-- Benedikt
Description:
Refactor and cleanup VirtualMemory.
Remove a lot of platform duplication, and simplify the virtual
memory implementation. Also improve readabilit
Reviewers: Sven Panne,
Message:
Committed patchset #1 manually as r16617 (presubmit successful).
Description:
Fix clang C++11 compiler warning.
TBR=svenpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16617
Please review this at https://codereview.chromium.org/236580
Revision: 16617
Author: bmeu...@chromium.org
Date: Tue Sep 10 13:39:53 2013 UTC
Log: Fix clang C++11 compiler warning.
TBR=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/23658034
http://code.google.com/p/v8/source/detail?r=16617
Modified:
/branches/bleeding_edge/
Reviewers: Yang,
Message:
This is a not large change to LiveEdit internal logic.
Description:
LiveEdit to mark more closure functions for re-instantiation when scope
layout
changes
BUG=2872
Please review this at https://codereview.chromium.org/23783007/
SVN Base: https://v8.googlecode.com/s
lgtm.
https://chromiumcodereview.appspot.com/23658033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc
File src/arm/regexp-macro-assembler-arm.cc (right):
https://codereview.chromium.org/23468015/diff/1/src/arm/regexp-macro-assembler-arm.cc#newcode1067
src/arm/regexp-macro-assembler-arm.cc:1067: if (stack_alignm
Revision: 16618
Author: rodolph.perfe...@gmail.com
Date: Tue Sep 10 13:50:26 2013 UTC
Log: ARM: replace RegExpCEntryStub with DirectCEntryStub.
RegExpCEntryStub is therefore removed.
BUG=none
TEST=none
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/23468015
http:/
Committed patchset #1 manually as r16618 (presubmit successful).
https://codereview.chromium.org/23468015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
lgtm, but I really wish we didn't have to put this in.
https://codereview.chromium.org/23629040/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Revision: 16619
Author: verwa...@chromium.org
Date: Tue Sep 10 13:53:22 2013 UTC
Log: Reload the descriptor after modifying the transition target.
R=da...@chromium.org
BUG=chromium:282736
Review URL: https://chromiumcodereview.appspot.com/23658033
http://code.google.com/p/v8/source/de
Committed patchset #2 manually as r16619 (presubmit successful).
https://chromiumcodereview.appspot.com/23658033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Comment #4 on issue 2487 by svenpa...@chromium.org: Force the explicit use
of Isolates in v8's external API
http://code.google.com/p/v8/issues/detail?id=2487
Apart from oddballs, all those objects live on the heap, which is
per-Isolate. And even the oddballs are per-Isolate entities, so you
Reviewers: Sven Panne,
Description:
pass Isolate to FunctionEntryHook
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/23499011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+119, -28 lines):
M include/v8.h
M src/api.cc
Revision: 16621
Author: dcar...@chromium.org
Date: Tue Sep 10 14:26:07 2013 UTC
Log: thread isolate for DebugMessage
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23904012
http://code.google.com/p/v8/source/detail?r=16621
Modified:
/branches/bleeding_edge
Reviewers: Toon Verwaest,
Description:
Use trampoline or handlified JSObject::SetLocalPropertyIgnoreAttributes.
R=verwa...@chromium.org
Please review this at https://codereview.chromium.org/24093002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+59, -62 lines
Addressed comment and refactored a bunch of stuff. Please take a look.
https://codereview.chromium.org/23842004/diff/19001/src/runtime-profiler.cc
File src/runtime-profiler.cc (right):
https://codereview.chromium.org/23842004/diff/19001/src/runtime-profiler.cc#newcode150
src/runtime-profiler.cc
Reviewers: dcarney, Michael Starzinger,
Message:
mstarzinger, could you review this?
Description:
Refactoring PropertyCallbackInfo & FunctionCallbackInfo, step 1.
The goal is to unify PropertyCallbackInfo and FunctionCallbackInfo so that
they
contain the same fields.
The field order will be
Committed patchset #2 manually as r16622 (presubmit successful).
https://codereview.chromium.org/23708030/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16622
Author: dcar...@chromium.org
Date: Tue Sep 10 14:30:36 2013 UTC
Log: Get rid of most uses of 'Temporary macro' HEAP
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23708030
http://code.google.com/p/v8/source/detail?r=16622
Modified:
/branche
Committed patchset #1 manually as r16621 (presubmit successful).
https://codereview.chromium.org/23904012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16623
Author: mstarzin...@chromium.org
Date: Tue Sep 10 14:33:06 2013 UTC
Log: Use raw-to-handle trampoline in
[Get/Set]HiddenPropertiesHashTable.
R=da...@chromium.org
Review URL: https://codereview.chromium.org/23629040
http://code.google.com/p/v8/source/detail?r=16623
Committed patchset #1 manually as r16623 (presubmit successful).
https://codereview.chromium.org/23629040/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Jakob,
Message:
There is obvious performance improvement on IA32 when using xorps to solve
the
cvtsi2sd partially written issue. The most benefit case is the
audio-oscillator
of kraken, which is improved by more than 15% and there is no negative
impact on
other cases. And for oct
Committed patchset #1 manually as r16625.
https://codereview.chromium.org/23766017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
Revision: 16625
Author: pal...@homejinni.com
Date: Tue Sep 10 15:12:05 2013 UTC
Log: Merged r16596 into trunk branch.
MIPS: thread isolate for HConstant::handle.
R=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23766017
http://code.google.com/p/v8/source/detail
Revision: 16626
Author: pal...@homejinni.com
Date: Tue Sep 10 15:13:12 2013 UTC
Log: Tagging version 3.21.12.2
http://code.google.com/p/v8/source/detail?r=16626
Added:
/tags/3.21.12.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rec
Committed patchset #1 manually as r16624 (presubmit successful).
https://codereview.chromium.org/23629031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: mvstanton, Michael Starzinger,
Description:
Check that AllocationMementos never get scavengend.
BUG=
Please review this at https://codereview.chromium.org/24052003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M src/heap-inl.h
In
Reviewers: Yang,
Description:
a small fix: DependentCode contains check against related dependency group
BUG=
Please review this at https://codereview.chromium.org/23648009/
SVN Base: git://github.com/v8/v8.git@master
Affected files (+3, -2 lines):
src/objects.cc
Index: src/objects.cc
dif
LGTM.
Ulan, could you take a second look before I land this?
https://codereview.chromium.org/23648009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsub
lgtm with nits
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.cc
File src/platform/virtual-memory.cc (right):
https://codereview.chromium.org/23641009/diff/4001/src/platform/virtual-memory.cc#newcode171
src/platform/virtual-memory.cc:171: // After three attempts
Reviewers: danno, Toon Verwaest,
Description:
Implement simplistic local alias analysis, which will be used in both check
elimination and load elimination.
BUG=
Please review this at https://codereview.chromium.org/23516010/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affec
Revision: 16620
Author: verwa...@chromium.org
Date: Tue Sep 10 14:01:48 2013 UTC
Log: Tagging version 3.20.17.7
http://code.google.com/p/v8/source/detail?r=16620
Added:
/tags/3.20.17.7
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
1 - 100 of 134 matches
Mail list logo
