Reviewers: Benedikt Meurer,
Description:
Refactoring only: Make it clear that MOD is special.
LArithmeticD should really be 5 different instructions... :-/
Please review this at https://codereview.chromium.org/2385/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected f
On 2013/09/16 14:54:24, Bangfu wrote:
On 2013/09/16 13:51:48, Sven Panne wrote:
> Committed patchset #2 manually as r16735.
for example:
var b = 0x1234;
function rol(num, cnt)
{
return (num << cnt) | (num >>> (32 - cnt));
}
var c;
for(var i = 0; i < 1000; i++)
{
c = rol(b, 30);
}
I
Revision: 16742
Author: mvstan...@chromium.org
Date: Mon Sep 16 16:50:41 2013 UTC
Log: Chromium 284577 needs a mitigation CL added. There is a TODO to
remove
the mitigation when the cause of the bug is discovered.
BUG=
R=hpa...@chromium.org, mstarzin...@chromium.org
Review URL: htt
Revision: 16725
Author: loi...@chromium.org
Date: Mon Sep 16 09:16:03 2013 UTC
Log: HeapProfiler: replace pointer based matching algorithm with
string matching algorithm for strings_ member.
pros: decreased snapshot size.
cons: increased serialization time.
I've tested the implemen
Revision: 16741
Author: yang...@chromium.org
Date: Mon Sep 16 16:09:07 2013 UTC
Log: Fix compile error.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/23651012
http://code.google.com/p/v8/source/detail?r=16741
Modified:
/branches/bleeding_edge/src/execut
Revision: 16729
Author: svenpa...@chromium.org
Date: Mon Sep 16 12:08:30 2013 UTC
Log: Fixed shared_library build on Windows.
BUG=v8:2879
R=u...@chromium.org
Review URL: https://codereview.chromium.org/24054008
http://code.google.com/p/v8/source/detail?r=16729
Modified:
/branches/bl
Committed patchset #3 manually as r16742 (presubmit successful).
https://codereview.chromium.org/23606032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16726
Author: verwa...@chromium.org
Date: Mon Sep 16 09:30:43 2013 UTC
Log: Rename StubType MAP_TRANSITION to TRANSITION.
R=mvstan...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/24120007
http://code.google.com/p/v8/source/detail?r=16726
Modified:
/branc
Reviewers: Paul Lind, kisg, kilvadyb, danno, oliv,
Message:
PTAL.
Description:
MIPS: Orthogonalize Lithium binary op instructions.
Port r16739 (cd8e4a21)
BUG=
Please review this at https://codereview.chromium.org/23494054/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affec
Committed patchset #1 manually as r16743 (presubmit successful).
https://codereview.chromium.org/23494054/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/23494054/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
Comment #7 on issue 2214 by a...@chromium.org: Implement Harmony iterators
http://code.google.com/p/v8/issues/detail?id=2214
Also, see issue 2323 about Map.prototype.forEach and Set.prototype.forEach
--
You received this message because this project is configured to send all
issue notificatio
lgtm
https://codereview.chromium.org/23598011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Committed patchset #4 manually as r16737 (presubmit successful).
https://codereview.chromium.org/23513048/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Revision: 16736
Author: svenpa...@chromium.org
Date: Mon Sep 16 14:09:22 2013 UTC
Log: Revert "Add flags to force or prevent setting of
isolate.is_memory_constrained."
It introduces static initializers for the new "MAYBE_BOOL" kind of
flags, which is a no-no for Chrome. This has to
Revision: 16722
Author: mvstan...@chromium.org
Date: Mon Sep 16 07:32:10 2013 UTC
Log: Prepare push to trunk. Now working on version 3.21.17.
R=machenb...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23437040
http://code.google.com/p/v8/source/detail?r=16722
Modifie
Comment #6 on issue 2323 by bjovano...@gmail.com: Add forEach to Map and Set
http://code.google.com/p/v8/issues/detail?id=2323
Am I missing something, or it is completely impossible to get size(), nor
keys() in current v8 implementation of maps/sets.. I have been spinning my
wheels for the l
Updates:
Cc: rossb...@chromium.org
Labels: Harmony
Comment #1 on issue 2735 by a...@chromium.org: Add support for @@iterator
http://code.google.com/p/v8/issues/detail?id=2735
(No comment was entered for this change.)
--
You received this message because this project is configure
Updates:
Status: Accepted
Cc: da...@chromium.org dslo...@chromium.org rossb...@chromium.org
Labels: Harmony
Comment #15 on issue 811 by a...@chromium.org: support destructuring
assignment
http://code.google.com/p/v8/issues/detail?id=811
This is part of ES6.
--
You rec
Updates:
Status: Accepted
Cc: mstarzin...@chromium.org da...@chromium.org rossb...@chromium.org
Labels: Harmony
Comment #5 on issue 2323 by a...@chromium.org: Add forEach to Map and Set
http://code.google.com/p/v8/issues/detail?id=2323
(No comment was entered for this cha
Comment #6 on issue 2214 by bjovano...@gmail.com: Implement Harmony
iterators
http://code.google.com/p/v8/issues/detail?id=2214
Maps and Sets are useless without iterators at least according to current
harmony spec..
--
You received this message because this project is configured to send
On 2013/09/14 19:32:07, Dmitry Lomov (chromium) wrote:
On 2013/09/13 23:31:38, zturner wrote:
> On 2013/09/13 23:14:07, zturner wrote:
>
> Not sure why the trybot is unable to apply the patch. Am I doing
something
> wrong? The Base URL and relative paths look ok to me.
trybots do not work
LGTM
https://codereview.chromium.org/23606032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
lgtm with nits
https://codereview.chromium.org/23601031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc#newcode1065
test/cctest/test-heap.cc:1065: // survive further).
On 2013/09/16 14:31:45, Hannes Payer wr
lgtm with nits
https://codereview.chromium.org/23601031/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23601031/diff/1/src/objects.cc#newcode1975
src/objects.cc:1975:
new_map->set_unused_property_fields(unused_property_fields);
Can we move these lines changin
On 2013/09/16 14:11:33, Michael Starzinger wrote:
lgtm.
https://codereview.chromium.org/24176002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
thx, Hannes, have another look then,
--Michael
https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9037
src/objects.cc:9037: Address site_address =
(reinterpret_cast(site) -
On 2013/09/
hey, ptal
https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h#newcode3884
src/hydrogen-instructions.h:3884: if (left->IsForceRepresentation()) {
On 2013/
On 2013/09/12 20:04:25, Michael Starzinger wrote:
Looking good. First round of comments, just one real issue about stores
with
map
transitions. But this needs dedicated test coverage in an
mjsunit/compiler/load-store-elimination.js file.
Done.
https://codereview.chromium.org/24117004/diff
Hi Hannes, here is the code we discussed. Michael, would you take a quick
look
at the Heap::Contains() call in objects.cc?
thx,
--Michael
https://codereview.chromium.org/23606032/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this mes
https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9040
src/objects.cc:9040: object->GetHeap()->Contains(site_address)) {
Instead of checking the whole heap, you could check if the addr
Revision: 16730
Author: bmeu...@chromium.org
Date: Mon Sep 16 12:38:41 2013 UTC
Log: Make HCompareNumericAndBranch safe for snapshots on ia32.
R=da...@chromium.org
Review URL: https://codereview.chromium.org/24078012
http://code.google.com/p/v8/source/detail?r=16730
Modified:
/branc
Revision: 16740
Author: yang...@chromium.org
Date: Mon Sep 16 15:34:46 2013 UTC
Log: Add mutex when accessing concurrent recompilation output queue.
Also small refactorings.
R=mstarzin...@chromium.org
BUG=291236
Review URL: https://codereview.chromium.org/23902033
http://code.google.
Committed patchset #2 manually as r16740 (presubmit successful).
https://codereview.chromium.org/23902033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
LGTM
https://codereview.chromium.org/23480031/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it,
LGTM with comment.
https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9037
src/objects.cc:9037: Address site_address =
(reinterpret_cast(site) -
nit: As discussed offline with Hannes,
Committed patchset #1 manually as r16741.
https://codereview.chromium.org/23651012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
LGTM (rubber-stamped).
https://codereview.chromium.org/23651012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivi
Revision: 16735
Author: svenpa...@chromium.org
Date: Mon Sep 16 13:51:14 2013 UTC
Log: In the case of shift amounts with two constants and if their sum
is equal 32, then shift can also be replaced with bit rotate.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org
Revision: 16733
Author: svenpa...@chromium.org
Date: Mon Sep 16 13:02:53 2013 UTC
Log: Add flags to force or prevent setting of
isolate.is_memory_constrained.
Also enable MAYBE_BOOL flags for when you want to only do something if the
flag was explicitly set to true or false.
BUG
Reviewers: Michael Starzinger,
Message:
Please take a look.
Note to self: don't commit last minute changes without running tests.
Description:
Fix compile error.
BUG=
Please review this at https://codereview.chromium.org/23651012/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg
Reviewers: Hannes Payer, Michael Starzinger,
Message:
Hi Hannes, here is the code we discussed. Michael, would you take a quick
look
at the Heap::Contains() call in objects.cc?
thx,
--Michael
Description:
Chromium 284577 needs a mitigation CL added. There is a TODO to remove
the mitigation wh
LGTM if comment about the stack guard is addressed.
https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/23902033/diff/1/src/optimizing-compiler-thread.cc#newcode140
src/optimizing-compi
Committed patchset #2 manually as r16739 (presubmit successful).
https://codereview.chromium.org/23703014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/16 15:19:50, loislo wrote:
Committed patchset #1 manually as r16738 (presubmit successful).
lgtm.
https://codereview.chromium.org/24178003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Reviewers: Yang,
Message:
Committed patchset #1 manually as r16738 (presubmit successful).
Description:
HeapProfiler: compile fix for win x64.
BUG=none
TBR=yang...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=16738
Please review this at https://codereview.chromium.org/
Reviewers: Michael Starzinger,
Description:
Ensure constant truncation is only done when it is safe.
BUG=
Please review this at https://codereview.chromium.org/23654041/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -12 lines):
M src/hydrogen-instructio
On 2013/09/16 13:53:02, Michael Starzinger wrote:
LGTM!
https://codereview.chromium.org/23496058/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscrib
Reviewers: Peter.Rybin, Yang, Yury Semikhatsky,
Description:
WIP: test case of V8 failing to step into in some cases.
BUG=289497
R=yang...@chromium.org,pry...@chromium.org, yu...@chromium.org
Please review this at https://codereview.chromium.org/23441070/
SVN Base: git://github.com/v8/v8.git@m
Status: New
Owner:
New issue 2888 by aand...@chromium.org: Debugger fails to step into in some
cases
http://code.google.com/p/v8/issues/detail?id=2888
Test case: https://codereview.chromium.org/23441070
In the following examples, the V8 debugger fails to step into the obj.fun
function
LGTM.
https://codereview.chromium.org/23461039/diff/18001/src/ia32/stub-cache-ia32.cc
File src/ia32/stub-cache-ia32.cc (right):
https://codereview.chromium.org/23461039/diff/18001/src/ia32/stub-cache-ia32.cc#newcode544
src/ia32/stub-cache-ia32.cc:544: ebp, (kFastApiCallArguments + 1) *
kPointer
On 2013/09/16 13:51:48, Sven Panne wrote:
Committed patchset #2 manually as r16735.
for example:
var b = 0x1234;
function rol(num, cnt)
{
return (num << cnt) | (num >>> (32 - cnt));
}
var c;
for(var i = 0; i < 1000; i++)
{
c = rol(b, 30);
}
In the above example, V8 compiler would replace
Reviewers: Michael Starzinger,
Description:
Add mutex when accessing concurrent recompilation output queue.
Also small refactorings.
R=mstarzin...@chromium.org
BUG=291236
Please review this at https://codereview.chromium.org/23902033/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc
File test/cctest/test-heap.cc (right):
https://codereview.chromium.org/23480031/diff/29001/test/cctest/test-heap.cc#newcode1065
test/cctest/test-heap.cc:1065: // survive further).
Since we have the mode now which is tur
On 2013/09/13 09:47:56, Yang wrote:
I'm not entirely familiar with how frame restart works, so let me try to
understand:
When we restart frames, we find the ones we want to restart, clear the
corresponding range on the stack, and replace it with the frame dropper
builtin,
which calls the fun
Revision: 16728
Author: bmeu...@chromium.org
Date: Mon Sep 16 11:30:10 2013 UTC
Log: Remove unused context parameter from AddIncrementCounter().
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/23622033
http://code.google.com/p/v8/source/detail?r=16728
Modified:
LGTM. Thanks for the fix. I'll land this for you.
https://codereview.chromium.org/23513048/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Reviewers: Yang,
Description:
Handlify JSReceiver::SetPropertyWithDefinedSetter method.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/24176002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+22, -27 lines):
M src/objects.h
M
Reviewers: danno,
Message:
Committed patchset #1 manually as r16736.
Description:
Revert "Add flags to force or prevent setting of
isolate.is_memory_constrained."
It introduces static initializers for the new "MAYBE_BOOL" kind of
flags, which is a no-no for Chrome. This has to be done differ
Reviewers: Yang,
Description:
Handlify JSReceiver::HasProperty and friends.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/23496058/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+95, -93 lines):
M src/api.cc
M src/objects-inl
Committed patchset #2 manually as r16735.
https://codereview.chromium.org/24095002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
lgtm
https://codereview.chromium.org/23440044/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Before we land this, I'd like to see where and why we will need this change.
https://codereview.chromium.org/23523060/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/23523060/diff/1/src/ia32/assembler-ia32.h#newcode538
src/ia32/assembler-
On 2013/09/16 12:34:11, ulan wrote:
> It speeds up sun spider benchmark by 0.3% with this optimization.
That looks within the noise to me. I ran this CL on other benchmarks, and
it
was
performance neutral there too.
Let's land the tests and skip the change CopyBytes, since its complexity
LGTM, although it would be nice to know if there is some real-world example
which benefits from this or if there is some follow-up CL building on this.
Landing this for you...
https://codereview.chromium.org/24095002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/gr
https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/23503058/diff/1/src/hydrogen-instructions.h#newcode3884
src/hydrogen-instructions.h:3884: if (left->IsForceRepresentation()) {
Why do we propagate
Reviewers: Benedikt Meurer, Sven Panne,
Message:
On 2013/09/13 12:54:49, Sven Panne wrote:
Can we have an explicit test case for this?
test case added, thank you for review.
Description:
In the case of shift amounts with two constants and if their sum is equal
32,
then shift can also be re
Comment #3 on issue 2885 by tha...@chromium.org: mksnapshot's output isn't
deterministic
http://code.google.com/p/v8/issues/detail?id=2885
I like deterministic builds. mksnapshot is the only part of Chromium
Framework's many inputs that doesn't build deterministically. (Having said
that,
Reviewers: Sven Panne,
Message:
let's try this again
Description:
reland 16717: line up crashing with chrome
R=svenpa...@chromium.org
BUG=
Please review this at https://chromiumcodereview.appspot.com/23440044/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20
Committed patchset #4 manually as r16734 (presubmit successful).
https://codereview.chromium.org/24174002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
On 2013/09/16 13:08:25, loislo wrote:
On 2013/09/16 12:45:10, Yang wrote:
> I suppose that the value is set by GetStringId, which assigns it by a
growing
> index, making it unrelated to the string content. In that case, the sort
order
> is arbitrary, even if reproducible. Why do we need it to
LGTM with nits
https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/23703014/diff/14001/src/arm/lithium-arm.cc#newcode759
src/arm/lithium-arm.cc:759: LOperand* left = (op == Token::MOD)
Refactor this into
On 2013/09/16 12:45:10, Yang wrote:
I suppose that the value is set by GetStringId, which assigns it by a
growing
index, making it unrelated to the string content. In that case, the sort
order
is arbitrary, even if reproducible. Why do we need it to be sorted to
begin
with?
heap snapshot
Committed patchset #4 manually as r16733 (presubmit successful).
https://codereview.chromium.org/23890027/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: ulan, Benedikt Meurer,
Message:
more breaking down of issue 23156006.
Description:
ARM: Tweak StoreKeyed.
Avoid corrupting its input in some cases.
BUG=none
TEST=test/mjsunit/lithium/StoreKeyed*.js
Please review this at https://codereview.chromium.org/23600054/
SVN Base: https://v
lgtm. There won't be a better time to do this. This is seems like the right
way
to go, but please send a corresponding email to v8-users when you actually
commit this to make sure embedders know what to do.
https://codereview.chromium.org/23003028/
--
--
v8-dev mailing list
v8-dev@googlegroups
Reviewers: Sven Panne,
Description:
Hydrogen binop improvements
- Truncate oddball if possible.
- Support for StringAdd with only one String argument.
- Propagate back truncation flag to HForceRepresentation.
- Use constructor macro for HMul.
- Add ForceNumberType for HydrogenStubs to enforce in
Revision: 16731
Author: da...@chromium.org
Date: Mon Sep 16 12:41:05 2013 UTC
Log: Tweak HConstant::EmitAtUses() to eliminate useless constant
generation
BUG=2881
R=da...@chromium.org
Review URL: https://codereview.chromium.org/23811011
Patch from Weiliang Lin .
http://code.google
I suppose that the value is set by GetStringId, which assigns it by a
growing
index, making it unrelated to the string content. In that case, the sort
order
is arbitrary, even if reproducible. Why do we need it to be sorted to begin
with?
https://codereview.chromium.org/24174002/diff/7001/sr
Committed patchset #2 manually as r16731 (presubmit successful).
https://codereview.chromium.org/23811011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Committed patchset #1 manually as r16732 (presubmit successful).
https://codereview.chromium.org/23691064/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Sven Panne,
Description:
Add a mechanism to override the detected cpu features.
BUG=
Please review this at https://codereview.chromium.org/23523060/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -1 lines):
M src/ia32/assembler-ia32.h
M src/
Committed patchset #1 manually as r16730 (presubmit successful).
https://codereview.chromium.org/24078012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
Reviewers: Sven Panne,
Description:
Orthogonalize Lithium binary op instructions.
BUG=
Please review this at https://codereview.chromium.org/23703014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+178, -245 lines):
M src/arm/lithium-arm.h
M src/arm/lithiu
It speeds up sun spider benchmark by 0.3% with this optimization.
That looks within the noise to me. I ran this CL on other benchmarks, and
it was
performance neutral there too.
Let's land the tests and skip the change CopyBytes, since its complexity
doesn't
payoff.
https://codereview.chro
lgtm
lgtm
https://codereview.chromium.org/24078012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/24078012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno,
Message:
Hey danno,
The HCompareNumericAndBranch instruction is necessary for the
NumberToStringStub, so we need an X87 fallback here. PTAL
-- Benedikt
Description:
Make HCompareNumericAndBranch safe for snapshots on ia32.
Please review this at https://codereview.chromium.org/
okay, this should be good, ptal
https://chromiumcodereview.appspot.com/23461039/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
lgtm
https://codereview.chromium.org/24174002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2013/09/16 09:52:54, Sven Panne wrote:
Hmmm, we have test failures in cctest/test-flags, see e.g.
make -j32 ia32.debug.check TESTJOBS="cctest/test-flags"
So we need one more review round. *Nothing* in v8 is easy... :-}
Whoops, I thought I'd run debug.check... Fixed and added some
Updates:
Status: Fixed
Owner: svenpa...@chromium.org
Comment #4 on issue 2879 by svenpa...@chromium.org: 3.21.13: Windows build
broken
http://code.google.com/p/v8/issues/detail?id=2879
Tentative fix: https://code.google.com/p/v8/source/detail?r=16729
Feel free to re-open this
Committed patchset #1 manually as r16729.
https://codereview.chromium.org/24054008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gro
lgtm
https://codereview.chromium.org/24054008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
On 2013/09/16 11:18:09, alph wrote:
https://codereview.chromium.org/24174002/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/24174002/diff/1/src/heap-snapshot-generator.cc#newcode2696
src/heap-snapshot-generator.cc:2696: Vector
Reviewers: ulan,
Description:
Fixed shared_library build on Windows.
BUG=v8:2879
Please review this at https://codereview.chromium.org/24054008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M include/v8.h
Index: include/v8.h
diff --git a/in
Reviewers: danno,
Message:
Hey danno,
The HCompareNumericAndBranch instruction is necessary for the
NumberToStringStub, so we need an X87 fallback here. PTAL
-- Benedikt
Description:
Make HCompareNumericAndBranch safe for snapshots on ia32.
Please review this at https://codereview.chromium.org/
On 2013/09/09 14:48:42, Peter.Rybin wrote:
Corresponding Chrome bug:
https://code.google.com/p/chromium/issues/detail?id=275672
LGTM.
https://codereview.chromium.org/23513023/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 manually as r16728 (presubmit successful).
https://codereview.chromium.org/23622033/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
1 - 100 of 134 matches
Mail list logo
