Revision: 17174
Author: haitao.f...@intel.com
Date: Mon Oct 14 06:31:01 2013 UTC
Log: Remove unnecessary MarkAsDeferredCalling when changing a tagged
value to double
R=da...@chromium.org
Review URL: https://codereview.chromium.org/25373003
Committed patchset #1 manually as r17174 (presubmit successful).
https://codereview.chromium.org/25373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Updates:
Status: Fixed
Comment #5 on issue 2293 by svenpa...@chromium.org: Removal of built-in
function prototype property
http://code.google.com/p/v8/issues/detail?id=2293
I think it is totally OK to mark this as fixed after i18n is back in v8
again. I am not aware of another use
On 2013/10/12 08:23:16, Weiliang wrote:
Hi Yang,
extractps is not used in current V8. I found this bug when prototyping
SIMD in
V8. Of course, we could just delete extractps instruction, but from my
view, I
hope it could be kept there.
Either we should fix it or remove the instruction,
Reviewers: Sven Panne,
Message:
Easy one, PTAL.
Description:
HIsStringAndBranch does an implicit SMI check if necessary.
No need to test for SMI first using HIsSmiAndBranch.
Please review this at https://codereview.chromium.org/27160002/
SVN Base:
On 2013/10/11 13:01:43, Hannes Payer wrote:
On 2013/10/11 09:20:14, Yury Semikhatsky wrote:
On 2013/10/11 08:27:11, Hannes Payer wrote:
On 2013/10/11 05:59:32, loislo wrote:
On 2013/10/10 18:54:39, Hannes Payer wrote:
I would propose to turn off allocation folding when you turn on
lgtm
https://codereview.chromium.org/27160002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 17175
Author: bmeu...@chromium.org
Date: Mon Oct 14 08:03:35 2013 UTC
Log: HIsStringAndBranch does an implicit SMI check if necessary.
No need to test for SMI first using HIsSmiAndBranch.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/27160002
Committed patchset #1 manually as r17175 (presubmit successful).
https://codereview.chromium.org/27160002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
If you do not think that the folding issue should be resolved now than LGTM
from
my side.
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
lgtm
https://codereview.chromium.org/27047002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 17176
Author: ma...@chromium.org
Date: Mon Oct 14 08:31:07 2013 UTC
Log: Experimental push model parser: various fixes.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/27047002
http://code.google.com/p/v8/source/detail?r=17176
Modified:
Reviewers: ulan,
Message:
Committed patchset #3 manually as r17176 (presubmit successful).
Description:
Experimental push model parser: various fixes.
BUG=
R=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17176
Please review this at
Reviewers: Benedikt Meurer,
Description:
Prepare push to trunk. Now working on version 3.22.12.
R=bmeu...@chromium.org
Please review this at https://codereview.chromium.org/27163003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -1 lines):
M ChangeLog
lgtm
https://codereview.chromium.org/27163003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r17177 (presubmit successful).
https://codereview.chromium.org/27163003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17177
Author: mstarzin...@chromium.org
Date: Mon Oct 14 08:42:54 2013 UTC
Log: Prepare push to trunk. Now working on version 3.22.12.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/27163003
http://code.google.com/p/v8/source/detail?r=17177
Modified:
Revision: 17179
Author: mstarzin...@chromium.org
Date: Mon Oct 14 08:46:24 2013 UTC
Log: Tagging version 3.22.11
http://code.google.com/p/v8/source/detail?r=17179
Added:
/tags/3.22.11
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #1 manually as r17180 (presubmit successful).
https://codereview.chromium.org/25382003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17180
Author: yu...@chromium.org
Date: Mon Oct 14 08:57:46 2013 UTC
Log: profile-generator.* code clean-up
* Removed unused CodeEntry::CopyData
* Removed unnecessary INLINE macros
BUG=None
R=loi...@chromium.org, yang...@chromium.org
Review URL:
LGTM.
https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc#newcode1532
src/spaces.cc:1532: NewSpacePage::Initialize(heap(), start_ + i *
Page::kPageSize, this);
nit: Only one white-space
Reviewers: Sven Panne,
Message:
Hey Sven,
Another easy one to start your day right. :-P
PTAL
-- Benedikt
Description:
Drop useless HForceRepresentation in BinaryOpStub.
Please review this at https://codereview.chromium.org/27167002/
SVN Base:
Reviewers: Michael Starzinger,
Description:
Return the new state from local analysis in flow-engine.
BUG=
Please review this at https://codereview.chromium.org/27166003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M
LGTM.
https://codereview.chromium.org/27166003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
One central comment about the way the accounting is done.
https://codereview.chromium.org/27023003/diff/3001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/3001/src/heap.h#newcode2374
src/heap.h:2374: intptr_t full_codegen_bytes_;
nit: I know the existing
lgtm
https://codereview.chromium.org/27167002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r17181 (presubmit successful).
https://codereview.chromium.org/27166003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17182
Author: bmeu...@chromium.org
Date: Mon Oct 14 09:22:34 2013 UTC
Log: Drop useless HForceRepresentation in BinaryOpStub.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/27167002
http://code.google.com/p/v8/source/detail?r=17182
Modified:
Committed patchset #1 manually as r17182 (presubmit successful).
https://codereview.chromium.org/27167002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/26865004/diff/1002/src/spaces.cc#newcode1532
src/spaces.cc:1532: NewSpacePage::Initialize(heap(), start_ + i *
Page::kPageSize, this);
On 2013/10/14 09:03:51, Michael
Revision: 17181
Author: tit...@chromium.org
Date: Mon Oct 14 09:22:19 2013 UTC
Log: Return the new state from local analysis in flow-engine.
BUG=
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/27166003
http://code.google.com/p/v8/source/detail?r=17181
Committed patchset #1 manually as r17183 (presubmit successful).
https://codereview.chromium.org/24076007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17184
Author: rossb...@chromium.org
Date: Mon Oct 14 09:41:41 2013 UTC
Log: Unify handling of position info in AST, part 2
* Eliminate Conditional::then/else_position and
WhileStatement::condition_position.
R=yang...@chromium.org
BUG=
Review URL:
Committed patchset #2 manually as r17184 (presubmit successful).
https://codereview.chromium.org/23597037/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17185
Author: hpa...@chromium.org
Date: Mon Oct 14 09:48:44 2013 UTC
Log: Use pages from lower to higher addresses in new space.
This CL constitutes the invariant that the top pointer in new space is
always larger than objects allocated since the last new space garbage
Committed patchset #3 manually as r17185 (presubmit successful).
https://codereview.chromium.org/26865004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
I think we should reconsider the whole test, and especially this CL. With a
running time of more than 8 seconds on a HP 620 it is by far the longest
running
test in release mode. Note that it only takes 24 seconds for all
ia32.release.check with -j32. Funnily enough, we take *less* time in
lgtm
https://codereview.chromium.org/27172002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan,
Message:
Committed patchset #1 manually as r17186 (presubmit successful).
Description:
Experimental push mode parser: More fixes.
BUG=
R=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17186
Please review this at
Revision: 17186
Author: ma...@chromium.org
Date: Mon Oct 14 10:48:11 2013 UTC
Log: Experimental push mode parser: More fixes.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/27172002
http://code.google.com/p/v8/source/detail?r=17186
Modified:
Reviewers: ulan,
Description:
Remove deprecated v8::preparser namespace.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/27174002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+26, -39 lines):
M src/parser.h
M src/parser.cc
M
Committed patchset #1 manually as r17187 (presubmit successful).
https://codereview.chromium.org/23684058/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Sven Panne,
Description:
Properly export uin32_bias double constant.
This makes LoadUint32 snapshot safe.
BUG=
Please review this at https://codereview.chromium.org/27156004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+21, -10 lines):
M
Revision: 17187
Author: rossb...@chromium.org
Date: Mon Oct 14 11:06:15 2013 UTC
Log: Unify handling of position info in AST, part 3
* Turn CaseClause into a proper AstNode
R=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/23684058
https://codereview.chromium.org/27023003/diff/3001/src/mark-compact.cc
File src/mark-compact.cc (right):
https://codereview.chromium.org/27023003/diff/3001/src/mark-compact.cc#newcode1010
src/mark-compact.cc:1010: isolate_-heap()-DecrementCodeGeneratedBytes(
On 2013/10/14 09:18:37, Michael
lgtm
https://chromiumcodereview.appspot.com/27034005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Revision: 17188
Author: u...@chromium.org
Date: Mon Oct 14 11:35:31 2013 UTC
Log: Add rule for generating lexer and implement lexer shell.
R=ma...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/27034005
http://code.google.com/p/v8/source/detail?r=17188
Added:
Reviewers: marja,
Message:
Committed patchset #2 manually as r17188 (presubmit successful).
Description:
Add rule for generating lexer and implement lexer shell.
R=ma...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17188
Please review this at
LGTM
https://codereview.chromium.org/27174002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
+1 to what Sven said. 3*600ms of scheduled delay time per run (and five
times
that with --stress-opt) is not something I like to see in a Release mode
test. I
guess Debug is faster because it only does two stress runs.
I have two suggestions for improvements:
- turn this into a cctest where
Reviewers: Michael Starzinger,
Message:
As discussed.
Description:
Move v8_optimized_debug default value to standalone.gypi
This is so that Chromium can have its own overridable default value without
colliding with ours.
Please review this at https://codereview.chromium.org/26317009/
SVN
Reviewers: Michael Starzinger,
Description:
Reenable 17167: Ensure lower = upper bound
Fixed handlification bug (see 2nd patch).
Will handlify Type::Union and Type::Intersect in separate CL.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/27164003/
SVN
LGTM (reviewed patch set #2, rubber-stamped the rest).
https://codereview.chromium.org/27164003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe
On 2013/10/11 18:31:06, jochen wrote:
https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
https://codereview.chromium.org/26848011/diff/1/test/cctest/test-api.cc#oldcode14449
test/cctest/test-api.cc:14449: class ApplyInterruptTest {
lgtm
https://codereview.chromium.org/27156004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/27177002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r17189 (presubmit successful).
https://codereview.chromium.org/27164003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17190
Author: ma...@chromium.org
Date: Mon Oct 14 12:15:07 2013 UTC
Log: Experimental push model parser: Numbers.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/27177002
http://code.google.com/p/v8/source/detail?r=17190
Modified:
Reviewers: ulan,
Message:
Committed patchset #2 manually as r17190 (presubmit successful).
Description:
Experimental push model parser: Numbers.
BUG=
R=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=17190
Please review this at
Revision: 17189
Author: rossb...@chromium.org
Date: Mon Oct 14 12:14:42 2013 UTC
Log: Reenable 17167: Ensure lower = upper bound
Fixed handlification bug (see 2nd patch).
Will handlify Type::Union and Type::Intersect in separate CL.
R=mstarzin...@chromium.org
BUG=
Review URL:
Reviewers: Dmitry Lomov (chromium),
Message:
Measured an 7x decrease in the memory allocated in the zone during this
phase,
from 2.2mb to 0.3mb on benchmarks/run.js. Shouldn't affect performance
significantly, and should generate identical code.
Description:
Reduce queue size in dead code
https://codereview.chromium.org/27178002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
On 2013/10/07 10:56:12, rmcilroy wrote:
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/23480031/diff/97001/src/ia32/full-codegen-ia32.cc#newcode171
Committed patchset #13 manually as r17191 (presubmit successful).
https://codereview.chromium.org/22852024/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17191
Author: yu...@chromium.org
Date: Mon Oct 14 12:41:28 2013 UTC
Log: Track JS allocations as they arrive with no affection on
performance when tracking is switched off.
BUG=277984
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/22852024
Patch from
lgtm with one nit.
Nice, thanks!
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc
File src/hydrogen-dce.cc (right):
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc#newcode35
src/hydrogen-dce.cc:35: HValue* instr, ZoneListHValue** worklist) {
add an
LGTM.
https://codereview.chromium.org/26317009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
rubberstamp LGTM. I'll land.
https://codereview.chromium.org/26034002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop
Committed patchset #1 manually as r17193 (presubmit successful).
https://codereview.chromium.org/26317009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17192
Author: mstarzin...@chromium.org
Date: Mon Oct 14 13:07:20 2013 UTC
Log: Remove deprecated v8::preparser namespace.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/27174002
http://code.google.com/p/v8/source/detail?r=17192
Modified:
Committed patchset #1 manually as r17192 (presubmit successful).
https://codereview.chromium.org/27174002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17193
Author: jkumme...@chromium.org
Date: Mon Oct 14 13:07:41 2013 UTC
Log: Move v8_optimized_debug default value to standalone.gypi
This is so that Chromium can have its own overridable default value without
colliding with ours.
R=mstarzin...@chromium.org
Review URL:
Committed patchset #1 manually as r17194 (presubmit successful).
https://codereview.chromium.org/26034002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17194
Author: jkumme...@chromium.org
Date: Mon Oct 14 13:08:52 2013 UTC
Log: Add additional postmortem debugging metadata to support decoding
two-byte
strings, sliced strings, and changes to some object property
representations.
R=jkumme...@chromium.org
Review URL:
On 2013/10/14 12:43:29, rmcilroy wrote:
lgtm with one nit.
Nice, thanks!
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc
File src/hydrogen-dce.cc (right):
https://codereview.chromium.org/27178002/diff/1/src/hydrogen-dce.cc#newcode35
src/hydrogen-dce.cc:35: HValue*
LGTM with one suggestion. Will land this for you once it has been addressed.
https://codereview.chromium.org/27023003/diff/9001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/9001/src/heap.h#newcode2366
src/heap.h:2366: size_t full_codegen_bytes_generated_;
Reviewers: Jakob,
Description:
Fix initial comparison combined_type
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/27183002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -4 lines):
M src/ast.h
M src/ast.cc
M
Reviewers: ulan,
Description:
Introduce ParserBase for common code between parser and pre-parser.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/27182002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+199, -276 lines):
M
LGTM.
https://codereview.chromium.org/27183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #1 manually as r17195 (presubmit successful).
https://codereview.chromium.org/27183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17195
Author: rossb...@chromium.org
Date: Mon Oct 14 13:25:36 2013 UTC
Log: Fix initial comparison combined_type
R=jkumme...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/27183002
http://code.google.com/p/v8/source/detail?r=17195
Modified:
Thanks Michael!
https://codereview.chromium.org/27023003/diff/3001/src/heap.h
File src/heap.h (right):
https://codereview.chromium.org/27023003/diff/3001/src/heap.h#newcode2374
src/heap.h:2374: intptr_t full_codegen_bytes_;
On 2013/10/14 09:18:37, Michael Starzinger wrote:
nit: I know the
Committed patchset #2 manually as r17196 (presubmit successful).
https://codereview.chromium.org/27178002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17196
Author: tit...@chromium.org
Date: Mon Oct 14 13:32:02 2013 UTC
Log: Reduce queue size in dead code elimination by eagerly processing
live instructions.
BUG=
R=rmcil...@chromium.org
Review URL: https://codereview.chromium.org/27178002
Reviewers: Jakob,
Description:
Retire concurrent recompilation delay for non-stress testing.
Instead, we block concurrent recompilation until unblocked. This makes
affected tests more predictable and run shorter.
R=jkumme...@chromium.org
BUG=
Please review this at
On 2013/10/14 11:46:38, Jakob wrote:
+1 to what Sven said. 3*600ms of scheduled delay time per run (and five
times
that with --stress-opt) is not something I like to see in a Release mode
test.
I
guess Debug is faster because it only does two stress runs.
I have two suggestions for
Revision: 17197
Author: u...@chromium.org
Date: Mon Oct 14 13:35:06 2013 UTC
Log: Out-of-line constant pool on Arm: Stage 2 - Introduce
ConstantPoolArray object.
Second stage of implementing an out-of-line constant pool on Arm. This CL
Introduces the ConstantPoolArray object which
Committed patchset #4 manually as r17198 (presubmit successful).
https://codereview.chromium.org/27023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17198
Author: mstarzin...@chromium.org
Date: Mon Oct 14 14:00:28 2013 UTC
Log: Add histograms to track fraction of heap spaces and percentage of
generated crankshaft code.
BUG=None
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/27023003
Patch
LGTM. Thanks!
https://codereview.chromium.org/26758003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r17199 (presubmit successful).
https://codereview.chromium.org/26758003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 17199
Author: yang...@chromium.org
Date: Mon Oct 14 14:15:22 2013 UTC
Log: Retire concurrent recompilation delay for non-stress testing.
Instead, we block concurrent recompilation until unblocked. This makes
affected tests more predictable and run shorter.
Reviewers: marja,
Message:
PTAL
https://chromiumcodereview.appspot.com/26764004/diff/1/src/lexer/lexer.re
File src/lexer/lexer.re (right):
https://chromiumcodereview.appspot.com/26764004/diff/1/src/lexer/lexer.re#newcode23
src/lexer/lexer.re:23: EConditionHtmlComment
Had to move it here from
Thx for the comments, here is my update.
https://codereview.chromium.org/24250005/diff/44001/src/allocation-site-scopes.h
File src/allocation-site-scopes.h (right):
https://codereview.chromium.org/24250005/diff/44001/src/allocation-site-scopes.h#newcode40
src/allocation-site-scopes.h:40: class
lgtm
https://chromiumcodereview.appspot.com/26764004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #1 manually as r17200 (presubmit successful).
https://chromiumcodereview.appspot.com/26764004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 17200
Author: u...@chromium.org
Date: Mon Oct 14 14:35:38 2013 UTC
Log: Invoke generated lexer along with baseline lexer to compare
results.
BUG=
R=ma...@chromium.org
Review URL: https://chromiumcodereview.appspot.com/26764004
Reviewers: marja,
Message:
PTAL
Description:
Some C++ style fixes in lexer.re.
Please review this at https://chromiumcodereview.appspot.com/26762004/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/parser
Affected files (+288, -303 lines):
M src/lexer/lexer.re
--
--
v8-dev
lgtm
https://chromiumcodereview.appspot.com/26762004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r17201 (presubmit successful).
https://chromiumcodereview.appspot.com/26762004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
1 - 100 of 118 matches
Mail list logo
