Revision: 18700
Author: machenb...@chromium.org
Date: Tue Jan 21 07:58:54 2014 UTC
Log: [Sheriff] Temporarily mark array-literal-feedback as flaky for GC
stress.
The test is blocking the v8 lkgr. It will be unmarked again after there is
infrastructure to disable it on GC stress on
Committed patchset #1 manually as r18700 (presubmit successful).
https://codereview.chromium.org/143463004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: mvstanton, Hannes Payer,
Message:
FYI
Description:
[Sheriff] Temporarily mark array-literal-feedback as flaky for GC stress.
The test is blocking the v8 lkgr. It will be unmarked again after there is
infrastructure to disable it on GC stress only.
BUG=
TBR=mvstan...@chromium.org
Pl
lgtm
https://codereview.chromium.org/143893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, just one semantic comment
https://codereview.chromium.org/140963004/diff/140001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/140963004/diff/140001/src/runtime.cc#newcode14783
src/runtime.cc:14783: type_info->IsAllocationSite()) {
Maybe I'm missing something,
Reviewers: Sven Panne,
Message:
Hey Sven,
Here's an easy starter for today. Fortunately the bug did not trigger any
bad
behavior except for some unnecessary checks that were emitted in Hydrogen.
PTAL
-- Benedikt
Description:
Fix invalid type assumption in GenerateNumberToString().
We don't h
Reviewers: Toon Verwaest,
Message:
As discussed at https://codereview.chromium.org/64453002/#msg4.
Description:
Introduce Assembler::RelocInfoNone function for X64
Please review this at https://codereview.chromium.org/140553004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
A
Comment #16 on issue 1858 by mcspainh...@gmail.com: Iteration over frozen
object is slow
http://code.google.com/p/v8/issues/detail?id=1858
This certainly appears to continue to be an issue:
Browser: Chrome 34.0.1796.0 canary
Test Case: http://jsperf.com/performance-frozen-object
Result: 11
Reviewers: Toon Verwaest,
Message:
Hi Toon,
This is a follow-up of https://codereview.chromium.org/137443004 and
https://codereview.chromium.org/105503006.
I examined the movp usage under _WIN64 macro and found them should be movq.
Windows does not support x32 ABI, so I tried my best to make th
Committed patchset #1 manually as r18699 (presubmit successful).
https://codereview.chromium.org/143663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18699
Author: pal...@homejinni.com
Date: Mon Jan 20 23:08:52 2014 UTC
Log: MIPS: Turn ArrayPush into a stub specialized on the elements kind
and argc.
Port r18696 (6e4b51b4)
BUG=
R=gerg...@homejinni.com
Review URL: https://codereview.chromium.org/143663002
http://code.go
LGTM
https://codereview.chromium.org/143663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Toon Verwaest, danno, Paul Lind, kisg, kilvadyb, dusmil,
Message:
PTAL.
Description:
MIPS: Turn ArrayPush into a stub specialized on the elements kind and argc.
Port r18696 (6e4b51b4)
BUG=
Please review this at https://codereview.chromium.org/143663002/
SVN Base: https://v8.google
Status: New
Owner:
New issue 3109 by dark.pa...@gmail.com: parseInt should treat the BOM
character as whitespace
http://code.google.com/p/v8/issues/detail?id=3109
The following returns `10` for pretty much every JavaScript implementation
I've tried except for on V8, where it returns `
I think we have checked in an expectation with FAIL in it already. Let me
look at it in detail tomorrow.
On Mon, Jan 20, 2014 at 3:51 PM, Dmitry Lomov wrote:
> It feels that there is more to it than just rebase - why we have
> 'arguments' and 'caller' here:
>
> FAIL getSortedOwnPropertyNames(Bo
It feels that there is more to it than just rebase - why we have
'arguments' and 'caller' here:
FAIL getSortedOwnPropertyNames(Boolean) should be
length,name,prototype. Was arguments,caller,length,name,prototype.
Or am I missing something?
On Mon, Jan 20, 2014 at 6:04 PM, Erik Arvidsson wrote:
Reviewers: Toon Verwaest,
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode703
src/x64/stub-cache-x64.cc:703: api_receiver,
Handle(lookup->holder()
Nice cleanup! lgtm
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc
File src/x64/stub-cache-x64.cc (right):
https://codereview.chromium.org/142973005/diff/1/src/x64/stub-cache-x64.cc#newcode417
src/x64/stub-cache-x64.cc:417: Handle
Handle prototype_map(
JSObject::c
Committed patchset #1 manually as r18698 (presubmit successful).
https://codereview.chromium.org/139343008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18698
Author: machenb...@chromium.org
Date: Mon Jan 20 19:05:31 2014 UTC
Log: [Sheriff] Temporarily mark two mjsunit tests as flaky.
The tests are blocking the v8 lkgr. They will be unmarked again after there
is infrastructure to disable them on GC stress only.
TBR=mvstan
Reviewers: mvstanton, Hannes Payer,
Message:
FYI
Description:
[Sheriff] Temporarily mark two mjsunit tests as flaky.
The tests are blocking the v8 lkgr. They will be unmarked again after there
is
infrastructure to disable them on GC stress only.
TBR=mvstan...@chromium.org
BUG=
Please revie
Revision: 18697
Author: tit...@chromium.org
Date: Mon Jan 20 19:00:11 2014 UTC
Log: Fix representation requirement in HReturn.
BUG=
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/143523002
http://code.google.com/p/v8/source/detail?r=18697
Added:
/branches/bleedi
Committed patchset #1 manually as r18697 (presubmit successful).
https://codereview.chromium.org/143523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/143523002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Fix representation requirement in HReturn.
BUG=
Please review this at https://codereview.chromium.org/143523002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+18, -9 lines):
M src/hydrogen-instructions.h
M src/hydrog
Committed patchset #3 manually as r18696 (presubmit successful).
https://codereview.chromium.org/143213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
The test expectation needs a rebase. I'll add the test to test expectations
so we can land this. Once the V8 roll is complete I'll have to update the
test.
Today is a holiday in US so I'll do that tomorrow. I'll keep you informed.
On Mon, Jan 20, 2014 at 6:01 AM, wrote:
> On 2014/01/20 10:38:0
OKay, LGTM.
https://codereview.chromium.org/143213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4505
src/ia32/code-stubs-ia32.cc:4505: masm, DONT_TRACK_ALLOCATION_SITE,
NULL);
Goo
lgtm
https://codereview.chromium.org/143093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 18695
Author: joc...@chromium.org
Date: Mon Jan 20 15:44:03 2014 UTC
Log: Update Isolate::RequestGarbageCollection after r18691
BUG=none
R=hpa...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/143403002
http://code.google.com/p/v8/source/detail?r=18695
Modif
Committed patchset #2 manually as r18695 (presubmit successful).
https://codereview.chromium.org/143403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM
https://codereview.chromium.org/143403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Status: New
Owner:
New issue 3108 by alexandr...@gmail.com: LCodeGen::DoForInCacheArray() have
different deopt conditions on different archs
http://code.google.com/p/v8/issues/detail?id=3108
On x64 LCodeGen::DoForInCacheArray() deoptimizes if the result is a smi,
and on other archs if
Comment #2 on issue 3106 by pe...@olssononline.se: Build on ARM seems to be
broken - it adds "-m32" even if the compiler doesn't support it
http://code.google.com/p/v8/issues/detail?id=3106
Yes, I know about that flag, but shouldn't icu.gyp be modified to handle
this the same way as it's do
Reviewers: Hannes Payer,
Description:
Update Isolate::RequestGarbageCollection after r18691
BUG=none
R=hpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/143403002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -10 lines):
M
Comment #1 on issue 3106 by rodolph@gmail.com: Build on ARM seems to be
broken - it adds "-m32" even if the compiler doesn't support it
http://code.google.com/p/v8/issues/detail?id=3106
As you noted the issue is ICU related. You can use the option
i18nsupport=off to build without it.
Revision: 18694
Author: ma...@chromium.org
Date: Mon Jan 20 15:03:01 2014 UTC
Log: Experimental parser: add braces.
TBR=u...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/133343003
http://code.google.com/p/v8/source/detail?r=18694
Modified:
/branches/experimental/par
Reviewers: ulan,
Message:
Committed patchset #1 manually as r18694 (presubmit successful).
Description:
Experimental parser: add braces.
TBR=u...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=18694
Please review this at https://codereview.chromium.org/133343003/
S
lgtm
https://codereview.chromium.org/143363003/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/143363003/diff/1/src/parser.cc#newcode574
src/parser.cc:574: scanner_ = new ExperimentalScanner(source,
isolate());
Please wrap the branches in { } since they are in
Reviewers: ulan,
Message:
Committed patchset #1 manually as r18693 (presubmit successful).
Description:
Experimental parser: tiny fix for silly code.
TBR=u...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=18693
Please review this at https://codereview.chromium.org/
Revision: 18693
Author: ma...@chromium.org
Date: Mon Jan 20 14:51:54 2014 UTC
Log: Experimental parser: tiny fix for silly code.
TBR=u...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/143363003
http://code.google.com/p/v8/source/detail?r=18693
Modified:
/branches/exp
Hi Toon, cupla questions.
--Michael
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc
File src/ia32/code-stubs-ia32.cc (right):
https://codereview.chromium.org/143213003/diff/150001/src/ia32/code-stubs-ia32.cc#newcode4459
src/ia32/code-stubs-ia32.cc:4459: __ j(gr
Revision: 18692
Author: u...@chromium.org
Date: Mon Jan 20 14:46:43 2014 UTC
Log: Experimental lexer: add handling of sliced strings in SubStringKey
BUG=
R=dcar...@chromium.org
Review URL: https://codereview.chromium.org/143303002
http://code.google.com/p/v8/source/detail?r=18692
Mod
Committed patchset #2 manually as r18692 (presubmit successful).
https://codereview.chromium.org/143303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Status: New
Owner:
New issue 3107 by pe...@olssononline.se: Fails to build V8 3.24.14 with
snapshot on OSX, when compiling as shared libraries
http://code.google.com/p/v8/issues/detail?id=3107
The following errors occurs, it seems it tries to load icu libraries from a
location where th
Updates:
Status: Assigned
Owner: jkumme...@chromium.org
Cc: -jkumme...@chromium.org
Comment #6 on issue 3105 by svenpa...@chromium.org: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
@Jakob: Feel free to re-a
https://codereview.chromium.org/139343007/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/139343007/diff/1/src/heap.cc#newcode5609
src/heap.cc:5609: kReduceMemoryFootprintMask |
kAbortIncrementalMarkingMask,
On 2014/01/20 14:09:30, Michael Starzinger wrote:
This not
lgtm
https://codereview.chromium.org/143303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/143223004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #5 on issue 3105 by pe...@olssononline.se: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
Yes, correct. In Linux and Mac OSX this works as expected. But the solution
files generated for Windows still tries to build these p
Updates:
Cc: jkumme...@chromium.org
Comment #4 on issue 3105 by svenpa...@chromium.org: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
For Linux platforms, mksnapshot is definitely not generated with
snapshot=off. Either w
Committed patchset #3 manually as r18691 (presubmit successful).
https://codereview.chromium.org/139343007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18691
Author: hpa...@chromium.org
Date: Mon Jan 20 14:14:07 2014 UTC
Log: Enable incremental marking when --expose-gc is turned on.
BUG=
R=mstarzin...@chromium.org, u...@chromium.org
Review URL: https://codereview.chromium.org/139343007
http://code.google.com/p/v8/source/det
LGTM with one comment.
https://codereview.chromium.org/139343007/diff/1/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/139343007/diff/1/src/heap.cc#newcode5609
src/heap.cc:5609: kReduceMemoryFootprintMask |
kAbortIncrementalMarkingMask,
This not only removes the special h
Comment #3 on issue 3105 by pe...@olssononline.se: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
Thanks for your comment. However, as I said in my report, even when
providing -Dv8_use_snapshot=false when generating the Visual Stu
the idle notification changes lgtm
https://codereview.chromium.org/139343007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Updates:
Status: Invalid
Comment #2 on issue 3105 by svenpa...@chromium.org: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
As you've figure out already, to build with a snapshot, you would need to
be able to run target co
Reviewers: Michael Starzinger, ulan,
Description:
Enable incremental marking when --expose-gc is turned on.
BUG=
Please review this at https://codereview.chromium.org/139343007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+11, -14 lines):
M src/extensions/
Comment #3 on issue 3072 by pe...@olssononline.se: does not link when using
clang++ -stdlib=libc++
http://code.google.com/p/v8/issues/detail?id=3072
Has anyone succeeded to find a workaround for this? I had to give up static
linking on OSX, and use dynamic linking instead.
--
You received
Status: New
Owner:
New issue 3106 by pe...@olssononline.se: Build on ARM seems to be broken -
it adds "-m32" even if the compiler doesn't support it
http://code.google.com/p/v8/issues/detail?id=3106
It looks like it's ok for the actual V8 stuff, but the gyp file for ICU
doesn't seem to
Comment #1 on issue 3105 by pe...@olssononline.se: Not possible to build
x64 target on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
This problem occurs in a new module I've commited to FreeSWITCH, for more
detailed info look here: http://jira.freeswitch.org/browse
Status: New
Owner:
New issue 3105 by pe...@olssononline.se: Not possible to build x64 target
on a Windows 32-bit host
http://code.google.com/p/v8/issues/detail?id=3105
Due to the snapshot feature it's not possible to build Windows x64 target
using Visual Studio, when building on a 32-b
Updated, thx for comments!
--Michael
https://codereview.chromium.org/140963004/diff/30001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/140963004/diff/30001/src/arm/code-stubs-arm.cc#oldcode5627
src/arm/code-stubs-arm.cc:5627: __ CompareRoot(r5
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc#newcode7645
src/hydrogen.cc:7645: bounds_check, elements_kind, false);
Will do so.
On 2014/01/20 12:45:39, mvstanton wrote:
Can we mak
ping
https://codereview.chromium.org/138503008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: mvstanton,
Message:
PTAL
Description:
Turn ArrayPush into a stub specialized on the elements kind and argc.
BUG=
Please review this at https://codereview.chromium.org/143213003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+625, -731 lines):
M s
Hi Toon, looks great, I just have a couple comments.
thx,
--Michael
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/137783023/diff/1/src/hydrogen.cc#newcode7645
src/hydrogen.cc:7645: bounds_check, elements_kind, fals
Reviewers: dcarney, marja,
Message:
PTAL. I didn't go with GetFlatContent of a string because it is too
generic. It
checks for (sliced/seq/ext)*(one/two byte). Instead, I make sure that only
seq/ext strings are stored in SubStringKey. Since the char type is a
template,
this requires only on
Reviewers: Hannes Payer,
Message:
plz review
Description:
Move the management of the already swept pages to MarkCompactCollector
That way, MCC doesn't need to know about the state the threads are in to
steal free memory from them.
BUG=v8:3104
R=hpa...@chromium.org
LOG=n
Please review this at
Revision: 18690
Author: ma...@chromium.org
Date: Mon Jan 20 12:27:20 2014 UTC
Log: Fix *.py and *.jinja in build rules. They don't really work.
Unfortunately, the suggested way to get this to work is to list the files
explicitly.
TBR=u...@chromium.org
BUG=
Review URL: https://coderev
Reviewers: ulan,
Message:
Committed patchset #1 manually as r18690 (presubmit successful).
Description:
Fix *.py and *.jinja in build rules. They don't really work.
Unfortunately, the suggested way to get this to work is to list the files
explicitly.
TBR=u...@chromium.org
BUG=
Committed: http
https://codereview.chromium.org/140963004/diff/30001/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (left):
https://codereview.chromium.org/140963004/diff/30001/src/arm/code-stubs-arm.cc#oldcode5627
src/arm/code-stubs-arm.cc:5627: __ CompareRoot(r5,
Heap::kAllocationSiteMapRootIndex);
Reviewers: Benedikt Meurer,
Message:
Hi Benedikt, here is a CL that removes a dependency on a type cell in the
other
direction. No hurry, thanks for a look when you can,
--Michael
Description:
Array constructor shouldn't require a Cell, just an AllocationSite.
The Array constructor has a nee
Committed patchset #1 manually as r18689 (presubmit successful).
https://codereview.chromium.org/143063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18689
Author: joc...@chromium.org
Date: Mon Jan 20 11:57:56 2014 UTC
Log: Explicitly initialize MarkCompactCollector and ExternalStringTable
BUG=none
R=dcar...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/143063003
http://code.google.com/p/v8/source/detail?
On 2014/01/20 11:30:55, rmcilroy wrote:
Committed patchset #5 manually as r18688 (presubmit successful).
I just landed this. Thanks for the fix Mostyn!
https://codereview.chromium.org/131823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #5 manually as r18688 (presubmit successful).
https://codereview.chromium.org/131823004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18688
Author: rmcil...@chromium.org
Date: Mon Jan 20 11:30:48 2014 UTC
Log: DoubleToIStub can't use ip on armv6, because the ubfx impl will
clobber it
This previous change broke DoubleToIStub on armv6:
https://code.google.com/p/v8/source/detail?r=16322
The problem is that
Reviewers: dcarney, Sven Panne,
Message:
PTAL. This is a cherry-pick from experimental lexer.
Description:
Generalize internalization of substrings.
Make a template version of SubStringKey, which allows internalization of
substrings of sequential and external strings.
R=svenpa...@chromium.org,
Issue 3102: V8 should not use non-POD function static variables
http://code.google.com/p/v8/issues/detail?id=3102
This issue is now blocking issue chromium:333871.
See http://code.google.com/p/chromium/issues/detail?id=333871
--
You received this message because you are listed in the owner
or CC
On 2014/01/20 10:38:09, Dmitry Lomov (chromium) wrote:
Committed patchset #4 manually as r18685 (presubmit successful).
Reverted in r18687 for breaking webkit tests:
http://build.chromium.org/p/client.v8/builders/V8%20Linux64/builds/8452/steps/OptimizeForSize/logs/stdio
https://codereview.chro
Revision: 18687
Author: dslo...@chromium.org
Date: Mon Jan 20 10:59:07 2014 UTC
Log: Revert "ES6: Implement Object.setPrototypeOf"
This reverts commit r18685 for breaking WebKit tests.
TBR=a...@chromium.org
http://code.google.com/p/v8/source/detail?r=18687
Deleted:
/branches/bleedin
Updates:
Status: Fixed
Comment #6 on issue 1775 by joc...@chromium.org: d8.gyp should allow
building d8#host for chrome/chrome_tests.gypi:browser_tests
http://code.google.com/p/v8/issues/detail?id=1775
(No comment was entered for this change.)
--
You received this message because thi
Reviewers: marja,
Message:
Committed patchset #1 manually as r18686 (presubmit successful).
Description:
Experimental lexer: fix style issues.
TBR=ma...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=18686
Please review this at https://codereview.chromium.org/143223002/
Revision: 18686
Author: u...@chromium.org
Date: Mon Jan 20 10:43:27 2014 UTC
Log: Experimental lexer: fix style issues.
TBR=ma...@chromium.org
Review URL: https://codereview.chromium.org/143223002
http://code.google.com/p/v8/source/detail?r=18686
Modified:
/branches/experimental/par
lgtm
https://codereview.chromium.org/143063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #4 manually as r18685 (presubmit successful).
https://codereview.chromium.org/141913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18685
Author: dslo...@chromium.org
Date: Mon Jan 20 10:38:01 2014 UTC
Log: ES6: Implement Object.setPrototypeOf
http://people.mozilla.org/~jorendorff/es6-draft.html#sec-object.setprototypeof
This just exposes the internal %SetPrototype and adds all the required
type checks a
Reviewers: dcarney,
Message:
plz review
Description:
Explicitly initialize MarkCompactCollector and ExternalStringTable
BUG=none
R=dcar...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/143063003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affect
On 2014/01/20 10:27:50, rossberg wrote:
lgtm
I'll land
https://codereview.chromium.org/141913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscr
lgtm
https://codereview.chromium.org/141913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 18684
Author: u...@chromium.org
Date: Mon Jan 20 09:56:42 2014 UTC
Log: Merge missing r18658 from bleeding_edge and add missing files.
BUG=
TBR=ma...@chromium.org
Review URL: https://codereview.chromium.org/138843005
http://code.google.com/p/v8/source/detail?r=18684
Added:
Reviewers: marja,
Message:
Committed patchset #2 manually as r18684 (presubmit successful).
Description:
Merge missing r18658 from bleeding_edge and add missing files.
BUG=
TBR=ma...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=18684
Please review this at https://coder
I ran golem jobs against r18668
https://codereview.chromium.org/143193002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
Committed patchset #9 manually as r18683 (presubmit successful).
https://codereview.chromium.org/121173009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18683
Author: dcar...@chromium.org
Date: Mon Jan 20 09:52:54 2014 UTC
Log: String:WriteUtf8: Add REPLACE_INVALID_UTF8 option
This patch makes String::WriteUtf8 replace invalid code points (i.e.
unmatched
surrogates) with the unicode replacement character when
REPLACE_INVA
Revision: 18682
Author: mvstan...@chromium.org
Date: Mon Jan 20 09:48:05 2014 UTC
Log: We no longer need to recover type cells from the oracle.
We only need the values within them. Function calls to Array from optimized
code needed the cell in the past, but no longer.
R=bmeu...@chr
Committed patchset #2 manually as r18682 (presubmit successful).
https://codereview.chromium.org/141893002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Hannes Payer,
Message:
plz review
Description:
Move the temporary private freelist closer to where it's used
BUG=v8:3104
R=hpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/143193002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affe
1 - 100 of 107 matches
Mail list logo
