Reviewers: Sven Panne,
Message:
Trivial cleanup. PTAL.
Description:
Use IfBuilder instead of handcrafted basic blocks in GenerateSetValueOf().
Please review this at https://codereview.chromium.org/130563009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+16, -
Revision: 18893
Author: bmeu...@chromium.org
Date: Wed Jan 29 07:27:35 2014 UTC
Log: Kill obsolete HLoadExternalArrayPointer instruction.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/141583011
http://code.google.com/p/v8/source/detail?r=18893
Modified:
/branc
Updates:
Status: Fixed
Comment #6 on issue 3069 by svenpa...@chromium.org: Map and Set should
consider +0 and -0 the same
http://code.google.com/p/v8/issues/detail?id=3069
Fix landed: https://code.google.com/p/v8/source/detail?r=18892
--
You received this message because this project
Committed patchset #1 manually as r18893 (presubmit successful).
https://codereview.chromium.org/141583011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18892
Author: svenpa...@chromium.org
Date: Wed Jan 29 07:27:05 2014 UTC
Log: ES6: Map and Set needs to normalize minus zero
BUG=v8:3069
LOG=Y
R=rossb...@chromium.org
Review URL: https://codereview.chromium.org/147143003
http://code.google.com/p/v8/source/detail?r=18892
Modi
Committed patchset #2 manually as r18892 (presubmit successful).
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r18891 (presubmit successful).
https://codereview.chromium.org/148453009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18891
Author: bmeu...@chromium.org
Date: Wed Jan 29 07:26:52 2014 UTC
Log: Both HGlobalObject and HGlobalReceiver can be replaced with
HLoadNamedField.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/148453009
http://code.google.com/p/v8/source/detail
lgtm
https://codereview.chromium.org/148453009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/141583011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Fixed
Owner: verwa...@chromium.org
Comment #1 on issue 3123 by verwa...@chromium.org: v8 fails to learn about
the holeyness of an array
http://code.google.com/p/v8/issues/detail?id=3123
Thanks for the report Ryan. I'm entirely rewriting the way we handle calls
Status: New
Owner:
New issue 3123 by rsturg...@google.com: v8 fails to learn about the
holeyness of an array
http://code.google.com/p/v8/issues/detail?id=3123
I have some repeated deopts in a function which calls other functions found
in an array (see simplified repro below).
It seem
Hey Jochen, does this (PS3) works for you?
https://codereview.chromium.org/145583014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this g
LGTM. Sven, could you please land this? I don't have access to a suitable
machine right now.
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
Thanks for fixing this! Mea culpa...
https://codereview.chromium.org/132633005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group a
Reviewers: Sven Panne,
Message:
No comment.
Description:
Kill obsolete HLoadExternalArrayPointer instruction.
Please review this at https://codereview.chromium.org/141583011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -160 lines):
M src/arm/lithium-ar
Reviewers: Sven Panne,
Message:
Kill all the redundant Hydrogen instructions!
Description:
Both HGlobalObject and HGlobalReceiver can be replaced with HLoadNamedField.
Please review this at https://codereview.chromium.org/148453009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edg
Revision: 18890
Author: pal...@homejinni.com
Date: Tue Jan 28 20:26:53 2014 UTC
Log: MIPS: Fix global object loading in DoWrapReceiver.
This commit fixes the global object loading to load the result into
the "result" register instead of the "receiver" register.
TEST=mjsunit/compile
Committed patchset #1 manually as r18890 (presubmit successful).
https://codereview.chromium.org/132633005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r18889 (presubmit successful).
https://codereview.chromium.org/134903004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18889
Author: pal...@homejinni.com
Date: Tue Jan 28 20:25:38 2014 UTC
Log: ARM: Fix global object loading in DoWrapReceiver.
This commit fixes the global object loading to load the result into
the "result" register instead of the "receiver" register.
BUG=
R=verwa...@chrom
Also lgtm, thanks Toon.
https://codereview.chromium.org/132633005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop recei
lgtm
https://codereview.chromium.org/132633005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/134903004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Paul Lind, kisg, kilvadyb, dusmil, danno, Jakob, Toon Verwaest,
Message:
This CL is the ARM port of: https://codereview.chromium.org/132633005
PTAL.
Description:
ARM: Fix global object loading in DoWrapReceiver.
This commit fixes the global object loading to load the result into
t
Reviewers: Paul Lind, kisg, kilvadyb, dusmil, danno, Toon Verwaest,
Message:
PTAL.
Description:
MIPS: Fix global object loading in DoWrapReceiver.
This commit fixes the global object loading to load the result into
the "result"
register instead of the "receiver" register.
TEST=mjsunit/compi
https://codereview.chromium.org/103243005/diff/31/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/103243005/diff/31/src/deoptimizer.cc#newcode3195
src/deoptimizer.cc:3195: prev_materialized_count_ =
previously_materialized_objects_.is_null() ?
On 2014/
Reviewers: ulan,
Description:
Consistenly use stderr for printing simulator and debug messages
stdout is buffered, so if we crash, we don't see the last messages
LOG=n
BUG=none
R=u...@chromium.org
Please review this at https://codereview.chromium.org/132233055/
SVN Base: https://v8.googlecode
Reviewers: ulan,
Description:
Don't prefix %p format with 0x
%p will automatically print 0x
BUG=none
R=u...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/137023011/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+2, -2 lines):
M
Revision: 1
Author: bmeu...@chromium.org
Date: Tue Jan 28 19:11:13 2014 UTC
Log: v8config.h: introduce V8_LIBC_MSVCRT
Use this for detecting MSVCRT library features instead of
V8_CC_MSVC.
One use case for this is when compiling with Clang together with the
MSVC library. In that ca
Committed patchset #4 manually as r1 (presubmit successful).
https://codereview.chromium.org/145593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM, thanks. I'll land it.
https://codereview.chromium.org/145593003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
On 2014/01/28 07:42:07, Sven Panne wrote:
On 2014/01/28 05:34:03, Benedikt Meurer wrote:
> Hm, thinking about this again: The problem is that we depend on
V8_CC_MSVC
to
> actually detect the MS C runtime, right? Wouldn't it make sense to
introduce
> V8_LIBC_MSVCRT and fix relevant uses of V
Updated. PTAL
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
LGTM, thanks. Got dropped during the rebase hell in december.
https://codereview.chromium.org/147763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Status: New
Owner:
New issue 3122 by mathi...@opera.com: Use the new `CHECK_OBJECT_COERCIBLE`
macro everywhere we can
http://code.google.com/p/v8/issues/detail?id=3122
Patch coming.
--
You received this message because this project is configured to send all
issue notifications to this
Revision: 18887
Author: ish...@chromium.org
Date: Tue Jan 28 17:49:13 2014 UTC
Log: Fix for potential issue related to replacing CheckMaps with
values.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/134733007
http://code.google.com/p/v8/source/detail?r=18887
Mod
Committed patchset #3 manually as r18887 (presubmit successful).
https://codereview.chromium.org/134733007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: titzer,
https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/134733007/diff/1/src/hydrogen.cc#newcode3922
src/hydrogen.cc:3922:
instruction->DeleteAndReplaceWith(instruction->ActualValue());
On 2014/01/23 18:34
Committed patchset #1 manually as r18886 (presubmit successful).
https://codereview.chromium.org/148263012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Rodolph Perfetta (ARM),
Message:
PTAL
https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.cc
File src/a64/code-stubs-a64.cc (right):
https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.cc#newcode2744
src/a64/code-stubs-a64.cc:2744:
Pro
Revision: 18886
Author: m.m.capew...@googlemail.com
Date: Tue Jan 28 17:32:54 2014 UTC
Log: A64: Rejig truncating and non double to i/smi
Replace existing DoubleToI/DoubleToSmi instructions with truncating and non-
truncating versions. This allows reuse of common code, register constra
Makes sense, lgtm
https://codereview.chromium.org/101123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving e
lgtm
https://codereview.chromium.org/148263012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: New
Owner:
New issue 3121 by kkooporat...@googlemail.com: typeof vs instanceof vs
constructor
http://code.google.com/p/v8/issues/detail?id=3121
I stumbled over an issue while we've been optimizing our code in production.
Why is it that typeof foo === "bar" is so much faster than
:) Mihai and I just talked about it. It should be landed, but I didn't have
time to do it. I'll do it today.
2014/1/27
> What's the state of this CL? If it's not necessary anymore, let's close it,
> otherwise let's land it... :-)
>
> https://codereview.chromium.org/68133016/
>
--
Nebojša Ći
Reviewers: Rodolph Perfetta (ARM), baptiste.afsa1,
Description:
A64: Rejig truncating and non double to i/smi
Replace existing DoubleToI/DoubleToSmi instructions with truncating and non-
truncating versions. This allows reuse of common code, register constraints
and environment requirements.
Al
On 2014/01/28 13:14:00, jochen wrote:
i think it would be preferable to have a src/base/ or something where
shared
headers are instead of duplicating the definitions
Will we have a src/base/globals.h, I suppose. I'll cook something like this
and
ping you back.
https://chromiumcodereview.a
Committed patchset #2 manually as r18885 (presubmit successful).
https://codereview.chromium.org/144013003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18885
Author: ish...@chromium.org
Date: Tue Jan 28 16:57:39 2014 UTC
Log: Flow engine fixes: unreachable block processing, state merging.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/144013003
http://code.google.com/p/v8/source/detail?r=18885
Modified:
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/144013003/diff/1/src/hydrogen-check-elimination.cc#newcode176
src/hydrogen-check-elimination.cc:176: void Merge(HBasicBlock* succ,
HC
PTAL, I removed double field tracking flag from StoreNamedField too.
https://codereview.chromium.org/101123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
lgtm
https://codereview.chromium.org/143413019/diff/21/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/143413019/diff/21/src/hydrogen-instructions.h#newcode6646
src/hydrogen-instructions.h:6646: // Preinitializing stores are made
o
https://codereview.chromium.org/143413019/diff/21/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/143413019/diff/21/src/hydrogen-instructions.h#newcode6646
src/hydrogen-instructions.h:6646: // Preinitializing stores are made
only to j
Revision: 18884
Author: ish...@chromium.org
Date: Tue Jan 28 16:45:04 2014 UTC
Log: Load elimination fix with a test case.
R=tit...@chromium.org, verwa...@chromium.org
Review URL: https://codereview.chromium.org/143413019
http://code.google.com/p/v8/source/detail?r=18884
Modified:
/
Committed patchset #4 manually as r18884 (presubmit successful).
https://codereview.chromium.org/143413019/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: jarin,
Message:
PTAL
Description:
Remove CallICs
BUG=
Please review this at https://codereview.chromium.org/148223002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+771, -3275 lines):
M src/accessors.h
M src/accessors.cc
M src/arm/stub-cache
Committed patchset #1 manually as r18883 (presubmit successful).
https://codereview.chromium.org/148153010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/148153010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/148153010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Using key === 0 will work. I didn't think of that. Thanks.
On Jan 27, 2014 11:35 PM, wrote:
> Quick DBC...
>
>
> https://codereview.chromium.org/147143003/diff/30001/src/collection.js
> File src/collection.js (right):
>
> https://codereview.chromium.org/147143003/diff/30001/src/
> collection.js#n
Reviewers: m.m.capewell, Rodolph Perfetta (ARM),
Description:
Synchronize with r15701.
This brings experimental/a64 up to 2013-07-17.
BUG=none
Please review this at https://codereview.chromium.org/148153010/
SVN Base: https://v8.googlecode.com/svn/branches/experimental/a64
Affected files (+5
Committed patchset #1 manually as r18882 (presubmit successful).
https://codereview.chromium.org/147763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18882
Author: hpa...@chromium.org
Date: Tue Jan 28 15:43:28 2014 UTC
Log: Allocation site pretenuring for StringAdd on all platforms.
BUG=
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/147763005
http://code.google.com/p/v8/source/detail?r=18882
Modifi
https://codereview.chromium.org/103243005/diff/31/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/103243005/diff/31/src/deoptimizer.cc#newcode3195
src/deoptimizer.cc:3195: prev_materialized_count_ =
previously_materialized_objects_.is_null() ?
nit: fun
Reviewers: mvstanton,
Message:
PTAL
Description:
Extend ArrayPop hydrogen support to COW arrays and popping from empty
arrays.
R=mvstan...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/148093009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Aff
That is very nice, so we only did it for ia32?
lgtm.
https://codereview.chromium.org/147763005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Reviewers: mvstanton, Benedikt Meurer,
Description:
Allocation site pretenuring for StringAdd on all platforms.
BUG=
Please review this at https://codereview.chromium.org/147763005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M src/arm/lithi
LGTM, modulo Sven's comment
https://codereview.chromium.org/147143003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
Reviewers: mvstanton,
Message:
Kill all the native code stubs! :-)
PTAL
Description:
Turn RegExpConstructResultStub into a HydrogenCodeStub.
This has the additional benefit that it is now possible to
inline the RegExpResult construction code into Hydrogen
builtins.
Please review this at https
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode65
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
On 2014/01/28 12:13:23, ulan wrote:
Committed patchset #1 manually as r18881 (presubmit successful).
https://codereview.chromium.org/148883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/148883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
For the record: I have a Hydrogen version of this stub, in case this causes
regressions in some important benchmarks.
https://codereview.chromium.org/148873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: m.m.capewell, Rodolph Perfetta (ARM),
Description:
Synchronize with r15594.
This brings experimental/a64 up to 2013-07-10.
R=rodolph.perhe...@arm.com,m.m.capew...@googlemail.com
BUG=none
Please review this at https://codereview.chromium.org/148883002/
SVN Base: https://v8.googlecod
Committed patchset #1 manually as r18880 (presubmit successful).
https://codereview.chromium.org/148873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18880
Author: bmeu...@chromium.org
Date: Tue Jan 28 13:43:04 2014 UTC
Log: Drop the native FastNewBlockContextStub.
This code is almost never executed in real world and benchmarks,
and there's obviously absolutely no need to have this native code
hanging around for no benefit
lgtm
https://codereview.chromium.org/148873002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Message:
Kick all the premature optimizations!
Description:
Drop the native FastNewBlockContextStub.
This code is almost never executed in real world and benchmarks,
and there's obviously absolutely no need to have this native code
hanging around for no benefit.
Please r
On 2014/01/28 12:28:45, Jakob wrote:
DBC.
I'm not super happy with changing behavior on simulator vs non-simulator
runs,
but if you guys think this makes more sense than any alternative (always
run,
always skip, always mark as timeout), then that's OK with me.
https://codereview.chromiu
Committed patchset #3 manually as r18879 (presubmit successful).
https://codereview.chromium.org/148273008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 18879
Author: joc...@chromium.org
Date: Tue Jan 28 13:29:19 2014 UTC
Log: SaveCallerSaveRegsisters needs to save all caller-save registers
While the macro assembler uses them as scratch registers, we need to
save them when calling out to builtins. In debug mode, the simulator
Nice catch. x8 and x9 used to be temp in the macro assembler. Not anymore.
lgtm with nit addressed.
https://codereview.chromium.org/148273008/diff/20001/src/a64/code-stubs-a64.h
File src/a64/code-stubs-a64.h (right):
https://codereview.chromium.org/148273008/diff/20001/src/a64/code-stubs-a64.
i think it would be preferable to have a src/base/ or something where shared
headers are instead of duplicating the definitions
https://chromiumcodereview.appspot.com/145583014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
lgtm
https://codereview.chromium.org/148273008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
no, i think this can be landed
https://chromiumcodereview.appspot.com/125133002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
ptal
https://codereview.chromium.org/148273008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: ulan,
Description:
SaveCallerSaveRegsisters needs to save all caller-save registers
While the macro assembler uses them as scratch registers, we need to
save them when calling out to builtins. In debug mode, the simulator
will clobber all registers after a call to a builtin which make
DBC.
I'm not super happy with changing behavior on simulator vs non-simulator
runs,
but if you guys think this makes more sense than any alternative (always
run,
always skip, always mark as timeout), then that's OK with me.
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctes
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode71
test/cctest/cctest.status:71: test-api/ExternalDoubleArray: SKIP
On 2014/01/28 12:13:23, ulan wr
lgtm
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status
File test/cctest/cctest.status (right):
https://codereview.chromium.org/137543009/diff/1/test/cctest/cctest.status#newcode65
test/cctest/cctest.status:65: test-api/ExternalArrays: SKIP
Maybe 'PASS || TIMEOUT' instea
Revision: 18878
Author: mvstan...@chromium.org
Date: Tue Jan 28 11:53:11 2014 UTC
Log: We shouldn't throw under FLAG_debug_code, rather abort.
Throwing under FLAG_debug_code confuses the rest of our infrastructure
which expects a safe point at the site of call into the runtime
for thro
Committed patchset #2 manually as r18878 (presubmit successful).
https://codereview.chromium.org/139903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/137543009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, CF is ready.
https://codereview.chromium.org/139903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Comment #3 on issue 3099 by wi...@igalia.com: next(value) call to newly
created generator should throw TypeError
http://code.google.com/p/v8/issues/detail?id=3099
As noted on the CL, there appears to be some discussion about this
behavior: https://github.com/tc39/agendas/pull/25. We'll wai
Reviewers: Rodolph Perfetta (ARM), ulan,
Message:
Committed patchset #1 manually as r18877 (presubmit successful).
Description:
A64: Ensure String::kContainsCachedArrayIndexMask is a uint32 constant.
BUG=
R=rodolph.perfe...@arm.com, u...@chromium.org
Committed: https://code.google.com/p/v8/sou
Revision: 18877
Author: baptiste.a...@arm.com
Date: Tue Jan 28 11:34:10 2014 UTC
Log: A64: Ensure String::kContainsCachedArrayIndexMask is a uint32
constant.
BUG=
R=rodolph.perfe...@arm.com, u...@chromium.org
Review URL: https://codereview.chromium.org/136453016
http://code.google.
lgtm
https://codereview.chromium.org/136453016/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Rodolph Perfetta (ARM), ulan, jochen,
Message:
Hello,
This one touches some global files, so adding reviewers from Google.
This patch allows to filter tests according to if we are running on the
simulator.
Alexandre
Description:
Introduce a parameter to skip slow tests when running
1 - 100 of 133 matches
Mail list logo
