Status: New
Owner:
New issue 3159 by rsturg...@google.com: Garbled typed array error messages
http://code.google.com/p/v8/issues/detail?id=3159
new Uint32Array(new ArrayBuffer(100), 2, 8);
throws an error with this message:
"RangeError: softshould be a multiple ofr"
Similarly for an inva
Comment #7 on issue 2672 by johnjbar...@chromium.org: Object.create,
Explicit "writable:false" results in error with setter/getters
http://code.google.com/p/v8/issues/detail?id=2672
Please reopen this issue with a new title:
Incorrect error message for Object.defineProperty() with writable:
Revision: 19344
Author: rafa...@chromium.org
Date: Wed Feb 12 22:04:19 2014 UTC
Log: V8 Microtask Queue & API
This patch generalizes Object.observe callbacks and promise resolution into
a FIFO queue called a "microtask queue".
It also exposes new V8 API which exposes the microtask
Committed patchset #9 manually as r19344 (presubmit successful).
https://codereview.chromium.org/154283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
I know that this is massively annoying, but AtomicWord that could
participate in
a data race should never be cast to a normal pointer (undefined behavior in
C++11). Instead, you should always use the Store/Load function to access the
atomic memory. Sadly, this might require some pretty awkward c
Thanks for your help, everyone.
https://codereview.chromium.org/154283002/diff/180001/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/154283002/diff/180001/include/v8.h#newcode5421
include/v8.h:5421: static const int kEmptyStringRootIndex = 148;
Got it. Thanks. What is g
Committed as r19343.
https://codereview.chromium.org/160713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 19343
Author: plin...@gmail.com
Date: Wed Feb 12 18:55:33 2014 UTC
Log: MIPS: Omit redundant smi checks in write barriers.
Port r19323 (929c047)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/160713002
Patch from Balazs Kilvady .
http://code.google.co
Revision: 19342
Author: verwa...@chromium.org
Date: Wed Feb 12 18:48:12 2014 UTC
Log: Reland: "Use stability to only conditionally flush information
from the CheckMaps table."
BUG=
R=ish...@chromium.org
Original CL: https://codereview.chromium.org/153823003
Review URL: https://cod
lgtm
https://codereview.chromium.org/160713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r19342 (presubmit successful).
https://codereview.chromium.org/153653007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/153653007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
pTAL
Description:
Reland: "Use stability to only conditionally flush information from the
CheckMaps table."
BUG=
R=ish...@chromium.org
Original CL: https://codereview.chromium.org/153823003
Please review this at https://codereview.chromium.org/153653007/
SV
Reviewers: danno, Benedikt Meurer, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Omit redundant smi checks in write barriers.
Port r19323 (929c047)
BUG=
Please review this at https://codereview.chromium.org/160713002/
SVN Base: https://github.com/v8/v8.git@gbl
Affected files (+6, -3 li
Committed patchset #2 manually as r19341 (presubmit successful).
https://codereview.chromium.org/147023005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19341
Author: verwa...@chromium.org
Date: Wed Feb 12 18:30:41 2014 UTC
Log: Don't propagate information through phis in loop headers.
To properly do this, we'd have to iterate over CompareMaps (and their
bodies) handling phis, until we have learned enough to decide which pat
lgtm
https://codereview.chromium.org/147023005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko, titzer,
Message:
PTAL
Description:
Don't propagate information through phis in loop headers.
To properly do this, we'd have to iterate over CompareMaps (and their
bodies)
handling phis, until we have learned enough to decide which paths can be
taken.
For now, just
Committed patchset #1 manually as r19340 (presubmit successful).
https://codereview.chromium.org/160633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19340
Author: rmcil...@chromium.org
Date: Wed Feb 12 18:22:28 2014 UTC
Log: [a64]: Disable failing sparse-array-reverse on a64 debug builds.
BUG=v8:3158
LOG=N
R=u...@chromium.org
Review URL: https://codereview.chromium.org/160633002
http://code.google.com/p/v8/source/detail?
lgtm
https://codereview.chromium.org/160633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan,
Description:
[a64]: Disable failing sparse-array-reverse on a64 debug builds.
BUG=v8:3158
LOG=N
Please review this at https://codereview.chromium.org/160633002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -0 lines):
M test/mjsunit/mjsu
Comment #1 on issue 3158 by rmcil...@chromium.org: A64:
mjsunit/sparse-array-reverse fails on no_snap
http://code.google.com/p/v8/issues/detail?id=3158
This appears to have been triggered by r19325, specifically by the removal
of the "if (!FLAG_disable_native_files)" around the code:
Status: Accepted
Owner:
CC: rmcil...@chromium.org, joc...@chromium.org, u...@chromium.org,
rodolph@arm.com, jacob.bram...@arm.com
Labels: Type-Bug Priority-Medium
New issue 3158 by rmcil...@chromium.org: A64: mjsunit/sparse-array-reverse
fails on no_snap
http://code.google.com/
Updates:
Status: Duplicate
Mergedinto: v8:287
Comment #1 on issue 3100 by yang...@chromium.org: RegEx is hanging in
Chrome 31.0.1650.63
http://code.google.com/p/v8/issues/detail?id=3100
(No comment was entered for this change.)
--
You received this message because this projec
Comment #12 on issue 287 by yang...@chromium.org: Long, complex regexp
pattern (in WebKit layout test) hangs
http://code.google.com/p/v8/issues/detail?id=287
Issue 3100 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifi
Comment #2 on issue 3119 by yang...@chromium.org: import _multiprocessing
problem
http://code.google.com/p/v8/issues/detail?id=3119
Looks like a Python issue, and the traceback doesn't look complete.
--
You received this message because this project is configured to send all
issue notifica
Updates:
Status: Invalid
Comment #1 on issue 3121 by yang...@chromium.org: typeof vs instanceof vs
constructor
http://code.google.com/p/v8/issues/detail?id=3121
Please address questions like that to the v8-users mailing list.
Short answer is that there is an optimization in place for
Revision: 19339
Author: ish...@chromium.org
Date: Wed Feb 12 17:31:29 2014 UTC
Log: KeyedLoadIC::GenerateGeneric() fix for MIPS.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/160353003
http://code.google.com/p/v8/source/detail?r=19339
Modified:
/branches/bleedi
LGTM with comments.
https://codereview.chromium.org/140683011/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
https://codereview.chromium.org/140683011/diff/1/src/hydrogen-instructions.h#newcode1170
src/hydrogen-instructions.h:1170: // TODO(vegorov): what we really
Committed patchset #1 manually as r19339 (presubmit successful).
https://codereview.chromium.org/160353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/160353003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
I noticed inconsistency between architectures, PTAL.
Description:
KeyedLoadIC::GenerateGeneric() fix for MIPS.
Please review this at https://codereview.chromium.org/160353003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3,
Committed patchset #1 manually as r19338 (presubmit successful).
https://codereview.chromium.org/148063008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19338
Author: yang...@chromium.org
Date: Wed Feb 12 16:18:18 2014 UTC
Log: Fix test-heap/OptimizedPretenuringAllocationFolding wrt
concurrent recompilation delay.
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/148063008
http://code.google.com/p/v8/sourc
lgtm
https://codereview.chromium.org/148063008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/138953018/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/138953018/diff/1/src/spaces.cc#newcode2085
src/spaces.cc:2085: if
(NoBarrier_Load(reinterpret_cast(&category->top_)) != 0) {
On 2014/02/12 14:09:02, jarin wrote:
You should
Revision: 19337
Author: yang...@chromium.org
Date: Wed Feb 12 16:08:05 2014 UTC
Log: Tagging version 3.22.24.21
http://code.google.com/p/v8/source/detail?r=19337
Added:
/tags/3.22.24.21
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Revision: 19336
Author: yang...@chromium.org
Date: Wed Feb 12 16:07:47 2014 UTC
Log: Merged r19031 into 3.22 branch.
Fix short-circuiting logical and/or in HOptimizedGraphBuilder.
BUG=336148
LOG=N
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/160543002
http://c
Committed patchset #1 manually as r19336.
https://codereview.chromium.org/160543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
lgtm
https://codereview.chromium.org/160543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Merged r19031 into 3.22 branch.
Fix short-circuiting logical and/or in HOptimizedGraphBuilder.
BUG=336148
LOG=N
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/160543002/
SVN Base: https://v8.googlecode.com/svn/branches/3.22
Affec
Revision: 19335
Author: yang...@chromium.org
Date: Wed Feb 12 16:03:28 2014 UTC
Log: Tagging version 3.23.17.13
http://code.google.com/p/v8/source/detail?r=19335
Added:
/tags/3.23.17.13
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You r
Committed patchset #1 manually as r19334.
https://codereview.chromium.org/155643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
Revision: 19334
Author: yang...@chromium.org
Date: Wed Feb 12 16:03:10 2014 UTC
Log: Merged r19031 into 3.23 branch.
Fix short-circuiting logical and/or in HOptimizedGraphBuilder.
BUG=336148
LOG=N
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/155643003
http://c
On 2014/02/12 16:01:05, aperez wrote:
I have rebased the patch after the latest changes in the parser
(FunctionState
et al.). Also, this new version moves the "allow_arrow_functions_" flag to
ParserBase.
Thank you,
however, you'll still have to go through the "new feature process" before as
Reviewers: Jakob,
Description:
Merged r19031 into 3.23 branch.
Fix short-circuiting logical and/or in HOptimizedGraphBuilder.
BUG=336148
LOG=N
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/155643003/
SVN Base: https://v8.googlecode.com/svn/branches/3.23
Affec
lgtm
https://codereview.chromium.org/155643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
I have rebased the patch after the latest changes in the parser
(FunctionState
et al.). Also, this new version moves the "allow_arrow_functions_" flag to
ParserBase.
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
Reviewers: Hannes Payer,
Description:
Fix test-heap/OptimizedPretenuringAllocationFolding wrt concurrent
recompilation
delay.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/148063008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Updates:
Status: Fixed
Comment #8 on issue 2342 by vse...@chromium.org: Support sourceURL for
dynamically inserted scripts.
http://code.google.com/p/v8/issues/detail?id=2342
Committed patchset #1 manually as r19333 (presubmit successful).
--
You received this message because this pro
Committed patchset #1 manually as r19333 (presubmit successful).
https://codereview.chromium.org/143283015/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19333
Author: a...@chromium.org
Date: Wed Feb 12 15:50:23 2014 UTC
Log: Stack trace string should use dynamic script sourceURL if present.
BUG=v8:2342
R=dcar...@chromium.org, yu...@chromium.org, yurys
LOG=N
Review URL: https://codereview.chromium.org/143283015
http://code.go
On 2014/02/12 15:33:19, Hannes Payer wrote:
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685
src/spaces.h:685: AtomicWord prev_chunk_;
On 2014/02/12 14:06:39, jarin wrote:
>
Revision: 19332
Author: hpa...@chromium.org
Date: Wed Feb 12 15:40:23 2014 UTC
Log: Make prev and next pointer in pages list AtomicWords and access
them using acquire/release semantics.
BUG=
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/150413009
http://code.goog
Committed patchset #3 manually as r19332 (presubmit successful).
https://codereview.chromium.org/150413009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19331
Author: verwa...@chromium.org
Date: Wed Feb 12 15:38:42 2014 UTC
Log: Revert "Use stability to only conditionally flush information
from the CheckMaps table."
R=ish...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/137863005
http://code.google.com/p/v
Committed patchset #1 manually as r19331 (tree was closed).
https://codereview.chromium.org/137863005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm
https://codereview.chromium.org/137863005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
Due to buildbot failures. Will investigate.
Description:
Revert "Use stability to only conditionally flush information from the
CheckMaps
table."
R=ish...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/137863005/
SVN Base: https:/
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685
src/spaces.h:685: AtomicWord prev_chunk_;
On 2014/02/12 14:06:39, jarin wrote:
Perhaps it would be better to add a comment de
LGTM... with the caveat that we'll have to turn it off again for the branch
if
unexplained crashes start showing up.
https://codereview.chromium.org/139983008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Jakob,
Description:
Enable concurrent OSR.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/139983008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/flag-definitions.h
Index: src/flag-definition
lgtm, but don't forget to support a64.
https://codereview.chromium.org/65413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
Revision: 19330
Author: verwa...@chromium.org
Date: Wed Feb 12 15:07:41 2014 UTC
Log: Use stability to only conditionally flush information from the
CheckMaps table.
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/153823003
http://code.google.com/p/v8/source/
Committed patchset #5 manually as r19330 (presubmit successful).
https://codereview.chromium.org/153823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/153823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Addressed comments
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode212
src/hydrogen-check-elimination.cc:212: // I
On 2014/02/12 14:58:07, Yang wrote:
In a rare twist, only fullcodegen, not crankshaft, is affected.
https://codereview.chromium.org/159903008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Reviewers: rossberg,
Description:
Fix assignment of function name constant.
If it's shadowed by a variable of the same name and both are forcibly
context-allocated, the function is assigned to the wrong context slot.
R=rossb...@chromium.org
BUG=v8:3138
LOG=Y
Please review this at https://code
https://codereview.chromium.org/138953018/diff/1/src/spaces.cc
File src/spaces.cc (right):
https://codereview.chromium.org/138953018/diff/1/src/spaces.cc#newcode2085
src/spaces.cc:2085: if
(NoBarrier_Load(reinterpret_cast(&category->top_)) != 0) {
You should change the FreeListCategory::top_ fie
lgtm with a nit.
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h
File src/spaces.h (right):
https://codereview.chromium.org/150413009/diff/30001/src/spaces.h#newcode685
src/spaces.h:685: AtomicWord prev_chunk_;
Perhaps it would be better to add a comment describing the type of
Committed patchset #1 manually as r19329 (presubmit successful).
https://codereview.chromium.org/159513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19329
Author: ish...@chromium.org
Date: Wed Feb 12 13:54:55 2014 UTC
Log: Port of r19288 to a64: Fix for smi stores optimization.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/159513004
http://code.google.com/p/v8/source/detail?r=19329
Modified:
/branches
Reviewers: Rodolph Perfetta (ARM), ulan, jochen,
Description:
A64: Indicate the correct size for constant pools.
This fixes potential issues that would appear when trying to insert a
breakpoint
from JavaScript.
Without this, computing the mapping of addresses between versions of the
code
w
lgtm
https://codereview.chromium.org/159513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: ulan,
Message:
PTAL
Description:
Port of r19288 to a64: Fix for smi stores optimization.
Please review this at https://codereview.chromium.org/159513004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M src/a64/lithium-codegen-a64.cc
Revision: 19328
Author: rmcil...@chromium.org
Date: Wed Feb 12 13:34:40 2014 UTC
Log: Avoid doing explicit cast in simulator-a64::get_sp().
R=rodolph.perfe...@arm.com
Review URL: https://codereview.chromium.org/153823012
http://code.google.com/p/v8/source/detail?r=19328
Modified:
/b
Revision: 19327
Author: rmcil...@chromium.org
Date: Wed Feb 12 13:33:54 2014 UTC
Log: Add to OWNERS for arm and a64
R=da...@chromium.org
Review URL: https://codereview.chromium.org/138953017
http://code.google.com/p/v8/source/detail?r=19327
Added:
/branches/bleeding_edge/src/a64/OWN
Committed patchset #1 manually as r19328 (presubmit successful).
https://codereview.chromium.org/153823012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r19327 (presubmit successful).
https://codereview.chromium.org/138953017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19326
Author: ja...@chromium.org
Date: Wed Feb 12 13:31:24 2014 UTC
Log: Fix for (One|Two)ByteSeqStringSetChar evaluation order/deopt.
This makes the evaluation order consistent between full codegen
and Hydrogen (so that deopt does not screw up stack).
R=jkumme...@chromium.o
Committed patchset #1 manually as r19326 (presubmit successful).
https://codereview.chromium.org/159983008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: jarin,
Description:
Use NoBarrier_Load and NoBarrier_Store in FreeListCategory::Concatenate.
BUG=
Please review this at https://codereview.chromium.org/138953018/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -3 lines):
M src/spaces.cc
Index
Revision: 19325
Author: rmcil...@chromium.org
Date: Wed Feb 12 13:27:13 2014 UTC
Log: Clean up some A64 specific code in common code that was
introduced by A64 merge
- Remove arch specific check macros
- Remove duplicate code in code-stubs.h
- Remove flag check in bootstrap.cc wh
Committed patchset #1 manually as r19325 (presubmit successful).
https://codereview.chromium.org/134333011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/138953017/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno,
Description:
Add to OWNERS for arm and a64
Please review this at https://codereview.chromium.org/138953017/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
A src/a64/OWNERS
A src/arm/OWNERS
Index: src/a64/OWNERS
diff --git a
More comments.
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc
File src/hydrogen-check-elimination.cc (right):
https://codereview.chromium.org/153823003/diff/60001/src/hydrogen-check-elimination.cc#newcode212
src/hydrogen-check-elimination.cc:212: // If th
Revision: 19324
Author: bmeu...@chromium.org
Date: Wed Feb 12 12:44:01 2014 UTC
Log: [a64] Omit redundant smi checks in write barriers.
R=rmcil...@chromium.org
Review URL: https://codereview.chromium.org/156603007
http://code.google.com/p/v8/source/detail?r=19324
Modified:
/branches
Committed patchset #1 manually as r19324 (presubmit successful).
https://codereview.chromium.org/156603007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/02/12 12:40:07, Benedikt Meurer wrote:
PTAL
lgtm
Thanks.
https://codereview.chromium.org/156603007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Updates:
Status: Assigned
Owner: vse...@chromium.org
Comment #7 on issue 2342 by vse...@chromium.org: Support sourceURL for
dynamically inserted scripts.
http://code.google.com/p/v8/issues/detail?id=2342
(No comment was entered for this change.)
--
You received this message b
Reviewers: jarin,
Description:
Make prev and next pointer in pages list AtomicWords and access them using
acquire/release semantics.
BUG=
Please review this at https://codereview.chromium.org/150413009/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+27, -24 li
Reviewers: rmcilroy,
Message:
PTAL
Description:
[a64] Omit redundant smi checks in write barriers.
Please review this at https://codereview.chromium.org/156603007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+6, -3 lines):
M src/a64/lithium-codegen-a64.cc
On 2014/02/12 12:36:59, Benedikt Meurer wrote:
Committed patchset #1 manually as r19323 (presubmit successful).
Please do this for A64 as well if applicable.
https://codereview.chromium.org/155843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Committed patchset #1 manually as r19323 (presubmit successful).
https://codereview.chromium.org/155843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19323
Author: bmeu...@chromium.org
Date: Wed Feb 12 12:36:53 2014 UTC
Log: Omit redundant smi checks in write barriers.
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/155843006
http://code.google.com/p/v8/source/detail?r=19323
Modified:
/branches/bleedin
LGTM
https://codereview.chromium.org/155843006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Committed patchset #4 manually as r19322 (presubmit successful).
https://codereview.chromium.org/152953004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
1 - 100 of 197 matches
Mail list logo
