Reviewers: rossberg,
Message:
Committed patchset #1 manually as r19736.
Description:
Reland "Enable Object.observe by default"
Original Issue: https://codereview.chromium.org/183683022/
TBR=rossberg
BUG=v8:2409
LOG=Y
Committed: https://code.google.com/p/v8/source/detail?r=19736
Please review
Comment #2 on issue 3205 by yang...@chromium.org: "Too many variables"
limit prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
Not entirely sure, but I think the limit is because the local variable
index is stored in a bitfield, sharing it w
Reviewers: rossberg,
Message:
Committed patchset #1 manually as r19735 (tree was closed).
Description:
Revert "Enable Object.observe by default"
TBR=rossberg
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=19735
Please review this at https://codereview.chromium.org/190853007/
SV
On 2014/03/08 03:08:05, Yang wrote:
On 2014/03/07 18:40:00, fmeawad-cr wrote:
> On 2014/03/07 18:33:49, I haz the power (commit-bot) wrote:
> > No LGTM from a valid reviewer yet. Only full committers are accepted.
> > Even if an LGTM may have been provided, it was from a non-committer or
> > a lo
On 2014/03/07 18:40:00, fmeawad-cr wrote:
On 2014/03/07 18:33:49, I haz the power (commit-bot) wrote:
> No LGTM from a valid reviewer yet. Only full committers are accepted.
> Even if an LGTM may have been provided, it was from a non-committer or
> a lowly provisional committer, _not_ a full supe
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js
File src/object-observe.js (left):
https://codereview.chromium.org/183683022/diff/1/src/object-observe.js#oldcode28
src/object-observe.js:28: "use strict";
Ok. Seems wrong, but I'll leave it in.
On 2014/03/07 07:14:44, rossb
Committed patchset #3 manually as r19734 (presubmit successful).
https://codereview.chromium.org/183683022/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc
File test/cctest/test-heap-profiler.cc (right):
https://codereview.chromium.org/191153002/diff/1/test/cctest/test-heap-profiler.cc#newcode2527
test/cctest/test-heap-profiler.cc:2527: CHECK_EQ(1,
static_cast(map.si
Updates:
Labels: -Priority-Medium Priority-High
Comment #1 on issue 3205 by k...@chromium.org: "Too many variables" limit
prohibits new Emscripten application from running
http://code.google.com/p/v8/issues/detail?id=3205
Note that Mozilla made some changes to the app and it really do
Committed as r19733.
https://codereview.chromium.org/189433008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 19733
Author: plin...@gmail.com
Date: Fri Mar 7 22:11:52 2014 UTC
Log: MIPS: Consistenly handle power-of-2 divisors in division-like
operations.
Port r19715 (0d6d244)
Original commit message:
Lithium currently supports 3 division-like operations on integral
operands: "No
LGTM. Note to Sven and rest of Google team, this gets us building/testing
ok,
but is an interim step. We'll revisit this next week, to bring the mips
division
support more in line with the other arch's.
https://codereview.chromium.org/189433008/
--
--
v8-dev mailing list
v8-dev@googlegroups.
Revision: 19732
Author: pal...@homejinni.com
Date: Fri Mar 7 22:08:20 2014 UTC
Log: MIPS: Introduce intrinsics for double values in Javascript.
Port r19704 (120500a)
Patch from Balazs Kilvady .
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/189913005
http://co
Committed patchset #1 manually as r19732 (presubmit successful).
https://codereview.chromium.org/189913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM.
https://codereview.chromium.org/189913005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Paul Lind, kisg, kilvadyb, danno, Yang,
Message:
PTAL.
Description:
MIPS: Introduce intrinsics for double values in Javascript.
Port r19704 (120500a)
Patch from Balazs Kilvady .
BUG=
Please review this at https://codereview.chromium.org/189913005/
SVN Base: https://v8.googlecode.
Reviewers: danno, Sven Panne, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Consistenly handle power-of-2 divisors in division-like operations.
Port r19715 (0d6d244)
Original commit message:
Lithium currently supports 3 division-like operations on integral
operands: "Normal" division (rou
Reviewers: ulan,
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Pass a Code object to Assembler::(set_)target_address_at for use by ool
constant
pool.
The ool constant pool will require a pointer to the code's constant pool
when
updating or reading target addre
Reviewers: ulan,
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Fix deoptimization for out-of-line constant pool.
Ensure that the stack contains the correct constant pool pointer when a
function deopts.
This CL depends on https://codereview.chromium.org/183803022/ l
Reviewers: ulan, Rodolph Perfetta (ARM),
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Introduce FrameAndConstantPoolScope and ConstantPoolUnavailableScope.
Adds FrameAndConstantPoolScope and ConstantPoolUnavailableScope to enable
scoped management of constant pool
Reviewers: ulan,
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Update constant pool correctly when resuming a generator
This CL depends on the following CLs landing first:
https://codereview.chromium.org/188063002/
https://codereview.chromium.org/190793002/
Ple
https://codereview.chromium.org/190833002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: ulan,
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Add support for movw/movt immediate loads to BackEdgeTable on ARM to enable
ool
constant pool.
Please review this at https://codereview.chromium.org/190833002/
SVN Base: https://v8.googlecode.com/svn
Reviewers: ulan,
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Update serializer to be able to deal with ool constant pool.
This CL depends on CL https://codereview.chromium.org/179813005/ landing
first.
Please review this at https://codereview.chromium.org/1908
Reviewers: ulan, Rodolph Perfetta (ARM),
Message:
Part of the out-of-line constant pool change - PTAL.
Description:
Clean up ARM mov 32bit immediate code in preparation for out of line
constant
pool.
Please review this at https://codereview.chromium.org/138503002/
SVN Base: https://v8.googl
Reviewers: ulan, Rodolph Perfetta (ARM),
Message:
This CL introduces the ool constant pool on arm support. I've tried to
split up
the massive patch-set into a set of manageable CLs for reviewing (the list
of
dependent CLs is in the CL description). I have also uploaded the complete
patch-s
On 2014/03/07 18:33:49, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/ge
Reviewers: ulan,
Description:
A64: UseRegisterAtStart for rhs of LMulS
BUG=
Please review this at https://codereview.chromium.org/191283002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+21, -8 lines):
M src/a64/lithium-a64.cc
M src/a64/lithium-codegen-a6
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing
LGTM with comments.
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.cc
File src/hydrogen-instructions.cc (right):
https://codereview.chromium.org/174863002/diff/50001/src/hydrogen-instructions.cc#newcode3142
src/hydrogen-instructions.cc:3142: }
I think you're miss
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing
LGTM.
Sorry, this fell through the cracks.
https://codereview.chromium.org/174883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Status: New
Owner:
CC: jkumme...@chromium.org, mstarzin...@chromium.org,
tit...@chromium.org, yang...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3205 by k...@chromium.org: "Too many variables" limit prohibits
new Emscripten application from running
http://code.google.co
I've tidied up the constraints so they're easier to read. We're trying to
avoid
using UseRegisterAndClobber where possible, due to register pressure and the
additional move it may require, so there should be a little performance
here.
https://codereview.chromium.org/189373006/
--
--
v8-dev
Revision: 19731
Author: yu...@chromium.org
Date: Fri Mar 7 17:20:03 2014 UTC
Log: Fix compiler warning on Win64
BUG=None
LOG=N
TBR=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/191153002
http://code.google.com/p/v8/source/detail?r=19731
Modified:
/branches/bl
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r19731 (presubmit successful).
Description:
Fix compiler warning on Win64
BUG=None
LOG=N
TBR=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=19731
Please review this at https://coderevie
Committed patchset #1 manually as r19730 (presubmit successful).
https://codereview.chromium.org/190783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19730
Author: m.m.capew...@googlemail.com
Date: Fri Mar 7 17:12:47 2014 UTC
Log: A64: Improve constraints on StoreKeyed instructions
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/190783002
http://code.google.com/p/v8/source/detail?r=19730
Modified:
On 2014/03/07 16:59:24, Alexandre Rames wrote:
On 2014/03/07 10:51:56, ulan wrote:
> Looks good. One question:
>
>
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
> File src/a64/assembler-a64.cc (right):
>
>
https://codereview.chromium.org/188253005/diff/1/src/a64/a
On 2014/03/07 10:51:56, ulan wrote:
Looks good. One question:
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc
File src/a64/assembler-a64.cc (right):
https://codereview.chromium.org/188253005/diff/1/src/a64/assembler-a64.cc#newcode2678
src/a64/assembler-a64.cc:2678
Revision: 19729
Author: yu...@chromium.org
Date: Fri Mar 7 16:34:10 2014 UTC
Log: Fix compilation on 32-bit platforms after r19728
BUG=None
TBR=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/191043002
http://code.google.com/p/v8/source/detail?r=19729
Modified:
Reviewers: Michael Starzinger,
Message:
Committed patchset #1 manually as r19729 (tree was closed).
Description:
Fix compilation on 32-bit platforms after r19728
BUG=None
TBR=mstarzin...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=19729
Please review this at https://c
Revision: 19728
Author: yu...@chromium.org
Date: Fri Mar 7 16:13:22 2014 UTC
Log: AllocationTracker now maintains a map from address range to stack
trace that allocated the range. When snapshot is generated the map is used
to find construction stack trace for an object using its ad
Committed patchset #6 manually as r19728 (presubmit successful).
https://codereview.chromium.org/177983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r19727 (presubmit successful).
https://codereview.chromium.org/171603020/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19727
Author: rodolph.perfe...@arm.com
Date: Fri Mar 7 16:11:50 2014 UTC
Log: A64: tidy up the disassembler
R=u...@chromium.org
Review URL: https://codereview.chromium.org/171603020
http://code.google.com/p/v8/source/detail?r=19727
Modified:
/branches/bleeding_edge/src/a6
Committed as r19726. (thx for review Michael)
https://codereview.chromium.org/189143006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
Revision: 19726
Author: plin...@gmail.com
Date: Fri Mar 7 15:48:50 2014 UTC
Log: MIPS: Symbols for type cells.
Port r19706 (81fd8dd)
Original commit message:
We can make more efficient code to check against type cells in the future
if we use symbols, guaranteed not to conflict with
On 2014/03/07 15:44:15, Yang wrote:
bad upload. ignore this.
https://codereview.chromium.org/190953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
Reviewers: ulan,
Description:
Do not overwrite already optimized code.
BUG=
Please review this at https://codereview.chromium.org/189603006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -4 lines):
M src/optimizing-compiler-thread.cc
M src/runtime.cc
Reviewers: ulan,
Description:
Do not overwrite already optimized code.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/190953002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+10, -4 lines):
src/optimizing-compiler-thread.cc
src/
https://codereview.chromium.org/190953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
https://codereview.chromium.org/190953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
https://codereview.chromium.org/190953002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
More thoughts ...
https://codereview.chromium.org/179813005/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/179813005/diff/1/src/objects.h#newcode10702
src/objects.h:10702: virtual void VisitCodeTarget(Address
target_address_pointer);
On 2014/03/07 14:36:59, Mic
Committed patchset #1 manually as r19725 (presubmit successful).
https://codereview.chromium.org/184103003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19725
Author: alexandre.ra...@arm.com
Date: Fri Mar 7 15:25:28 2014 UTC
Log: A64: Clean and improve ArgumentsAdaptorTrampoline.
This patch:
- uses named registers
- reserves all the stack space in one go to avoid operations on csp
- uses LDP/STP to copy the arguments
R=j
Committed patchset #1 manually as r19724 (presubmit successful).
https://codereview.chromium.org/185793002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19724
Author: alexandre.ra...@arm.com
Date: Fri Mar 7 15:20:32 2014 UTC
Log: A64: Handle a few TODOs.
Notes about a few TODOs handled in this patch:
* In ProfileEntryHookStub::Generate:
Stubs are always called with relocation.
* In CreateArrayDispatchOneArgument:
T
https://codereview.chromium.org/189373006/diff/1/src/a64/lithium-a64.cc
File src/a64/lithium-a64.cc (right):
https://codereview.chromium.org/189373006/diff/1/src/a64/lithium-a64.cc#newcode2237
src/a64/lithium-a64.cc:2237: LOperand* object =
UseRegister(instr->object());
This is difficult to unde
Looking good. Just one concern about the initialization of the code entry
pointers within the constant pool.
https://codereview.chromium.org/183883011/diff/80001/src/heap.cc
File src/heap.cc (right):
https://codereview.chromium.org/183883011/diff/80001/src/heap.cc#newcode5312
src/heap.cc:5312:
Revision: 19723
Author: yang...@chromium.org
Date: Fri Mar 7 14:58:41 2014 UTC
Log: Reland "Introduce intrinsics for double values in Javascript."
This relands r19704 with a fix to the test case.
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/189823003
http://c
Committed patchset #1 manually as r19723 (presubmit successful).
https://codereview.chromium.org/189823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/02/21 08:37:43, Yang wrote:
ping
https://codereview.chromium.org/174883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this gr
lgtm
https://codereview.chromium.org/190783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/07 13:12:16, Sven Panne wrote:
Committed patchset #1 manually as r19722 (tree was closed).
Could you include some mjsunit tests for this optimization when you land
this
again? (e.g. various dividend / divisor combinations). It is quite a tricky
thing and seems like better test cov
LGTM, only nits and naming.
https://codereview.chromium.org/179813005/diff/1/src/assembler.h
File src/assembler.h (right):
https://codereview.chromium.org/179813005/diff/1/src/assembler.h#newcode415
src/assembler.h:415: INLINE(Address constant_pool_entry_address());
nit: Let's add an empty newl
Comment #2 on issue 3202 by u...@chromium.org: regression for
kraken/oscillator on a15/a9 after patch r19635
http://code.google.com/p/v8/issues/detail?id=3202
Thanks for reporting, Vincent. I uploaded a fix:
https://codereview.chromium.org/189263009/
It is a timing issue: the code gets op
Reviewers: ulan, jochen (OOO until March 10),
Description:
A64: Improve constraints on StoreKeyed instructions
BUG=
Please review this at https://codereview.chromium.org/190783002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+19, -16 lines):
M src/a64/lith
Reviewers: Benedikt Meurer, ulan,
Message:
PTAL
Description:
ARM: cleanning of InstanceOfKnownGlobal
BUG=
R=u...@chromium.org, bmeu...@chromium.org
Please review this at https://codereview.chromium.org/189263011/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (
Reviewers: Benedikt Meurer,
Message:
Committed patchset #1 manually as r19722 (tree was closed).
Description:
Revert "Handle non-power-of-2 divisors in division-like operations", "A64
tweaks
for division-like operations." and "Windows build fix.".
This reverts commit 19719, 19720 and 19721 b
Reviewers: ulan, jochen (OOO until March 10),
Description:
A64: Improve constraints for StoreNamedField
Improve register constraints for cases that don't need write barriers, and
remove TODOs.
BUG=
Please review this at https://codereview.chromium.org/189373006/
SVN Base: https://v8.googlecod
lgtm
https://codereview.chromium.org/190713002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/07 12:30:16, ulan wrote:
PTAL
LGTM.
https://codereview.chromium.org/189263009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Reviewers: Yang,
Message:
PTAL
Description:
Fix kraken/oscillator performance regression after r19635.
Evict previously optimized code after new optimization.
BUG=v8:3202
LOG=N
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/189263009/
SVN Base: https://v8.google
Reviewers: Sven Panne,
Message:
First step. PTAL.
Description:
Replace the recursion in PropagateMinusZeroChecks() with a loop and a
worklist.
Also refactor the related code in preparation for fixing the
range analysis.
BUG=v8:3204
Please review this at https://codereview.chromium.org/1907
Comment #1 on issue 3204 by bmeu...@chromium.org: Users of range analysis
results assume SSI, but we have only "adhoc SSI in random places"
http://code.google.com/p/v8/issues/detail?id=3204
The ranges are also incorrectly used during the minus zero checks phase.
--
You received this message
Revision: 19721
Author: svenpa...@chromium.org
Date: Fri Mar 7 12:12:50 2014 UTC
Log: Windows build fix.
TBR=u...@chromium.org
Review URL: https://codereview.chromium.org/189093009
http://code.google.com/p/v8/source/detail?r=19721
Modified:
/branches/bleeding_edge/src/assembler.cc
Reviewers: ulan,
Message:
Committed patchset #1 manually as r19721 (tree was closed).
Description:
Windows build fix.
TBR=u...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=19721
Please review this at https://codereview.chromium.org/189093009/
SVN Base: https://v8.goog
lgtm
https://codereview.chromium.org/189143006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM (rubberstamped)
https://codereview.chromium.org/189823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Reviewers: Sven Panne,
Description:
Reland "Introduce intrinsics for double values in Javascript."
This relands r19704 with a fix to the test case.
R=svenpa...@chromium.org
Please review this at https://codereview.chromium.org/189823003/
SVN Base: https://v8.googlecode.com/svn/branches/bleedi
Committed patchset #1 manually as r19720 (tree was closed).
https://codereview.chromium.org/190603003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 19720
Author: svenpa...@chromium.org
Date: Fri Mar 7 12:02:52 2014 UTC
Log: A64 tweaks for division-like operations.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/190603003
http://code.google.com/p/v8/source/detail?r=19720
Modified:
/branches/bleeding
LGTM
https://codereview.chromium.org/190603003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Benedikt Meurer, m.m.capewell,
Description:
A64 tweaks for division-like operations.
Please review this at https://codereview.chromium.org/190603003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -11 lines):
M src/a64/lithium-codegen-a64.cc
M
On 2014/03/07 11:37:29, m.m.capewell wrote:
[...]
Ooops, the comments slipped between the LGTM and the actual commit, caused
by a
rebase orgy. :-P I'll handle these in a separate CL...
https://codereview.chromium.org/190383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://group
Committed patchset #3 manually as r19719 (presubmit successful).
https://codereview.chromium.org/190383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc
File src/a64/macro-assembler-a64.cc (right):
https://codereview.chromium.org/190383002/diff/1/src/a64/macro-assembler-a64.cc#newcode4939
src/a64/macro-assembler-a64.cc:4939: ASSERT(!AreAliased(dividend,
result, tmp))
Reviewers: danno, mvstanton, Paul Lind, palfia, kisg, dusmil,
Description:
MIPS: Symbols for type cells.
Port r19706 (81fd8dd)
Original commit message:
We can make more efficient code to check against type cells in the future
if we
use symbols, guaranteed not to conflict with user code. Curre
Revision: 19718
Author: yu...@chromium.org
Date: Fri Mar 7 11:32:01 2014 UTC
Log: Allocation tracker: add separate entry for allocations via V8 API
When object is creating via native V8 API calls JS callstack is empty and
the allocation is indistinguishable from say compiler allocat
Committed patchset #2 manually as r19718 (presubmit successful).
https://codereview.chromium.org/177203002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM
https://codereview.chromium.org/190383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Updates:
Status: Assigned
Owner: u...@chromium.org
Comment #1 on issue 3202 by svenpa...@chromium.org: regression for
kraken/oscillator on a15/a9 after patch r19635
http://code.google.com/p/v8/issues/detail?id=3202
(No comment was entered for this change.)
--
You received thi
Committed patchset #2 manually as r19717 (presubmit successful).
https://codereview.chromium.org/181063008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 19717
Author: u...@chromium.org
Date: Fri Mar 7 11:03:35 2014 UTC
Log: Introduce Runtime_GetAllScopesDetails to get all scopes at once
for a frame.
This will reduce heavy ScopeIterator instantiations.
Once incorporated into chromium, will give 30% speed boost.
BUG=chromi
Revision: 19716
Author: mvstan...@chromium.org
Date: Fri Mar 7 11:01:03 2014 UTC
Log: Test FeedbackVectorPreservedAcrossRecompiles needs crankshaft
The new test didn't recognize that non-sse2 builds on ia32 would
disable crankshaft.
R=yang...@chromium.org
Review URL: https://coderev
Committed patchset #1 manually as r19716 (tree was closed).
https://codereview.chromium.org/189263007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: Yang,
Message:
Hi Yang, PTAL
Description:
Test FeedbackVectorPreservedAcrossRecompiles needs crankshaft
The new test didn't recognize that non-sse2 builds on ia32 would
disable crankshaft.
Please review this at https://codereview.chromium.org/189263007/
SVN Base: https://v8.googlec
On 2014/03/07 11:00:18, mvstanton wrote:
Hi Yang, PTAL
LGTM.
https://codereview.chromium.org/189263007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To un
1 - 100 of 146 matches
Mail list logo
