https://codereview.chromium.org/205243012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: rossberg,
Message:
It turns out the the blink dev tools needs to be able to fire a microtask
with
script on the stack. The basic idea here is if the embedder is taking
control of
microtask delivery, it should have freedom to do what it knows is correct.
Description:
Assert that e
CL updated
https://codereview.chromium.org/160073006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails f
On 2014/03/21 17:22:47, Toon Verwaest wrote:
Sure, the optimization I'm suggesting isn't there yet. It's just "the
right
thing to do".
Right. I would say this patch could also be generalized to support the
case of writable global objects with constant properties. However, outside
Math.*
there
On 2014/03/21 17:21:24, rmcilroy wrote:
PTAL.
lgtm.
https://codereview.chromium.org/208613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe
Sure, the optimization I'm suggesting isn't there yet. It's just "the right
thing to do".
Your implementation is not only pretty hacky, but also wrong. E.g., you only
deoptimize while overwriting the property through the runtime. An
assignment via
IC or Crankshaft would not trap, and would lea
Reviewers: Yang,
Message:
PTAL.
Description:
Remove an unused isolate_ field from BacktrackStack.
Found by Nico Weber with -Wunused-private-field
Please review this at https://codereview.chromium.org/208613002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2
https://codereview.chromium.org/203443002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
What is the performance impact of this patch?
https://codereview.chromium.org/198533007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from thi
Updates:
Status: Fixed
Comment #3 on issue 3209 by rodolph@gmail.com: ASSERT(shift_op != ROR |
| shift_imm != 0) in src/arm/assembler-arm.cc fires
http://code.google.com/p/v8/issues/detail?id=3209
(No comment was entered for this change.)
--
You received this message because this
Comment #2 on issue 3209 by rodolph@gmail.com: ASSERT(shift_op != ROR |
| shift_imm != 0) in src/arm/assembler-arm.cc fires
http://code.google.com/p/v8/issues/detail?id=3209
Fixed in r20171
--
You received this message because this project is configured to send all
issue notifications t
Reviewers: Sven Panne, Toon Verwaest,
Message:
Hi Sven, hi Toon,
This CL demonstrates gathering feedback from a custom platform on some known
function. PTAL, thanks,
--Michael
Description:
This CL is based on https://codereview.chromium.org/172523002/ ("Create a
function call IC").
This CL de
Committed patchset #1 manually as r20171 (presubmit successful).
https://codereview.chromium.org/198053014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20171
Author: rodolph.perfe...@arm.com
Date: Fri Mar 21 15:59:45 2014 UTC
Log: ARM: fix assertions for uxtb and co.
Allow operands with ROR #0. Behind the scene they are mapped to LSL #0.
BUG=v8:3209
LOG=N
R=u...@chromium.org
Review URL: https://codereview.chromium.org/1980
Revision: 20170
Author: ma...@chromium.org
Date: Fri Mar 21 15:24:36 2014 UTC
Log: Tentative Windows dll build fix: Don't V8_EXPORT
ScriptCompiler::Source.
For more information, see the bug. Compare to ScriptOrigin
which is not exported either.
BUG=v8:3228
LOG=Y
R=dcar...@chromium.
Reviewers: dcarney,
Message:
Committed patchset #1 manually as r20170 (presubmit successful).
Description:
Tentative Windows dll build fix: Don't V8_EXPORT ScriptCompiler::Source.
For more information, see the bug. Compare to ScriptOrigin
which is not exported either.
BUG=v8:3228
LOG=Y
R=dcar.
lgtm
https://codereview.chromium.org/198053014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
On 2014/03/21 12:27:34, Yang wrote:
On 2014/03/21 12:26:54, Yang wrote:
> On 2014/03/21 09:52:22, Yang wrote:
> > LGTM.
> >
> >
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc
> > File src/ia32/full-codegen-ia32.cc (right):
> >
> >
>
https://codereview.chromium.or
Revision: 20168
Author: machenb...@chromium.org
Date: Fri Mar 21 15:04:54 2014 UTC
Log: Let auto-roll push the lkgr.
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/205703004
http://code.google.com/p/v8/source/detail?r=20168
Modified:
/branches/bleeding_edg
Revision: 20169
Author: alexandre.ra...@arm.com
Date: Fri Mar 21 15:08:50 2014 UTC
Log: A64: Now that we have veneers, fix a couple of branches to
directly jump to their target.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/207883002
http://code.google.com/p/v8/so
Committed patchset #1 manually as r20169 (presubmit successful).
https://codereview.chromium.org/207883002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #2 manually as r20168 (presubmit successful).
https://codereview.chromium.org/205703004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Done
https://codereview.chromium.org/205703004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
On 2014/03/19 12:00:30, Jakob wrote:
Well, rule #1 of V8 test coverage: never assume that it exists.
A quick way to find out is to insert an int3 instruction into the changed
code
path and see if any test hits it. Please do add tests for any paths that
are
not
covered yet -- yes, that takes
Revision: 20167
Author: u...@chromium.org
Date: Fri Mar 21 15:03:40 2014 UTC
Log: Add special check for topmost optimized code in deoptimizer
verification.
BUG=354843
LOG=N
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/208283002
http://code.google.com/p/v8/so
Committed patchset #2 manually as r20167 (presubmit successful).
https://codereview.chromium.org/208283002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
can do Math.PI = {1.24}; for example.
err. I mean Math = {PI: 1.24};
https://codereview.chromium.org/198533007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group
On 2014/03/21 14:53:48, Toon Verwaest wrote:
No LGTM.
We inline read-only properties of global constants using a more general
mechanism.
It doesn't look like the mechanism is active for Math.PI and
others. Also from the top of my head I don't know any other cases. Just to
make sure, this is
Thanks, landing.
https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc#newcode363
src/deoptimizer.cc:363: bool safe_to_deopt_topmost_optmized_code =
false;
On 2014/03/21 14:50:27,
With no lgtm, I meant not lgtm.
https://codereview.chromium.org/198533007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
No LGTM.
We inline read-only properties of global constants using a more general
mechanism.
https://codereview.chromium.org/198533007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google
LGTM with nit. Thanks for fixing this!
https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/208283002/diff/1/src/deoptimizer.cc#newcode363
src/deoptimizer.cc:363: bool safe_to_deopt_topmost_optmized_code =
false;
ni
lgtm
https://codereview.chromium.org/207703004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Looking good, but I still have some comments. Lets wait until after the
branch.
https://codereview.chromium.org/167303005/diff/150001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/167303005/diff/150001/src/hydrogen.cc#newcode5489
src/hydrogen.cc:5489: field_map
Reviewers: Jakob,
Message:
PTAL
Description:
Add special check for topmost optimized code in deoptimizer verification.
BUG=354843
LOG=N
Please review this at https://codereview.chromium.org/208283002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+38, -24 lin
LGTM with nit.
https://codereview.chromium.org/205703004/diff/1/tools/push-to-trunk/auto_roll.py
File tools/push-to-trunk/auto_roll.py (right):
https://codereview.chromium.org/205703004/diff/1/tools/push-to-trunk/auto_roll.py#newcode143
tools/push-to-trunk/auto_roll.py:143: "-R", self["lkgr"],
Comment #3 on issue 3228 by ma...@chromium.org: Windows DLL build broken on
trunk
http://code.google.com/p/v8/issues/detail?id=3228
Alright, seems that V8_EXPORTING something that contains Handles is a bad
idea:
http://www.stackoverflow.com/questions/2132747/warning-c4251-when-building-a-
Committed patchset #1 manually as r20166 (presubmit successful).
https://codereview.chromium.org/198053013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20166
Author: ish...@chromium.org
Date: Fri Mar 21 14:29:27 2014 UTC
Log: JSObject::EnsureCanContainElements() handlified.
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/198053013
http://code.google.com/p/v8/source/detail?r=20166
Modified:
/branches/bl
Updates:
Status: Accepted
Comment #2 on issue 3228 by ma...@chromium.org: Windows DLL build broken on
trunk
http://code.google.com/p/v8/issues/detail?id=3228
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue
lgtm
https://codereview.chromium.org/208183002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/208263002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Assigned
Owner: ma...@chromium.org
Comment #1 on issue 3228 by jkumme...@chromium.org: Windows DLL build
broken on trunk
http://code.google.com/p/v8/issues/detail?id=3228
(No comment was entered for this change.)
--
You received this message because this proj
Reviewers: Michael Starzinger,
Description:
Add support for per-isolate private symbols
Reland "Implement ES6 symbol registry and predefined symbols"
Only change relative to original CL is the updated assertion condition at
objects-inl.h:2119
R=mstarzin...@chromium.org
BUG=
LOG=Y
Please revi
lgtm
https://codereview.chromium.org/198053013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Description:
Remove Failure::OutOfMemory propagation and V8::IgnoreOutOfMemoryException.
R=dcar...@chromium.org
BUG=v8:3060
LOG=Y
Please review this at https://codereview.chromium.org/208263002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files
Reviewers: danno,
Description:
Enable concurrent OSR.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/208253002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/flag-definitions.h
Index: src/flag-definitions.h
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
JSObject::EnsureCanContainElements() handlified.
Please review this at https://codereview.chromium.org/198053013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+50, -79 lines):
M src/objects-inl.h
M src/
Revision: 20165
Author: yang...@chromium.org
Date: Fri Mar 21 14:05:49 2014 UTC
Log: Enable concurrent OSR.
R=da...@chromium.org
Review URL: https://codereview.chromium.org/208253002
http://code.google.com/p/v8/source/detail?r=20165
Modified:
/branches/bleeding_edge/src/flag-definit
lgtm
https://codereview.chromium.org/208253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 manually as r20165 (presubmit successful).
https://codereview.chromium.org/208253002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: ,
Message:
MSVC 2012 generates this file.
Description:
gitignore: *.opensdf
Please review this at https://codereview.chromium.org/208243002/
Affected files (+1, -0 lines):
M .gitignore
Index: .gitignore
diff --git a/.gitignore b/.gitignore
index
de51f8a1ee4d4d8a29c9353009559b7
Reviewers: Jakob,
Message:
PTAL
Description:
Let auto-roll push the lkgr.
BUG=
Please review this at https://codereview.chromium.org/205703004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+45, -49 lines):
M tools/push-to-trunk/auto_roll.py
M tools/push-
Reviewers: Toon Verwaest,
Description:
Inline mathematical constants
Where possible, mathematical constant references
such as Math.PI are replaced with HConstant of their
actual value.
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/198533007/
SVN Base: http
Reviewers: ulan, Benedikt Meurer,
Description:
ARM: fix assertions for uxtb and co.
Allow operands with ROR #0. Behind the scene they are mapped to LSL #0.
BUG=v8:3209
LOG=N
Please review this at https://codereview.chromium.org/198053014/
SVN Base: https://v8.googlecode.com/svn/branches/bleed
Reviewers: jochen, ulan,
Message:
PTAL
Description:
ARM64: Use a double register to break cycle involving double values.
R=joc...@chromium.org, u...@chromium.org
Please review this at https://codereview.chromium.org/208183002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Af
Revision: 20164
Author: m.m.capew...@googlemail.com
Date: Fri Mar 21 13:11:50 2014 UTC
Log: ARM64: Fix some stub-cache TODOs
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/208023002
http://code.google.com/p/v8/source/detail?r=20164
Modified:
/branches/bleeding_
Committed patchset #1 manually as r20164 (presubmit successful).
https://codereview.chromium.org/208023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20163
Author: m.m.capew...@googlemail.com
Date: Fri Mar 21 13:04:20 2014 UTC
Log: ARM: Fix Q register encoding
Fix Q register encoding for registers other than Q0. Also, fix value in
NeonSize
enumeration.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.o
Committed patchset #1 manually as r20163 (presubmit successful).
https://codereview.chromium.org/207523005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
uploaded new patchset
https://codereview.chromium.org/177493002/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/177493002/diff/1/src/optimizing-compiler-thread.cc#newcode200
src/optimizing-compiler-thread.cc:200: NoBarrie
Status: New
Owner:
New issue 3228 by clearscr...@gmail.com: Windows DLL build broken on trunk
http://code.google.com/p/v8/issues/detail?id=3228
Commands:
C:\v8> third_party\python_26\python build\gyp_v8 -Dtarget_arch=ia32
-Dcomponent=shared_library -Dv8_use_snapshot=false
-Dv8_enable_i
drive-by comment...
https://codereview.chromium.org/177493002/diff/1/src/optimizing-compiler-thread.cc
File src/optimizing-compiler-thread.cc (right):
https://codereview.chromium.org/177493002/diff/1/src/optimizing-compiler-thread.cc#newcode200
src/optimizing-compiler-thread.cc:200: NoBarrier_S
Reviewers: Michael Starzinger,
Description:
IA32: Rename MacroAssembler::Set() and MacroAssembler::SafeSet() to Move()
and
SafeMove().
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/208073003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_e
https://codereview.chromium.org/179773002/diff/110001/src/x64/lithium-gap-resolver-x64.cc
File src/x64/lithium-gap-resolver-x64.cc (right):
https://codereview.chromium.org/179773002/diff/110001/src/x64/lithium-gap-resolver-x64.cc#newcode223
src/x64/lithium-gap-resolver-x64.cc:223: if
(cgen_->IsS
https://codereview.chromium.org/207613005/diff/1/src/api.cc
File src/api.cc (right):
https://codereview.chromium.org/207613005/diff/1/src/api.cc#newcode5423
src/api.cc:5423: CHECK(!result.is_null());
Not using CHECK_NOT_EMPTY_HANDLE because this could be called after an
exception has already bee
Reviewers: Igor Sheludko,
Description:
No longer OOM on invalid string length.
R=ish...@chromium.org
BUG=v8:3060
LOG=Y
Please review this at https://codereview.chromium.org/207613005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+182, -68 lines):
M src/api.
Revision: 20162
Author: u...@chromium.org
Date: Fri Mar 21 12:30:58 2014 UTC
Log: Add option to run ScopeIterator faster giving up nested scope
chain.
We'd like to be able to trade nested scope chain info (consisting of with,
block and catch scopes) in favor of speed in some cases
Committed patchset #8 manually as r20162 (presubmit successful).
https://codereview.chromium.org/203463011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/03/21 12:26:54, Yang wrote:
On 2014/03/21 09:52:22, Yang wrote:
> LGTM.
>
>
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc
> File src/ia32/full-codegen-ia32.cc (right):
>
>
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc#n
On 2014/03/21 09:52:22, Yang wrote:
LGTM.
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/207543003/diff/1/src/ia32/full-codegen-ia32.cc#newcode191
src/ia32/full-codegen-ia32.cc:191:
lgtm
https://codereview.chromium.org/207523005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 20161
Author: ish...@chromium.org
Date: Fri Mar 21 12:23:39 2014 UTC
Log: Reland of r20146 "JSObject::NormalizeElements() handlified."
R=verwa...@chromium.org
Review URL: https://codereview.chromium.org/208003002
http://code.google.com/p/v8/source/detail?r=20161
Modified:
Committed patchset #2 manually as r20161 (presubmit successful).
https://codereview.chromium.org/208003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/208023002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 20160
Author: tit...@chromium.org
Date: Fri Mar 21 12:16:37 2014 UTC
Log: Add a utility method to the ia32 macro assembler to move a double
immediate into an XMM register.
R=mstarzin...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/197233011
http://code.go
Committed patchset #1 manually as r20160 (presubmit successful).
https://codereview.chromium.org/197233011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20159
Author: machenb...@chromium.org
Date: Fri Mar 21 12:15:25 2014 UTC
Log: Split of rolling Chromium from push-to-trunk.
This moves rolling Chromium into a new script with its own tests.
BUG=
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/199733012
Committed patchset #5 manually as r20159 (presubmit successful).
https://codereview.chromium.org/199733012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20158
Author: u...@chromium.org
Date: Fri Mar 21 12:14:44 2014 UTC
Log: Visit return statement of inlined function in value context.
BUG=354357
LOG=N
TEST=mjsunit/regress/regress-354357.js
R=mstarzin...@chromium.org
Review URL: https://codereview.chromium.org/206413005
http:
Committed patchset #3 manually as r20158 (presubmit successful).
https://codereview.chromium.org/206413005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Done
https://codereview.chromium.org/199733012/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Michael Starzinger,
Description:
Don' left-trim arrays when concurrent sweeping is active.
BUG=
Please review this at https://codereview.chromium.org/207613004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+39, -4 lines):
M src/builtins.cc
M sr
Reviewers: Michael Starzinger,
Description:
Don' left-trim arrays when concurrent sweeping is active.
BUG=
Please review this at https://codereview.chromium.org/207613004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+39, -4 lines):
M src/builtins.cc
M sr
https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/206413005/diff/20001/src/hydrogen.cc#newcode4368
src/hydrogen.cc:4368: // (e.g. VisitCountOperation) change the
environment depending on context.
On 2014/03/21 09:57
https://codereview.chromium.org/208003002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4665
src/objects.cc:4665: MUST_USE_RESULT Handle
CopyFastElementsToDictionary(
On 2014/03/21 12:01:15, Toon Verwaest wrote:
Remove
https://codereview.chromium.org/208003002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4682
src/objects.cc:4682: // exceed the capacity of new space, and we would
fail repeatedly
Remove comment and TENURED flag below, t
https://codereview.chromium.org/203463011/diff/110001/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/203463011/diff/110001/src/runtime.cc#newcode11875
src/runtime.cc:11875: if (scope_info->scope_type() != EVAL_SCOPE &&
Considering the comment above: "we only provide
lgtm otherwise.
https://codereview.chromium.org/208003002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving ema
https://codereview.chromium.org/208003002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/208003002/diff/1/src/objects.cc#newcode4665
src/objects.cc:4665: MUST_USE_RESULT Handle
CopyFastElementsToDictionary(
Remove the MUST_USE_RESULT annotation.
https://coder
Committed patchset #2 manually as r20157 (presubmit successful).
https://codereview.chromium.org/208043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20157
Author: yang...@chromium.org
Date: Fri Mar 21 11:45:54 2014 UTC
Log: Mark CollectCpuProfile as flaky.
R=machenb...@chromium.org
BUG=v8:2999
LOG=N
Review URL: https://codereview.chromium.org/208043002
http://code.google.com/p/v8/source/detail?r=20157
Modified:
/branch
lgtm
https://codereview.chromium.org/208043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: Yang,
Message:
PTAL
Description:
Use V8_FINAL and V8_OVERRIDE in ElementsAccessor classses.
Please review this at https://codereview.chromium.org/208063002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+46, -37 lines):
M src/elements.cc
Index:
PTAL.
Changed runtime.cc to not to add nested scope_info for GLOBAL_SCOPE (along
with
EVAL_SCOPE), otherwise a debug test was failing.
if (scope_info->scope_type() != EVAL_SCOPE &&
scope_info->scope_type() != GLOBAL_SCOPE) {
nested_scope_chain_.Add(scope_info);
}
https://codereview.chr
I think you can keep the PASS FAIL expectations where they were. I remember
this
test to be _very_ flaky on windows. The expectations on more specific
sections
should overwrite what is in the ALWAYS block.
https://codereview.chromium.org/208043002/
--
--
v8-dev mailing list
v8-dev@googlegrou
Reviewers: Michael Achenbach,
Description:
Mark CollectCpuProfile as flaky.
R=machenb...@chromium.org
BUG=v8:2999
LOG=N
Please review this at https://codereview.chromium.org/208043002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -7 lines):
M test/cctes
Updates:
Cc: a...@chromium.org loi...@chromium.org
Comment #5 on issue 2999 by yu...@chromium.org:
test-cpu-profiler/CollectCpuProfile fails flakily.
http://code.google.com/p/v8/issues/detail?id=2999
(No comment was entered for this change.)
--
You received this message because this
Reviewers: Yang,
Message:
PTAL
Description:
Builtin helper function EnsureJSArrayWithWritableFastElements() handlified.
Please review this at https://codereview.chromium.org/208033002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+33, -57 lines):
M src/buil
Updates:
Status: Duplicate
Mergedinto: 2999
Comment #1 on issue 3227 by yang...@chromium.org:
cctest/test-cpu-profiler/CollectCpuProfile Flaky
http://code.google.com/p/v8/issues/detail?id=3227
(No comment was entered for this change.)
--
You received this message because this
1 - 100 of 174 matches
Mail list logo
