lgtm.
https://codereview.chromium.org/214613004/diff/20001/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
https://codereview.chromium.org/214613004/diff/20001/src/arm/lithium-arm.cc#newcode1917
src/arm/lithium-arm.cc:1917: LOperand* value = UseRegisterAtStart(val);
Is moving this l
On 2014/03/31 20:53:33, jochen wrote:
use private symbols?
lgtm
https://codereview.chromium.org/215293005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To
Revision: 20374
Author: machenb...@chromium.org
Date: Tue Apr 1 06:36:07 2014 UTC
Log: Tagging version 3.26.2
http://code.google.com/p/v8/source/detail?r=20374
Added:
/tags/3.26.2
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
Revision: 20373
Author: machenb...@chromium.org
Date: Tue Apr 1 06:35:49 2014 UTC
Log: Version 3.26.2 (based on bleeding_edge revision r20370)
Performance and stability improvements on all platforms.
http://code.google.com/p/v8/source/detail?r=20373
Modified:
/trunk/ChangeLog
/trun
On 2014/03/31 17:33:38, Fritz wrote:
I agree that passing register size around is not ideal. But I disagree
that
changing that will solve this problem. There is one register file that
is 64
bits. This can be accessed by both 32 bit op codes and 64 bit op codes.
The
register access for th
On 2014/03/31 08:58:38, Toon Verwaest wrote:
lgtm
Thanks Toon,
Could you please help me land this patch?
Thanks
-Weiliang
https://codereview.chromium.org/218613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Reviewers: Michael Starzinger, rossberg,
Message:
This could definitely use some more polish before landing (for example, the
initial capacity of 4 is probably silly), but I wanted to get some review
comments before I worked much more on this.
(Note that I spent some time working on this patch o
Updates:
Owner: ad...@chromium.org
Cc: mstarzin...@chromium.org rossb...@chromium.org
Comment #8 on issue 1793 by ad...@chromium.org: Implement iteration for
Harmony sets and maps.
http://code.google.com/p/v8/issues/detail?id=1793
(No comment was entered for this change.)
--
Revision: 20372
Author: machenb...@chromium.org
Date: Tue Apr 1 00:05:36 2014 UTC
Log: Tagging version 3.26.1
http://code.google.com/p/v8/source/detail?r=20372
Added:
/tags/3.26.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
Revision: 20370
Author: pal...@homejinni.com
Date: Mon Mar 31 22:50:53 2014 UTC
Log: MIPS: Fix PrepareKeyedOperand on MIPS.
Port r20363 (235f866c)
Original commit message:
When additional_offset is specified, the 'key' operand can be negative
and still pass the bounds check. Therefore
Committed patchset #1 manually as r20370 (presubmit successful).
https://codereview.chromium.org/219923005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/03/31 22:39:59, Paul Lind wrote:
LGTM, just fix the nit when you land it.
https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.
Revision: 20369
Author: pal...@homejinni.com
Date: Mon Mar 31 22:48:54 2014 UTC
Log: MIPS: Reland and fix "Fix LoadFieldByIndex to take mutable
heap-numbers into account."
Port r20358 (5e9b653d)
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/219163010
http://
Committed patchset #1 manually as r20369 (presubmit successful).
https://codereview.chromium.org/219163010/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
lgtm
https://codereview.chromium.org/219923005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
LGTM, just fix the nit when you land it.
https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):
https://codereview.chromium.org/219163010/diff/1/src/mips/lithium-codegen-mips.cc#newcode5801
src/mips/lithium-codegen-mips.c
Reviewers: Dmitry Lomov (chromium), danno, Paul Lind, kisg, kilvadyb,
dusmil,
Message:
PTAL.
Description:
MIPS: Fix PrepareKeyedOperand on MIPS.
Port r20363 (235f866c)
Original commit message:
When additional_offset is specified, the 'key' operand can be negative
and still pass the bounds ch
Reviewers: Toon Verwaest, danno, kisg, kilvadyb, Paul Lind, dusmil,
Message:
PTAL.
Description:
MIPS: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into
account."
Port r20358 (5e9b653d)
BUG=
Please review this at https://codereview.chromium.org/219163010/
SVN Base: https:
Reviewers: dcarney,
Description:
Store i18n meta data in hidden symbols instead of js accessible properties
There were some tests that are supposed to protect against js messing
with the meta data, however, they just didn't try hard enough.
BUG=354967
R=dcar...@chromium.org
LOG=y
Please review
On 2014/03/31 13:32:53, Sven Panne wrote:
Browsing through the simulator code a bit, I think the fundamental
problem is
that passing around the register size at runtime is a bad idea from a
performance point of view. This leads to tons of dynamic checks and the
casting
problem at hand, and we'
Reviewers: Toon Verwaest,
Message:
ptal
Description:
always lookup api holder from receiver
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/219723002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -1 lines):
M src/hyd
Revision: 20368
Author: ja...@chromium.org
Date: Mon Mar 31 16:45:46 2014 UTC
Log: We should perform the illegal redeclaration check earlier so that
we do not confuse the AST typer with missing type feedback nodes.
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/
Committed patchset #1 manually as r20368 (presubmit successful).
https://codereview.chromium.org/218493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Comment #3 on issue 3107 by dnl.r...@gmail.com: Fails to build V8 3.24.14
with snapshot on OSX, when compiling as shared libraries
http://code.google.com/p/v8/issues/detail?id=3107
Obviously this works until the libicui18n.dylib is located in
${prefix}/v8/out/native/.
Moving it from that pl
Comment #2 on issue 3107 by dnl.r...@gmail.com: Fails to build V8 3.24.14
with snapshot on OSX, when compiling as shared libraries
http://code.google.com/p/v8/issues/detail?id=3107
As workaround, I used:
cd v8/out/third_party/icu
grep -l -R "/usr/local/lib" . | tr '\n' '\0' | xargs -0 sed -
Revision: 20367
Author: verwa...@chromium.org
Date: Mon Mar 31 16:21:20 2014 UTC
Log: Use JSObject::SetMapAndElements rather than set_map +
set_elements.
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/218583008
http://code.google.com/p/v8/source/detail?r=203
Committed patchset #1 manually as r20367 (presubmit successful).
https://codereview.chromium.org/218583008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20366
Author: rossb...@chromium.org
Date: Mon Mar 31 15:53:21 2014 UTC
Log: Fix Type::Intersect to skip uninhabited bitsets
R=verwa...@chromium.org, bmeu...@chromium.org
BUG=chromium:357330
LOG=Y
Review URL: https://codereview.chromium.org/219333003
http://code.google.com/p/
Committed patchset #1 manually as r20366 (presubmit successful).
https://codereview.chromium.org/219333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
https://codereview.chromium.org/219173002/diff/1/src/string-stream.h
File src/string-stream.h (left):
https://codereview.chromium.org/219173002/diff/1/src/string-stream.h#oldcode1
src/string-stream.h:1: // Copyright 2006-2008 the V8 project authors.
All rights reserved.
Are you sure it is OK to
Committed patchset #1 manually as r20365 (presubmit successful).
https://codereview.chromium.org/219493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20365
Author: machenb...@chromium.org
Date: Mon Mar 31 15:47:18 2014 UTC
Log: Update list of V8 try bots.
R=ja...@chromium.org
TBR=ja...@chromium.org
BUG=353487
LOG=n
Review URL: https://codereview.chromium.org/219493002
http://code.google.com/p/v8/source/detail?r=20365
Mod
Reviewers: Benedikt Meurer,
Description:
Provide Type::Contains methods.
Also, rename all *Currently methods to Now*.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/219523003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3
https://codereview.chromium.org/202293004/diff/160001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/202293004/diff/160001/src/objects.cc#newcode15903
src/objects.cc:15903: capacity = Max(kMinCapacity, capacity);
On 2014/03/29 02:26:07, arv wrote:
Can be an assert i
lgtm
https://codereview.chromium.org/219493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 manually as r20364 (presubmit successful).
https://codereview.chromium.org/218753005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20364
Author: verwa...@chromium.org
Date: Mon Mar 31 15:30:13 2014 UTC
Log: Replace set_map_and_elements by MigrateToMap-based
SetMapAndElements
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/218753005
http://code.google.com/p/v8/source/detail?r=20
lgtm
https://codereview.chromium.org/219333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Message:
PTAL
Description:
Update list of V8 try bots.
BUG=
Please review this at https://codereview.chromium.org/219493002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -0 lines):
M PRESUBMIT.py
Index: PRESUBMIT.py
diff --git a/PRE
lgtm with nit
https://codereview.chromium.org/219313002/diff/40001/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/219313002/diff/40001/src/ic.cc#newcode362
src/ic.cc:362: receiver, Handle::cast(name))) {
&& TryMarkMono...
https://codereview.chromium.org/219313002/
--
--
v8-
Committed patchset #1 manually as r20363 (presubmit successful).
https://codereview.chromium.org/219473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20363
Author: dslo...@chromium.org
Date: Mon Mar 31 15:14:28 2014 UTC
Log: Fix PrepareKeyedOperand on arm.
When additional_offset is specified, the 'key' operand can be negative
and still pass the bounds check. Therefore, when converting key from
Smi, arithmetic and not logic
lgtm
https://codereview.chromium.org/219473002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #1 on issue 3107 by dnl.r...@gmail.com: Fails to build V8 3.24.14
with snapshot on OSX, when compiling as shared libraries
http://code.google.com/p/v8/issues/detail?id=3107
Same problem here.
--
You received this message because this project is configured to send all
issue notifica
Reviewers: Toon Verwaest,
Description:
Fix PrepareKeyedOperand on arm.
When additional_offset is specified, the 'key' operand can be nagative
and still pass the bounds check. Therefore, when converting key from
Smi, arithmetic and not logical shift must be used.
R=verwa...@chromium.org
BUG=3580
Revision: 20362
Author: ja...@chromium.org
Date: Mon Mar 31 15:01:46 2014 UTC
Log: Fix left trimming check for large objects
BUG=358090
TEST=test/mjsunit/regress/regress-358090.js
LOG=N
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/213833008
http://code.google.com/
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r20362 (presubmit successful).
Description:
Fix left trimming check for large objects
BUG=358090
TEST=test/mjsunit/regress/regress-358090.js
LOG=N
R=hpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=2
Committed patchset #5 manually as r20361 (presubmit successful).
https://codereview.chromium.org/219103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20361
Author: hpa...@chromium.org
Date: Mon Mar 31 14:29:01 2014 UTC
Log: Make sure when we shrink an object that we store a filler first
into the free memory before updating the map or size.
BUG=
R=ja...@chromium.org
Review URL: https://codereview.chromium.org/219103002
Revision: 20360
Author: machenb...@chromium.org
Date: Mon Mar 31 14:26:00 2014 UTC
Log: Tagging version 3.26.0
http://code.google.com/p/v8/source/detail?r=20360
Added:
/tags/3.26.0
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You receiv
Committed patchset #2 manually as r20358 (presubmit successful).
https://codereview.chromium.org/218663005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20358
Author: verwa...@chromium.org
Date: Mon Mar 31 14:21:04 2014 UTC
Log: Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers
into account.""
BUG=
R=hpa...@chromium.org
Review URL: https://codereview.chromium.org/218663005
http://code.google.com/p/v8/sourc
lgtm
https://codereview.chromium.org/218663005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Status: Duplicate
Mergedinto: v8:3060
Comment #1 on issue 2726 by yang...@chromium.org: Out-of-memory fatal error
despite v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=2726
(No comment was entered for this change.)
--
You received
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Reland and fix "Fix LoadFieldByIndex to take mutable heap-numbers into
account.""
BUG=
Please review this at https://codereview.chromium.org/218663005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+259, -14
Comment #25 on issue 3060 by yang...@chromium.org: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
Issue 2726 has been merged into this issue.
--
You received this message because this project is configured to send all
Updates:
Status: Fixed
Comment #24 on issue 3060 by yang...@chromium.org: V8 3.23.1 and later do
not honor v8::V8::IgnoreOutOfMemoryException()
http://code.google.com/p/v8/issues/detail?id=3060
(No comment was entered for this change.)
--
You received this message because this projec
Revision: 20357
Author: yang...@chromium.org
Date: Mon Mar 31 14:14:54 2014 UTC
Log: Do not check for interrupt when allocating stack locals.
R=dcar...@chromium.org
BUG=357137
LOG=N
Review URL: https://codereview.chromium.org/219373004
http://code.google.com/p/v8/source/detail?r=20357
Committed patchset #1 manually as r20357 (presubmit successful).
https://codereview.chromium.org/219373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 20356
Author: alexandre.ra...@arm.com
Date: Mon Mar 31 14:06:42 2014 UTC
Log: ARM64: Optimize AllocateHeapNumber to use STP.
R=joc...@chromium.org
Review URL: https://codereview.chromium.org/216933003
http://code.google.com/p/v8/source/detail?r=20356
Modified:
/branches/bl
Reviewers: Hannes Payer,
Description:
Tighten object verification.
Often, when we call MaybeObject::Verify, what we want is
Object::ObjectVerify.
R=hpa...@chromium.org
Please review this at https://codereview.chromium.org/218993005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding
Committed patchset #1 manually as r20356 (presubmit successful).
https://codereview.chromium.org/216933003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: jarin,
Message:
PTAL
Description:
Implement auto-roll script.
This script will (1) check if there is an active roll on rietveld (2) check
if
there is a trunk revision ready to be rolled and (3) call the chromium_roll
script, creating a roll CL. The script will be called regularly
lgtm
https://codereview.chromium.org/219373004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/219213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: dcarney,
Description:
Do not check for interrupt when allocating stack locals.
R=dcar...@chromium.org
BUG=357137
LOG=N
Please review this at https://codereview.chromium.org/219373004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+57, -11 lines):
https://codereview.chromium.org/219103002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/219103002/diff/40001/src/objects.cc#newcode2476
src/objects.cc:2476: // change the actual object size.
On 2014/03/31 13:30:01, jarin wrote:
On 2014/03/31 13:23:15, Ha
Revision: 20355
Author: rossb...@chromium.org
Date: Mon Mar 31 13:35:12 2014 UTC
Log: Finalisation disclaimer
R=svenpa...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/219403002
http://code.google.com/p/v8/source/detail?r=20355
Modified:
/branches/bleeding_edge/inclu
Committed patchset #1 manually as r20355 (tree was closed).
https://codereview.chromium.org/219403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm
https://codereview.chromium.org/219403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Sven Panne,
Description:
Finalisation disclaimer
R=svenpa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/219403002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+7, -0 lines):
M include/v8.h
Index: include/v8.h
diff
Browsing through the simulator code a bit, I think the fundamental problem
is
that passing around the register size at runtime is a bad idea from a
performance point of view. This leads to tons of dynamic checks and the
casting
problem at hand, and we're just trying to cure the symptoms. The
Hello, PTAL, thanks,
--Michael
https://codereview.chromium.org/219313002/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/219313002/diff/1/src/ic.cc#newcode1187
src/ic.cc:1187: if
(!ic->IsNameCompatibleWithMonomorphicPrototypeFailure(name)) return
false;
On 2014/03/31 12
lgtm. Just one nit regarding comments.
https://codereview.chromium.org/219103002/diff/40001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/219103002/diff/40001/src/objects.cc#newcode2476
src/objects.cc:2476: // change the actual object size.
On 2014/03/31 13:23:15,
Revision: 20354
Author: joc...@chromium.org
Date: Mon Mar 31 13:23:32 2014 UTC
Log: Revert 20348 - "Fix LoadFieldByIndex to take mutable heap-numbers
into account."
Reason for revert: crashes benchmarks/sunspider/string-fasta on ia32.debug
This also reverts r20350 and r20352
Fix
Committed patchset #1 manually as r20354 (tree was closed).
https://codereview.chromium.org/219393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Yes, this is the first part. The concurrent GC counter-part is in the next
CL.
https://codereview.chromium.org/219103002/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/219103002/diff/40001/src/objects-inl.h#newcode1432
src/objects-inl.h:1432: // h
Reviewers: Toon Verwaest,
Description:
Revert 20348 - "Fix LoadFieldByIndex to take mutable heap-numbers into
account."
Reason for revert: crashes benchmarks/sunspider/string-fasta on ia32.debug
This also reverts r20350 and r20352
Fix LoadFieldByIndex to take mutable heap-numbers into acco
On 2014/03/29 23:14:24, Jakob wrote:
PTAL. Does this fix make sense?
It fixes the symptoms, but not the root bug, which was that the comparisons
"bitset != kNone" should have been refined to IsInhabited(bitset) when I
introduced representation types.
I fixed it here, reusing parts of your CL f
Reviewers: Benedikt Meurer,
Description:
Fix assertion violation in Type::Intersect
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/219333003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+32, -37 lines):
M src/types.cc
A
lgtm.
https://codereview.chromium.org/218493007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Yang,
Description:
We should perform the illegal redeclaration check earlier so that we do not
confuse the AST typer with missing type feedback nodes.
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/218493007/
SVN Base: https://v8.googlecode.com/svn/bran
Reviewers: Dmitry Lomov (chromium),
Description:
Fixed power-of-2 predicates, excluding 0.
Please review this at https://codereview.chromium.org/219213003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+14, -21 lines):
M src/arm/lithium-codegen-arm.cc
M src
As discussed in person, we still need to sync a bit more, see the comments
below. (Obviously, the sweeper will also need to synchronize, but I am
expecting
that to come in a different CL.)
https://codereview.chromium.org/219103002/diff/40001/src/objects-inl.h
File src/objects-inl.h (right):
lgtm with nit:
https://codereview.chromium.org/218783003/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/218783003/diff/1/src/runtime.cc#newcode2971
src/runtime.cc:2971: function->map()->CopyReplaceDescriptor(
Does it make sense to make a handlified wrapper fo
lgtm
https://codereview.chromium.org/218583008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Use JSObject::SetMapAndElements rather than set_map + set_elements.
BUG=
Please review this at https://codereview.chromium.org/218583008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -2 lines):
M src
Revision: 20353
Author: joc...@chromium.org
Date: Mon Mar 31 12:40:32 2014 UTC
Log: Revert 20313 - "Ship promises and weak collections"
R=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20211
Review URL: https://codereview.chromium.org/20616
Committed patchset #1 manually as r20353 (tree was closed).
https://codereview.chromium.org/219303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Addressed comment
https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h#newcode1715
src/objects-inl.h:1715: WRITE_BARRIER(obj->GetHeap(), obj,
kElementsOffset, val);
That makes more s
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Replace uses of set_map by MigrateToMap.
BUG=
Please review this at https://codereview.chromium.org/218783003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+23, -20 lines):
M src/runtime.cc
Index: src/
lgtm with a nit:
https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h
File src/objects-inl.h (right):
https://codereview.chromium.org/218753005/diff/1/src/objects-inl.h#newcode1715
src/objects-inl.h:1715: WRITE_BARRIER(obj->GetHeap(), obj,
kElementsOffset, val);
What about calling
https://codereview.chromium.org/219313002/diff/1/src/ic.cc
File src/ic.cc (right):
https://codereview.chromium.org/219313002/diff/1/src/ic.cc#newcode1187
src/ic.cc:1187: if
(!ic->IsNameCompatibleWithMonomorphicPrototypeFailure(name)) return
false;
This is not exactly the same...
The name only ha
Good catch. LGTM, but protect with a cc-test to trigger this case.
--Michael
https://codereview.chromium.org/219173003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev"
lgtm
https://codereview.chromium.org/219303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
Hi Toon, here is the fix we discussed, have a look, thanks!
--Michael
Description:
Monomorphic prototype failures should be reserved for already-seen keys.
We incorrectly mark a KeyedStoreIC miss as a monomorphic prototype
failure even though it's the first ti
Reviewers: Igor Sheludko,
Message:
Committed patchset #1 manually as r20352 (tree was closed).
Description:
Don't | int and bool
BUG=
R=ish...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=20352
Please review this at https://codereview.chromium.org/219293002/
SVN Base:
Revision: 20352
Author: verwa...@chromium.org
Date: Mon Mar 31 12:24:51 2014 UTC
Log: Don't | int and bool
BUG=
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/219293002
http://code.google.com/p/v8/source/detail?r=20352
Modified:
/branches/bleeding_edge/src/handles
lgtm
https://codereview.chromium.org/219293002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: rossberg,
Description:
Revert 20313 - "Ship promises and weak collections"
R=mstarzin...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20211
Review URL: https://codereview.chromium.org/206163004
TBR=rossb...@chromium.org
LOG=y
BUG=n
Please review
1 - 100 of 159 matches
Mail list logo
