Reviewers: Sven Panne,
Message:
Trivial one... PTAL
Description:
Add unhandlified versions of Of() and NowOf().
Please review this at https://codereview.chromium.org/221813002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -7 lines):
M src/types.h
M
lgtm.
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py
File tools/push-to-trunk/auto_roll.py (right):
https://codereview.chromium.org/212983003/diff/20001/tools/push-to-trunk/auto_roll.py#newcode93
tools/push-to-trunk/auto_roll.py:93: print A author (-a) is
lgtm
https://codereview.chromium.org/221813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
All done.
https://codereview.chromium.org/212983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r20422 (presubmit successful).
https://codereview.chromium.org/212983003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20422
Author: machenb...@chromium.org
Date: Wed Apr 2 06:59:25 2014 UTC
Log: Implement auto-roll script.
This script will (1) check if there is an active roll on rietveld (2) check
if there is a trunk revision ready to be rolled and (3) call the
chromium_roll script,
Revision: 20423
Author: bmeu...@chromium.org
Date: Wed Apr 2 07:01:43 2014 UTC
Log: Add unhandlified versions of Of() and NowOf().
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/221813002
http://code.google.com/p/v8/source/detail?r=20423
Modified:
Committed patchset #1 manually as r20423 (presubmit successful).
https://codereview.chromium.org/221813002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20424
Author: machenb...@chromium.org
Date: Wed Apr 2 07:04:53 2014 UTC
Log: Add execution permission to auto-roll script.
TBR=ja...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/220203010
http://code.google.com/p/v8/source/detail?r=20424
Modified:
Reviewers: jarin,
Message:
Committed patchset #1 manually as r20424 (presubmit successful).
Description:
Add execution permission to auto-roll script.
TBR=ja...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=20424
Please review this at
Reviewers: jarin,
Message:
FYI
Description:
Fix auto-roll configuration.
TBR=ja...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/221833003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 lines):
M
Committed patchset #2 manually as r20425 (presubmit successful).
https://codereview.chromium.org/221833003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20425
Author: machenb...@chromium.org
Date: Wed Apr 2 07:13:17 2014 UTC
Log: Fix auto-roll configuration.
TBR=ja...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/221833003
http://code.google.com/p/v8/source/detail?r=20425
Modified:
Comment #6 on issue 3246 by da...@chromium.org: Weak references should be
handled uniformly
http://code.google.com/p/v8/issues/detail?id=3246
There are situations that you wan't to mix weak and non-weak references in
an array. So alternatively, I think what you really want is a
single
Comment #8 on issue 3246 by svenpa...@chromium.org: Weak references should
be handled uniformly
http://code.google.com/p/v8/issues/detail?id=3246
Continuing #6: ... and by using another word one can easily get the
equivalent of
Committed patchset #1 manually as r20426 (presubmit successful).
https://codereview.chromium.org/220923003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20426
Author: u...@chromium.org
Date: Wed Apr 2 07:59:54 2014 UTC
Log: Lazily initialize the target map list in IC.
This makes sure that we keep the target map list alive in the handle scope
during IC computation.
BUG=
R=verwa...@chromium.org
Review URL:
Reviewers: Dmitry Lomov (chromium),
Description:
Use the correct natives in messages.js
R=dslo...@chromium.org
Please review this at https://codereview.chromium.org/221903002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -2 lines):
M src/messages.js
It seems that this buildbot is green again, so I closed this CL.
https://codereview.chromium.org/212223013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
On 2014/03/20 13:38:14, mvstanton wrote:
Committed patchset #1 manually as r20127 (presubmit successful).
Hi Micheal,
Will V8 back port this patch to 3.24 branch. This CL seems to have big
performance impact on DOM cases. I see that your previous
lgtm
https://codereview.chromium.org/221903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Revision: 20427
Author: yang...@chromium.org
Date: Wed Apr 2 08:21:37 2014 UTC
Log: Use the correct natives in messages.js
R=dslo...@chromium.org
Review URL: https://codereview.chromium.org/221903002
http://code.google.com/p/v8/source/detail?r=20427
Modified:
Committed patchset #1 manually as r20427 (presubmit successful).
https://codereview.chromium.org/221903002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Hi Weiliang,
Ah yes, it has been on my list. I needed to see some results in chrome
first.
I'll make this port in the next day...
Thanks,
--michael
On Wed, Apr 2, 2014 at 10:20 AM, weiliang@intel.com wrote:
On 2014/03/20 13:38:14, mvstanton wrote:
Committed patchset #1 manually as r20127
Status: New
Owner:
New issue 3251 by yak...@gmail.com: Memory Leak essue
http://code.google.com/p/v8/issues/detail?id=3251
Detailed description of the issue.
isolate.cc
StaticInitializer
has
thread_data_table_ = new Isolate::ThreadDataTable();
default_isolate_ = new Isolate();
Following JF's comment, I updated the clobber list of NoBarrier operations
to
include memory, and added a comment explaining why.
Tests showed no difference in the code generated between integrating the
barrier
in the inline asm and using a function MemoryBarrier(), so I prefer not
Comment #1 on issue 3251 by yak...@gmail.com: Memory Leak essue
http://code.google.com/p/v8/issues/detail?id=3251
i am change my isolate.cc code to
struct StaticInitializer {
StaticInitializer() {
Isolate::EnsureDefaultIsolate();
}
~StaticInitializer() {
On 2014/04/02 09:42:26, Alexandre Rames wrote:
Following JF's comment, I updated the clobber list of NoBarrier
operations to
include memory, and added a comment explaining why.
Tests showed no difference in the code generated between integrating the
barrier
in the inline asm and using a
(still lgtm)
https://codereview.chromium.org/217823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
Committed patchset #2 manually as r20428 (presubmit successful).
https://codereview.chromium.org/217823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20428
Author: rossb...@chromium.org
Date: Wed Apr 2 11:03:05 2014 UTC
Log: Make invalid LHSs that are calls late errors
Necessary for web legacy compatibility.
Also fold in additional strict mode checks into LHS checks.
Minor constness clean-ups on the way.
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/a...@chromium.org/213673006/40001
https://codereview.chromium.org/213673006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing
Committed patchset #3 manually as r20429 (presubmit successful).
https://codereview.chromium.org/213673006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20429
Author: a...@chromium.org
Date: Wed Apr 2 11:19:53 2014 UTC
Log: Show references from weak containers as weak in heap snapshots.
BUG=356590
LOG=Y
R=u...@chromium.org, yu...@chromium.org
Review URL: https://codereview.chromium.org/213673006
lgtm
https://codereview.chromium.org/212693006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
Check that environments assigned via AssignEnvironment are actually used.
Removed some temporary marker comments on the way.
Please review this at https://codereview.chromium.org/218403006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
LGTM
https://codereview.chromium.org/218403006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Revision: 20430
Author: svenpa...@chromium.org
Date: Wed Apr 2 11:30:13 2014 UTC
Log: Check that environments assigned via AssignEnvironment are
actually used.
Removed some temporary marker comments on the way.
R=bmeu...@chromium.org
Review URL:
Committed patchset #3 manually as r20430 (presubmit successful).
https://codereview.chromium.org/218403006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
It seems to me that Crankshaft is disabled while making snapshot.
In isolate.cc:
use_crankshaft_ = FLAG_crankshaft !Serializer::enabled()
CPU::SupportsCrankshaft();
Is there particular difficulty in serializing Crankshaft-compiled codes, or
was it
just not worth bothering?
Thanks!
--
--
Revision: 20431
Author: machenb...@chromium.org
Date: Wed Apr 2 11:34:46 2014 UTC
Log: Edited wiki page UsingGit through web user interface.
http://code.google.com/p/v8/source/detail?r=20431
Modified:
/wiki/UsingGit.wiki
===
---
Reviewers: jochen, dcarney,
Message:
Committed patchset #1 manually as r20432 (presubmit successful).
Description:
Remove V8_INLINE from v8-util.h.
(These have been causing compilation problems on some
platforms. For VS, V8_INLINE turns into 'force inline',
which will then cause a problem when
Revision: 20432
Author: vogelh...@chromium.org
Date: Wed Apr 2 12:07:10 2014 UTC
Log: Remove V8_INLINE from v8-util.h.
(These have been causing compilation problems on some
platforms. For VS, V8_INLINE turns into 'force inline',
which will then cause a problem when the compiler won't
Looking good, I like this. The bulk of the comments is about handles vs. raw
pointers.
https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15924
src/objects.cc:15924: MaybeObject*
One clarification.
https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15924
src/objects.cc:15924: MaybeObject*
OrderedHashTableentrysize::EnsureGrowable() {
On 2014/04/02 12:09:37,
Reviewers: Yang,
Description:
Fix HGraphBuilder::BuildAddStringLengths
length == String::kMaxLength is fine and should not bail out.
BUG=chromium:357052
LOG=n
R=yang...@chromium.org
Please review this at https://codereview.chromium.org/222113002/
SVN Base:
On 2014/04/02 12:14:52, Jakob wrote:
lgtm.
https://codereview.chromium.org/222113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Reviewers: marja,
Description:
Make stray 'return' an early error
As required by the spec, and implemented by other browsers.
R=ma...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/220473014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Revision: 20433
Author: jkumme...@chromium.org
Date: Wed Apr 2 12:24:42 2014 UTC
Log: Fix HGraphBuilder::BuildAddStringLengths
length == String::kMaxLength is fine and should not bail out.
BUG=chromium:357052
LOG=n
R=yang...@chromium.org
Review URL:
Committed patchset #1 manually as r20433 (presubmit successful).
https://codereview.chromium.org/222113002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
lgtm
https://codereview.chromium.org/220473014/diff/1/src/runtime.cc
File src/runtime.cc (left):
https://codereview.chromium.org/220473014/diff/1/src/runtime.cc#oldcode2205
src/runtime.cc:2205: return ThrowRedeclarationError(isolate, function,
name);
Why don't we differentiate between
https://codereview.chromium.org/220473014/diff/1/src/runtime.cc
File src/runtime.cc (left):
https://codereview.chromium.org/220473014/diff/1/src/runtime.cc#oldcode2205
src/runtime.cc:2205: return ThrowRedeclarationError(isolate, function,
name);
On 2014/04/02 12:29:57, marja wrote:
Why don't
Committed patchset #1 manually as r20434 (presubmit successful).
https://codereview.chromium.org/220473014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20434
Author: rossb...@chromium.org
Date: Wed Apr 2 12:38:01 2014 UTC
Log: Make stray 'return' an early error
As required by the spec, and implemented by other browsers.
(Plus minor clean-up for redeclaration TypeErrors.)
R=ma...@chromium.org
BUG=
LOG=Y
Review URL:
LGTM, I'll land.
https://codereview.chromium.org/199843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
Committed patchset #1 manually as r20435 (presubmit successful).
https://codereview.chromium.org/199843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20435
Author: jkumme...@chromium.org
Date: Wed Apr 2 12:55:22 2014 UTC
Log: Remove Apple-only GCC_WARN_ABOUT_MISSING_NEWLINE
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/199843003
Patch from Ben Noordhuis b...@strongloop.com.
LGTM, I'll land.
Since this doesn't affect production code, I think we can backport this;
however
it would be great if you could submit patches you want in a given branch
before
we create that branch.
https://codereview.chromium.org/221513002/
--
--
v8-dev mailing list
Committed patchset #1 manually as r20436 (presubmit successful).
https://codereview.chromium.org/221513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20436
Author: jkumme...@chromium.org
Date: Wed Apr 2 13:04:08 2014 UTC
Log: tools: strip whitespace in gen-postmortem-metadata.py
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/221513002
Patch from Ben Noordhuis b...@strongloop.com.
Reviewers: Toon Verwaest, Igor Sheludko,
Message:
Please take a look.
Description:
Introduce UncheckedHandle to police exception checking in handlified code.
Please review this at https://codereview.chromium.org/222163002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
https://codereview.chromium.org/220293002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/220293002/diff/1/src/objects.cc#newcode15924
src/objects.cc:15924: MaybeObject*
OrderedHashTableentrysize::EnsureGrowable() {
On 2014/04/02 12:09:37, Michael Starzinger
Reviewers: Toon Verwaest,
Message:
Using a simpler and more generic approach in inlining immutable properties
like
Math.PI. PTAL.
Description:
Inline loading of immutable properties
Adds detection for property loads that are immutable (non-configurable and
non-writable) and inlines them
Committed patchset #1 manually as r20437 (presubmit successful).
https://codereview.chromium.org/218633014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20437
Author: verwa...@chromium.org
Date: Wed Apr 2 13:30:36 2014 UTC
Log: Replace CopyMap(constructor-initial_map()) by
Map::Create(constructor)
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/218633014
Reviewers: Yang,
Description:
Merged r20436 into 3.25 branch.
tools: strip whitespace in gen-postmortem-metadata.py
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/222133004/
SVN Base: https://v8.googlecode.com/svn/branches/3.25
Affected files (+8, -4
On 2014/04/02 13:34:41, Jakob wrote:
lgtm (rubberstamp)
https://codereview.chromium.org/222133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Reviewers: Toon Verwaest,
Message:
PTAL.
Description:
Update Integer32ToSmiField, SmiToInteger32 and SmiToInteger64 to support
31-bit
SMI for x32 port
Please review this at https://codereview.chromium.org/222133003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected
Committed patchset #1 manually as r20438.
https://codereview.chromium.org/222133004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 20438
Author: jkumme...@chromium.org
Date: Wed Apr 2 13:36:43 2014 UTC
Log: Merged r20436 into 3.25 branch.
tools: strip whitespace in gen-postmortem-metadata.py
R=yang...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/222133004
Revision: 20439
Author: jkumme...@chromium.org
Date: Wed Apr 2 13:37:08 2014 UTC
Log: Tagging version 3.25.28.3
http://code.google.com/p/v8/source/detail?r=20439
Added:
/tags/3.25.28.3
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
https://codereview.chromium.org/222163002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: alph, y.endoh,
Description:
Mark link between (Detached DOM Trees) and Detached DOM Tree as weak.
With this fix (Detached DOM Trees) will not appear in the retainers tree
of a
detached tree.
BUG=
Please review this at https://codereview.chromium.org/221923006/
SVN Base:
Reviewers: Michael Achenbach,
Description:
Make build/gyp_v8 cope with ninja on linux
ninja doesn't support/need the output dir and generator dir flags
BUG=v8:3252
R=machenb...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/222023004/
SVN Base:
Status: Accepted
Owner: joc...@chromium.org
CC: tha...@chromium.org, machenb...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3252 by joc...@chromium.org: it should be possible to use ninja
for every day development
http://code.google.com/p/v8/issues/detail?id=3252
it should be
https://codereview.chromium.org/221923006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
Updates:
Cc: jkumme...@chromium.org
Comment #1 on issue 3252 by joc...@chromium.org: it should be possible to
use ninja for every day development
http://code.google.com/p/v8/issues/detail?id=3252
(No comment was entered for this change.)
--
You received this message because this
https://codereview.chromium.org/221923006/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/221923006/diff/1/src/heap-snapshot-generator.cc#newcode2411
src/heap-snapshot-generator.cc:2411: HeapGraphEdge::kWeak,
May be shortcut?
Drive-by comments.
https://codereview.chromium.org/222163002/diff/20001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode38
src/handles.h:38: class MaybeHandle {
Can we get a few comments above this class about why we have it
Ooops, completely dropped this one on the floor. Addressed comments now.
Landing.
https://codereview.chromium.org/204493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Comment #2 on issue 3252 by tha...@chromium.org: it should be possible to
use ninja for every day development
http://code.google.com/p/v8/issues/detail?id=3252
I talked about this a bit with machenbach a while ago. We came up with
several possible approaches:
config approaches:
1.) Have
drive-by-comment
https://codereview.chromium.org/222163002/diff/20001/src/handles.h
File src/handles.h (right):
https://codereview.chromium.org/222163002/diff/20001/src/handles.h#newcode88
src/handles.h:88: class Handle : public MaybeHandleT {
I find it pretty confusing that a checked handle
On 2014/04/02 14:19:09, alph wrote:
https://codereview.chromium.org/221923006/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
https://codereview.chromium.org/221923006/diff/1/src/heap-snapshot-generator.cc#newcode2411
src/heap-snapshot-generator.cc:2411:
Committed patchset #2 manually as r20440 (presubmit successful).
https://codereview.chromium.org/204493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 20440
Author: mstarzin...@chromium.org
Date: Wed Apr 2 14:47:26 2014 UTC
Log: Fix assert in Runtime_SetIsObserved.
R=rafa...@chromium.org
BUG=chromium:352664
LOG=N
Review URL: https://codereview.chromium.org/204493002
http://code.google.com/p/v8/source/detail?r=20440
Much cleaner!
Could you move the code to BuildNamedAccess though? That's the single
bottleneck
where all named property accesses go through.
https://codereview.chromium.org/220163012/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
Reviewers: Yang,
Message:
yangguo, wdyt?
An alternative solution would be fix all callers, but I think this is more
correct.
Description:
Allow flags strings in quotes.
If the user wants to run Chromium and pass several js flags to V8, the
command
line would be:
chrome --js-flags=--foo
Reviewers: ulan,
Description:
Check in Lithium that allocation size in Smi range.
This is to avoid triggering an assertion from Smi::FromInt. The
generated code is unreachable, so it is not a real bug.
R=u...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/221743005/
lgtm
https://codereview.chromium.org/221743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Starzinger,
Description:
Do not generate LDummyUse instruction for HCapturedObject
LDummyUse confuses the register allocator (since there is no definition
for the use).
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/83002/
SVN
lgtm
lgtm
https://codereview.chromium.org/217343007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
lgtm
https://codereview.chromium.org/217343007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
LGTM.
https://codereview.chromium.org/83002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Extended version of this CL with a dynamic check that CanDeoptimize doesn't
lie:
https://codereview.chromium.org/63002/. No tricky stuff for a better
approximation there yet, but at least it survives our test suite.
https://codereview.chromium.org/210813004/
--
--
v8-dev mailing list
Reviewers: ulan,
Description:
Merged r19804, r19890, r19894, r19935 into 3.24 branch.
fix bad access check check
Check that constant is an integer before getting its value in
HGraphBuilder::MatchRotateRight.
Simplify GetEnumPropertyKeys and avoid trimming fixed arrays in large object
space.
Reviewers: Toon Verwaest, Michael Starzinger,
Message:
PTAL.
Description:
Make maps in monomorphic IC stubs weak.
Maps in monomorphic Load, KeyedLoad, Store, KeyedStore, and CompareNil IC
stubs are treated as weak references by the marking visitor.
During generation of an IC stub with a weak
Comment #3 on issue 3252 by joc...@chromium.org: it should be possible to
use ninja for every day development
http://code.google.com/p/v8/issues/detail?id=3252
I think we should do something along the lines of (3), probably with a
trampoline in the top-level makefile to minimize
On 2014/04/02 14:43:09, loislo wrote:
On 2014/04/02 14:19:09, alph wrote:
https://codereview.chromium.org/221923006/diff/1/src/heap-snapshot-generator.cc
File src/heap-snapshot-generator.cc (right):
lgtm (rubber-stamp)
https://codereview.chromium.org/13004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
1 - 100 of 160 matches
Mail list logo
