Comment #1 on issue 3348 by srl...@gmail.com: v8 Intl doesn't handle
failure conditions
http://code.google.com/p/v8/issues/detail?id=3348
(Oops, it could be a little more detailed.)
the i18n.cc functions do NOT check for null returns from the CreateICUXX..
functions. This can happen if inc
Status: New
Owner:
New issue 3348 by srl...@gmail.com: v8 Intl doesn't handle failure
conditions
http://code.google.com/p/v8/issues/detail?id=3348
Detailed description of the issue.
--
You received this message because this project is configured to send all
issue notifications to thi
Committed as r21471.
https://codereview.chromium.org/297093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 21471
Author: plin...@gmail.com
Date: Fri May 23 19:32:48 2014 UTC
Log: MIPS: Fix r21470 "Reland r21442 Inobject slack tracking is done
on a per-closure basis instead of per-shared info basis."
BUG=
R=plin...@gmail.com
Review URL: https://codereview.chromium.org/297093002
lgtm
https://codereview.chromium.org/297093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc#newcode400
src/mips/builtins-mips.cc:400: __ mov(t2, zero_reg);
On 2014/05/23 19:18:05, Paul Lind wrote:
https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/297093002/diff/1/src/mips/builtins-mips.cc#newcode400
src/mips/builtins-mips.cc:400: __ mov(t2, zero_reg);
Can we add a comment here: // Slack tracki
Reviewers: danno, Igor Sheludko, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Fix r21470 "Reland r21442 Inobject slack tracking is done on a
per-closure
basis instead of per-shared info basis."
BUG=
Please review this at https://codereview.chromium.org/297093002/
SVN Base: g...@githu
Comment #11 on issue 3337 by bradley@gmail.com: Not caching map
transitions when using SetIndexedPropertiesToExternalArrayData()
http://code.google.com/p/v8/issues/detail?id=3337
Any chance we can get this into 3.25 branch?
--
You received this message because this project is configured
Of course t2 is just clobbered, and knowing runtime call sets count to 0
lets us
avoid reloading it.
https://codereview.chromium.org/294973013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to t
On 2014/05/23 18:10:19, Igor Sheludko wrote:
t2 must be set to zero here (which is JSFunction::kNoSlackTracking) since
the
slack tracking is actually over after the runtime call.
Not sure if t7 survives after the runtime call above.
Yep, t7 would get clobbered, and I not understand Runtime
lgtm
https://codereview.chromium.org/299173002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode114
BUILD.gn:114: if (v8_target_arch == "ia32") {
GN uses x86 for this.
https://codereview.chromium.org/299173002/diff/1/BUILD.gn#newcode136
Sorry for being late, but...
https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/40001/src/mips/builtins-mips.cc#newcode401
src/mips/builtins-mips.cc:401: __ Pop(a1, a2);
t2 must be
Committed as r21470.
https://codereview.chromium.org/294973013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receivin
Revision: 21470
Author: plin...@gmail.com
Date: Fri May 23 18:05:40 2014 UTC
Log: MIPS: Reland r21442 "Inobject slack tracking is done on a
per-closure basis instead of per-shared info basis."
Port r21457 (8db39a8)
Original commit message:
This fixes inobject slack tracking for pro
lgtm
https://codereview.chromium.org/294973013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390
src/mips/builtins-mips.cc:390: __
DecodeField(a3, t0);
On 2014/05/23 15:33:39, Paul Lind wrote:
Committed patchset #4 manually as r21469 (presubmit successful).
https://codereview.chromium.org/293743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
LGTM, I'll land this for you.
https://codereview.chromium.org/293743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
On 2014/05/23 10:04:22, danno wrote:
This patch as uploaded doesn't apply to bleeding_edge. Could you please
rebase?
Rebasing is done. Thanks a lot!
https://codereview.chromium.org/293743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Comment #21 on issue 2825 by glaim...@gmail.com: breakpoint resolved to
incorrect location
http://code.google.com/p/v8/issues/detail?id=2825
I'm also baffled that more developers don't have a problem with this. I
can't believe this is still a problem. I can't get the suggested
workarounds
Thanks for detailed review Igor!
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390
src/mips/builtins-mips.cc:390: __
DecodeField(a3, t0);
On 201
Comment #2 on issue 3345 by srl...@gmail.com: i18n: Make break iterator use
optional
http://code.google.com/p/v8/issues/detail?id=3345
space: about 1M of code (linux x86_64) and about 4M of data (which we can
save without this change, but then the code is really dead)
Intl object: break
lgtm
https://codereview.chromium.org/292743009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode390
src/mips/builtins-mips.cc:390: __
DecodeField(a3, t0);
What do you think about storing decoded
One comment, PTAL
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc
File src/mips/builtins-mips.cc (right):
https://codereview.chromium.org/294973013/diff/1/src/mips/builtins-mips.cc#newcode440
src/mips/builtins-mips.cc:440: Label no_inobject_slack_tracking;
The deleted
lgtm
https://codereview.chromium.org/296953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/296953005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: ulan,
Description:
Fix leak in debug mirror cache.
When fetching loaded scripts, mirror objects are created and cached.
If the cache is not cleared, it holds script objects alive.
This also fixes a minor issue with script unloading.
R=u...@chromium.org
BUG=376534
Please review this
Thank you for review. I uploaded new patch set.
https://codereview.chromium.org/292743009/diff/60001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/292743009/diff/60001/src/parser.cc#newcode2858
src/parser.cc:2858: // loop is executed to update the loop variables.
The
Reviewers: danno, Igor Sheludko, Paul Lind, kisg, palfia, dusmil,
Description:
MIPS: Reland r21442 "Inobject slack tracking is done on a per-closure basis
instead of per-shared info basis."
Port r21457 (8db39a8)
Original commit message:
This fixes inobject slack tracking for prototype inheritan
Thanks for adding the comments!
https://codereview.chromium.org/298723014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and st
Revision: 21468
Author: alexandre.ra...@arm.com
Date: Fri May 23 14:06:42 2014 UTC
Log: Allow HPushArgument to handle more than one argument.
R=u...@chromium.org
Review URL: https://codereview.chromium.org/296113008
http://code.google.com/p/v8/source/detail?r=21468
Modified:
/branch
Updates:
Status: Fixed
Cc: verwa...@chromium.org
Comment #1 on issue 3307 by mstarzin...@chromium.org: Incorrect handling of
mutable double boxes by allocation-sinking
http://code.google.com/p/v8/issues/detail?id=3307
This is unrelated to escape analysis. It's a bug in represe
Committed patchset #3 manually as r21468 (presubmit successful).
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21467
Author: mstarzin...@chromium.org
Date: Fri May 23 14:02:08 2014 UTC
Log: Fix representation inference for mutable double boxes.
R=ja...@chromium.org
BUG=v8:3307
TEST=mjsunit/regress/regress-3307
LOG=N
Review URL: https://codereview.chromium.org/298723014
http://code.go
Revision: 21466
Author: dslo...@chromium.org
Date: Fri May 23 14:01:17 2014 UTC
Log: Check for cached transition to ExternalArray elements kind.
R=ish...@chromium.org, verwa...@chromium.org
BUG=v8:3337
LOG=Y
Review URL: https://codereview.chromium.org/291193011
http://code.google.com/
Committed patchset #2 manually as r21467 (presubmit successful).
https://codereview.chromium.org/298723014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Updates:
Status: Fixed
Comment #10 on issue 3337 by dslo...@chromium.org: Not caching map
transitions when using SetIndexedPropertiesToExternalArrayData()
http://code.google.com/p/v8/issues/detail?id=3337
Fixed in https://code.google.com/p/v8/source/detail?r=21466
--
You received thi
Committed patchset #1 manually as r21466 (presubmit successful).
https://codereview.chromium.org/291193011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Done. Will focus on implementation now...
https://codereview.chromium.org/293023006/diff/40001/benchmarks/octane.json
File benchmarks/octane.json (right):
https://codereview.chromium.org/293023006/diff/40001/benchmarks/octane.json#newcode4
benchmarks/octane.json:4: "results_regexp": "^%s: (\\d+
Revision: 21465
Author: alexandre.ra...@arm.com
Date: Fri May 23 13:15:07 2014 UTC
Log: Provide a helper to generate multiple Lithium instructions for
one Hydrogen instruction.
R=jkumme...@chromium.org, u...@chromium.org
Review URL: https://codereview.chromium.org/296993002
http://
Updates:
Owner: mvstan...@chromium.org
Comment #5 on issue 2890 by mvstan...@chromium.org: Deopt loops involving
Math.round / Math.floor
http://code.google.com/p/v8/issues/detail?id=2890
Working on fix...
--
You received this message because this project is configured to send all
i
Committed patchset #2 manually as r21465 (presubmit successful).
https://codereview.chromium.org/296993002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Comment #1 on issue 3345 by pmue...@gmail.com: i18n: Make break iterator
use optional
http://code.google.com/p/v8/issues/detail?id=3345
Some questions:
- how much space are we saving?
- re: "notify .js side that no break iterators are available". Seems like
the "Intl" object is the right
Yep, lgtm
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails fr
On 2014/05/23 10:31:58, ulan wrote:
LGTM with one nit: please use "int" instead of "unsigned" where possible
to
avoid mixing them.
Uploaded the fixed patch. Can you confirm it's still ok?
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://gro
Revision: 21464
Author: ish...@chromium.org
Date: Fri May 23 12:55:57 2014 UTC
Log: Cleanup after inobject slack tracking improvement.
1) %SetExpectedNumberOfProperties() function removed.
2) Obsolete SharedFunctionInfo::BeforeVisitingPointers() removed.
R=mstarzin...@chromium.org
Re
Committed patchset #2 manually as r21464 (presubmit successful).
https://codereview.chromium.org/289283018/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
On 2014/05/23 12:32:48, Yang wrote:
On 2014/05/23 12:30:07, yurys wrote:
> Now that v8's debug agent is removed what is the current way for
debugging
> Node.js?
>
> I'm also curious if it's a part of a bigger debugger clean-up and if so
are
you
> going to remove other methods related to v8
On 2014/05/23 12:30:07, yurys wrote:
Now that v8's debug agent is removed what is the current way for debugging
Node.js?
I'm also curious if it's a part of a bigger debugger clean-up and if so
are
you
going to remove other methods related to v8 built-in debugging protocol?
I wrote a post
Now that v8's debug agent is removed what is the current way for debugging
Node.js?
I'm also curious if it's a part of a bigger debugger clean-up and if so are
you
going to remove other methods related to v8 built-in debugging protocol?
https://codereview.chromium.org/279423004/
--
--
v8-dev
lgtm with a nit:
https://codereview.chromium.org/291193011/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/291193011/diff/1/src/objects.cc#newcode3383
src/objects.cc:3383: // allows to change elements from arbitrary kind to
any
nit: please reformat comment
ht
Reviewers: Benedikt Meurer,
Description:
Various extensions to types
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/296213005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+317, -143 lines):
M src/conversions.h
M src/hyd
lgtm
https://codereview.chromium.org/298723014/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: New
Owner:
New issue 3347 by a...@google.com: Optimization causes dart2js to fail in
Try Dart
http://code.google.com/p/v8/issues/detail?id=3347
Repro:
1. Install Chrome Version 36.0.1985.18 beta
2. Open http://v8.try-dart-lang.appspot.com/
3. Wait for the example to compile
4
Committed patchset #1 manually as r21463 (presubmit successful).
https://codereview.chromium.org/297933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21463
Author: bmeu...@chromium.org
Date: Fri May 23 11:48:40 2014 UTC
Log: Skip dead blocks/instructions in store elimination.
Also improve tracing.
R=ish...@chromium.org
Review URL: https://codereview.chromium.org/297933002
http://code.google.com/p/v8/source/detail?r=21463
https://codereview.chromium.org/293993021/diff/1/include/v8.h
File include/v8.h (right):
https://codereview.chromium.org/293993021/diff/1/include/v8.h#newcode4668
include/v8.h:4668: #ifdef V8_USE_EXTERNAL_STARTUP_DATA
embedders won't see this #define, the api should always be present
https://co
lgtm :(
https://codereview.chromium.org/296133013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/297933002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jarin,
Description:
Fix representation inference for mutable double boxes.
R=ja...@chromium.org
BUG=v8:3307
TEST=mjsunit/regress/regress-3307
Please review this at https://codereview.chromium.org/298723014/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
Revision: 21462
Author: svenpa...@chromium.org
Date: Fri May 23 11:25:23 2014 UTC
Log: Tiny steps towards a non-local 'Merge removable simulates' phase.
Distinguish copying/merging of the state. Better tracing.
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/299883
Committed patchset #1 manually as r21462 (presubmit successful).
https://codereview.chromium.org/299883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Igor Sheludko,
Message:
PTAL
Description:
Skip dead blocks/instructions in store elimination.
Also improve tracing.
Please review this at https://codereview.chromium.org/297933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+8, -3 lines):
M sr
LGTM
https://codereview.chromium.org/299883003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 21461
Author: mstarzin...@chromium.org
Date: Fri May 23 11:12:25 2014 UTC
Log: Revert "Make v8::TryCatch able to consume natively thrown
exceptions (again)."
TBR=machenb...@chromium.org
Review URL: https://codereview.chromium.org/296133013
http://code.google.com/p/v8/sour
Reviewers: Benedikt Meurer,
Message:
Not sure if I can finish this today, so I'd like to land at least the parts
dealing with the structure of copying/merging the state.
Description:
Tiny steps towards a non-local 'Merge removable simulates' phase.
Distinguish copying/merging of the state. Bett
Committed patchset #1 manually as r21461 (presubmit successful).
https://codereview.chromium.org/296133013/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Reviewers: Michael Achenbach,
Description:
Revert "Make v8::TryCatch able to consume natively thrown exceptions
(again)."
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/296133013/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected fil
Committed patchset #3 manually as r21460 (presubmit successful).
https://codereview.chromium.org/294163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21460
Author: yu...@chromium.org
Date: Fri May 23 11:05:22 2014 UTC
Log: Support ES6 weak collections in heap profiler
BUG=chromium:376196
LOG=Y
R=a...@chromium.org, yang...@chromium.org
Review URL: https://codereview.chromium.org/294163005
http://code.google.com/p/v8/source
LGTM with one nit: please use "int" instead of "unsigned" where possible to
avoid mixing them.
https://codereview.chromium.org/296113008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Googl
Looks good. I didn't understand one part with is_observed:
https://codereview.chromium.org/262053011/diff/80001/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/262053011/diff/80001/src/objects.cc#newcode4438
src/objects.cc:4438: } else if (is_observed) {
Shouldn't we
Reviewers: Igor Sheludko, Toon Verwaest,
Message:
PTAL
Description:
Check for cached transition to ExternalArray elements kind.
R=ish...@chromium.org,verwa...@chromium.org
BUG=v8:3337
LOG=Y
Please review this at https://codereview.chromium.org/291193011/
SVN Base: https://v8.googlecode.com/sv
This patch as uploaded doesn't apply to bleeding_edge. Could you please
rebase?
https://codereview.chromium.org/293743005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-
https://codereview.chromium.org/293023006/diff/40001/tools/run-benchmarks.py
File tools/run-benchmarks.py (right):
https://codereview.chromium.org/293023006/diff/40001/tools/run-benchmarks.py#newcode50
tools/run-benchmarks.py:50: "results_regexp": "^%s: (\\d+)$",
Note that some benchmarks have c
Reviewers: ulan,
Description:
Merge the classes Debug and Debugger.
Also:
- moved code around to more appropriate locations
- removed dead code
- inlined where it made sense.
R=u...@chromium.org
Please review this at https://codereview.chromium.org/298863011/
SVN Base: https://v8.googlecode.c
On 2014/05/23 06:16:22, yurys wrote:
Yang, please do OWNERS review
lgtm.
https://codereview.chromium.org/294163005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
On 2014/05/20 19:53:07, Rodolph Perfetta wrote:
On 2014/05/20 19:45:03, Fritz wrote:
> Do I need to do anything else to land this?
I don't think so :-)
Committed, you can close your review.
https://codereview.chromium.org/286193004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://
one kine ping...
https://codereview.chromium.org/262053011/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
Revision: 21459
Author: rodolph.perfe...@arm.com
Date: Fri May 23 09:41:41 2014 UTC
Log: ARM64 simulator fix for EXTR
Fixes extract when imms = 0 because a left shift of 64 is not valid.
R=rodolph.perfe...@arm.com, svenpa...@chromium.org
Review URL: https://codereview.chromium.org/28
Comment #3 on issue 3037 by p.anto...@partner.samsung.com: "bad value
context for arguments value"
http://code.google.com/p/v8/issues/detail?id=3037
I'd like to work on this
--
You received this message because this project is configured to send all
issue notifications to this address.
Yo
Reviewers: brettw,
Description:
Some progress on translating toolchain.gypi to gn
BUG=none
R=bre...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/299173002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+99, -36 lines):
M BUILD.gn
Committed patchset #1 manually as r21458 (presubmit successful).
https://codereview.chromium.org/293223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21458
Author: bmeu...@chromium.org
Date: Fri May 23 09:30:47 2014 UTC
Log: Avoid dynamic initial map check when inlining call-new.
This improves check elimination and removes a load plus
a map check for every inlined call-new.
R=hpa...@chromium.org
Review URL: https://coder
lgtm
https://codereview.chromium.org/293223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #2 on issue 3037 by petka.an...@gmail.com: "bad value context for
arguments value"
http://code.google.com/p/v8/issues/detail?id=3037
I'd like to work on this
--
You received this message because this project is configured to send all
issue notifications to this address.
You may ad
Reviewers: Sven Panne, danno,
Description:
Set SAHF flag correctly in ia32
sahf flag will not be set for ia32 on some old platform because some old
processors does not support CPUID's extended features.
This also avoids redundant cpuid check in ia32 for sahf.
BUG=
Please review this at https:/
Reviewers: Hannes Payer,
Message:
PTAL
Description:
Avoid dynamic initial map check when inlining call-new.
This improves check elimination and removes a load plus
a map check for every inlined call-new.
Please review this at https://codereview.chromium.org/293223002/
SVN Base: https://v8.goo
Status: New
Owner:
New issue 3346 by mjju...@gmail.com: performance drop introduced by
Function::NewInstance() and Object::SetPrototype()
http://code.google.com/p/v8/issues/detail?id=3346
We are upgrading from v3.22.24.19 to v3.25.30, and found there is
significant performance drop int
Committed patchset #2 manually as r21457 (presubmit successful).
https://codereview.chromium.org/292183008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21456
Author: mstarzin...@chromium.org
Date: Fri May 23 08:34:10 2014 UTC
Log: Make v8::TryCatch able to consume natively thrown exceptions
(again).
R=yang...@chromium.org
BUG=chromium:362388
TEST=cctest/test-api/TryCatchNative
LOG=N
Review URL: https://codereview.chromiu
Committed patchset #1 manually as r21456 (presubmit successful).
https://codereview.chromium.org/291393002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Committed patchset #1 manually as r21455 (presubmit successful).
https://codereview.chromium.org/300453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To u
Revision: 21455
Author: joc...@chromium.org
Date: Fri May 23 08:23:41 2014 UTC
Log: Drop gitignore entry for now obsolete test262 archive
BUG=none
R=jkumme...@chromium.org
LOG=n
Review URL: https://codereview.chromium.org/300453003
http://code.google.com/p/v8/source/detail?r=21455
Mo
LGTM (rubber-stamped).
https://codereview.chromium.org/292183008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiv
Revision: 21454
Author: bmeu...@chromium.org
Date: Fri May 23 08:20:34 2014 UTC
Log: Fix compilation errors.
TBR=hpa...@chromium.org
Review URL: https://codereview.chromium.org/291343006
http://code.google.com/p/v8/source/detail?r=21454
Modified:
/branches/bleeding_edge/src/compiler
lgtm
https://codereview.chromium.org/300453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Hannes Payer,
Message:
Committed patchset #1 manually as r21454 (tree was closed).
Description:
Fix compilation errors.
TBR=hpa...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=21454
Please review this at https://codereview.chromium.org/291343006/
SVN Base:
1 - 100 of 118 matches
Mail list logo
