[v8-dev] [v8] r21544 committed - Tagging version 3.27.15

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21544 Author: machenb...@chromium.org Date: Wed May 28 06:49:18 2014 UTC Log: Tagging version 3.27.15 http://code.google.com/p/v8/source/detail?r=21544 Added: /tags/3.27.15 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You rece

[v8-dev] [v8] r21542 committed - Fix path tracer test....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21542 Author: yang...@chromium.org Date: Wed May 28 06:42:01 2014 UTC Log: Fix path tracer test. Path tracer is not compatible with --enable-slow-assert. R=mstarzin...@chromium.org BUG=v8:3350 LOG=N Review URL: https://codereview.chromium.org/297193005 http://code.google.co

[v8-dev] Re: Fix path tracer test. (issue 297193005)

2014-05-27 Thread yangguo
Committed patchset #2 manually as r21542 (presubmit successful). https://codereview.chromium.org/297193005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Set SAHF flag correctly in ia32 (issue 298823008)

2014-05-27 Thread weiliang . lin
On 2014/05/23 09:18:03, Weiliang wrote: Friendly ping. It is not a specific fix for x87 port, but for overall ia32. https://codereview.chromium.org/298823008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] X87: Fix a typo in below CL (issue 301563008)

2014-05-27 Thread weiliang . lin
Reviewers: danno, Description: X87: Fix a typo in below CL r21515 (6d0ec9a) Convert ElementsKind into a BitField BUG= Please review this at https://codereview.chromium.org/301563008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/x87/cod

[v8-dev] X87: Merge Debugger and Debug. (issue 298193004)

2014-05-27 Thread weiliang . lin
Reviewers: danno, Description: X87: Merge Debugger and Debug. port r21524 (af88824) BUG= Please review this at https://codereview.chromium.org/298193004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+15, -14 lines): M src/x87/debug-x87.cc Index: src/x87/

[v8-dev] X87: Convert String array index/length hash to BitField. (issue 298293007)

2014-05-27 Thread weiliang . lin
Reviewers: danno, Description: X87: Convert String array index/length hash to BitField. Port r21533 (736c779) BUG= Please review this at https://codereview.chromium.org/298293007/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+18, -8 lines): M src/x87/macro

[v8-dev] X87: Small changes in preparation for Hydrogen-generated KeyedLoadGeneric (issue 302453011)

2014-05-27 Thread weiliang . lin
Reviewers: danno, Description: X87: Small changes in preparation for Hydrogen-generated KeyedLoadGeneric Port r21535(8bb4c2b) BUG= Please review this at https://codereview.chromium.org/302453011/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -0 lines):

[v8-dev] X87: Avoid HeapObject check in HStoreNamedField. (issue 306483013)

2014-05-27 Thread weiliang . lin
Reviewers: danno, Description: X87: Avoid HeapObject check in HStoreNamedField. port r21509 (78a54b0) Original commit message: This way an HStoreNamedField instruction can never deoptimize itself, which is another important step towards a working store elimination. BUG= Please review this at

[v8-dev] Re: X87: Skip write barriers in the fast case when setting up local context. (issue 307433004)

2014-05-27 Thread weiliang . lin
Committed patchset #1 manually as r21541. https://codereview.chromium.org/307433004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gr

[v8-dev] [v8] r21541 committed - X87: Skip write barriers in the fast case when setting up local contex...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21541 Author: weiliang@intel.com Date: Wed May 28 04:56:28 2014 UTC Log: X87: Skip write barriers in the fast case when setting up local context. Port r21481 (5973b48) Original commit message: The FastNewContextStub always allocates in new space, so we don't need to u

[v8-dev] Reuse ZoneList memory if possible. (issue 302783007)

2014-05-27 Thread bmeurer
Reviewers: jarin, Message: PTAL Description: Reuse ZoneList memory if possible. Clear() is rather wasteful for ZoneLists, because it discards all previously allocated memory, making it impossible to reuse until the whole Zone is released. Better use Rewind(0) in this case, which just resets the

[v8-dev] Re: Allow microtasks to throw exceptions and handle them gracefully (issue 294943009)

2014-05-27 Thread adamk
Ping? Don't worry, no gotos anymore! https://codereview.chromium.org/294943009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group a

[v8-dev] Re: MIPS: Fix improper register use in DoMinMax. (issue 300853002)

2014-05-27 Thread plind44
Committed as r21540. https://codereview.chromium.org/300853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] [v8] r21540 committed - MIPS: Fix improper register use in DoMinMax....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21540 Author: plin...@gmail.com Date: Tue May 27 23:54:07 2014 UTC Log: MIPS: Fix improper register use in DoMinMax. This fixes failure on pidigit benchmark from web-shootout after 840 digits are calculated. TEST= BUG= R=plin...@gmail.com Review URL: https://codereview.chro

[v8-dev] Re: MIPS: Fix improper register use in DoMinMax. (issue 300853002)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/300853002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Simplify, speed-up correct-context ObjectObserve calls (issue 307543008)

2014-05-27 Thread rafaelw
https://codereview.chromium.org/307543008/diff/50001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/307543008/diff/50001/src/objects.h#newcode8797 src/objects.h:8797: kArrayIndexValueBits> {} These aren't a part of this change. git-cl was complaining about style, so I

[v8-dev] Simplify, speed-up correct-context ObjectObserve calls (issue 307543008)

2014-05-27 Thread rafaelw
Reviewers: Toon Verwaest, Description: Simplify, speed-up correct-context ObjectObserve calls The original patch which ensured that Object.observe did allocations in the correct context regressed performance about 12%. This patch gets back most of that (about 11%) by simply returning the corre

[v8-dev] Re: Change arm64 simulator register backing store. (issue 213943002)

2014-05-27 Thread frkoenig via v8-dev
Can I just open this up? Or do I need to create another CL? https://codereview.chromium.org/213943002/diff/180001/src/arm64/simulator-arm64.cc File src/arm64/simulator-arm64.cc (right): https://codereview.chromium.org/213943002/diff/180001/src/arm64/simulator-arm64.cc#newcode839 src/arm64/simu

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread brettw
lgtm https://codereview.chromium.org/293363009/diff/20001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/293363009/diff/20001/BUILD.gn#newcode986 BUILD.gn:986: component("v8") { CAn you indent the stuff inside the if? https://codereview.chromium.org/293363009/ -- -- v8-dev

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread jochen
ptal I also added the v8 target. the only problem is that the resulting binary doesn't work :) https://codereview.chromium.org/293363009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Goog

[v8-dev] Re: Change arm64 simulator register backing store. (issue 213943002)

2014-05-27 Thread frkoenig via v8-dev
Will work on getting this fixed up before Sven gets back. https://codereview.chromium.org/213943002/diff/160001/src/arm64/simulator-arm64.cc File src/arm64/simulator-arm64.cc (right): https://codereview.chromium.org/213943002/diff/160001/src/arm64/simulator-arm64.cc#newcode843 src/arm64/simulat

[v8-dev] Reland "Make 'name' property on functions configurable." (issue 303463006)

2014-05-27 Thread mstarzinger
Reviewers: rossberg, Message: This relands r21492 unchanged, I will wait patiently with landing until the layout test expectation has been rolled into Chrome. Description: Reland "Make 'name' property on functions configurable." R=rossb...@chromium.org BUG=v8: LOG=N Please review this at h

[v8-dev] Add flag to test harness to stop sorting test cases. (issue 307553003)

2014-05-27 Thread mstarzinger
Reviewers: Jakob, Michael Achenbach, Message: Jakob: PTAL. Michael: FYI. Description: Add flag to test harness to stop sorting test cases. R=jkumme...@chromium.org,machenb...@chromium.org Please review this at https://codereview.chromium.org/307553003/ SVN Base: https://v8.googlecode.com/svn/

[v8-dev] MIPS: Fix improper register use in DoMinMax. (issue 300853002)

2014-05-27 Thread dusan . milosavljevic
Reviewers: Paul Lind, kisg, palfia, kilvadyb, Description: MIPS: Fix improper register use in DoMinMax. This fixes failure on pidigit benchmark from web-shootout after 840 digits are calculated. TEST= BUG= Please review this at https://codereview.chromium.org/300853002/ SVN Base: https://v8.g

[v8-dev] Re: First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread brettw
On 2014/05/27 15:36:59, jochen wrote: is script = "mksnapshot" enough to make gn build mksnapshot first? And does it figure out itself that it needs to build mksnapshot for the host arch? No and no. To make it build mksnapshot for the host arch before running the action, do: deps = [ ":mks

[v8-dev] Re: Harden Runtime_FunctionSetPrototype, Isolate::PrintStack (issue 306543002)

2014-05-27 Thread dslomov
lgtm https://codereview.chromium.org/306543002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Inlined optimized runtime functions: expose Runtime versions for direct testing, skip Hydrogen vers... (issue 302703004)

2014-05-27 Thread dslomov
lgtm https://codereview.chromium.org/302703004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: MIPS: Convert String array index/length hash to BitField. (issue 297233007)

2014-05-27 Thread plind44
Committed as r21539. https://codereview.chromium.org/297233007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] [v8] r21539 committed - MIPS: Convert String array index/length hash to BitField....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21539 Author: plin...@gmail.com Date: Tue May 27 17:11:33 2014 UTC Log: MIPS: Convert String array index/length hash to BitField. Port r21533 (736c779) BUG= R=plin...@gmail.com Review URL: https://codereview.chromium.org/297233007 Patch from Balazs Kilvady . http://code.go

[v8-dev] Re: MIPS: Convert String array index/length hash to BitField. (issue 297233007)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/297233007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix check for empty type (issue 307453005)

2014-05-27 Thread rossberg
Committed patchset #1 manually as r21538. https://codereview.chromium.org/307453005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gr

[v8-dev] [v8] r21538 committed - Fix check for empty type...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21538 Author: rossb...@chromium.org Date: Tue May 27 17:07:39 2014 UTC Log: Fix check for empty type R=mstarzin...@chromium.org BUG= Review URL: https://codereview.chromium.org/307453005 http://code.google.com/p/v8/source/detail?r=21538 Modified: /branches/bleeding_edge/sr

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
Committed as r21537. https://codereview.chromium.org/305563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

[v8-dev] [v8] r21537 committed - MIPS: Use TempDoubleRegister....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21537 Author: plin...@gmail.com Date: Tue May 27 17:06:40 2014 UTC Log: MIPS: Use TempDoubleRegister. Port r21517 (53d6507) BUG= R=plin...@gmail.com Review URL: https://codereview.chromium.org/305563002 Patch from Balazs Kilvady . http://code.google.com/p/v8/source/detail?

[v8-dev] Re: Fix check for empty type (issue 307453005)

2014-05-27 Thread mstarzinger
LGTM. https://codereview.chromium.org/307453005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
lgtm https://codereview.chromium.org/305563002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Fix check for empty type (issue 307453005)

2014-05-27 Thread rossberg
Reviewers: Michael Starzinger, Description: Fix check for empty type R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/307453005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/typing.cc Index: src/ty

[v8-dev] MIPS: Convert String array index/length hash to BitField. (issue 297233007)

2014-05-27 Thread kilvadyb
Reviewers: danno, Paul Lind, palfia, kisg, dusmil, Description: MIPS: Convert String array index/length hash to BitField. Port r21533 (736c779) BUG= Please review this at https://codereview.chromium.org/297233007/ SVN Base: https://github.com/v8/v8.git@gbl Affected files (+23, -12 lines):

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread kilvadyb
https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc#newcode1159 src/mips/lithium-mips.cc:1159: LOperand* temp = FixedTemp(f6); On 2014/05/27 13:56:22, Paul Lind

[v8-dev] Re: Issue 1475 in v8: Prototypal inheritance of properties does not maintain accessibility

2014-05-27 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Owner: verwa...@chromium.org Cc: kmilli...@chromium.org Comment #10 on issue 1475 by verwa...@chromium.org: Prototypal inheritance of properties does not maintain accessibility http://code.google.com/p/v8/issues/detail?id=1475 This was fixed ages

[v8-dev] First cut at run_mksnapshot action for gn (issue 293363009)

2014-05-27 Thread jochen
Reviewers: brettw, Message: is script = "mksnapshot" enough to make gn build mksnapshot first? And does it figure out itself that it needs to build mksnapshot for the host arch? Description: First cut at run_mksnapshot action for gn BUG=none R=bre...@chromium.org LOG=n Please review this at

[v8-dev] Rename EnterDebugger to DebugScope. (issue 300683005)

2014-05-27 Thread yangguo
Reviewers: ulan, Message: This depends on https://codereview.chromium.org/297303006/ Description: Rename EnterDebugger to DebugScope. R=u...@chromium.org Please review this at https://codereview.chromium.org/300683005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected f

[v8-dev] Entering debugger scope should not make debugger active. (issue 306563002)

2014-05-27 Thread yangguo
Reviewers: ulan, Message: This depends on https://codereview.chromium.org/297303006/ Description: Entering debugger scope should not make debugger active. The motivation is that by only entering the debugger scope to call into the debug context should not cause code to be compiled for debugging

[v8-dev] Re: Cleanup GetPropertyWithCallback / SetPropertyWithCallback API (issue 305513004)

2014-05-27 Thread ishell
lgtm https://codereview.chromium.org/305513004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Some more debugger-related refactorings. (issue 297303006)

2014-05-27 Thread yangguo
Reviewers: ulan, Message: This depends on https://codereview.chromium.org/300553008/ Description: Some more debugger-related refactorings. R=u...@chromium.org Please review this at https://codereview.chromium.org/297303006/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affec

[v8-dev] Re: Small changes in preparation for Hydrogen-generated KeyedLoadGeneric (issue 303583002)

2014-05-27 Thread danno
Committed patchset #1 manually as r21535 (presubmit successful). https://codereview.chromium.org/303583002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Support external startup data in V8. (issue 293993021)

2014-05-27 Thread vogelheim
PTAL. (Had to rebase, so unfortunately the diffs between versions are hard to read. Is there any way around that?) https://codereview.chromium.org/293993021/diff/40001/src/natives-external.cc File src/natives-external.cc (right): https://codereview.chromium.org/293993021/diff/40001/src/nati

[v8-dev] Extract build configuration into a separate header and move it to the base lib (issue 303463005)

2014-05-27 Thread jochen
Reviewers: Jakob, Description: Extract build configuration into a separate header and move it to the base lib With this, change, atomicops, once, and lazy instance are no longer dependant on v8 core. I'll move them in a follow-up change to the libbase as well. BUG=none R=jkumme...@chromiu

[v8-dev] [v8] r21536 committed - Reland 21529 - "Add a flag to d8 to invoke weak callbacks"...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21536 Author: joc...@chromium.org Date: Tue May 27 15:16:42 2014 UTC Log: Reland 21529 - "Add a flag to d8 to invoke weak callbacks" This will send an idle notification and a low memory notification after each test. For some reason it's not enough to send a low memory not

[v8-dev] Re: Reland 21529 - "Add a flag to d8 to invoke weak callbacks" (issue 297213006)

2014-05-27 Thread jochen
Committed patchset #1 manually as r21536 (presubmit successful). https://codereview.chromium.org/297213006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] [v8] r21535 committed - Small changes in preparation for Hydrogen-generated KeyedLoadGeneric...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21535 Author: da...@chromium.org Date: Tue May 27 15:15:49 2014 UTC Log: Small changes in preparation for Hydrogen-generated KeyedLoadGeneric R=mvstan...@chromium.org Review URL: https://codereview.chromium.org/303583002 http://code.google.com/p/v8/source/detail?r=21535

[v8-dev] Reland 21529 - "Add a flag to d8 to invoke weak callbacks" (issue 297213006)

2014-05-27 Thread jochen
Reviewers: Yang, Description: Reland 21529 - "Add a flag to d8 to invoke weak callbacks" This will send an idle notification and a low memory notification after each test. For some reason it's not enough to send a low memory notification alone. BUG=none R=yang...@chromium.org LOG=n BUG=

[v8-dev] Re: Reland 21529 - "Add a flag to d8 to invoke weak callbacks" (issue 297213006)

2014-05-27 Thread yangguo
On 2014/05/27 15:06:38, jochen wrote: lgtm. https://codereview.chromium.org/297213006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this

[v8-dev] Re: Refactor CallICStub to use a different stub for each customization. (issue 295383004)

2014-05-27 Thread verwaest
lgtm https://codereview.chromium.org/295383004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r21534 committed - Revert "Make 'name' property on functions configurable."...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21534 Author: mstarzin...@chromium.org Date: Tue May 27 15:00:26 2014 UTC Log: Revert "Make 'name' property on functions configurable." R=da...@google.com, da...@chromium.org Review URL: https://codereview.chromium.org/297163009 http://code.google.com/p/v8/source/detail?r=21

[v8-dev] Some debugger-related clean-ups and renamings. (issue 300553008)

2014-05-27 Thread yangguo
Reviewers: ulan, Message: This depends on https://codereview.chromium.org/301563004/ Description: Some debugger-related clean-ups and renamings. R=u...@chromium.org Please review this at https://codereview.chromium.org/300553008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

[v8-dev] Re: Revert "Make 'name' property on functions configurable." (issue 297163009)

2014-05-27 Thread mstarzinger
Committed patchset #1 manually as r21534 (presubmit successful). https://codereview.chromium.org/297163009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: Revert "Make 'name' property on functions configurable." (issue 297163009)

2014-05-27 Thread danno via v8-dev
rubber-stamp lgtm https://codereview.chromium.org/297163009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving e

[v8-dev] Re: Small changes in preparation for Hydrogen-generated KeyedLoadGeneric (issue 303583002)

2014-05-27 Thread danno
Reviewers: mvstanton, https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc#newcode2907 src/hydrogen-instructions.cc:2907: if (representation().IsExte

[v8-dev] Revert "Make 'name' property on functions configurable." (issue 297163009)

2014-05-27 Thread mstarzinger
Reviewers: danno, Message: This reverts a perfectly fine conformance fix because the test expectation didn't make it into Chrome yet and we wouldn't be able to roll V8 otherwise. Description: Revert "Make 'name' property on functions configurable." R=da...@chromium.org Please review this at ht

[v8-dev] [v8] r21533 committed - Convert String array index/length hash to BitField...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21533 Author: da...@chromium.org Date: Tue May 27 14:55:29 2014 UTC Log: Convert String array index/length hash to BitField R=verwa...@chromium.org Review URL: https://codereview.chromium.org/300023011 http://code.google.com/p/v8/source/detail?r=21533 Modified: /branches/b

[v8-dev] Re: Convert String array index/length hash to BitField (issue 300023011)

2014-05-27 Thread danno
Committed patchset #8 manually as r21533 (presubmit successful). https://codereview.chromium.org/300023011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Small changes in preparation for Hydrogen-generated KeyedLoadGeneric (issue 303583002)

2014-05-27 Thread mvstanton
lgtm, just one question below. https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc File src/hydrogen-instructions.cc (right): https://codereview.chromium.org/303583002/diff/1/src/hydrogen-instructions.cc#newcode2907 src/hydrogen-instructions.cc:2907: if (representation

[v8-dev] Re: Unflake and speedup JsNative*Sample cpu profile tests (issue 301603005)

2014-05-27 Thread yurys
lgtm https://codereview.chromium.org/301603005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Unflake and speedup JsNative*Sample cpu profile tests (issue 301603005)

2014-05-27 Thread alph
https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc#newcode404 test/cctest/test-cpu-profiler.cc:404: unsigned min_js_samples, bool start_

[v8-dev] Re: Unflake and speedup JsNative*Sample cpu profile tests (issue 301603005)

2014-05-27 Thread yurys
https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc File test/cctest/test-cpu-profiler.cc (right): https://codereview.chromium.org/301603005/diff/1/test/cctest/test-cpu-profiler.cc#newcode404 test/cctest/test-cpu-profiler.cc:404: unsigned min_js_samples, bool start_

[v8-dev] Re: Split StringLiteral from Literal. (issue 300103005)

2014-05-27 Thread marja
(this turned out to be a side track; closing) https://codereview.chromium.org/300103005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from thi

[v8-dev] Re: Fix path tracer test. (issue 297193005)

2014-05-27 Thread mstarzinger
LGTM. https://codereview.chromium.org/297193005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Refactor after break target computation. (issue 301563004)

2014-05-27 Thread yangguo
Reviewers: ulan, Message: This depends on https://codereview.chromium.org/300793002/ Description: Refactor after break target computation. R=u...@chromium.org Please review this at https://codereview.chromium.org/301563004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affec

[v8-dev] Re: Fix path tracer test. (issue 297193005)

2014-05-27 Thread mstarzinger
This CL seems to contain several changes smashed together ... could you re-upload just the path tracer changes? https://codereview.chromium.org/297193005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscr

[v8-dev] Re: Remove cpp hack to avoid link failures on Windows (issue 298133005)

2014-05-27 Thread yangguo
On 2014/05/27 14:26:40, rossberg wrote: Committed patchset #1 manually as r21532 (tree was closed). lgtm. https://codereview.chromium.org/298133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribe

[v8-dev] Re: Remove cpp hack to avoid link failures on Windows (issue 298133005)

2014-05-27 Thread rossberg
Committed patchset #1 manually as r21532 (tree was closed). https://codereview.chromium.org/298133005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] [v8] r21532 committed - Remove cpp hack to avoid link failures on Windows...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21532 Author: rossb...@chromium.org Date: Tue May 27 14:26:32 2014 UTC Log: Remove cpp hack to avoid link failures on Windows TBR=yang...@chromium.org BUG= Review URL: https://codereview.chromium.org/298133005 http://code.google.com/p/v8/source/detail?r=21532 Modified: /br

[v8-dev] Remove cpp hack to avoid link failures on Windows (issue 298133005)

2014-05-27 Thread rossberg
Reviewers: Yang, Description: Remove cpp hack to avoid link failures on Windows TBR=yang...@chromium.org BUG= Please review this at https://codereview.chromium.org/298133005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+30, -13 lines): M src/types.h M te

[v8-dev] [v8] r21531 committed - Revert "Add a flag to d8 to invoke weak callbacks"...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21531 Author: yang...@chromium.org Date: Tue May 27 14:21:46 2014 UTC Log: Revert "Add a flag to d8 to invoke weak callbacks" This reverts r21529. TBR=joc...@chromium.org Review URL: https://codereview.chromium.org/302543004 http://code.google.com/p/v8/source/detail?r=21531

[v8-dev] Re: Revert "Add a flag to d8 to invoke weak callbacks" (issue 302543004)

2014-05-27 Thread yangguo
Committed patchset #1 manually as r21531 (tree was closed). https://codereview.chromium.org/302543004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] Revert "Add a flag to d8 to invoke weak callbacks" (issue 302543004)

2014-05-27 Thread yangguo
Reviewers: jochen, Description: Revert "Add a flag to d8 to invoke weak callbacks" This reverts r21529. TBR=joc...@chromium.org Please review this at https://codereview.chromium.org/302543004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+11, -26 lines): M

[v8-dev] Unflake and speedup JsNative*Sample cpu profile tests (issue 301603005)

2014-05-27 Thread alph
Reviewers: yurys, loislo, Benedikt Meurer, Description: Unflake and speedup JsNative*Sample cpu profile tests Instead of running cpu profiler for a hundred milliseconds, collecting samples distributed in a non-deterministic way all along the code, make the tests rely on a single sample we collec

[v8-dev] Fix path tracer test. (issue 297193005)

2014-05-27 Thread yangguo
Reviewers: Michael Starzinger, Description: Fix path tracer test. Path tracer is not compatible with --enable-slow-assert. R=mstarzin...@chromium.org BUG=v8:3350 LOG=N Please review this at https://codereview.chromium.org/297193005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_ed

[v8-dev] Cleanup GetPropertyWithCallback / SetPropertyWithCallback API (issue 305513004)

2014-05-27 Thread verwaest
Reviewers: Igor Sheludko, Message: PTAL Description: Cleanup GetPropertyWithCallback / SetPropertyWithCallback API BUG= Please review this at https://codereview.chromium.org/305513004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+139, -153 lines): M src/o

[v8-dev] Re: Convert String array index/length hash to BitField (issue 300023011)

2014-05-27 Thread verwaest
lgtm with comment: please always move hash to index before decoding to avoid destroying hash (on some platforms). https://codereview.chromium.org/300023011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are s

[v8-dev] Issue 3352 in v8: Cpu profiler is missing a native frame

2014-05-27 Thread codesite-noreply via v8-dev
Status: Accepted Owner: a...@chromium.org Labels: Type-Bug Priority-Medium New issue 3352 by a...@chromium.org: Cpu profiler is missing a native frame http://code.google.com/p/v8/issues/detail?id=3352 === cctest/test-cpu-profiler/JsNative1JsNative2JsSample === [Top down]: 0 (root) 0 #1

[v8-dev] Re: Drop unused includes from worker-thread.cc (issue 302463007)

2014-05-27 Thread jochen
Committed patchset #1 manually as r21530 (presubmit successful). https://codereview.chromium.org/302463007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] [v8] r21530 committed - Drop unused includes from worker-thread.cc...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21530 Author: joc...@chromium.org Date: Tue May 27 13:58:51 2014 UTC Log: Drop unused includes from worker-thread.cc BUG=none R=ma...@chromium.org LOG=n Review URL: https://codereview.chromium.org/302463007 http://code.google.com/p/v8/source/detail?r=21530 Modified: /branc

[v8-dev] [v8] r21529 committed - Add a flag to d8 to invoke weak callbacks...

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21529 Author: joc...@chromium.org Date: Tue May 27 13:57:48 2014 UTC Log: Add a flag to d8 to invoke weak callbacks This will send an idle notification and a low memory notification after each test. For some reason it's not enough to send a low memory notification alone. BU

[v8-dev] Re: Add a flag to d8 to invoke weak callbacks (issue 306483006)

2014-05-27 Thread jochen
Committed patchset #2 manually as r21529 (presubmit successful). https://codereview.chromium.org/306483006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] Re: MIPS: Use TempDoubleRegister. (issue 305563002)

2014-05-27 Thread plind44
https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc File src/mips/lithium-mips.cc (right): https://codereview.chromium.org/305563002/diff/1/src/mips/lithium-mips.cc#newcode1159 src/mips/lithium-mips.cc:1159: LOperand* temp = FixedTemp(f6); please remove this one, also. htt

[v8-dev] Re: Establish distributivity for type union & intersection (issue 251753005)

2014-05-27 Thread rossberg
Committed patchset #3 manually as r21528 (presubmit successful). https://codereview.chromium.org/251753005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] [v8] r21526 committed - Skip PathTracer test for now....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21526 Author: yang...@chromium.org Date: Tue May 27 13:40:40 2014 UTC Log: Skip PathTracer test for now. TBR=mstarzin...@chromium.org BUG=3350 LOG=N Review URL: https://codereview.chromium.org/305583002 http://code.google.com/p/v8/source/detail?r=21526 Modified: /branches/

[v8-dev] Convert String array index/length hash to BitField (issue 300023011)

2014-05-27 Thread danno
Reviewers: Toon Verwaest, Message: PTAL Description: Convert String array index/length hash to BitField R=verwa...@chromium.org Please review this at https://codereview.chromium.org/300023011/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+64, -43 lines): M

[v8-dev] Re: Replace STATIC_CHECK with STATIC_ASSERT. (issue 304553002)

2014-05-27 Thread jochen
Committed patchset #1 manually as r21527 (presubmit successful). https://codereview.chromium.org/304553002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To u

[v8-dev] [v8] r21527 committed - Replace STATIC_CHECK with STATIC_ASSERT....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21527 Author: joc...@chromium.org Date: Tue May 27 13:43:29 2014 UTC Log: Replace STATIC_CHECK with STATIC_ASSERT. It's just an alias, and STATIC_ASSERT is used way more often BUG=none R=jkumme...@chromium.org LOG=n Review URL: https://codereview.chromium.org/304553002 http

[v8-dev] Re: Replace STATIC_CHECK with STATIC_ASSERT. (issue 304553002)

2014-05-27 Thread jochen
yes, yes. very happy. https://codereview.chromium.org/304553002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivi

[v8-dev] Re: Add a flag to d8 to invoke weak callbacks (issue 306483006)

2014-05-27 Thread yangguo
LGTM with comment. https://codereview.chromium.org/306483006/diff/1/src/d8.cc File src/d8.cc (right): https://codereview.chromium.org/306483006/diff/1/src/d8.cc#newcode1387 src/d8.cc:1387: } This duplicate code could be factored out into a helper function. https://codereview.chromium.org/30648

[v8-dev] Re: Skip PathTracer test for now. (issue 305583002)

2014-05-27 Thread yangguo
Committed patchset #1 manually as r21526. https://codereview.chromium.org/305583002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gr

[v8-dev] Skip PathTracer test for now. (issue 305583002)

2014-05-27 Thread yangguo
Reviewers: Michael Starzinger, Description: Skip PathTracer test for now. TBR=mstarzin...@chromium.org BUG=3350 LOG=N Please review this at https://codereview.chromium.org/305583002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+3, -0 lines): M test/cctest/

[v8-dev] Add a flag to d8 to invoke weak callbacks (issue 306483006)

2014-05-27 Thread jochen
Reviewers: Yang, Description: Add a flag to d8 to invoke weak callbacks This will send an idle notification and a low memory notification after each test. For some reason it's not enough to send a low memory notification alone. BUG=none R=yang...@chromium.org LOG=n Please review this at https

[v8-dev] [v8] r21525 committed - MIPS: Avoid HeapObject check in HStoreNamedField....

2014-05-27 Thread codesite-noreply via v8-dev
Revision: 21525 Author: plin...@gmail.com Date: Tue May 27 13:37:33 2014 UTC Log: MIPS: Avoid HeapObject check in HStoreNamedField. Port r21509 (78a54b0) Original commit message: This way an HStoreNamedField instruction can never deoptimize itself, which is another important step towa

[v8-dev] Re: MIPS: Avoid HeapObject check in HStoreNamedField. (issue 297143007)

2014-05-27 Thread plind44
Committed as r21525. https://codereview.chromium.org/297143007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receivin

  1   2   >