lgtm
https://codereview.chromium.org/436593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h
File src/compiler/machine-node-factory.h (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/machine-node-factory.h#newcode203
src/compiler/machine-node-factory.h:203: Node*
Int32AddWithOverfl
LGTM with comment.
https://codereview.chromium.org/437583002/diff/1/src/compiler/simplified-lowering.h
File src/compiler/simplified-lowering.h (right):
https://codereview.chromium.org/437583002/diff/1/src/compiler/simplified-lowering.h#newcode19
src/compiler/simplified-lowering.h:19: class Simp
Committed as r22775
https://codereview.chromium.org/431263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Revision: 22775
Author: weiliang@intel.com
Date: Fri Aug 1 01:58:56 2014 UTC
Log: X87: Remove keyed_store_calling convention and friends
port r22706.
original commit message:
Remove keyed_store_calling convention and friends
BUG=
R=weiliang@intel.com
Review URL: https://c
lgtm
https://codereview.chromium.org/431263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
weiliang.
please review this patch.
thanks.
https://codereview.chromium.org/431263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this
Reviewers: Weiliang, Toon Verwaest,
Message:
weiliang.
please review this patch.
thanks.
Description:
X87: Remove keyed_store_calling convention and friends
port r22706.
original commit message:
Remove keyed_store_calling convention and friends
BUG=
Please review this at https://coderevie
Status: New
Owner:
New issue 3482 by kie...@kieran.ca: GC clears outer scope, even when
there's `debugger` statement in inner closure
http://code.google.com/p/v8/issues/detail?id=3482
Currently, unreferenced variables are removed from the lexical scope of
nested callbacks. NBD.
When
Revision: 22774
Author: machenb...@chromium.org
Date: Thu Jul 31 18:49:08 2014 UTC
Log: Tagging version 3.28.52
http://code.google.com/p/v8/source/detail?r=22774
Added:
/tags/3.28.52
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You rece
Yes, that seem correct. Let me know if you have any issues doing this.
On 31 July 2014 17:29, wrote:
> Would like some advice on the best way to keep this patch current relative
> to
> the bleeding edge.
>
> This set of patches will no longer cleanly apply.
>
> I'm using the git svn / git cl i
LGTM with comment.
https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):
https://codereview.chromium.org/432863002/diff/1/build/toolchain.gypi#newcode464
build/toolchain.gypi:464: ['OS=="win" and target_arch=="ia32"', {
better use v8_target_arc
Reviewers: Jakob,
Message:
PTAL
Description:
Only activate SSE2 by default on ia32
Please review this at https://codereview.chromium.org/432863002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -0 lines):
M build/toolchain.gypi
Index: build/toolchain.g
Reviewers: titzer,
Description:
Implement lowering of JSStoreContext to machine operators.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/420073004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+15, -22 lines):
M src/compiler/js
Comment #51 on issue 3006 by r...@chromium.org: Inaccurate sin/cos values
http://code.google.com/p/v8/issues/detail?id=3006
This analysis by the mozilla folks is interesting:
https://bugzilla.mozilla.org/show_bug.cgi?id=967709#c33
They show that over the range 0-1, V8 is off up to 35 ul
On 2014/07/31 11:24:53, rmcilroy wrote:
On 2014/07/31 07:53:55, Yang wrote:
> The CQ bit was unchecked by mailto:yang...@chromium.org
The Android team fixed the issue, however should I still land this to be
safe?
Can I land it now while the tree is still throttled, it should be safe?
Dro
Reviewers: bmeuer_chromium.org,
Description:
TF: Lowering representation changes to machine operators (WIP: need inline
allocation for some). Move tests related to lowering representation changes
into
test-changes-lowering.cc.
R=bme...@chromium.org
BUG=
Please review this at https://coderevi
Would like some advice on the best way to keep this patch current relative
to
the bleeding edge.
This set of patches will no longer cleanly apply.
I'm using the git svn / git cl integration.
So I think I'm supposed to:
$ git svn fetch
$ git svn rebase master
$ git cl rebase
.. fix issues ..
$
Reviewers: Yang,
https://codereview.chromium.org/430213004/diff/1/src/serialize.cc
File src/serialize.cc (right):
https://codereview.chromium.org/430213004/diff/1/src/serialize.cc#newcode530
src/serialize.cc:530:
Add(ExternalReference::flush_icache_function(isolate).address(),
Comment in the st
On 2014/07/30 08:21:21, danno wrote:
Committed patchset #6 manually as r22675 (presubmit successful).
hello this is giving a ton of new warnings on a 64-bit build:
cl : Command line warning D9002 : ignoring unknown option '/arch:SSE2'
This is because SSE2 is always enabled on x86_64.
Can you
Revision: 22772
Author: da...@chromium.org
Date: Thu Jul 31 16:22:27 2014 UTC
Log: Fix Win64 build
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/434623003
http://code.google.com/p/v8/source/detail?r=22772
Modified:
/branches/bleeding_edge/src/compiler/x64/code-ge
Committed patchset #1 manually as r22772 (tree was closed).
https://codereview.chromium.org/434623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Comment #1 on issue 3479 by r...@chromium.org: Math.expm1 is inaccurate
http://code.google.com/p/v8/issues/detail?id=3479
An accurate expm1 function would allow accurate computation of the
hyperbolic functions over the entire domain of finite floating-point
numbers.
--
You received this me
Status: New
Owner:
New issue 3481 by r...@chromium.org: Math.log1p inaccurate
http://code.google.com/p/v8/issues/detail?id=3481
Math.log1p(8070450532247929/Math.pow(2,60)) returns
0.006975613736425138
The correct answer from maxima is
6.975613736425242244226051930404380841777243297883756
Revision: 22771
Author: akos.pa...@imgtec.com
Date: Thu Jul 31 16:15:05 2014 UTC
Log: Tagging version 3.28.51.1
http://code.google.com/p/v8/source/detail?r=22771
Added:
/tags/3.28.51.1
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
Revision: 22770
Author: akos.pa...@imgtec.com
Date: Thu Jul 31 16:14:47 2014 UTC
Log: Version 3.28.51.1 (merged r22708, r22723, r22724)
MIPS: Encapsulate type in the PropertyHandlerCompiler.
MIPS: Encapsulate the holder in the PropertyHolderCompilers.
MIPS: Remove keyed_store_calling
Committed patchset #1 manually as r22770 (tree was closed).
https://codereview.chromium.org/435643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm
https://codereview.chromium.org/434623003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/435643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Revision: 22769
Author: jacob.bram...@arm.com
Date: Thu Jul 31 16:02:27 2014 UTC
Log: Correct a misuse of sizeof (introduced in r22709).
BUG=
R=da...@chromium.org
Review URL: https://codereview.chromium.org/436653002
http://code.google.com/p/v8/source/detail?r=22769
Modified:
/branc
Committed patchset #1 manually as r22769 (tree was closed).
https://codereview.chromium.org/436653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Reviewers: titzer,
Message:
PTAL
Description:
Fix Win64 build
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/434623003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+14, -0 lines):
M src/compiler/x64/code-generator-x64.cc
M s
lgtm
https://codereview.chromium.org/436653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Michael Achenbach, danno, ulan,
Description:
Correct a misuse of sizeof (introduced in r22709).
BUG=
Please review this at https://codereview.chromium.org/436653002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/runtime.cc
I
PTAL.
https://codereview.chromium.org/435643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: Michael Achenbach,
Description:
Version 3.28.51.1 (merged r22708, r22723, r22724)
MIPS: Encapsulate type in the PropertyHandlerCompiler.
MIPS: Encapsulate the holder in the PropertyHolderCompilers.
MIPS: Remove keyed_store_calling convention and friends.
R=machenb...@chromium.org
B
Revision: 22768
Author: mstarzin...@chromium.org
Date: Thu Jul 31 15:36:22 2014 UTC
Log: Add new files to the GN build after r22709.
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/434673002
http://code.google.com/p/v8/source/detail?r=22768
Modified:
/branches/b
Committed patchset #2 manually as r22768 (tree was closed).
https://codereview.chromium.org/434673002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
On 2014/07/31 15:33:14, Alexandra Mikhaylova wrote:
BTW, this is DevTools backend support for this:
https://codereview.chromium.org/433653003/.
https://codereview.chromium.org/416213004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received th
Reviewers: Yang, aandrey,
Description:
Merge three PromiseEvent's into one with the "type" field.
This also adds missing instrumentation and removes resolver tracking.
BUG=v8:3093
Please review this at https://codereview.chromium.org/416213004/
SVN Base: https://v8.googlecode.com/svn/branches
On 2014/07/31 15:18:20, Benedikt Meurer wrote:
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
Comments addressed, also for the GYP file. Thanks. Landing.
https://codereview.chromium.org/434673002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/434673002/diff/1/BUILD.gn#newcode548
BUILD.gn:548: "src/compiler/representation-changer.h",
On 2014/07/31 15:24:50, Jakob
Reviewers: Benedikt Meurer, danno, dcarney (ooto),
Message:
Committed patchset #1 manually as r22767 (tree was closed).
Description:
Skip more test.
TBR=dcar...@chromium.org,bmeu...@chromium.org,da...@chromium.org
BUG=
Committed: https://code.google.com/p/v8/source/detail?r=22767
Please revi
Revision: 22767
Author: machenb...@chromium.org
Date: Thu Jul 31 15:27:03 2014 UTC
Log: Skip more test.
TBR=dcar...@chromium.org,bmeu...@chromium.org,da...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/432823002
http://code.google.com/p/v8/source/detail?r=22767
Modif
https://codereview.chromium.org/429453005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/429453005/diff/1/src/runtime.cc#newcode11201
src/runtime.cc:11201: // Advances the iterator to to the frame that
matches the index and returns
On 2014/07/31 14:43:17, aand
Reviewers: Jakob,
Description:
Add new files to the GN build after r22709.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/434673002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+103, -0 lines):
M BUILD.gn
--
--
v8-dev mail
Updates:
Status: Assigned
Owner: verwa...@chromium.org
Comment #5 on issue 3480 by da...@chromium.org: V8 Array.join performance
regression
http://code.google.com/p/v8/issues/detail?id=3480
(No comment was entered for this change.)
--
You received this message because this pr
Two files appear to be missing:
common-operator.h
opcodes.h
and one has a typo (see below).
Other than that LGTM.
https://codereview.chromium.org/434673002/diff/1/BUILD.gn
File BUILD.gn (right):
https://codereview.chromium.org/434673002/diff/1/BUILD.gn#newcode548
BUILD.gn:548: "src/compiler/
Revision: 22766
Author: mstarzin...@chromium.org
Date: Thu Jul 31 15:19:41 2014 UTC
Log: Ensure environment does not contain nil values.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/436553003
http://code.google.com/p/v8/source/detail?r=22766
Modified:
/branches/
Committed patchset #1 manually as r22766 (tree was closed).
https://codereview.chromium.org/436553003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251
src/compiler/arm/instruction-selector-
Committed patchset #1 manually as r22765 (tree was closed).
https://codereview.chromium.org/436623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/436593002/diff/1/src/compiler/arm/instruction-selector-arm.cc#newcode251
src/compiler/arm/instruction-selector-
Revision: 22765
Author: tit...@chromium.org
Date: Thu Jul 31 15:06:54 2014 UTC
Log: TF: Clear upper bits of ConvertFloat64ToUint32 because Win64.
R=bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/436623002
http://code.google.com/p/v8/source/detail?r=22765
Modifi
LGTM.
https://codereview.chromium.org/430223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Revision: 22764
Author: akos.pa...@imgtec.com
Date: Thu Jul 31 14:56:58 2014 UTC
Log: MIPS64: Fix build after r22709.
BUG=
R=paul.l...@imgtec.com
Review URL: https://codereview.chromium.org/430223002
http://code.google.com/p/v8/source/detail?r=22764
Modified:
/branches/bleeding_edge
Committed patchset #1 manually as r22764 (tree was closed).
https://codereview.chromium.org/430223002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
LGTM
https://codereview.chromium.org/436623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
lgtm
https://codereview.chromium.org/429053005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Description:
TF: Clear upper bits of ConvertFloat64ToUint32 because Win64.
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/436623002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+23, -16 lines):
lgtm w/ comments
https://codereview.chromium.org/429453005/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/429453005/diff/1/src/runtime.cc#newcode11201
src/runtime.cc:11201: // Advances the iterator to to the frame that
matches the index and returns
typo: to t
lgtm
https://codereview.chromium.org/431063003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Revision: 22763
Author: bmeu...@chromium.org
Date: Thu Jul 31 14:30:28 2014 UTC
Log: [turbofan] C calls are broken. Blacklist related tests.
TBR=tit...@chromium.org
Review URL: https://codereview.chromium.org/431063003
http://code.google.com/p/v8/source/detail?r=22763
Modified:
/bra
Reviewers: danno, paul.l..., gergely.kis.imgtec, balazs.kilvady,
dusmil.imgtec,
Message:
PTAL.
Description:
MIPS64: Fix build after r22709.
BUG=
Please review this at https://codereview.chromium.org/430223002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+
Reviewers: titzer,
Message:
Committed patchset #1 manually as r22763 (tree was closed).
Description:
[turbofan] C calls are broken. Blacklist related tests.
TBR=tit...@chromium.org
Committed: https://code.google.com/p/v8/source/detail?r=22763
Please review this at https://codereview.chromium.
Revision: 22762
Author: ish...@chromium.org
Date: Thu Jul 31 14:24:17 2014 UTC
Log: Tagging version 3.26.31.14
http://code.google.com/p/v8/source/detail?r=22762
Added:
/tags/3.26.31.14
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
Revision: 22761
Author: ish...@chromium.org
Date: Thu Jul 31 14:23:34 2014 UTC
Log: Version 3.26.31.14 (merged r21375)
Fix invalid condition in check elimination effects.
BUG=398426
LOG=Y
R=jkumme...@chromium.org
Review URL: https://codereview.chromium.org/435613002
http://code.googl
Committed patchset #1 manually as r22761 (tree was closed).
https://codereview.chromium.org/435613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 22760
Author: tit...@chromium.org
Date: Thu Jul 31 14:17:58 2014 UTC
Log: TF: Disable Win64 as a TurboFan target until calling conventions
are sorted out.
R=da...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/423713003
http://code.google.com/p/v8/source/de
Failed to commit the patch.
Sendingtest/cctest/compiler/test-run-machops.cc
Transmitting file data .svn: Commit failed (details follow):
svn: Commit failed unexpectedly --- please try again later (9)
https://codereview.chromium.org/416213003/
--
--
v8-dev mailing list
v8-dev@googlegroup
Committed patchset #1 manually as r22758 (tree was closed).
https://codereview.chromium.org/430473008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 22759
Author: bmeu...@chromium.org
Date: Thu Jul 31 14:08:08 2014 UTC
Log: Another fix for cctest/test-run-machops/RunLoadImmIndex.
TBR=da...@chromium.org
Review URL: https://codereview.chromium.org/430203002
http://code.google.com/p/v8/source/detail?r=22759
Modified:
/bra
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/machenb...@chromium.org/416213003/1
https://codereview.chromium.org/416213003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Revision: 22758
Author: machenb...@chromium.org
Date: Thu Jul 31 14:07:13 2014 UTC
Log: Whitespace change to trigger bots.
TBR=machenb...@chromium.org
NOTREECHECKS=true
BUG=
Review URL: https://codereview.chromium.org/430473008
http://code.google.com/p/v8/source/detail?r=22758
Modifi
Failed to commit the patch.
Sendingtools/whitespace.txt
Transmitting file data .svn: Commit failed (details follow):
svn: Commit failed unexpectedly --- please try again later (1)
https://codereview.chromium.org/430473008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/machenb...@chromium.org/430473008/1
https://codereview.chromium.org/430473008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/machenb...@chromium.org/430473008/1
https://codereview.chromium.org/430473008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
lgtm
https://codereview.chromium.org/435613002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Jakob,
Description:
Version 3.26.31.14 (merged r21375)
Fix invalid condition in check elimination effects.
BUG=398426
LOG=Y
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/435613002/
SVN Base: https://v8.googlecode.com/svn/branches/3.26
Affected file
lgtm
https://codereview.chromium.org/423713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno,
Description:
TF: Disable Win64 as a TurboFan target until calling conventions are sorted
out.
R=da...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/423713003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -0 l
Comment #4 on issue 3480 by eus...@chromium.org: V8 Array.join performance
regression
http://code.google.com/p/v8/issues/detail?id=3480
Surely, typo. Slow case is arr.join(" ")
--
You received this message because this project is configured to send all
issue notifications to this address.
Comments addressed, PTAL.
https://codereview.chromium.org/429053005/diff/1/src/field-index.cc
File src/field-index.cc (right):
https://codereview.chromium.org/429053005/diff/1/src/field-index.cc#newcode24
src/field-index.cc:24: FieldIndex FieldIndex::ForLookupIterator(const
LookupIterator* look
Reviewers: aandrey,
Description:
Do not include native Javascript in ExecutionState frames.
When a debug event is triggered, the ExecutionState object should not
expose native JS code.
R=aand...@chromium.org
Please review this at https://codereview.chromium.org/429453005/
SVN Base: https://v8
Comment #3 on issue 3480 by eus...@chromium.org: V8 Array.join performance
regression
http://code.google.com/p/v8/issues/detail?id=3480
I meant something like this: http://jsperf.com/join-vs-default-join
--
You received this message because this project is configured to send all
issue noti
On 2014/07/31 10:43:59, Hannes Payer wrote:
LGTM
https://codereview.chromium.org/432743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
Updates:
Cc: jkumme...@chromium.org
Comment #2 on issue 3480 by yang...@chromium.org: V8 Array.join performance
regression
http://code.google.com/p/v8/issues/detail?id=3480
Mind clarifying 'In Chrome 37 arr.join(",") works 10-15 times faster than
arr.join(",")'? Typo?
Jakob, could
Reviewers: titzer,
Message:
PTAL
Description:
[turbofan] Add Int32AddWithOverflow machine operator.
TEST=cctest/test-run-machops,cctest/test-instruction-selector-arm
Please review this at https://codereview.chromium.org/436593002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
lgtm
https://codereview.chromium.org/437513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Cc: yang...@chromium.org rossb...@chromium.org
Comment #1 on issue 3480 by aand...@chromium.org: V8 Array.join performance
regression
http://code.google.com/p/v8/issues/detail?id=3480
(No comment was entered for this change.)
--
You received this message because this project
Revision: 22757
Author: hpa...@chromium.org
Date: Thu Jul 31 12:20:50 2014 UTC
Log: Tagging version 3.26.31.13
http://code.google.com/p/v8/source/detail?r=22757
Added:
/tags/3.26.31.13
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You re
Revision: 22756
Author: hpa...@chromium.org
Date: Thu Jul 31 12:20:32 2014 UTC
Log: Version 3.26.31.13 (merged r22667)
Reduce max executable size limit.
BUG=395679
LOG=N
R=machenb...@chromium.org, ish...@chromium.org
Review URL: https://codereview.chromium.org/416323003
http://code.g
Committed patchset #1 manually as r22756 (tree was closed).
https://codereview.chromium.org/416323003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
lgtm (rubber stamp)
https://codereview.chromium.org/416323003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/416323003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
Reviewers: Igor Sheludko,
Description:
Version 3.26.31.13 (merged r22667)
Reduce max executable size limit.
BUG=395679
LOG=N
R=ish...@chromium.org
Please review this at https://codereview.chromium.org/416323003/
SVN Base: https://v8.googlecode.com/svn/branches/3.26
Affected files (+5, -5 lin
Committed patchset #1 manually as r22755 (tree was closed).
https://codereview.chromium.org/437483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubs
Revision: 22755
Author: mstarzin...@chromium.org
Date: Thu Jul 31 12:07:30 2014 UTC
Log: Unify InstanceofStub interface descriptors.
R=tit...@chromium.org
Review URL: https://codereview.chromium.org/437483003
http://code.google.com/p/v8/source/detail?r=22755
Modified:
/branches/blee
lgtm
https://codereview.chromium.org/437483003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: titzer,
Description:
Unify InstanceofStub interface descriptors.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/437483003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+23, -48 lines):
M src/arm/code-stubs-arm.cc
M
1 - 100 of 179 matches
Mail list logo
