[v8-dev] Re: Add `CheckObjectCoercible` for the `String.prototype` HTML methods (issue 422543003 by math...@qiwi.be)

Note that this patch also contains the (few) commented-out tests for V8 issue 2217 (since the tests are a 1:1 copy of ). Once this lands, I'll upload a new patch for issue 2217. PTAL. https://codereview.chromium.org/422543003/ -- -- v8-dev ma

[v8-dev] Re：waterproof led driver and led lighting driver from hyrite lighting Co

Hello! How are you! I am May from Hyrite Lighting Co. I know you are in the market of led drivers. We are the manufacture of led driver. We have more than 20 years experience in design, development and manufacturing of electronic power supply. The specification and price as below: 1. 12V/24V i

[v8-dev] [v8] r22840 committed - X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs....

Revision: 22840 Author: weiliang@intel.com Date: Tue Aug 5 03:24:18 2014 UTC Log: X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. port r22805 original commit message: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. BUG= R=weiliang@int

[v8-dev] Re: X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 438163003 by chunyang....@intel.com)

Committed as r22840 https://codereview.chromium.org/438163003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 438163003 by chunyang....@intel.com)

lgtm https://codereview.chromium.org/438163003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Avoid one repeated property lookup when computing load ICs. (issue 441873002 by chunyang....@intel.com)

Committed as r22839 https://codereview.chromium.org/441873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] [v8] r22839 committed - X87: Avoid one repeated property lookup when computing load ICs....

Revision: 22839 Author: weiliang@intel.com Date: Tue Aug 5 03:20:18 2014 UTC Log: X87: Avoid one repeated property lookup when computing load ICs. r22802 touches X87 port but it is not changed completely. port r22802. original commit message: Avoid one repeated property look

[v8-dev] Re: X87: Avoid one repeated property lookup when computing load ICs. (issue 441873002 by chunyang....@intel.com)

lgtm https://codereview.chromium.org/441873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] X87: Avoid one repeated property lookup when computing load ICs. (issue 441873002 by chunyang....@intel.com)

Reviewers: Weiliang, Jakob, Message: weiliang. please review and commit it. thanks. Description: X87: Avoid one repeated property lookup when computing load ICs. r22802 touches X87 port but it is not changed completely. port r22802. original commit message: Avoid one repeated property loo

[v8-dev] X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 438163003 by chunyang....@intel.com)

Reviewers: Weiliang, Toon Verwaest, Message: weiliang. please review and commit this patch. thanks. Description: X87: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. This patch contains one changes from R22802. In R22802 patch the X87 port is touched but it's not changed com

[v8-dev] [v8] r22838 committed - Tagging version 3.28.57

Revision: 22838 Author: machenb...@chromium.org Date: Tue Aug 5 00:11:52 2014 UTC Log: Tagging version 3.28.57 http://code.google.com/p/v8/source/detail?r=22838 Added: /tags/3.28.57 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You rece

[v8-dev] Mark global-constructors-listing as failing in TestExpectations (issue 435363002 by ad...@chromium.org)

Reviewers: Michael Achenbach, Message: Committed patchset #2 manually as 22836 (tree was closed). Description: Mark global-constructors-listing as failing in TestExpectations They're failing due to the addition of Symbol to the global scope. These expectations can be removed once https://code

[v8-dev] [v8] r22836 committed - Mark global-constructors-listing as failing in TestExpectations...

Revision: 22836 Author: ad...@chromium.org Date: Mon Aug 4 23:59:25 2014 UTC Log: Mark global-constructors-listing as failing in TestExpectations They're failing due to the addition of Symbol to the global scope. These expectations can be removed once https://codereview.chromium.org

[v8-dev] Re: Update webkit test for expected own properties (issue 439153005 by a...@chromium.org)

I am not in OWNERS, so we should probably get someone else to review... https://codereview.chromium.org/439153005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group

[v8-dev] Re: Issue 2217 in v8: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only "

Updates: Blockedon: v8:2218 Comment #21 on issue 2217 by math...@qiwi.be: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only " http://code.google.com/p/v8/issues/detail?id=2217 I'll wait until the patch for 2218 is merged, as it includes the (co

[v8-dev] Re: Issue 2218 in v8: HTML extensions to String.prototype should throw an error if the `this` object is not coercible (i.e. `null` or `undefined`)

Issue 2218: HTML extensions to String.prototype should throw an error if the `this` object is not coercible (i.e. `null` or `undefined`) http://code.google.com/p/v8/issues/detail?id=2218 This issue is now blocking issue v8:2217. See http://code.google.com/p/v8/issues/detail?id=2217 -- You rece

[v8-dev] Re: Update webkit test for expected own properties (issue 439153005 by a...@chromium.org)

On 2014/08/04 at 20:57:35, adamk wrote: lgtm Thanks. Can you land this for me? https://codereview.chromium.org/439153005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-

[v8-dev] Re: Update webkit test for expected own properties (issue 439153005 by a...@chromium.org)

lgtm https://codereview.chromium.org/439153005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Issue 2217 in v8: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only "

Updates: Owner: mathi...@opera.com Comment #20 on issue 2217 by math...@qiwi.be: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only " http://code.google.com/p/v8/issues/detail?id=2217 (No comment was entered for this change.) -- You received this

[v8-dev] Re: Issue 2217 in v8: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only "

Comment #19 on issue 2217 by math...@qiwi.be: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only " http://code.google.com/p/v8/issues/detail?id=2217 I'd love to! I'll start rebasing my old patch (comment 3) right away. -- You received this message becaus

[v8-dev] [v8] r22835 committed - Tagging version 3.28.55

Revision: 22835 Author: machenb...@chromium.org Date: Mon Aug 4 20:39:15 2014 UTC Log: Tagging version 3.28.55 http://code.google.com/p/v8/source/detail?r=22835 Added: /tags/3.28.55 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You rece

[v8-dev] Update webkit test for expected own properties (issue 439153005 by a...@chromium.org)

Reviewers: adamk, Message: PTAL https://codereview.chromium.org/439153005/diff/1/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt File test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt (right): https://codereview.chromium.org/439153005/diff/1/test/webkit/fast/js/Object-get

[v8-dev] Re: Enable ES6 Symbols by default (issue 421313004 by ad...@chromium.org)

On 2014/08/04 at 19:32:15, rossberg wrote: Hi Adam, sorry, I had my vacation extended by 2 days. I actually had the same CL finished before my vacation, but couldn't land it: https://codereview.chromium.org/405803006/ From a cursory look it seems they are equivalent. :) Ah, I didn't

[v8-dev] Issue 3486 in v8: RegExp.$input is V8 only

Status: Accepted Owner: a...@chromium.org Labels: Type-Bug Priority-Medium New issue 3486 by a...@chromium.org: RegExp.$input is V8 only http://code.google.com/p/v8/issues/detail?id=3486 RegExp.$input is not part of the spec and not implemented in any other browser -- You received this messa

[v8-dev] Re: Enable ES6 Symbols by default (issue 421313004 by ad...@chromium.org)

Hi Adam, sorry, I had my vacation extended by 2 days. I actually had the same CL finished before my vacation, but couldn't land it: https://codereview.chromium.org/405803006/ From a cursory look it seems they are equivalent. :) https://codereview.chromium.org/421313004/ -- -- v8-dev maili

[v8-dev] Re: Fix Object-getOwnPropertyNames test after turning on Symbols (issue 438103002 by ad...@chromium.org)

On 2014/08/04 at 19:17:01, arv wrote: Why don't we update the test so that it does not have an incorrect expectation? That is a good question, but one I want to handle separately. (There a bunch of FAIL lines elsewhere in this test). https://codereview.chromium.org/438103002/ -- -- v8-dev

[v8-dev] Fix spurious debug-script assertion after enabling Symbols (issue 439833002 by ad...@chromium.org)

Reviewers: Dmitry Lomov (chromium), Message: Committed patchset #1 manually as 22834 (tree was closed). Description: Fix spurious debug-script assertion after enabling Symbols This approach, of allowing either N or N+1 in this assert, is the same approach used before my Symbols patch that naive

[v8-dev] [v8] r22834 committed - Fix spurious debug-script assertion after enabling Symbols...

Revision: 22834 Author: ad...@chromium.org Date: Mon Aug 4 19:17:21 2014 UTC Log: Fix spurious debug-script assertion after enabling Symbols This approach, of allowing either N or N+1 in this assert, is the same approach used before my Symbols patch that naively changed to use assertE

[v8-dev] Re: Fix Object-getOwnPropertyNames test after turning on Symbols (issue 438103002 by ad...@chromium.org)

Why don't we update the test so that it does not have an incorrect expectation? https://codereview.chromium.org/438103002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-

[v8-dev] [v8] r22833 committed - Fix Object-getOwnPropertyNames test after turning on Symbols...

Revision: 22833 Author: ad...@chromium.org Date: Mon Aug 4 19:08:13 2014 UTC Log: Fix Object-getOwnPropertyNames test after turning on Symbols TBR=dslo...@chromium.org Review URL: https://codereview.chromium.org/438103002 http://code.google.com/p/v8/source/detail?r=22833 Modified:

[v8-dev] Fix Object-getOwnPropertyNames test after turning on Symbols (issue 438103002 by ad...@chromium.org)

Reviewers: Dmitry Lomov (chromium), Message: Committed patchset #1 manually as 22833 (tree was closed). Description: Fix Object-getOwnPropertyNames test after turning on Symbols TBR=dslo...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22833 Please review this at https:

[v8-dev] [v8] r22832 committed - [Auto-roll] Bump up version to 3.28.56.0...

Revision: 22832 Author: machenb...@chromium.org Date: Mon Aug 4 19:04:14 2014 UTC Log: [Auto-roll] Bump up version to 3.28.56.0 TBR=machenb...@chromium.org Review URL: https://codereview.chromium.org/435233002 http://code.google.com/p/v8/source/detail?r=22832 Modified: /branches/bl

[v8-dev] [Auto-roll] Bump up version to 3.28.56.0 (issue 435233002 by machenb...@chromium.org)

Reviewers: Michael Achenbach, Description: [Auto-roll] Bump up version to 3.28.56.0 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/435233002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/version.cc I

[v8-dev] Re: [Auto-roll] Bump up version to 3.28.56.0 (issue 435233002 by machenb...@chromium.org)

Committed patchset #1 manually as 22832 (tree was closed). https://codereview.chromium.org/435233002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubsc

[v8-dev] Re: Issue 2218 in v8: HTML extensions to String.prototype should throw an error if the `this` object is not coercible (i.e. `null` or `undefined`)

Updates: Status: Assigned Owner: math...@qiwi.be Cc: a...@chromium.org rossb...@chromium.org Comment #12 on issue 2218 by a...@chromium.org: HTML extensions to String.prototype should throw an error if the `this` object is not coercible (i.e. `null` or `undefined`) ht

[v8-dev] Re: Enable ES6 Map and Set by default (issue 427723002 by ad...@chromium.org)

Non owner LGTM https://codereview.chromium.org/427723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emai

[v8-dev] Re: Issue 2217 in v8: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only "

Updates: Status: Accepted Comment #18 on issue 2217 by a...@chromium.org: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only " http://code.google.com/p/v8/issues/detail?id=2217 Mathias, are you planning on fixing this one? -- You received this me

[v8-dev] Re: Enable ES6 Map and Set by default (issue 427723002 by ad...@chromium.org)

Now rebased against bleeding_edge, to tryjobs should work here. Please take a look. https://codereview.chromium.org/427723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: Issue 2217 in v8: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only "

Updates: Cc: a...@chromium.org Comment #17 on issue 2217 by a...@chromium.org: HTML extensions to String.prototype shouldn't escape ', < and > in argument values; only " http://code.google.com/p/v8/issues/detail?id=2217 (No comment was entered for this change.) -- You received this m

[v8-dev] Re: Track usage of "this" and "arguments" in Scope (issue 422923004 by ape...@igalia.com)

FYI, we will need to do the same for super soon... https://codereview.chromium.org/422923004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe fro

[v8-dev] [v8] r22831 committed - Enable ES6 Symbols by default...

Revision: 22831 Author: ad...@chromium.org Date: Mon Aug 4 18:17:54 2014 UTC Log: Enable ES6 Symbols by default In doing so also remove all references to the --harmony-symbols flag. Due to the way context snapshotting works, it's not possible to simply enable the flag by default.

[v8-dev] Re: Enable ES6 Symbols by default (issue 421313004 by ad...@chromium.org)

Committed patchset #1 manually as 22831 (presubmit successful). https://codereview.chromium.org/421313004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Track number of generic ICs per function (issue 441643008 by jkumme...@chromium.org)

Surely these IC-based heuristics are a temporary solution until we have more stable feedback. https://codereview.chromium.org/441643008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google

[v8-dev] Re: Track number of generic ICs per function (issue 441643008 by jkumme...@chromium.org)

Surely these IC-based heuristics are a temporary solution until we have more stable feedback. On Mon, Aug 4, 2014 at 7:59 PM, wrote: > DBC: > > I have seen IC based heuristics misfire for code that is high on direct > function > calls but low on ICs. > > e.g. see http://jsperf.com/standalone-vs

[v8-dev] Re: Track number of generic ICs per function (issue 441643008 by jkumme...@chromium.org)

DBC: I have seen IC based heuristics misfire for code that is high on direct function calls but low on ICs. e.g. see http://jsperf.com/standalone-vs-method/2 where OSR never hits the loop because we use amount of initialized ICs to drive optimization decisions. https://codereview.chromium

[v8-dev] Remove special frontend for callbacks with slow-mode holders. (issue 436273002 by verwa...@chromium.org)

Reviewers: Igor Sheludko, Message: PTAL Description: Remove special frontend for callbacks with slow-mode holders. BUG= Please review this at https://codereview.chromium.org/436273002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+9, -358 lines): M src/arm/

[v8-dev] Re: Issue 3475 in v8: Arrow function declaration cannot be optimized

Updates: Owner: wi...@igalia.com Comment #5 on issue 3475 by wi...@igalia.com: Arrow function declaration cannot be optimized http://code.google.com/p/v8/issues/detail?id=3475 (No comment was entered for this change.) -- You received this message because this project is configured to

[v8-dev] Re: Track number of generic ICs per function (issue 441643008 by jkumme...@chromium.org)

lgtm https://codereview.chromium.org/441643008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 3485 in v8: EcmaScript internal method invariants violated in some cases

Comment #1 on issue 3485 by bzbar...@mit.edu: EcmaScript internal method invariants violated in some cases http://code.google.com/p/v8/issues/detail?id=3485 I would appreciate responses to that thread with an indication of how you propose the invariant violation be resolved so I can spec it

[v8-dev] Re: Move a bunch of GC related files to heap/ subdirectory (issue 437993003 by joc...@chromium.org)

LGTM, first step to get a proper heap/gc interface. Michael, Danno, have you guys seen this? https://codereview.chromium.org/437993003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google

[v8-dev] Issue 3485 in v8: EcmaScript internal method invariants violated in some cases

Status: New Owner: New issue 3485 by bzbar...@mit.edu: EcmaScript internal method invariants violated in some cases http://code.google.com/p/v8/issues/detail?id=3485 See the links in https://mail.mozilla.org/pipermail/es-discuss/2014-July/038524.html which show Chrome violating ES in

[v8-dev] Re: Remove all encountered weak maps from the list of weak collections when incremental marking is abor... (issue 439233002 by hpa...@chromium.org)

https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc#newcode268 test/cctest/test-weakmaps.cc:268: CHECK(*weak_map != NULL); On 2014/08/04 15:3

[v8-dev] Track number of generic ICs per function (issue 441643008 by jkumme...@chromium.org)

Reviewers: Toon Verwaest, Message: PTAL. Description: Track number of generic ICs per function and use it to disable optimization if too many ICs are generic. Please review this at https://codereview.chromium.org/441643008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affec

[v8-dev] Re: Implement lowering of JSStoreProperty to ICs. (issue 434343005 by mstarzin...@chromium.org)

Closing. Superseded by: https://codereview.chromium.org/439263004/ https://codereview.chromium.org/434343005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] Implement lowering of JS[Load,Store][Property,Named] to ICs. (issue 439263004 by mstarzin...@chromium.org)

Reviewers: titzer, Description: Implement lowering of JS[Load,Store][Property,Named] to ICs. R=tit...@chromium.org Please review this at https://codereview.chromium.org/439263004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+140, -27 lines): M src/compiler

[v8-dev] Re: Remove all encountered weak maps from the list of weak collections when incremental marking is abor... (issue 439233002 by hpa...@chromium.org)

Still LGTM. https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/60001/test/cctest/test-weakmaps.cc#newcode268 test/cctest/test-weakmaps.cc:268: CHECK(*weak_map != NULL); nit:

[v8-dev] Re: Remove all encountered weak maps from the list of weak collections when incremental marking is abor... (issue 439233002 by hpa...@chromium.org)

https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc#newcode270 test/cctest/test-weakmaps.cc:270: if (marking->IsStopped()) { On 2014/08/04 15

[v8-dev] [v8] r22830 committed - Also mark as prototype when passing in while creating a function....

Revision: 22830 Author: verwa...@chromium.org Date: Mon Aug 4 15:23:29 2014 UTC Log: Also mark as prototype when passing in while creating a function. BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/422233010 http://code.google.com/p/v8/source/detail?r=22830 M

[v8-dev] Re: Also mark as prototype when passing in while creating a function. (issue 422233010 by verwa...@chromium.org)

Committed patchset #2 manually as 22830 (presubmit successful). https://codereview.chromium.org/422233010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Also mark as prototype when passing in while creating a function. (issue 422233010 by verwa...@chromium.org)

lgtm https://codereview.chromium.org/422233010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Also mark as prototype when passing in while creating a function. (issue 422233010 by verwa...@chromium.org)

Reviewers: Igor Sheludko, Message: PTAL Description: Also mark as prototype when passing in while creating a function. BUG= Please review this at https://codereview.chromium.org/422233010/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+5, -0 lines): M src/f

[v8-dev] [v8] r22829 committed - ARM64: fixed a couple of typos in TF...

Revision: 22829 Author: rodolph.perfe...@arm.com Date: Mon Aug 4 15:17:19 2014 UTC Log: ARM64: fixed a couple of typos in TF BUG= R=bmeu...@chromium.org Review URL: https://codereview.chromium.org/427713003 http://code.google.com/p/v8/source/detail?r=22829 Modified: /branches/bleed

[v8-dev] Re: ARM64: fixed a couple of typos in TF (issue 427713003 by rodolph.perfe...@arm.com)

Committed patchset #1 manually as 22829 (presubmit successful). https://codereview.chromium.org/427713003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Remove all encountered weak maps from the list of weak collections when incremental marking is abor... (issue 439233002 by hpa...@chromium.org)

https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc File test/cctest/test-weakmaps.cc (right): https://codereview.chromium.org/439233002/diff/20001/test/cctest/test-weakmaps.cc#newcode270 test/cctest/test-weakmaps.cc:270: if (marking->IsStopped()) { Please use Simul

[v8-dev] [v8] r22828 committed - Don't insert transitions between maps for prototypes....

Revision: 22828 Author: verwa...@chromium.org Date: Mon Aug 4 15:12:01 2014 UTC Log: Don't insert transitions between maps for prototypes. BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/437953004 http://code.google.com/p/v8/source/detail?r=22828 Modified: /b

[v8-dev] Re: Don't insert transitions between maps for prototypes. (issue 437953004 by verwa...@chromium.org)

Committed patchset #2 manually as 22828 (presubmit successful). https://codereview.chromium.org/437953004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] Re: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s... (issue 439243005 by verwa...@chromium.org)

Committed patchset #2 manually as 22827 (presubmit successful). https://codereview.chromium.org/439243005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] [v8] r22827 committed - Ensure prototypes always stay fast by turning them fast again after an...

Revision: 22827 Author: verwa...@chromium.org Date: Mon Aug 4 15:06:28 2014 UTC Log: Ensure prototypes always stay fast by turning them fast again after an operation that turned them slow BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/439243005 http://code.

[v8-dev] [v8] r22826 committed - Keep function.prototype fast....

Revision: 22826 Author: verwa...@chromium.org Date: Mon Aug 4 15:02:07 2014 UTC Log: Keep function.prototype fast. BUG= R=ish...@chromium.org Review URL: https://codereview.chromium.org/437083004 http://code.google.com/p/v8/source/detail?r=22826 Modified: /branches/bleeding_edge/sr

[v8-dev] Re: Keep function.prototype fast. (issue 437083004 by verwa...@chromium.org)

Committed patchset #4 manually as 22826 (presubmit successful). https://codereview.chromium.org/437083004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To un

[v8-dev] yield* calls @@iterator on iterable (issue 430693003 by wi...@igalia.com)

Reviewers: rossberg, Description: yield* calls @@iterator on iterable R=rossb...@chromium.org BUG=v8:3422 LOG=N Please review this at https://codereview.chromium.org/430693003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+61, -20 lines): M src/parser.h M

[v8-dev] Issue 3484 in v8: yield* should only propagate throw() if iterator has throw() implementation

Status: Accepted Owner: wi...@igalia.com CC: mstarzin...@chromium.org, rossb...@chromium.org, yang...@chromium.org Labels: Type-Bug Priority-Medium New issue 3484 by wi...@igalia.com: yield* should only propagate throw() if iterator has throw() implementation http://code.google.com/p/v8/issu

[v8-dev] Re: [Auto-roll] Bump up version to 3.28.55.0 (issue 436253003 by machenb...@chromium.org)

Committed patchset #1 manually as r22825 (tree was closed). https://codereview.chromium.org/436253003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] [v8] r22825 committed - [Auto-roll] Bump up version to 3.28.55.0...

Revision: 22825 Author: machenb...@chromium.org Date: Mon Aug 4 14:34:14 2014 UTC Log: [Auto-roll] Bump up version to 3.28.55.0 TBR=machenb...@chromium.org Review URL: https://codereview.chromium.org/436253003 http://code.google.com/p/v8/source/detail?r=22825 Modified: /branches/bl

[v8-dev] [Auto-roll] Bump up version to 3.28.55.0 (issue 436253003 by machenb...@chromium.org)

Reviewers: Michael Achenbach, Description: [Auto-roll] Bump up version to 3.28.55.0 TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/436253003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -1 lines): M src/version.cc I

[v8-dev] [v8] r22824 committed - MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs....

Revision: 22824 Author: akos.pa...@imgtec.com Date: Mon Aug 4 14:30:01 2014 UTC Log: MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. Port r22805 (d6b2885f) BUG= R=dusan.milosavlje...@imgtec.com Review URL: https://codereview.chromium.org/439733003 http://code

[v8-dev] Re: MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 439733003 by akos.pa...@imgtec.com)

Committed patchset #1 manually as r22824 (tree was closed). https://codereview.chromium.org/439733003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubs

[v8-dev] Re: Don't insert transitions between maps for prototypes. (issue 437953004 by verwa...@chromium.org)

lgtm with a nit: https://codereview.chromium.org/437953004/diff/60001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/437953004/diff/60001/src/objects.cc#newcode7210 src/objects.cc:7210: result->set_owns_descriptors(false); This is going to be done again in ConnectTr

[v8-dev] Re: Fix more stack smashing bugs in test. (issue 415403008 by tit...@chromium.org)

On 2014/08/04 14:09:58, Michael Starzinger wrote: LGTM. https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc File test/cctest/compiler/test-simplified-lowering.cc (right): https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/tes

[v8-dev] Re: MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 439733003 by akos.pa...@imgtec.com)

LGTM. https://codereview.chromium.org/439733003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r22821 committed - Fix more stack smashing bugs in test....

Revision: 22821 Author: tit...@chromium.org Date: Mon Aug 4 14:17:52 2014 UTC Log: Fix more stack smashing bugs in test. R=mstarzin...@chromium.org BUG= Review URL: https://codereview.chromium.org/415403008 http://code.google.com/p/v8/source/detail?r=22821 Modified: /branches/bleed

[v8-dev] [v8] r22823 committed - Tagging version 3.27.34.11

Revision: 22823 Author: hpa...@chromium.org Date: Mon Aug 4 14:18:22 2014 UTC Log: Tagging version 3.27.34.11 http://code.google.com/p/v8/source/detail?r=22823 Added: /tags/3.27.34.11 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You re

[v8-dev] [v8] r22822 committed - Version 3.27.34.11 (merged r22007, r22019, r22090)...

Revision: 22822 Author: hpa...@chromium.org Date: Mon Aug 4 14:18:05 2014 UTC Log: Version 3.27.34.11 (merged r22007, r22019, r22090) Wait for sweeper threads when expansion of old generation fails. Collect garbage with kReduceMemoryFootprintMask in IdleNotification. Waiting for swe

[v8-dev] Re: Fix more stack smashing bugs in test. (issue 415403008 by tit...@chromium.org)

Committed patchset #2 manually as 22821 (tree was closed). https://codereview.chromium.org/415403008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubsc

[v8-dev] Re: Version 3.27.34.11 (merged r22007, r22019, r22090) (issue 419743003 by hpa...@chromium.org)

Committed patchset #1 manually as 22822 (tree was closed). https://codereview.chromium.org/419743003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubsc

[v8-dev] Re: ARM64: fixed a couple of typos in TF (issue 427713003 by rodolph.perfe...@arm.com)

lgtm https://codereview.chromium.org/427713003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 3.27.34.11 (merged r22007, r22019, r22090) (issue 419743003 by hpa...@chromium.org)

lgtm (rubber stamp) https://codereview.chromium.org/419743003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Version 3.27.34.11 (merged r22007, r22019, r22090) (issue 419743003 by hpa...@chromium.org)

Reviewers: Michael Achenbach, Description: Version 3.27.34.11 (merged r22007, r22019, r22090) Wait for sweeper threads when expansion of old generation fails. Collect garbage with kReduceMemoryFootprintMask in IdleNotification. Waiting for sweeper threads is last resort in SlowAllocateRaw. BU

[v8-dev] Re: Merge three PromiseEvent's into one with the "type" field. (issue 416213004 by amikhayl...@google.com)

LGTM. Will land as soon as the tree allows it. https://codereview.chromium.org/416213004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from th

[v8-dev] Re: Fix more stack smashing bugs in test. (issue 415403008 by tit...@chromium.org)

LGTM. https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc File test/cctest/compiler/test-simplified-lowering.cc (right): https://codereview.chromium.org/415403008/diff/1/test/cctest/compiler/test-simplified-lowering.cc#newcode399 test/cctest/compile

[v8-dev] Re: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s... (issue 439243005 by verwa...@chromium.org)

Updated the ASSERT to ensure that the code itself never made the object slow. It can only be slow because of too many descriptors. https://codereview.chromium.org/439243005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message b

[v8-dev] ARM64: fixed a couple of typos in TF (issue 427713003 by rodolph.perfe...@arm.com)

Reviewers: Benedikt Meurer, ulan, Description: ARM64: fixed a couple of typos in TF BUG= Please review this at https://codereview.chromium.org/427713003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+2, -2 lines): M src/compiler/arm64/instruction-selector-a

[v8-dev] Fix more stack smashing bugs in test. (issue 415403008 by tit...@chromium.org)

Reviewers: Michael Starzinger, Description: Fix more stack smashing bugs in test. R=mstarzin...@chromium.org BUG= Please review this at https://codereview.chromium.org/415403008/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+3, -2 lines): M test/cctest/comp

[v8-dev] Re: Ensure prototypes always stay fast by turning them fast again after an operation that turned them s... (issue 439243005 by verwa...@chromium.org)

lgtm with a nit: https://codereview.chromium.org/439243005/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/439243005/diff/1/src/objects.cc#newcode5711 src/objects.cc:5711: ASSERT(!old_map->is_prototype_map()); I'm afraid that it could fail. https://codereview

[v8-dev] Implement lowering of JSStoreProperty to ICs. (issue 434343005 by mstarzin...@chromium.org)

Reviewers: titzer, Description: Implement lowering of JSStoreProperty to ICs. R=tit...@chromium.org Please review this at https://codereview.chromium.org/434343005/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+36, -2 lines): M src/compiler/js-generic-lower

[v8-dev] Re: Merge three PromiseEvent's into one with the "type" field. (issue 416213004 by amikhayl...@google.com)

On 2014/08/04 13:39:02, aandrey wrote: On 2014/08/04 13:28:22, Yang wrote: > On 2014/08/01 14:55:54, aandrey wrote: > > lgtm > > A bit confused by this. Do we no longer care about the source of the event (aka > type)? we can calculate it from the data set that we receive I've updated the

[v8-dev] Don't insert transitions between maps for prototypes. (issue 437953004 by verwa...@chromium.org)

Reviewers: Igor Sheludko, Message: PTAL Description: Don't insert transitions between maps for prototypes. BUG= Please review this at https://codereview.chromium.org/437953004/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+62, -48 lines): M src/objects.h

[v8-dev] MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. (issue 439733003 by akos.pa...@imgtec.com)

Reviewers: danno, Toon Verwaest, paul.l..., gergely.kis.imgtec, balazs.kilvady, dusmil.imgtec, Message: PTAL. Description: MIPS: Cleanup in stub-cache.cc; remove unused ArrayLength store ICs. Port r22805 (d6b2885f) BUG= Please review this at https://codereview.chromium.org/439733003/ SVN B

[v8-dev] Re: Merge three PromiseEvent's into one with the "type" field. (issue 416213004 by amikhayl...@google.com)

On 2014/08/04 13:28:22, Yang wrote: On 2014/08/01 14:55:54, aandrey wrote: > lgtm A bit confused by this. Do we no longer care about the source of the event (aka type)? we can calculate it from the data set that we receive https://codereview.chromium.org/416213004/ -- -- v8-dev mailing

[v8-dev] Re: Merge three PromiseEvent's into one with the "type" field. (issue 416213004 by amikhayl...@google.com)

On 2014/08/04 13:28:22, Yang wrote: On 2014/08/01 14:55:54, aandrey wrote: > lgtm A bit confused by this. Do we no longer care about the source of the event (aka type)? We do, but we can tell the type according to property values (e.g. parentPromise is not undefined => it's a promise cha

  1   2   >