[v8-dev] [turbofan] Drop obsolete test after r24236. (issue 602193005 by bmeu...@chromium.org)

2014-09-25 Thread bmeurer
Reviewers: jarin, Message: Committed patchset #1 (id:1) manually as 24237 (tree was closed). Description: [turbofan] Drop obsolete test after r24236. This was missing from the previous commit. TBR=ja...@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24237 Please review

[v8-dev] [v8] r24237 committed - [turbofan] Drop obsolete test after r24236....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24237 Author: bmeu...@chromium.org Date: Fri Sep 26 06:52:23 2014 UTC Log: [turbofan] Drop obsolete test after r24236. This was missing from the previous commit. TBR=ja...@chromium.org Review URL: https://codereview.chromium.org/602193005 https://code.google.com/p/v8/source

[v8-dev] Re: Force scavenge in idle notification if we estimate that it will take long. (issue 583593006 by hpa...@chromium.org)

2014-09-25 Thread hpayer
This is now way simpler. PTAL https://codereview.chromium.org/583593006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [turbofan] GraphReducer is more "fixpointish" now. (issue 605933002 by bmeu...@chromium.org)

2014-09-25 Thread bmeurer
Committed patchset #1 (id:1) manually as 24236 (tree was closed). https://codereview.chromium.org/605933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] [v8] r24236 committed - [turbofan] GraphReducer is more "fixpointish" now....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24236 Author: bmeu...@chromium.org Date: Fri Sep 26 06:40:07 2014 UTC Log: [turbofan] GraphReducer is more "fixpointish" now. R=ja...@chromium.org Review URL: https://codereview.chromium.org/605933002 https://code.google.com/p/v8/source/detail?r=24236 Modified: /branches/b

[v8-dev] Re: [turbofan] GraphReducer is more "fixpointish" now. (issue 605933002 by bmeu...@chromium.org)

2014-09-25 Thread jarin
lgtm. https://codereview.chromium.org/605933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from i

[v8-dev] Re: MIPS: Add turbofan support for mips32. (issue 601723002 by paul.l...@imgtec.com)

2014-09-25 Thread bmeurer
On 2014/09/26 at 00:30:18, paul.lind wrote: I should add that this CL does not yet attempt to fix the somewhat ugly but functional AssembleArchBranch()/Boolean(). I do have one improvement in mind there, as discussed in comment #10 above, and I'm certainly open to suggestions. IMO that could

[v8-dev] [turbofan] GraphReducer is more "fixpointish" now. (issue 605933002 by bmeu...@chromium.org)

2014-09-25 Thread bmeurer
Reviewers: jarin, Description: [turbofan] GraphReducer is more "fixpointish" now. R=ja...@chromium.org Please review this at https://codereview.chromium.org/605933002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+5, -8 lines): M src/compiler/graph-reducer.

[v8-dev] Re: [turbofan] GraphReducer is more "fixpointish" now. (issue 605933002 by bmeu...@chromium.org)

2014-09-25 Thread bmeurer
PTAL https://codereview.chromium.org/605933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] [turbofan] GrahpReducer has to be run several times currently. (issue 610513003 by bmeu...@chromium.org)

2014-09-25 Thread bmeurer
Reviewers: Michael Starzinger, Description: [turbofan] GrahpReducer has to be run several times currently. R=mstarzin...@chromium.org Please review this at https://codereview.chromium.org/610513003/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+3, -0 lines):

[v8-dev] MIPS: Add cvt_d_s to disassembler. (issue 605113002 by paul.l...@imgtec.com)

2014-09-25 Thread paul . lind
Reviewers: danno, dusmil.imgtec, balazs.kilvady, akos.palfi.imgtec, Message: PTAL. Now using this instruction in turbofan. Description: MIPS: Add cvt_d_s to disassembler. BUG= Please review this at https://codereview.chromium.org/605113002/ SVN Base: https://v8.googlecode.com/svn/branches/ble

[v8-dev] Re: Initial implementation of GetStackSample sampling profiler API. (issue 596533002 by a...@chromium.org)

2014-09-25 Thread bmeurer
lgtm https://codereview.chromium.org/596533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] ARM64 support for multiply-accumulate (issue 605693003 by m.m.capew...@googlemail.com)

2014-09-25 Thread bmeurer
Nice work. LGTM. https://codereview.chromium.org/605693003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving em

[v8-dev] Re: Issue 3596 in v8: V8 new Set problem

2014-09-25 Thread codesite-noreply via v8-dev
Comment #2 on issue 3596 by fedor.in...@gmail.com: V8 new Set problem https://code.google.com/p/v8/issues/detail?id=3596 Arv, could you please post a link to a changeset that does fix it? We are using `3.26.x` in v0.11 node.js, and are blocked by DebuggerProtocol removal (so we can't really

[v8-dev] Re: X87: convert disassembler to use OStream. (issue 607723003 by chunyang....@intel.com)

2014-09-25 Thread weiliang . lin
Committed as r24235 https://codereview.chromium.org/607723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] [v8] r24235 committed - X87: convert disassembler to use OStream....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24235 Author: weiliang@intel.com Date: Fri Sep 26 01:12:13 2014 UTC Log: X87: convert disassembler to use OStream. port r24214. original commit message: convert disassembler to use OStream. BUG= R=weiliang@intel.com Review URL: https://codereview.chromium.org/60

[v8-dev] Re: X87: convert disassembler to use OStream. (issue 607723003 by chunyang....@intel.com)

2014-09-25 Thread weiliang . lin
lgtm https://codereview.chromium.org/607723003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] X87: convert disassembler to use OStream. (issue 607723003 by chunyang....@intel.com)

2014-09-25 Thread chunyang . dai
Reviewers: Weiliang, dcarney, Message: WL. PTAL. thanks Description: X87: convert disassembler to use OStream. port r24214. original commit message: convert disassembler to use OStream. BUG= Please review this at https://codereview.chromium.org/607723003/ SVN Base: https://chromium.googl

Re: [v8-dev] Add a fast case for one-element string arrays in ArrayJoin (issue 607503004 by fmea...@chromium.org)

2014-09-25 Thread 'Erik Arvidsson' via v8-dev
Is this worth it? It makes all the other cases slower. Is a single element string common enough that this extra branch is needed? On Sep 25, 2014 8:52 PM, wrote: > Reviewers: Yang, > > Message: > PTAL. > > Description: > Add a fast case for one-element string arrays in ArrayJoin > > This case han

[v8-dev] Re: Add a fast case for one-element string arrays in ArrayJoin (issue 607503004 by fmea...@chromium.org)

2014-09-25 Thread fmeawad
https://codereview.chromium.org/607503004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Add a fast case for one-element string arrays in ArrayJoin (issue 607503004 by fmea...@chromium.org)

2014-09-25 Thread fmeawad
Reviewers: Yang, Message: PTAL. Description: Add a fast case for one-element string arrays in ArrayJoin This case handles CONS_ONE_BYTE_STRING_TYPE as well as Two Byte strings. BUG= Please review this at https://codereview.chromium.org/607503004/ SVN Base: https://v8.googlecode.com/svn/branc

[v8-dev] Re: MIPS: Add turbofan support for mips32. (issue 601723002 by paul.l...@imgtec.com)

2014-09-25 Thread paul . lind
I should add that this CL does not yet attempt to fix the somewhat ugly but functional AssembleArchBranch()/Boolean(). I do have one improvement in mind there, as discussed in comment #10 above, and I'm certainly open to suggestions. IMO that could be a follow-on CL. https://codereview.chromi

[v8-dev] Re: MIPS: Add turbofan support for mips32. (issue 601723002 by paul.l...@imgtec.com)

2014-09-25 Thread paul . lind
PTAL, it's rebased, comments addressed, and passes all the tests. https://codereview.chromium.org/601723002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] [v8] r24234 committed - Tagging version 3.29.91

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24234 Author: machenb...@chromium.org Date: Fri Sep 26 00:07:30 2014 UTC Log: Tagging version 3.29.91 https://code.google.com/p/v8/source/detail?r=24234 Added: /tags/3.29.91 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You rec

[v8-dev] Re: Issue 3579 in v8: Math.log2 and Math.log10 should be exact for exact powers

2014-09-25 Thread codesite-noreply via v8-dev
Comment #7 on issue 3579 by r...@chromium.org: Math.log2 and Math.log10 should be exact for exact powers https://code.google.com/p/v8/issues/detail?id=3579 Here is a port of fdlibm's log10: www/~rtoy/V8/log10.js with tests in log10-tests.js and test driver test-log10.html -- You received

[v8-dev] Re: Issue 3579 in v8: Math.log2 and Math.log10 should be exact for exact powers

2014-09-25 Thread codesite-noreply via v8-dev
Comment #6 on issue 3579 by r...@chromium.org: Math.log2 and Math.log10 should be exact for exact powers https://code.google.com/p/v8/issues/detail?id=3579 Oh, it may be true that log10(10^n) = n for n > 22 (and even for n < 0), but since 10^n isn't exactly representable, this needs to be i

[v8-dev] Re: Issue 3596 in v8: V8 new Set problem

2014-09-25 Thread codesite-noreply via v8-dev
Updates: Status: Fixed Owner: a...@chromium.org Comment #1 on issue 3596 by a...@chromium.org: V8 new Set problem https://code.google.com/p/v8/issues/detail?id=3596 This has been fixed. You need a newer version. -- You received this message because this project is configured t

[v8-dev] Re: MIPS: Add turbofan support for mips32. (issue 601723002 by paul.l...@imgtec.com)

2014-09-25 Thread paul . lind
Hey guys, thanks for all your feedback! Most things have been addressed, though a couple are still up for further discussion. This is NOT ready for landing yet, still need to rebase to today and add Benedikt's float32 constant change. And I have one small bug still to chase. https://coderevi

[v8-dev] Issue 3596 in v8: V8 new Set problem

2014-09-25 Thread codesite-noreply via v8-dev
Status: New Owner: New issue 3596 by ilia...@gmail.com: V8 new Set problem https://code.google.com/p/v8/issues/detail?id=3596 new Set([1,2]).size === 0 (should be 2) v8: '3.26.33', -- You received this message because this project is configured to send all issue notifications to this ad

[v8-dev] Re: Issue 2323 in v8: Add forEach to Map and Set

2014-09-25 Thread codesite-noreply via v8-dev
Comment #15 on issue 2323 by ilia...@gmail.com: Add forEach to Map and Set https://code.google.com/p/v8/issues/detail?id=2323 P.S. That was from the recent node.js 0.11.14 which has "v8: Upgrade to 3.26.33" -- You received this message because this project is configured to send all issue n

[v8-dev] Re: Issue 2323 in v8: Add forEach to Map and Set

2014-09-25 Thread codesite-noreply via v8-dev
Comment #14 on issue 2323 by ilia...@gmail.com: Add forEach to Map and Set https://code.google.com/p/v8/issues/detail?id=2323 ``` new Set([1,2]).forEach(function(item) { console.log(item); }); ``` Outputs nothing. Looks like a bug isn't it? -- You received this message because this project is

[v8-dev] Re: Add new git port to merge_to_branch script. (issue 604853002 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/604853002/diff/20001/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/604853002/diff/20001/tools/push-to-trunk/common_includes.py#newcode780 tools/push-to-trunk/common_includes.py:7

[v8-dev] Add new git port to merge_to_branch script. (issue 604853002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Reviewers: tandrii, Message: PTAL. The test is 1:1 c/p to ease review. After the git switch, the first test will be dropped again. https://codereview.chromium.org/604853002/diff/1/tools/push-to-trunk/test_scripts.py File tools/push-to-trunk/test_scripts.py (right): https://codereview.chromi

[v8-dev] Re: Stores and compound assignments for named super properties. (issue 593073002 by dslo...@chromium.org)

2014-09-25 Thread arv
https://codereview.chromium.org/593073002/diff/40001/test/mjsunit/harmony/super.js File test/mjsunit/harmony/super.js (right): https://codereview.chromium.org/593073002/diff/40001/test/mjsunit/harmony/super.js#newcode144 test/mjsunit/harmony/super.js:144: }()); Can you add a test of a strict fun

[v8-dev] Re: Correct bailout from TurboFan for unsupported targets. (issue 603923002 by mstarzin...@chromium.org)

2014-09-25 Thread mstarzinger
Committed patchset #1 (id:1) manually as 24232 (tree was closed). https://codereview.chromium.org/603923002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] [v8] r24232 committed - Correct bailout from TurboFan for unsupported targets....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24232 Author: mstarzin...@chromium.org Date: Thu Sep 25 15:26:03 2014 UTC Log: Correct bailout from TurboFan for unsupported targets. R=tit...@chromium.org TEST=mjsunit/asm/math-fround Review URL: https://codereview.chromium.org/603923002 https://code.google.com/p/v8/source/

[v8-dev] Re: ES6: Disallow binary and octal representation in Number (issue 587873002 by a...@chromium.org)

2014-09-25 Thread arv
Going to close this after TC39's conclusion to make ToNumber support all number literals. https://codereview.chromium.org/587873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google G

[v8-dev] Re: ExtendStorageStub added, it is aimed for extending objects backing store when it runs out of space. (issue 587203002 by ish...@chromium.org)

2014-09-25 Thread ishell
Yang, PTAL. https://codereview.chromium.org/587203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread ulan
lgtm https://codereview.chromium.org/608503002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: [turbofan] more verification of rpo (issue 603533002 by dcar...@chromium.org)

2014-09-25 Thread titzer
https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/603533002/diff/1/src/compiler/scheduler.cc#newcode879 src/compiler/scheduler.cc:879: } Can we put this new code into ScheduleVerifier::Run()? https:

[v8-dev] Re: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread yangguo
https://codereview.chromium.org/608503002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, send

[v8-dev] Re: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread yangguo
On 2014/09/25 14:39:12, aandrey wrote: On 2014/09/25 14:34:02, Yang wrote: > Would it make sense to have v8::Function::IsGenerator() instead of > v8::Value::IsGeneratorFunction()? > > Adding Ulan because this is an API change. It's your call. To me, it's clearer to have the IsGeneratorFunct

[v8-dev] Re: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread aandrey
On 2014/09/25 14:34:02, Yang wrote: Would it make sense to have v8::Function::IsGenerator() instead of v8::Value::IsGeneratorFunction()? Adding Ulan because this is an API change. It's your call. To me, it's clearer to have the IsGeneratorFunction/IsGeneratorObject pair than IsGenerator/I

[v8-dev] Re: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread yangguo
Would it make sense to have v8::Function::IsGenerator() instead of v8::Value::IsGeneratorFunction()? Adding Ulan because this is an API change. https://codereview.chromium.org/608503002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received th

[v8-dev] Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. (issue 608503002 by aand...@chromium.org)

2014-09-25 Thread aandrey
Reviewers: wingo, yangguo, Description: Add IsGeneratorFunction and IsGeneratorObject checks to v8::Value. R=yangguo, wingo Please review this at https://codereview.chromium.org/608503002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+48, -0 lines): M inclu

[v8-dev] Re: Correct bailout from TurboFan for unsupported targets. (issue 603923002 by mstarzin...@chromium.org)

2014-09-25 Thread titzer
On 2014/09/25 12:52:09, Michael Starzinger wrote: On 2014/09/25 11:25:15, titzer wrote: > Does this mean that TypedLowering cannot run on non-supported platforms because > of the builtin reducer (in turn because of Linkage?). If that's the case, then > that should get better when we split lin

[v8-dev] Re: Refactoring: Remove unnecessary logic from push_to_trunk. (issue 598403003 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/598403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Disable version increment and tagging until after the git migration. (issue 609443002 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/609443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r24231 committed - Refactoring: Remove unnecessary logic from push_to_trunk....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24231 Author: machenb...@chromium.org Date: Thu Sep 25 14:09:34 2014 UTC Log: Refactoring: Remove unnecessary logic from push_to_trunk. Remove some svnish things that are output-only. BUG=chromium:410721 LOG=n TBR=tand...@chromium.org Review URL: https://codereview.chromium

[v8-dev] Re: Refactoring: Remove unnecessary logic from push_to_trunk. (issue 598403003 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Committed patchset #1 (id:1) manually as 24231 (tree was closed). https://codereview.chromium.org/598403003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] Re: Stores and compound assignments for named super properties. (issue 593073002 by dslo...@chromium.org)

2014-09-25 Thread dslomov
Feedback addressed, starting platform ports https://codereview.chromium.org/593073002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this

[v8-dev] Re: Initial implementation of GetStackSample sampling profiler API. (issue 596533002 by a...@chromium.org)

2014-09-25 Thread alph
On 2014/09/25 06:08:39, Benedikt Meurer wrote: Tests are failing on ARM? Fixed. Simulator is probably managing stack at some distinct location, so passing a raw sp just didn't work. ptal https://codereview.chromium.org/596533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gr

[v8-dev] Re: Stores and compound assignments for named super properties. (issue 593073002 by dslo...@chromium.org)

2014-09-25 Thread dslomov
https://codereview.chromium.org/593073002/diff/20001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/593073002/diff/20001/src/runtime.cc#newcode2118 src/runtime.cc:2118: if (!proto->IsJSReceiver()) return isolate->heap()->undefined_value(); On 2014/09/25 13:51:41, arv

[v8-dev] Re: Stores and compound assignments for named super properties. (issue 593073002 by dslo...@chromium.org)

2014-09-25 Thread arv
https://codereview.chromium.org/593073002/diff/20001/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/593073002/diff/20001/src/runtime.cc#newcode2118 src/runtime.cc:2118: if (!proto->IsJSReceiver()) return isolate->heap()->undefined_value(); On 2014/09/24 16:23:46, Dmi

[v8-dev] Refactoring: Remove unnecessary logic from push_to_trunk. (issue 598403003 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Reviewers: tandrii, Jakob, Message: PTAL Description: Refactoring: Remove unnecessary logic from push_to_trunk. Remove some svnish things that are output-only. BUG=chromium:410721 LOG=n TBR=tand...@chromium.org Please review this at https://codereview.chromium.org/598403003/ SVN Base: https:

[v8-dev] Re: Disable version increment and tagging until after the git migration. (issue 609443002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Committed patchset #2 (id:20001) manually as 24230 (tree was closed). https://codereview.chromium.org/609443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r24230 committed - Disable version increment and tagging until after the git migration....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24230 Author: machenb...@chromium.org Date: Thu Sep 25 13:36:08 2014 UTC Log: Disable version increment and tagging until after the git migration. BUG=chromium:410721 LOG=n TBR=tand...@chromium.org Review URL: https://codereview.chromium.org/609443002 https://code.google.

[v8-dev] Disable version increment and tagging until after the git migration. (issue 609443002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Reviewers: tandrii, Message: PTAL Description: Disable version increment and tagging until after the git migration. BUG=chromium:410721 LOG=n Please review this at https://codereview.chromium.org/609443002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+12, -

[v8-dev] Disable version increment and tagging until after the git migration. (issue 609443002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Reviewers: tandrii, Message: PTAL Description: Disable version increment and tagging until after the git migration. BUG=chromium:410721 LOG=n Please review this at https://codereview.chromium.org/609443002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+12, -

[v8-dev] [v8] r24229 committed - Ignore generated JSON files for TurboFan graphs....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24229 Author: mstarzin...@chromium.org Date: Thu Sep 25 13:30:08 2014 UTC Log: Ignore generated JSON files for TurboFan graphs. R=da...@chromium.org Review URL: https://codereview.chromium.org/605733002 https://code.google.com/p/v8/source/detail?r=24229 Modified: /branches

[v8-dev] Re: Ignore generated JSON files for TurboFan graphs. (issue 605733002 by mstarzin...@chromium.org)

2014-09-25 Thread mstarzinger
Committed patchset #1 (id:1) manually as 24229 (tree was closed). https://codereview.chromium.org/605733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] Ignore generated JSON files for TurboFan graphs. (issue 605733002 by mstarzin...@chromium.org)

2014-09-25 Thread mstarzinger
Reviewers: danno, Description: Ignore generated JSON files for TurboFan graphs. R=da...@chromium.org Please review this at https://codereview.chromium.org/605733002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (+1, -0 lines): M .gitignore Index: .gitignor

[v8-dev] Re: Ignore generated JSON files for TurboFan graphs. (issue 605733002 by mstarzin...@chromium.org)

2014-09-25 Thread danno
lgtm https://codereview.chromium.org/605733002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Refactoring: Extract interface for VC in release scripts. (issue 607463002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Committed patchset #2 (id:20001) manually as 24228 (tree was closed). https://codereview.chromium.org/607463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [v8] r24228 committed - Refactoring: Extract interface for VC in release scripts....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24228 Author: machenb...@chromium.org Date: Thu Sep 25 13:25:14 2014 UTC Log: Refactoring: Extract interface for VC in release scripts. Also simplify tagging in merge_to_branch. BUG=chromium:410721 LOG=n R=jkumme...@chromium.org, tand...@chromium.org Review URL: https://cod

[v8-dev] Re: Reland sticky regexps https://codereview.chromium.org/567313003/ (issue 580383003 by erik.co...@gmail.com)

2014-09-25 Thread yangguo
On 2014/09/24 11:05:41, Sven Panne wrote: Can we actually land this now? Closing this as this has already been relanded. https://codereview.chromium.org/580383003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because yo

[v8-dev] Re: Refactoring: Extract interface for VC in release scripts. (issue 607463002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Done. https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py#newcode263 tools/push-to-trunk/common_includes.py:263: raise

[v8-dev] Re: Fix version increment. (issue 600383003 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/600383003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] [v8] r24227 committed - [Auto-roll] Bump up version to 3.29.90.0

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24227 Author: v8-autor...@chromium.org Date: Thu Sep 25 13:01:29 2014 UTC Log: [Auto-roll] Bump up version to 3.29.90.0 https://code.google.com/p/v8/source/detail?r=24227 Modified: /branches/bleeding_edge/src/version.cc === --- /branches/

[v8-dev] Re: Refactoring: Extract interface for VC in release scripts. (issue 607463002 by machenb...@chromium.org)

2014-09-25 Thread jkummerow
lgtm https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/merge_to_branch.py File tools/push-to-trunk/merge_to_branch.py (left): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/merge_to_branch.py#oldcode257 tools/push-to-trunk/merge_to_branch.py:257: print

[v8-dev] [v8] r24226 committed - X87: fix the bug which is introduced by R24169....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24226 Author: weiliang@intel.com Date: Thu Sep 25 12:57:14 2014 UTC Log: X87: fix the bug which is introduced by R24169. Two more DeoptimizeIf(...) are added so the branch distance changed. we need to use Label::kFar. BUG= R=weiliang@intel.com Review URL: ht

[v8-dev] Re: X87: fix the bug which is introduced by R24169. (issue 598353002 by chunyang....@intel.com)

2014-09-25 Thread weiliang . lin
Committed as r24226 https://codereview.chromium.org/598353002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: X87: fix the bug which is introduced by R24169. (issue 598353002 by chunyang....@intel.com)

2014-09-25 Thread weiliang . lin
lgtm https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc File src/x87/lithium-codegen-x87.cc (right): https://codereview.chromium.org/598353002/diff/1/src/x87/lithium-codegen-x87.cc#newcode5308 src/x87/lithium-codegen-x87.cc:5308: __ jmp(&done, Label::kFar); The de

[v8-dev] Re: Correct bailout from TurboFan for unsupported targets. (issue 603923002 by mstarzin...@chromium.org)

2014-09-25 Thread mstarzinger
On 2014/09/25 11:25:15, titzer wrote: Does this mean that TypedLowering cannot run on non-supported platforms because of the builtin reducer (in turn because of Linkage?). If that's the case, then that should get better when we split linkage. But until then can we make the builtin reducer

[v8-dev] Re: Refactoring: Extract interface for VC in release scripts. (issue 607463002 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py#newcode263 tools/push-to-trunk/common_includes.py:263: raise

[v8-dev] Re: Switch v8 mirror in version script. (issue 601103003 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/601103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix scheduler to correctly schedule nested diamonds. (issue 602083003 by sigu...@chromium.org)

2014-09-25 Thread titzer
https://codereview.chromium.org/602083003/diff/1/src/compiler/scheduler.cc File src/compiler/scheduler.cc (right): https://codereview.chromium.org/602083003/diff/1/src/compiler/scheduler.cc#newcode658 src/compiler/scheduler.cc:658: one_placed = true; So this basically matches the first node that

[v8-dev] [v8] r24225 committed - Disable merging simulates across captured objects....

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24225 Author: ja...@chromium.org Date: Thu Sep 25 12:16:32 2014 UTC Log: Disable merging simulates across captured objects. BUG=chromium:416730 LOG=N R=jkumme...@chromium.org Review URL: https://codereview.chromium.org/607453002 https://code.google.com/p/v8/source/detail?r=2

[v8-dev] Re: Disable merging simulates across captured objects. (issue 607453002 by ja...@chromium.org)

2014-09-25 Thread jarin
Committed patchset #2 (id:20001) manually as 24225 (tree was closed). https://codereview.chromium.org/607453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Fix scheduler to correctly schedule nested diamonds. (issue 602083003 by sigu...@chromium.org)

2014-09-25 Thread sigurds
Reviewers: titzer, Message: PTAL Description: Fix scheduler to correctly schedule nested diamonds. The scheduler rewires control based on the last *control* node that appears in the schedule of a block. This is not sufficient to account for dependencies, instead at least phi nodes must be consi

[v8-dev] Re: Disable merging simulates across captured objects. (issue 607453002 by ja...@chromium.org)

2014-09-25 Thread jkummerow
LGTM. Thanks for investigating and fixing this! https://codereview.chromium.org/607453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from t

[v8-dev] Re: Fix auto roll after switching v8 mirror. (issue 606553003 by machenb...@chromium.org)

2014-09-25 Thread tandrii
lgtm https://codereview.chromium.org/606553003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Issue 1543 in v8: Implement Proxy proposal

2014-09-25 Thread codesite-noreply via v8-dev
Comment #43 on issue 1543 by nison.m...@gmail.com: Implement Proxy proposal https://code.google.com/p/v8/issues/detail?id=1543 @Ross wouldn't it better to finish implementing ES6 before the standard is officially sanctionned, so you can give some implementor feedback before shipping flawed s

[v8-dev] [v8] r24224 committed - Tagging version 3.29.88.1

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24224 Author: jkumme...@chromium.org Date: Thu Sep 25 11:37:03 2014 UTC Log: Tagging version 3.29.88.1 https://code.google.com/p/v8/source/detail?r=24224 Added: /tags/3.29.88.1 -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Version 3.29.88.1 (merged r24221) (issue 604743004 by jkumme...@chromium.org)

2014-09-25 Thread jkummerow
Committed patchset #1 (id:1) manually as 24223 (tree was closed). https://codereview.chromium.org/604743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] [v8] r24223 committed - Version 3.29.88.1 (merged r24221)...

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24223 Author: jkumme...@chromium.org Date: Thu Sep 25 11:36:44 2014 UTC Log: Version 3.29.88.1 (merged r24221) Revert part of r24098 BUG=chromium:417508 LOG=N R=machenb...@chromium.org Review URL: https://codereview.chromium.org/604743004 https://code.google.com/p/v8/source

[v8-dev] Re: Version 3.29.88.1 (merged r24221) (issue 604743004 by jkumme...@chromium.org)

2014-09-25 Thread machenbach
lgtm https://codereview.chromium.org/604743004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Refactoring: Extract interface for VC in release scripts. (issue 607463002 by machenb...@chromium.org)

2014-09-25 Thread machenbach
Reviewers: tandrii, Jakob, Message: PTAL. jkummerow for the changed tagging method in merge_to_branch. Description: Refactoring: Extract interface for VC in release scripts. BUG=chromium:410721 LOG=n Please review this at https://codereview.chromium.org/607463002/ SVN Base: https://v8.googlec

[v8-dev] Version 3.29.88.1 (merged r24221) (issue 604743004 by jkumme...@chromium.org)

2014-09-25 Thread jkummerow
Reviewers: Michael Achenbach, Description: Version 3.29.88.1 (merged r24221) Revert part of r24098 BUG=chromium:417508 LOG=N R=machenb...@chromium.org Please review this at https://codereview.chromium.org/604743004/ SVN Base: https://v8.googlecode.com/svn/trunk Affected files (+7, -7 lines):

[v8-dev] Disable merging simulates across captured objects. (issue 607453002 by ja...@chromium.org)

2014-09-25 Thread jarin
Reviewers: Jakob, Message: Could you take a look, please? Description: Disable merging simulates across captured objects. BUG=chromium:416730 LOG=N Please review this at https://codereview.chromium.org/607453002/ SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge Affected files (

[v8-dev] [v8] r24222 committed - Add myself to CC in merge_to_branch.py...

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24222 Author: u...@chromium.org Date: Thu Sep 25 11:28:27 2014 UTC Log: Add myself to CC in merge_to_branch.py BUG= R=machenb...@chromium.org Review URL: https://codereview.chromium.org/603113002 https://code.google.com/p/v8/source/detail?r=24222 Modified: /branches/bleedi

[v8-dev] Re: Add myself to CC in merge_to_branch.py (issue 603113002 by u...@chromium.org)

2014-09-25 Thread ulan
Committed patchset #2 (id:20001) manually as 24222 (tree was closed). https://codereview.chromium.org/603113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Correct bailout from TurboFan for unsupported targets. (issue 603923002 by mstarzin...@chromium.org)

2014-09-25 Thread titzer
Does this mean that TypedLowering cannot run on non-supported platforms because of the builtin reducer (in turn because of Linkage?). If that's the case, then that should get better when we split linkage. But until then can we make the builtin reducer do nothing if it's not a supported target

[v8-dev] Re: Add myself to CC in merge_to_branch.py (issue 603113002 by u...@chromium.org)

2014-09-25 Thread machenbach
https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/603113002/diff/1/tools/push-to-trunk/common_includes.py#newcode673 tools/push-to-trunk/common_includes.py:673: options.bypa

[v8-dev] Re: Add myself to CC in merge_to_branch.py (issue 603113002 by u...@chromium.org)

2014-09-25 Thread machenbach
lgtm https://codereview.chromium.org/603113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it

[v8-dev] Re: Revert part of r24098 (issue 604703006 by jkumme...@chromium.org)

2014-09-25 Thread jkummerow
Committed patchset #1 (id:1) manually as 24221 (tree was closed). https://codereview.chromium.org/604703006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To

[v8-dev] [v8] r24221 committed - Revert part of r24098...

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24221 Author: jkumme...@chromium.org Date: Thu Sep 25 11:18:22 2014 UTC Log: Revert part of r24098 BUG=chromium:417508 LOG=y R=mvstan...@chromium.org Review URL: https://codereview.chromium.org/604703006 https://code.google.com/p/v8/source/detail?r=24221 Modified: /branche

[v8-dev] [v8] r24220 committed - [TurboFan]: Add JSON output for the visualizer...

2014-09-25 Thread codesite-noreply via v8-dev
Revision: 24220 Author: da...@chromium.org Date: Thu Sep 25 11:13:50 2014 UTC Log: [TurboFan]: Add JSON output for the visualizer R=mstarzin...@chromium.org Review URL: https://codereview.chromium.org/599453002 https://code.google.com/p/v8/source/detail?r=24220 Modified: /branches/b

[v8-dev] Re: [TurboFan]: Add JSON output for the visualizer (issue 599453002 by da...@chromium.org)

2014-09-25 Thread danno
Committed patchset #5 (id:80001) manually as 24220 (tree was closed). https://codereview.chromium.org/599453002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] Re: Revert part of r24098 (issue 604703006 by jkumme...@chromium.org)

2014-09-25 Thread mvstanton
lgtm https://codereview.chromium.org/604703006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

  1   2   >