Reviewers: Hannes Payer,
Description:
Remove support for parallel sweeping
BUG=none
R=hpa...@chromium.org
LOG=y
Please review this at https://codereview.chromium.org/618323007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -32 lines):
M
Reviewers: Sven Panne,
Description:
Change minimum code range size to 3MB
There will be at least 2MB of guard pages around allocatable code memory
BUG=none
R=svenpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/617103006/
SVN Base:
Reviewers: Sven Panne,
Description:
Update the documentation of Isolate::GetCodeRange
On Win64, the first page is reserved for the embedder.
BUG=v8:3597
R=svenpa...@chromium.org
LOG=n
Please review this at https://codereview.chromium.org/619233003/
SVN Base:
https://codereview.chromium.org/619913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it, send
lgtm
https://codereview.chromium.org/619913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
do you have a pointer to the blink side CL?
https://codereview.chromium.org/619913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this
Revision: 24376
Author: yang...@chromium.org
Date: Thu Oct 2 06:52:39 2014 UTC
Log: Introduce v8::Object::GetIsolate().
API=v8::Object::GetIsolate()
LOG=Y
R=svenpa...@chromium.org
Review URL: https://codereview.chromium.org/617263003
Committed patchset #1 (id:1) manually as 24376 (presubmit successful).
https://codereview.chromium.org/617263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Humm, this one I saw was only a preparation CL and doesn't tie all the
strings:
https://codereview.chromium.org/621593003/
https://codereview.chromium.org/619913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because
Committed patchset #1 (id:1) manually as 24377 (presubmit successful).
https://codereview.chromium.org/606083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 24377
Author: yang...@chromium.org
Date: Thu Oct 2 07:04:28 2014 UTC
Log: Fulfill some code serializer related TODOs.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/606083004
https://code.google.com/p/v8/source/detail?r=24377
Modified:
Committed patchset #1 (id:1) manually as 24378 (presubmit successful).
https://codereview.chromium.org/623453003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
On 2014/10/01 14:26:22, mvstanton wrote:
Nice solution. LGTM, just one comment about a nice to have in the test.
https://codereview.chromium.org/623453003/diff/1/test/cctest/test-serialize.cc
File test/cctest/test-serialize.cc (right):
Revision: 24378
Author: yang...@chromium.org
Date: Thu Oct 2 07:12:46 2014 UTC
Log: Handle external strings in the code serializer.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/623453003
https://code.google.com/p/v8/source/detail?r=24378
Modified:
Revision: 24379
Author: hpa...@chromium.org
Date: Thu Oct 2 07:21:53 2014 UTC
Log: Force scavenge in idle notification if we estimate that it will
take long.
BUG=
R=u...@chromium.org
Review URL: https://codereview.chromium.org/583593006
Committed patchset #6 (id:11) manually as 24379 (presubmit successful).
https://codereview.chromium.org/583593006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/583593006/diff/80001/src/heap/gc-idle-time-handler.cc#newcode107
src/heap/gc-idle-time-handler.cc:107: // (1) If the new space is
On 2014/09/26 14:03:10, Weiliang wrote:
On 2014/09/18 16:09:30, yurys wrote:
On 2014/09/18 13:59:24, Weiliang wrote:
On 2014/09/17 13:48:21, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are
accepted.
Even if an LGTM may have been
lgtm
https://codereview.chromium.org/618323007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Benedikt Meurer,
Message:
PTAL
Description:
Skip test on all architectures but arm.
BUG=
Please review this at https://codereview.chromium.org/622713003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -1 lines):
M test/mjsunit/mjsunit.status
Reviewers: Yang,
Description:
Fix Windows compile.
BUG=
Please review this at https://codereview.chromium.org/619853007/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+2, -1 lines):
M src/heap/gc-idle-time-handler.cc
Index:
On 2014/10/02 07:40:38, Hannes Payer wrote:
lgtm.
https://codereview.chromium.org/619853007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from
Committed patchset #1 (id:1) manually as 24380 (tree was closed).
https://codereview.chromium.org/619853007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To
Revision: 24380
Author: hpa...@chromium.org
Date: Thu Oct 2 07:42:11 2014 UTC
Log: Fix Windows compile.
BUG=
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/619853007
https://code.google.com/p/v8/source/detail?r=24380
Modified:
On 2014/10/02 07:26:28, Denis Pravdin wrote:
On 2014/09/26 14:03:10, Weiliang wrote:
On 2014/09/18 16:09:30, yurys wrote:
On 2014/09/18 13:59:24, Weiliang wrote:
On 2014/09/17 13:48:21, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are
I applied the patch locally and getting the following error when building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory `/sources/chromium/src/v8/out'
LINK(target) /sources/chromium/src/v8/out/x64.debug/mksnapshot
Status: New
Owner:
New issue 3607 by zloir...@gmail.com: Symbol + Object.create /
Object.defineProperties
https://code.google.com/p/v8/issues/detail?id=3607
var o = {}
, s = Symbol();
o[s] = {value: 42};
console.log(Object.getOwnPropertyDescriptor(o, s).enumerable); // = true
var x =
Reviewers: marja,
Description:
Fix name clashes in cctests.
R=ma...@chromium.org
Please review this at https://codereview.chromium.org/617123006/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -8 lines):
M test/cctest/test-serialize.cc
Index:
LGTM
https://codereview.chromium.org/601723002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
lgtm
https://codereview.chromium.org/622713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/617123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 24381 (presubmit successful).
https://codereview.chromium.org/617123006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 24381
Author: yang...@chromium.org
Date: Thu Oct 2 08:18:03 2014 UTC
Log: Fix name clashes in cctests.
R=ma...@chromium.org
Review URL: https://codereview.chromium.org/617123006
https://code.google.com/p/v8/source/detail?r=24381
Modified:
Revision: 24382
Author: joc...@chromium.org
Date: Thu Oct 2 08:24:48 2014 UTC
Log: Remove support for parallel sweeping
BUG=none
R=hpa...@chromium.org
LOG=y
Review URL: https://codereview.chromium.org/618323007
https://code.google.com/p/v8/source/detail?r=24382
Modified:
Committed patchset #1 (id:1) manually as 24382 (presubmit successful).
https://codereview.chromium.org/618323007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
On 2014/10/02 07:54:52, yurys wrote:
I applied the patch locally and getting the following error when building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory `/sources/chromium/src/v8/out'
LINK(target) /sources/chromium/src/v8/out/x64.debug/mksnapshot
lgtm
https://codereview.chromium.org/617103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/619233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 24384 (presubmit successful).
https://codereview.chromium.org/617103006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #1 (id:1) manually as 24383 (presubmit successful).
https://codereview.chromium.org/619233003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 24383
Author: joc...@chromium.org
Date: Thu Oct 2 08:28:04 2014 UTC
Log: Update the documentation of Isolate::GetCodeRange
On Win64, the first page is reserved for the embedder.
BUG=v8:3597
R=svenpa...@chromium.org
LOG=n
Review URL:
Revision: 24384
Author: joc...@chromium.org
Date: Thu Oct 2 08:28:29 2014 UTC
Log: Change minimum code range size to 3MB
There will be at least 2MB of guard pages around allocatable code memory
BUG=none
R=svenpa...@chromium.org
LOG=n
Review URL:
Comment #3 on issue 3597 by bugdro...@chromium.org: x64 backend does not
produce ABI compliant stack frames
https://code.google.com/p/v8/issues/detail?id=3597#c3
The following revision refers to this bug:
The linker error looks like a bug in gcc as the following change fixes it:
-return pc_offset_map_.empty() ?
(v8::CpuProfileNode::kNoLineNumberInfo) :
(--pc_offset_map_.end())-second;
+if (pc_offset_map_.empty())
+ return v8::CpuProfileNode::kNoLineNumberInfo;
+return
LGTM.
https://codereview.chromium.org/621863002/diff/60001/src/factory.cc
File src/factory.cc (right):
https://codereview.chromium.org/621863002/diff/60001/src/factory.cc#newcode1773
src/factory.cc:1773: array-set_length(*NewNumberFromSize(length));
This is not handle-safe I think, GCMole will
Revision: 24385
Author: machenb...@chromium.org
Date: Thu Oct 2 08:37:51 2014 UTC
Log: Skip test on all architectures but arm.
BUG=
R=bmeu...@chromium.org
Review URL: https://codereview.chromium.org/622713003
https://code.google.com/p/v8/source/detail?r=24385
Modified:
Committed patchset #1 (id:1) manually as 24385 (presubmit successful).
https://codereview.chromium.org/622713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Committed patchset #5 (id:80001) manually as 24386 (presubmit successful).
https://codereview.chromium.org/621863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 24386
Author: bmeu...@chromium.org
Date: Thu Oct 2 08:38:37 2014 UTC
Log: [turbofan] Fix lowering of typed loads/stores.
We can only access to external typed arrays; lowering of internal
typed arrays would require a map check plus eager deoptimization.
Also embed the array
Reviewers: yurys, Sven Panne, danno, alph, Denis Pravdin, Weiliang,
Message:
Patch set #1 is exact copy of https://codereview.chromium.org/424973004/. I
moved implementation JITLineInfoTable into profile-generator.cc (PS#2) and
fixed
x64.debug linker failure (PS#3)
Description:
Extend CPU
On 2014/10/02 08:26:38, Denis Pravdin wrote:
On 2014/10/02 07:54:52, yurys wrote:
I applied the patch locally and getting the following error when
building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory `/sources/chromium/src/v8/out'
LINK(target)
Sven, can you stamp this please?
https://codereview.chromium.org/616963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/616963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
On 2014/10/02 08:41:26, yurys wrote:
On 2014/10/02 08:26:38, Denis Pravdin wrote:
On 2014/10/02 07:54:52, yurys wrote:
I applied the patch locally and getting the following error when
building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory
PTAL.
Patch is fixed, platform ports done, added tests as Erik suggested (thanks!)
https://codereview.chromium.org/622523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
[turbofan] support all shift operands on x64
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/615223005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+152, -106 lines):
DBC.
https://codereview.chromium.org/622713003/diff/1/test/mjsunit/mjsunit.status
File test/mjsunit/mjsunit.status (right):
https://codereview.chromium.org/622713003/diff/1/test/mjsunit/mjsunit.status#newcode199
test/mjsunit/mjsunit.status:199: 'nans': [PASS, ],
wut? Just remove the
LGTM
https://codereview.chromium.org/615223005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from it,
Committed patchset #1 (id:80001) manually as 24387 (presubmit successful).
https://codereview.chromium.org/619663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 24387
Author: dcar...@chromium.org
Date: Thu Oct 2 09:04:04 2014 UTC
Log: [turbofan] support all shift operands on ia32
R=bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/619663002
https://code.google.com/p/v8/source/detail?r=24387
Modified:
Reviewers: mvstanton,
Description:
Serialize all external strings except for native source code strings.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/604373008/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+89, -20 lines):
Committed patchset #1 (id:40001) manually as 24388 (presubmit successful).
https://codereview.chromium.org/615223005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 24388
Author: dcar...@chromium.org
Date: Thu Oct 2 09:08:09 2014 UTC
Log: [turbofan] support all shift operands on x64
R=bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/615223005
https://code.google.com/p/v8/source/detail?r=24388
Modified:
Yes, LGTM.
https://codereview.chromium.org/604373008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails
https://codereview.chromium.org/609843002/diff/1/src/ia32/assembler-ia32.h
File src/ia32/assembler-ia32.h (right):
https://codereview.chromium.org/609843002/diff/1/src/ia32/assembler-ia32.h#newcode1102
src/ia32/assembler-ia32.h:1102: // Support not implemented in ia32 yet.
On 2014/09/26
Committed patchset #3 (id:40001) manually as 24389 (presubmit successful).
https://codereview.chromium.org/616963005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
On 2014/10/02 08:41:26, yurys wrote:
On 2014/10/02 08:26:38, Denis Pravdin wrote:
On 2014/10/02 07:54:52, yurys wrote:
I applied the patch locally and getting the following error when
building
x64.debug:
$ make x64.debug.check -j300
make[1]: Entering directory
Revision: 24389
Author: yu...@chromium.org
Date: Thu Oct 2 09:20:37 2014 UTC
Log: Extend CPU profiler with mapping ticks to source lines
The idea behind of this solution is to use the existing relocation info
instead of consumption the CodeLinePosition events emitted by the V8
Reviewers: mvstanton,
Description:
Merged FeedbackSlotInterface into AstNode, removing the need for a 2nd
vtable.
This tiny change shaves off 112MB from the peak memory usage in the
bug mentioned below, more to come...
BUG=chrome:417697
LOG=y
Please review this at
Very nice.
LGTM.
https://codereview.chromium.org/611393004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving
https://codereview.chromium.org/622523004/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/622523004/diff/20001/src/ia32/full-codegen-ia32.cc#newcode2750
src/ia32/full-codegen-ia32.cc:2750: // - this (receiver) --
Revision: 24390
Author: svenpa...@chromium.org
Date: Thu Oct 2 09:38:28 2014 UTC
Log: Merged FeedbackSlotInterface into AstNode, removing the need for
a 2nd vtable.
This tiny change shaves off 112MB from the peak memory usage in the
bug mentioned below, more to come...
BUG=417697
Committed patchset #2 (id:20001) manually as 24390 (presubmit successful).
https://codereview.chromium.org/611393004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Committed patchset #1 (id:1) manually as 24391 (presubmit successful).
https://codereview.chromium.org/604373008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 24391
Author: yang...@chromium.org
Date: Thu Oct 2 09:39:13 2014 UTC
Log: Serialize all external strings except for native source code
strings.
R=mvstan...@chromium.org
Review URL: https://codereview.chromium.org/604373008
Reviewers: rossberg, Yang, yurys,
Description:
Make PromiseRejectCallback fire after end-of-turn.
R=yang...@chromium.org, yu...@chromium.org, rossb...@chromium.org
LOG=Y
BUG=v8:3093
Please review this at https://codereview.chromium.org/622783002/
SVN Base:
https://codereview.chromium.org/622523004/diff/20001/src/runtime/runtime-classes.cc
File src/runtime/runtime-classes.cc (right):
https://codereview.chromium.org/622523004/diff/20001/src/runtime/runtime-classes.cc#newcode102
src/runtime/runtime-classes.cc:102: if (name-AsArrayIndex(index)) {
On
LGTM.
https://codereview.chromium.org/623513002/diff/1/src/hydrogen-bch.cc
File src/hydrogen-bch.cc (right):
https://codereview.chromium.org/623513002/diff/1/src/hydrogen-bch.cc#newcode245
src/hydrogen-bch.cc:245: has_upper_constant_limit
current_check-HasUpperLimit()
This seems like a bug
Comments addressed.
https://codereview.chromium.org/622523004/diff/20001/src/ia32/full-codegen-ia32.cc
File src/ia32/full-codegen-ia32.cc (right):
https://codereview.chromium.org/622523004/diff/20001/src/ia32/full-codegen-ia32.cc#newcode2750
src/ia32/full-codegen-ia32.cc:2750: // - this
Reviewers: Benedikt Meurer,
Message:
ptal
Description:
fix imul(reg, op, imm) emission on x64
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/619903005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -12 lines):
M
After discussing this offline one more time we decided to implement it in
Blink.
In particular it would be easier to control the moment when unhandled
rejections
are reported (end of turn). Closing this issue.
https://codereview.chromium.org/622783002/
--
--
v8-dev mailing list
lgtm
https://codereview.chromium.org/622523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Igor, thanks a lot for the review!
Erik, could you take a look as well, esp. at tests? Many thanks!
https://codereview.chromium.org/622523004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Updates:
Status: Assigned
Owner: mvstan...@chromium.org
Comment #1 on issue 3605 by jkumme...@chromium.org: TypeFeedbackInfo
somehow getting more than 100% of ICs with typeinfo
https://code.google.com/p/v8/issues/detail?id=3605
Small repro with --expose-gc:
Committed patchset #1 (id:1) manually as 24392 (presubmit successful).
https://codereview.chromium.org/623513002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
Revision: 24392
Author: jkumme...@chromium.org
Date: Thu Oct 2 10:52:12 2014 UTC
Log: Drop some unused code
Bonus: fix bitrot in (disabled) Hydrogen-BCH
R=yang...@chromium.org
Review URL: https://codereview.chromium.org/623513002
https://code.google.com/p/v8/source/detail?r=24392
Reviewers: mvstanton,
Description:
Squeeze the layout of expression nodes a bit.
Again 112MB less peak memory usage in the bug mentioned below. :-)
Routed all writes to to_boolean_types_ through its setter on the way.
BUG=417697
LOG=y
Please review this at
lgtm
https://codereview.chromium.org/615423006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as 24393 (presubmit successful).
https://codereview.chromium.org/615423006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/624443005/1
https://codereview.chromium.org/624443005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/624443005/ by yu...@chromium.org.
The reason for reverting is: It broke layout test
fast/events/window-onerror-02.html:
Revision: 24393
Author: svenpa...@chromium.org
Date: Thu Oct 2 11:52:54 2014 UTC
Log: Squeeze the layout of expression nodes a bit.
Again 112MB less peak memory usage in the bug mentioned below. :-)
Routed all writes to to_boolean_types_ through its setter on the way.
BUG=417697
Reviewers: Sven Panne, danno, alph, Denis Pravdin, Weiliang,
Message:
Created Revert of Extend CPU profiler with mapping ticks to source lines
Description:
Revert of Extend CPU profiler with mapping ticks to source lines (patchset
#3
id:40001 of https://codereview.chromium.org/616963005/)
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do
Like it! However, I think there is an issue with lower bounds in some cases.
Also, some tests would be good...
https://codereview.chromium.org/618803003/diff/40001/src/compiler/typer.cc
File src/compiler/typer.cc (right):
Committed patchset #2 (id:20004) manually as 24394 (presubmit successful).
https://codereview.chromium.org/624443005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 24394
Author: yu...@chromium.org
Date: Thu Oct 2 11:58:21 2014 UTC
Log: Revert of Extend CPU profiler with mapping ticks to source lines
(patchset #3 id:40001 of https://codereview.chromium.org/616963005/)
Reason for revert:
It broke layout test
lgtm
https://codereview.chromium.org/619903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #2 (id:20001) manually as 24395 (presubmit successful).
https://codereview.chromium.org/619903005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev
Revision: 24395
Author: dcar...@chromium.org
Date: Thu Oct 2 12:22:36 2014 UTC
Log: fix imul(reg, op, imm) emission on x64
R=bmeu...@chromium.org
BUG=
Review URL: https://codereview.chromium.org/619903005
https://code.google.com/p/v8/source/detail?r=24395
Modified:
1 - 100 of 137 matches
Mail list logo
