Updates:
Cc: joc...@chromium.org
Comment #4 on issue 3454 by js...@chromium.org: some intl tests fail with
ICU 5.2
https://code.google.com/p/v8/issues/detail?id=3454
https://codereview.chromium.org/410733003 was landed, but reverted by
https://codereview.chromium.org/410083004
@
Comment #12 on issue 3692 by agelos.p...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
Besides V8 integration strategies/politics in nodejs, may I add that we
should check if this very weird optimization bug still exists in more
current
Updates:
Status: Fixed
Cc: ad...@chromium.org
Comment #2 on issue 3507 by ad...@chromium.org: getter/setter with numeric
name does not use numeric key value.
https://code.google.com/p/v8/issues/detail?id=3507
(No comment was entered for this change.)
--
You received this mess
Updates:
Status: Fixed
Cc: ad...@chromium.org
Comment #3 on issue 3461 by ad...@chromium.org: ArrayLengthGetter uses the
wrong object
https://code.google.com/p/v8/issues/detail?id=3461
Looks like this was fixed in r22575
--
You received this message because this project is co
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js
File src/harmony-string.js (right):
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode187
src/harmony-string.js:187: while (true) {
On 2014/11/14 23:29:58, caitp wrote:
On 2014/11/14 22:54
Updates:
Cc: ad...@chromium.org
Comment #1 on issue 3462 by ad...@chromium.org: FunctionPrototypeSetter is
not correct
https://code.google.com/p/v8/issues/detail?id=3462
From what I can tell this was fixed in r22606.
--
You received this message because this project is configured to
I felt like it made more sense under --harmony-strings because it doesn't
really
depend on template literals, but I've changed it to be behind
--harmony-templates anyways.
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js
File src/harmony-string.js (right):
https://co
Updates:
Status: Fixed
Comment #14 on issue 1859 by ad...@chromium.org: v8 is full of static
initializers
https://code.google.com/p/v8/issues/detail?id=1859
Oops, thought I'd already marked as fixed. Now done.
--
You received this message because this project is configured to send al
Comment #13 on issue 1859 by tha...@chromium.org: v8 is full of static
initializers
https://code.google.com/p/v8/issues/detail?id=1859
Yes, this is done. Please mark this as fixed, thanks :-)
--
You received this message because this project is configured to send all
issue notifications to
Updates:
Owner: ad...@chromium.org
Cc: rafa...@chromium.org
Labels: Harmony
Comment #1 on issue 3239 by ad...@chromium.org: Array.splice & Array.length
truncation create and mutate regular Arrays whose prototypes may have been
altered
https://code.google.com/p/v8/issu
Updates:
Status: Fixed
Owner: ad...@chromium.org
Comment #2 on issue 3134 by ad...@chromium.org: Optimization for
Array.prototype.indexOf does not take getters into account
https://code.google.com/p/v8/issues/detail?id=3134
This was fixed in r24855 when we stopped using the sp
Comment #11 on issue 3692 by i...@bnoordhuis.nl: function suddenly becomes
undefined
https://code.google.com/p/v8/issues/detail?id=3692
Does anyone know if there's a new plan already in place for doing that
with 0.12?
The tentative plan post-v0.12 is to switch to time-based releases, so w
I think it would make more sense to put this under --harmony-templates
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js
File src/harmony-string.js (right):
https://codereview.chromium.org/731573004/diff/20001/src/harmony-string.js#newcode177
src/harmony-string.js:177:
Updates:
Cc: ad...@chromium.org
Comment #12 on issue 1859 by ad...@chromium.org: v8 is full of static
initializers
https://code.google.com/p/v8/issues/detail?id=1859
I think this is now fixed. thakis, feel free to reopen if we've somehow
regressed here.
--
You received this messag
Updates:
Status: Fixed
Owner: joc...@chromium.org
Comment #8 on issue 2639 by ad...@chromium.org: List is more inefficient
than std::vector. Can't push work from Blink to V8 without regressing
performance.
https://code.google.com/p/v8/issues/detail?id=2639
(No comment was en
Updates:
Status: Fixed
Cc: ad...@chromium.org
Labels: ES5
Comment #4 on issue 3534 by ad...@chromium.org: Array.prototype.{reduce,
reduceRight}: Wrong order of operations when determining initial value
https://code.google.com/p/v8/issues/detail?id=3534
(No comment was
Updates:
Status: Fixed
Comment #6 on issue 3076 by ad...@chromium.org: Object.observe does not
call native functions
https://code.google.com/p/v8/issues/detail?id=3076
I can't reproduce this bug, may have gotten fixed at some point. In any
case, I'm adding tests to exercise this at
Reviewers: rossberg,
Description:
Add a cctest for using a C++ FunctionCallback as an Object.observe observer
R=rossb...@chromium.org
BUG=v8:3076
Please review this at https://codereview.chromium.org/733483003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+43,
PTAL
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1247
src/debug.cc:1247: if (function_proto->shared()->bound()) {
On 2014/11/14 19:27:13, aandrey wrote:
this if-else block
Updates:
Status: Fixed
Comment #3 on issue 3684 by ad...@chromium.org: ElementsAccessor::SetLength
does not respect non-writeablity of length
https://code.google.com/p/v8/issues/detail?id=3684
(No comment was entered for this change.)
--
You received this message because this project
Updates:
Status: Fixed
Comment #22 on issue 3683 by ad...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
iss
Reviewers: ,
Message:
A quick addition to the String object which makes more sense now that
templates
are implemented-ish
Description:
Implement ES6 String.raw behind --harmony-strings
BUG=
Please review this at https://codereview.chromium.org/731573004/
Base URL: https://chromium.googleso
Comment #2 on issue 3659 by a...@chromium.org: Classes: Make sure function
name inferrer works
https://code.google.com/p/v8/issues/detail?id=3659
Given
class B {
m() {
throw new Error()
}
}
class C extends B {
m() {
super.m();
}
}
class D extends C {
m() {
super.m();
https://codereview.chromium.org/726643002/diff/60001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/726643002/diff/60001/src/runtime/runtime-debug.cc#newcode1257
src/runtime/runtime-debug.cc:1257: seen_script_scope_ = scope_type ==
ScopeTy
lgtm
https://codereview.chromium.org/726643002/diff/60001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/726643002/diff/60001/src/runtime/runtime-debug.cc#newcode1257
src/runtime/runtime-debug.cc:1257: seen_script_scope_ = scope_type ==
Comment #2 on issue 3684 by bugdro...@chromium.org:
ElementsAccessor::SetLength does not respect non-writeablity of length
https://code.google.com/p/v8/issues/detail?id=3684#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/4a4158f3632ba2b18f6525a
Committed patchset #2 (id:20001)
https://codereview.chromium.org/726773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Thanks. I'll extract the code into a shared function and see if we should
apply
the apply/call logic there.
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1658
src/debug.cc:1
Comment #21 on issue 3683 by bugdro...@chromium.org: C-style for-let can't
handle continue
https://code.google.com/p/v8/issues/detail?id=3683#c21
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/b17eaaa5755e625493c5fe537f42b58838923c52
commit b17e
Committed patchset #8 (id:140001)
https://codereview.chromium.org/720863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc
File src/debug.cc (right):
https://codereview.chromium.org/725983002/diff/40001/src/debug.cc#newcode1247
src/debug.cc:1247: if (function_proto->shared()->bound()) {
this if-else block is repeated several times below. maybe extract
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/726773002/20001
https://codereview.chromium.org/726773002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
https://codereview.chromium.org/726773002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/726773002/diff/1/src/objects.cc#newcode13100
src/objects.cc:13100: bool JSArray::HasReadOnlyLength(Handle
array) {
On 2014/11/14 17:00:22, Michael Starzinger wrote:
On 20
Comment #4 on issue 3230 by ad...@chromium.org: implement template literals
https://code.google.com/p/v8/issues/detail?id=3230
Issue 2891 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
You may
Updates:
Status: Duplicate
Mergedinto: 3230
Comment #5 on issue 2891 by ad...@chromium.org: Implement template strings
https://code.google.com/p/v8/issues/detail?id=2891
(No comment was entered for this change.)
--
You received this message because this project is configured to
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/720863002/140001
https://codereview.chromium.org/720863002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
https://codereview.chromium.org/720863002/diff/120001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/720863002/diff/120001/src/parser.cc#newcode3175
src/parser.cc:3175: loop->Initialize(NULL, flag_cond,
compound_next_statement, body_or_stop);
On 2014/11/14 10:58:01, ro
Comment #3 on issue 3230 by bugdro...@chromium.org: implement template
literals
https://code.google.com/p/v8/issues/detail?id=3230#c3
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/353b6964678f7d4382be1db7b2eadce1acf5c830
commit 353b6964678f7d43
Committed patchset #33 (id:710001)
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/663683006/710001
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
btw lgtm from my side, but please let Yury or Andrey to review as well.
https://codereview.chromium.org/725983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" gro
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-constructor.js
File test/mjsunit/harmony/debug-step-into-constructor.js (right):
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-constructor.js#newcode41
test/mjsun
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-constructor.js
File test/mjsunit/harmony/debug-step-into-constructor.js (right):
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-constructor.js#newcode41
test/mjsun
looks good but Andrey or Yury should take a look as well.
https://codereview.chromium.org/725983002/diff/40001/test/mjsunit/harmony/debug-step-into-class-extends.js
File test/mjsunit/harmony/debug-step-into-class-extends.js (right):
https://codereview.chromium.org/725983002/diff/40001/test/mjsu
LGTM. Added Toon just FYI about the change in the objects.cc file. And
Kudos for
tackling all of the conformance issues in the Array builtins, you are my
hero.
:)
https://codereview.chromium.org/726773002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/726
PTAL
(I wasn't sure who the right person for debugger related changes is?)
https://codereview.chromium.org/725983002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" g
Committed patchset #8 (id:140001)
https://codereview.chromium.org/727733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Hey Ian!
Thanks for the patch. The change is looking good. Unfortunately I wasn't
able to
find a CLA entry for your email address. Could you please head to the
following
page and verify that there is CLA on file for your email address? Thanks.
Verify that there is a CLA on file for your a c
Addressed nits and rebased patch for landing.
Will wait until DevTools are ready.
https://codereview.chromium.org/726643002/diff/20001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/726643002/diff/20001/test/cctest/test-debug.cc#newcode7634
tes
Reviewers: jarin,
Description:
Fix loop information computation for floating loops.
R=ja...@chromium.org
TEST=cctest/test-scheduler/LoopedFloatingDiamond3
Please review this at https://codereview.chromium.org/726953002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected fil
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/727733002/140001
https://codereview.chromium.org/727733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
lgtm
https://codereview.chromium.org/727733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/727733002/diff/11/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/727733002/diff/11/src/compiler/pipeline.cc#newcode330
src/compiler/pipeline.cc:330: static const char* phase_name() { return
"graph builder";
let me update DevTools code before landing
https://codereview.chromium.org/726643002/diff/20001/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):
https://codereview.chromium.org/726643002/diff/20001/test/cctest/test-debug.cc#newcode7634
test/cctest/test-debug.cc:7634: CHECK_EQ(1
Try jobs failed on following builders:
v8_linux64_asan_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/28)
v8_linux64_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/1237)
v8_linux_rel on tryserver
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/663683006/670001
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Comment #10 on issue 3692 by mobilebr...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
I def don't want to point fingers at any of the teams involved, and I hope
my frustration above didn't come across as finger pointing. It's the
situa
Reviewers: titzer,
Message:
more, ptal
Description:
[turbofan] refactor pipeline to use hydrogen like Run calls
BUG=
Please review this at https://codereview.chromium.org/727733002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+507, -302 lines):
M src/compil
Updated, now we should be good to go for real :)
https://codereview.chromium.org/699953003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from
On 2014/11/14 14:27:50, wingo wrote:
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js#newcode67
src/harmony-typedarray.js:67: var array = ToObject(this)
Committed patchset #5 (id:11)
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Comment #63 on issue 3330 by bugdro...@chromium.org: Implement ES6 classes
https://code.google.com/p/v8/issues/detail?id=3330#c63
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f3d5b13e04c9cedd1f020ce0beec64275fcc40d5
commit f3d5b13e04c9cedd1f020ce
LGTM.
I filed a bug on supporting this in DevTools:
https://code.google.com/p/chromium/issues/detail?id=433324.
https://codereview.chromium.org/726643002/diff/20001/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/726643002/diff/20001/src/
On 2014/11/14 14:40:02, arv wrote:
Can you also update the BUILD.gn file?
Done (I think), does that look about right?
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you a
Can you also update the BUILD.gn file?
https://codereview.chromium.org/663683006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/722793005/11
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js
File src/harmony-typedarray.js (right):
https://codereview.chromium.org/699953003/diff/1/src/harmony-typedarray.js#newcode67
src/harmony-typedarray.js:67: var array = ToObject(this);
On 2014/11/13 16:34:36, aperez wrote:
Comment #9 on issue 3692 by bcorriga...@gmail.com: function suddenly
becomes undefined
https://code.google.com/p/v8/issues/detail?id=3692
In the same vein, it might be worth it for the Node team to consider more
frequent patch releases releases that focus only on maintaining parity with
V
https://codereview.chromium.org/721723004/diff/1/test/cctest/compiler/test-js-typed-lowering.cc
File test/cctest/compiler/test-js-typed-lowering.cc (right):
https://codereview.chromium.org/721723004/diff/1/test/cctest/compiler/test-js-typed-lowering.cc#newcode1216
test/cctest/compiler/test-js-ty
Committed patchset #2 (id:20001) manually as
a210f3684628e74cddf1f739a053946002418431 (presubmit successful).
https://codereview.chromium.org/73003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1321)
v8_win64_compile_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_win64_compile_rel/builds/445)
v8_win_rel on tryserver.v8
(ht
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/722793005/80001
https://codereview.chromium.org/722793005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Reviewers: titzer, Benedikt Meurer,
Message:
Could you take a look please?
Description:
[turbofan] Remove int32 narrowing during typed lowering.
With Int32Add we lose the int/uint distinction, so later, in simplified
lowering
we can make a wrong decision. E.g., see the attached test case, whe
lgtm
https://codereview.chromium.org/73003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/727733002/diff/60001/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/727733002/diff/60001/src/compiler/pipeline.cc#newcode258
src/compiler/pipeline.cc:258: void Run(PipelineData* data) {
I like this a lot better!
Ca
Reviewers: titzer, rossberg,
Message:
PTAL. Addressed comments and added unit test.
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering
Addressed comments.
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js#newcode198
src/mirror-debugger.js:198: Script: 1,
On 2014/11/14 12:25:32, yurys wrote:
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering.cc#newcode495
src/compiler/js-typed-lowering.cc:495: Type* intersect =
Type::Intersec
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering.cc
File src/compiler/js-typed-lowering.cc (right):
https://codereview.chromium.org/73003/diff/1/src/compiler/js-typed-lowering.cc#newcode495
src/compiler/js-typed-lowering.cc:495: Type* intersect =
Type::Intersec
Comment #4 on issue 3690 by bugdro...@chromium.org: Support harmony-scoping
in debugger API
https://code.google.com/p/v8/issues/detail?id=3690#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/7e69b2f996b5f1b77a14474f9b8dd9731fd04f9f
commit 7e69
Committed patchset #2 (id:20001) manually as
7e69b2f996b5f1b77a14474f9b8dd9731fd04f9f (presubmit successful).
https://codereview.chromium.org/732543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Comments addressed, landing
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blockscopes.js
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blockscopes.js#ne
lgtm
https://codereview.chromium.org/663683006/diff/640001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/663683006/diff/640001/src/parser.cc#newcode5152
src/parser.cc:5152: if ((from_index + 1) < length &&
raw_chars[from_index + 1] == '\n') {
Nit: redundant parens.
Thanks for the look, I've re-arranged code a bit to address the style
issues,
and added some extra test cases.
https://codereview.chromium.org/663683006/diff/61/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/663683006/diff/61/src/parser.cc#newcode5150
src/pa
lgtm
https://codereview.chromium.org/725073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1) manually as
4faa0ae88aaabdfe41e7d9c8dcfc6ee0484eaec4 (presubmit successful).
https://codereview.chromium.org/679943004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blockscopes.js
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blockscopes.js#newcode88
test/mjsunit/
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js#newcode198
src/mirror-debugger.js:198: Script: 1,
Can you add the new scope at the end. Our code depends on
LGTM, I'd just suggest one more test.
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blockscopes.js
File test/mjsunit/harmony/debug-evaluate-blockscopes.js (right):
https://codereview.chromium.org/732543002/diff/1/test/mjsunit/harmony/debug-evaluate-blocksc
Looks good, just a few nits and some more tests.
https://codereview.chromium.org/663683006/diff/61/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/663683006/diff/61/src/parser.cc#newcode5054
src/parser.cc:5054: #define COOKED_STRING(i) cooked_strings->at(i)
Nit
lgtm
https://codereview.chromium.org/732543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js
File src/mirror-debugger.js (right):
https://codereview.chromium.org/726643002/diff/20001/src/mirror-debugger.js#newcode198
src/mirror-debugger.js:198: Script: 1,
This will break DevTools code as we rely on these constan
Reviewers: *rossberg, aandrey, yurys,
Message:
rossberg: PTAL
aandrey, yurys: FYI
Description:
Implement 'setVariableValue' for debugger block scopes.
R=rossb...@chromium.org
BUG=v8:3690
LOG=N
Please review this at https://codereview.chromium.org/732543002/
Base URL: https://chromium.googleso
+aandrey who worked on the debugger stuff recently.
https://codereview.chromium.org/726643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe fr
Looks like Yang is OOO today. Yury, maybe you could take a look? Thanks
https://codereview.chromium.org/726643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" grou
Reviewers: Michael Achenbach,
Message:
Committed patchset #1 (id:1) manually as
27cc3c685c2fc7f0ce89585499cba2f620f8c4bc (tree was closed).
Description:
Revert "[turbofan] Smartify the GraphReducer."
This reverts commit 6e148989a4227a5290a7f8ca72c71f5740870afe for
breaking Massive/Embenchen.
T
Updates:
Status: Duplicate
Mergedinto: 3696
Comment #2 on issue 3697 by jkumme...@chromium.org: Poor code for integer
tests
https://code.google.com/p/v8/issues/detail?id=3697
(No comment was entered for this change.)
--
You received this message because this project is config
Comment #2 on issue 3696 by jkumme...@chromium.org: slow code for 'integer'
checks
https://code.google.com/p/v8/issues/detail?id=3696
Issue 3697 has been merged into this issue.
--
You received this message because this project is configured to send all
issue notifications to this address.
Committed patchset #1 (id:1) manually as
cf85209035e93a1ae904a3c2e47167f82c64ca34 (tree was closed).
https://codereview.chromium.org/718393004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
Reviewers: Toon Verwaest,
Description:
Do not do field type tracking with GC stress.
R=verwa...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/718393004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -0 lines):
M test/mjsunit/mjsun
1 - 100 of 141 matches
Mail list logo
