Coming a bit late to the party, but anyway... :-)
https://codereview.chromium.org/736043002/diff/40001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/736043002/diff/40001/src/ast.h#newcode1930
src/ast.h:1930: class IsUninitializedField : public BitField8 {};
This is not so go
https://codereview.chromium.org/745233002/diff/1/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/745233002/diff/1/src/parser.cc#newcode5306
src/parser.cc:5306: Vector hash_string =
Vector::New(num_hash_chars);
One thing that seems strange to me is that we have to assemb
Status: New
Owner:
New issue 3714 by loke.chi...@gmail.com: JSON.parse({a:0111}) gives output
as {"a":73} Which is not correct.
https://code.google.com/p/v8/issues/detail?id=3714
Hi,
I am passing a json string as {a:0123} any number starting from 0 will be
changed to some other number
LGTM. Thanks.
https://codereview.chromium.org/737733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
Reviewers: Dmitry Lomov (chromium), rossberg, arv,
Message:
On 2014/11/21 04:49:11, caitp wrote:
mailto:caitpotte...@gmail.com changed reviewers:
+ mailto:a...@chromium.org, mailto:dslo...@chromium.org,
mailto:rossb...@chromium.org
It's based on https://codereview.chromium.org/742643003/#ps600
Reviewers: titzer,
Message:
Hello, Titzer,
PTAL.
Thanks.
Description:
Fix the compilation issue for turbofan unsupported backend which
is introduced by
https://chromium.googlesource.com/v8/v8/+/aed26c05a50b2a1257ef8accc67143825f2e1f60.
( [turbofan] Clean up and factor out branch generation lo
Comment #59 on issue 2599 by karimell...@gmail.com: Implement "use asm"
https://code.google.com/p/v8/issues/detail?id=2599
How fast would V8 be after this issue is resolved? would it outperform the
DartVM for example?
--
You received this message because this project is configured to send al
Committed patchset #1 (id:1) manually as
9182813fb05d25ccb5d49736aa84a1a85f9be647 (tree was closed).
https://codereview.chromium.org/742243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the
LGTM.
https://codereview.chromium.org/742243003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Reviewers: danno, titzer, paul.l..., gergely.kis.imgtec, kilvadyb,
dusmil.imgtec,
Message:
PTAL.
Description:
MIPS: [turbofan] Clean up and factor out branch generation logic.
Port aed26c05a50b2a1257ef8accc67143825f2e1f60
BUG=
Please review this at https://codereview.chromium.org/742243003/
Reviewers: rossberg,
Message:
PTAL
Description:
harmony-scoping: Disallow cross-script assignment to const
R=rossb...@chromium.org
BUG=v8:2198
LOG=N
Please review this at https://codereview.chromium.org/745963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+
On 2014/11/20 10:47:40, rossberg wrote:
On 2014/11/19 18:22:34, Dmitry Lomov (chromium) wrote:
> you will have to rebase onto
>
https://chromium.googlesource.com/v8/v8/+/c32114f1dcb1102c685007a5da813c664ded94cf
That's already the baseline, see CL Description. :)
Ah ic, your last patchset wa
Comment #7 on issue 3230 by bugdro...@chromium.org: implement template
literals
https://code.google.com/p/v8/issues/detail?id=3230#c7
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/ad86a1a27a73a73a524918f2bfac7e30d6894108
commit ad86a1a27a73a73a
Committed patchset #10 (id:170001)
https://codereview.chromium.org/742643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Updates:
Owner: dslo...@chromium.org
Cc: rossb...@chromium.org
Comment #6 on issue 2243 by dslo...@chromium.org: Assigning to function
identifier under strict should throw
https://code.google.com/p/v8/issues/detail?id=2243
(No comment was entered for this change.)
--
You rece
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/742643003/170001
https://codereview.chromium.org/742643003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscri
Committed patchset #1 (id:1)
https://codereview.chromium.org/738153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/738153003/1
https://codereview.chromium.org/738153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/738153003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Comment #5 on issue 3323 by jsha...@gmail.com: Embedder's Guide is out of
date
https://code.google.com/p/v8/issues/detail?id=3323
It would definitely be nice to see additions for the correct way of working
with Persistent, as well. For example, I'm having trouble figuring out how
to get a
Andrew, thanks for reporting this!
I know the solution is not ideal but I tried everything under the sun to
simply
replace the last argument of 'action' by a variable that would be either
snapshot_blob.bin or snapshot_blob_host.bin, depending on what toolset it
being
built. Nothing worked,
Committed patchset #2 (id:20001)
https://codereview.chromium.org/742963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/742963002/20001
https://codereview.chromium.org/742963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Thanks
https://codereview.chromium.org/736383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #3 (id:40001)
https://codereview.chromium.org/736043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Comment #2 on issue 3709 by bugdro...@chromium.org: unexpected
deoptimization due to fn.apply(this, arguments);
https://code.google.com/p/v8/issues/detail?id=3709#c2
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/dc88962350ea03cc132bbbda99747fc60e
Committed patchset #3 (id:40001)
https://codereview.chromium.org/745633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Committed patchset #1 (id:1)
https://codereview.chromium.org/736383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/737373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: vogelheim,
Message:
Committed patchset #1 (id:1) manually as
be782ea773ece9e80c4b4e2e49cc09b84d4e20c4 (tree was closed).
Description:
[turbofan] use double temp registers for stack-stack swap on arm64
TBR=vogelh...@chromium.org
BUG=
Committed:
https://chromium.googlesource.com/v8/v
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/736043002/40001
https://codereview.chromium.org/736043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
LGTM.
I'm a bit sad that we have to increase Call nodes' sizes, but since calls
probably aren't all that frequent, that should be fine.
https://codereview.chromium.org/736043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messa
Try jobs failed on following builders:
v8_mac_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/1413)
https://codereview.chromium.org/743843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
Reviewers: Hannes Payer,
Message:
Committed patchset #1 (id:1) manually as
29704b508207c47bd7ccd7408e0ead18a7b3a9f7 (tree was closed).
Description:
Fix Regress3540 after r25441.
BUG=
TBR=hpa...@chromium.org
Committed:
https://chromium.googlesource.com/v8/v8/+/29704b508207c47bd7ccd7408e0ead18a7
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/743843003/1
https://codereview.chromium.org/743843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/743843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: Accepted
Owner: dslo...@chromium.org
CC: rossb...@chromium.org
Labels: Type-Bug Priority-High Harmony
New issue 3713 by rossb...@chromium.org: Assignment to const should not be
an early error
https://code.google.com/p/v8/issues/detail?id=3713
There should be no SyntaxError for
cons
Reviewers: rossberg,
Description:
Slightly improve tests that rely on lazy compilation.
R=rossb...@chromium.org
BUG=v8:3712
LOG=N
Please review this at https://codereview.chromium.org/743843003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+2, -2 lines):
M te
Thanks for the comments! I uploaded new patch set.
https://codereview.chromium.org/736043002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/736043002/diff/1/src/hydrogen.cc#newcode9282
src/hydrogen.cc:9282: if (CanBeFunctionApplyArguments(expr, false)) {
On
Updates:
Summary: Missing early errors in the preparser
Status: Assigned
Owner: ma...@chromium.org
Comment #1 on issue 3712 by rossb...@chromium.org: Missing early errors in
the preparser
https://code.google.com/p/v8/issues/detail?id=3712
These are cases of early error
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/737373003/1
https://codereview.chromium.org/737373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/736383002/1
https://codereview.chromium.org/736383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/736383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: danno,
Description:
Remove superflous SharedFunctionInfo::uses_super call.
R=da...@chromium.org
Please review this at https://codereview.chromium.org/736383002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+0, -1 lines):
M src/compiler.cc
Index:
Status: New
Owner:
CC: rossb...@chromium.org, ma...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3712 by yang...@chromium.org: Some test cases fail with
SyntaxError when compiling eagerly (--nolazy)
https://code.google.com/p/v8/issues/detail?id=3712
test/mjsunit/function-leng
lgtm
https://codereview.chromium.org/737373003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/745633002/40001
https://codereview.chromium.org/745633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Committed patchset #5 (id:80001)
https://codereview.chromium.org/742733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Committed patchset #4 (id:60001)
https://codereview.chromium.org/725083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/745633002/1
https://codereview.chromium.org/745633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/745633002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Good idea.
* array-shift4.js - this covers the case where a hole is encountered in the
copy
step of shifting a holey smi array. Before this fix, the method would
deoptimize.
* array-methods-read-only-length.js change - this test was succeeding only
because of the silent deopt isolated in arra
Reviewers: dcarney,
Description:
[turbofan] Clean up and factor out branch generation logic.
R=dcar...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/745633002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+139, -174 lines):
M src/com
Reviewers: Jakob,
Description:
When optimizing deserialized code, make sure IC state is preserved.
R=jkumme...@chromium.org
Please review this at https://codereview.chromium.org/737373003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+46, -16 lines):
M src/co
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/742733002/80001
https://codereview.chromium.org/742733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/742733002/80001
https://codereview.chromium.org/742733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Status: Accepted
Owner: mstarzin...@chromium.org
CC: svenpa...@chromium.org
Labels: Type-Bug Priority-Medium
New issue 3711 by svenpa...@chromium.org: valgrind issue with GC within
finally block
https://code.google.com/p/v8/issues/detail?id=3711
"valgrind ~/v8/out/ia32.debug/d8 --trace-gc --e
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/725083004/60001
https://codereview.chromium.org/725083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/725083004/40001
https://codereview.chromium.org/725083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Thanks, Erik and Hannes!
I tried RegExp and eval for generating code and ended up using eval, since
it is
easier to control caching/flushing for it. The test is in patch set #3: it
uses
a new flag --code-range-size, otherwise it would take long time to fill up
512MB. The test uncovered a bog
Committed patchset #5 (id:80001) manually as
5a494cf00ca4626758cc41e0ca800ebb0bff3a9b (presubmit successful).
https://codereview.chromium.org/738073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/738073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Please take another look
https://codereview.chromium.org/738073002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop rece
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc#newcode157
src/compiler/instruction-selector.cc:157: bool
Instruc
On 2014/11/19 08:00:23, Benedikt Meurer wrote:
Please don't use GetMachineType(), it's not going to stay and probably
wrong
anyway.
Done.
I uploaded a new patch set which don't use GetMachineType.
https://codereview.chromium.org/737733002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
Committed patchset #2 (id:20001) manually as
481772acdd6cded6b3320cdf7cde1084a01a1b22 (presubmit successful).
https://codereview.chromium.org/732103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Please add some tests for the additional issues you fixed.
Otherwise looks good.
https://codereview.chromium.org/737383002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-d
lgtm
https://codereview.chromium.org/725083004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Message:
Hi Toon,
Here is the fix we discussed, thx for the look,
--Michael
Description:
Fix for 435073: CHECK failure in CHECK(p->IsSmi()) failed.
The bug was an error when copying arrays in crankshaft. If it's a holey smi
array, the copy must be done as FAST_HOLEY_E
Updates:
Summary: Add fast path for smis to Number.isInteger()
Comment #6 on issue 3696 by jkumme...@chromium.org: Add fast path for smis
to Number.isInteger()
https://code.google.com/p/v8/issues/detail?id=3696
I don't think this is related to compiler architectures. The reason for no
Looks good with a couple comments.
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/738073002/diff/60001/src/compiler/instruction-selector.cc#newcode157
src/compiler/instr
LGTM, thanks for fixing.
It should still be possible to detect ROR on ARM, we just need to also take
into
account the & 0x1f's
https://codereview.chromium.org/732103002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message bec
1. I would prefer another name, i.e. how about WordShiftIsSafe or
something
along the lines?
Done
2. Shouldn't that also apply to Word32Ror?
Unlike shifts ror is not the result of a JavaScript operator but generated
through pattern matching and currently the pattern will not match if the
Committed patchset #2 (id:20001)
https://codereview.chromium.org/743963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/743963002/20001
https://codereview.chromium.org/743963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Committed patchset #1 (id:1) manually as
4f635647002b36283681d95bd6388816682e1d72 (presubmit successful).
https://codereview.chromium.org/739563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/743963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #3 (id:60001) manually as
1808badc2d83432af0e9fd1ba5bf49e40f279b39 (presubmit successful).
https://codereview.chromium.org/722203006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
On 2014/11/19 18:22:34, Dmitry Lomov (chromium) wrote:
you will have to rebase onto
https://chromium.googlesource.com/v8/v8/+/c32114f1dcb1102c685007a5da813c664ded94cf
That's already the baseline, see CL Description. :)
https://codereview.chromium.org/722203006/
--
--
v8-dev mailing list
v8-d
Reviewers: mvstanton,
Description:
Enable TurboFan for Win64 targets.
R=mvstan...@chromium.org
Please review this at https://codereview.chromium.org/743963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+1, -1 lines):
M src/globals.h
Index: src/globals.h
https://codereview.chromium.org/736043002/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
https://codereview.chromium.org/736043002/diff/1/src/hydrogen.cc#newcode9282
src/hydrogen.cc:9282: if (CanBeFunctionApplyArguments(expr, false)) {
I don't see a good alternative right now ("expr->IsUn
On 2014/11/20 09:04:12, Yang wrote:
On 2014/11/20 09:03:05, Michael Achenbach wrote:
> Created Revert of Rename String.prototype.contains to 'includes'.
LGTM. test262-es6.status needs to be updated before relanding.
test262 patch: https://github.com/tc39/test262/pull/119
https://codereview.
Comment #1 on issue 3152 by bugdro...@chromium.org: A64:
mozilla/js1_5/extensions/regress-355497 crashes in debug mode
https://code.google.com/p/v8/issues/detail?id=3152#c1
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/fbcfce69aa478bdfb629bc21d23
Committed patchset #2 (id:20001)
https://codereview.chromium.org/735723006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Comment #9 on issue 3579 by yang...@chromium.org: Math.log2 and Math.log10
should be exact for exact powers
https://code.google.com/p/v8/issues/detail?id=3579
The log10 part of the bug is fixed. log2 is still inaccurate.
--
You received this message because this project is configured to send
Committed patchset #2 (id:20001)
https://codereview.chromium.org/739913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/735723006/20001
https://codereview.chromium.org/735723006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/739913003/20001
https://codereview.chromium.org/739913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
LGTM (mostly rubber-stamped)
https://codereview.chromium.org/739913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/739913003/20001
https://codereview.chromium.org/739913003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
https:/
https://codereview.chromium.org/739913003/diff/1/src/third_party/fdlibm/fdlibm.cc
File src/third_party/fdlibm/fdlibm.cc (right):
https://codereview.chromium.org/739913003/diff/1/src/third_party/fdlibm/fdlibm.cc#newcode30
src/third_party/fdlibm/fdlibm.cc:30: 6.36619772367581382433e-01, //
invpi
On 2014/11/20 09:03:05, Michael Achenbach wrote:
Created Revert of Rename String.prototype.contains to 'includes'.
LGTM. test262-es6.status needs to be updated before relanding.
https://codereview.chromium.org/745543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.c
Committed patchset #1 (id:1)
https://codereview.chromium.org/745543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/745543002/ by machenb...@chromium.org.
The reason for reverting is: Breaks test262-es6:
http://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/1289.
https://codereview.chromium.org/742963002/
--
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/745543002/1
https://codereview.chromium.org/745543002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: arv, Yang, Dmitry Lomov (chromium),
Message:
Created Revert of Rename String.prototype.contains to 'includes'.
Description:
Revert of Rename String.prototype.contains to 'includes'. (patchset #1 id:1
of
https://codereview.chromium.org/742963002/)
Reason for revert:
Breaks test262-
Committed patchset #1 (id:1)
https://codereview.chromium.org/723023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
lgtm with a comment: You can also hit the CQ - then I'll do a refactoring
of the
code afterwards.
https://codereview.chromium.org/735723006/diff/20001/tools/testrunner/local/testsuite.py
File tools/testrunner/local/testsuite.py (right):
https://codereview.chromium.org/735723006/diff/20001/too
lgtm. Hmm, it is pretty sad it has to be this way...
https://codereview.chromium.org/739563002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe f
1 - 100 of 105 matches
Mail list logo
