Comment #1 on issue 3857 by i...@bnoordhuis.nl: max_old_space_size broken
for increasing heap size
https://code.google.com/p/v8/issues/detail?id=3857
I filed a CR for that yesterday[0], it just needs a gentle nudge to get
past the commit bot.
[0] https://codereview.chromium.org/890563003/
Status: New
Owner:
New issue 3859 by zloir...@gmail.com: Init collections from iterable &
SameValueZero
https://code.google.com/p/v8/issues/detail?id=3859
new Map([[NaN, 42]]).get(NaN) // => undefined
new Set([NaN, NaN, NaN]).size // => 2 O_o
Chromium 42.0.2290.0, before was correct.
-
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/894493002/1
https://codereview.chromium.org/894493002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/build/gyp to 4d7c139b1820c5fcb993868c61f170a02cda8a40
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/894493002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files (+1
Status: New
Owner:
New issue 3858 by rfkel...@gmail.com: d8 appears to hang on
pypy.js "richards" benchmark
https://code.google.com/p/v8/issues/detail?id=3858
I'm working on a project to port the PyPy python interpreter to
javascript. While running various python benchmarks, I found a
Comment #2 on issue 3854 by a...@chromium.org: Symbol.toStringTag is added
even if disabled
https://code.google.com/p/v8/issues/detail?id=3854
I don't think it is doing much harm but it does give a false impression.
--
You received this message because this project is configured to send all
Status: New
Owner:
New issue 3857 by dan.sca...@gmail.com: max_old_space_size broken for
increasing heap size
https://code.google.com/p/v8/issues/detail?id=3857
You can no longer make the heap size on a 64-bit machine greater than
2047Mbtes, because some casting code was lost between t
Patchset 1 (id:??) landed as
https://crrev.com/eaa2c63a9642e370c9b388399d7ea470aa375ccc
Cr-Commit-Position: refs/heads/master@{#26368}
https://codereview.chromium.org/888093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/888093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Comment #1 on issue 3854 by caitpott...@gmail.com: Symbol.toStringTag is
added even if disabled
https://code.google.com/p/v8/issues/detail?id=3854
I am not sure this matters --- in particular, Symbol.toStringTag is exposed
via O.getOwnPropertySymbols, but nothing can really be done with tha
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/888093002/1
https://codereview.chromium.org/888093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/888093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: paul.l..., gergely.kis.imgtec, akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Remove unnecessary printf lines from assembler tests.
BUG=
Please review this at https://codereview.chromium.org/888093002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected file
Patchset 2 (id:??) landed as
https://crrev.com/320d42e58aed0dfbee4ac4721939aa6c3bbb4624
Cr-Commit-Position: refs/heads/master@{#26367}
https://codereview.chromium.org/892613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/892613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892613003/20001
https://codereview.chromium.org/892613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
LGTM, thanks!
https://codereview.chromium.org/892613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc
File test/cctest/test-assembler-mips64.cc (right):
https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc#newcode69
test/cctest/test-assembler-mips64.cc:69: ::printf("f() = %lld\n
not LGTM, small issue to fix.
https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc
File test/cctest/test-assembler-mips64.cc (right):
https://codereview.chromium.org/892613003/diff/1/test/cctest/test-assembler-mips64.cc#newcode69
test/cctest/test-assembler-mips6
lgtm.
https://codereview.chromium.org/892613003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Test added.
https://codereview.chromium.org/885043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails
Comment #11 on issue 2159 by bugdro...@chromium.org: Add support for rest
parameters
https://code.google.com/p/v8/issues/detail?id=2159#c11
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/f6f56de8e3856f988f39d51884948ccd03957601
commit f6f56de8e3
Committed patchset #1 (id:1)
https://codereview.chromium.org/888713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/f6f56de8e3856f988f39d51884948ccd03957601
Cr-Commit-Position: refs/heads/master@{#26366}
https://codereview.chromium.org/888713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Patchset 1 (id:??) landed as
https://crrev.com/bddf5eeb39493ce911bccb6b7fc50584736aa423
Cr-Commit-Position: refs/heads/master@{#26365}
https://codereview.chromium.org/885923004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1) manually as
bddf5eeb39493ce911bccb6b7fc50584736aa423 (presubmit successful).
https://codereview.chromium.org/885923004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/888713003/1
https://codereview.chromium.org/888713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Updates:
Status: Assigned
Owner: a...@chromium.org
Labels: Type-Bug Priority-Medium OS-All Harmony
Comment #1 on issue 3856 by a...@chromium.org: {get a(){}, a:1, set a(_){}}
should only have a setter
https://code.google.com/p/v8/issues/detail?id=3856
This was introduc
Patchset 4 (id:??) landed as
https://crrev.com/1bd398ab16a2cfbff6e116bcf21c8efd2a0b6f04
Cr-Commit-Position: refs/heads/master@{#26364}
https://codereview.chromium.org/881683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/881683004/50001
https://codereview.chromium.org/881683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Committed patchset #4 (id:50001)
https://codereview.chromium.org/881683004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Done
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py
File tools/release/create_release.py (right):
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode38
tools/release/create_release.py:38: print "Release revision %s"
LGTM
https://codereview.chromium.org/888713003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Patchset 1 (id:??) landed as
https://crrev.com/5e4951b89990e5198afd59e02fa2abdc91d77873
Cr-Commit-Position: refs/heads/master@{#26363}
https://codereview.chromium.org/893573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/893573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: arv, marja,
Message:
PTAL --- trivial fixup, I didn't realize the message wasn't included in the
other CL
Description:
Add param_after_rest error message after r26362
BUG=v8:2159
LOG=N
R=ma...@chromium.org, a...@chromium.org
Please review this at https://codereview.chromium.org/8887
Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.
https://codereview.chromium.org/890563003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Comment #8 on issue 3832 by mih...@chromium.org: Array variable suddenly
becomes number
https://code.google.com/p/v8/issues/detail?id=3832
Awesome! Do you know when it will hit the dev channel? We most recently saw
this with 42.0.2288.4.
--
You received this message because this project i
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/893573003/1
https://codereview.chromium.org/893573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
LGTM
https://codereview.chromium.org/885923004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it
Reviewers: paul.l..., akos.palfi.imgtec, balazs.kilvady,
Description:
MIPS: Fix bug in elements transition code for smi to double transitions.
This fixes intermittent sin-cos test failures when corrupted values are
returned
for referent sin and cos functions in test which require factorial va
Reviewers: danno, Benedikt Meurer, paul.l..., gergely.kis.imgtec,
akos.palfi.imgtec, dusmil.imgtec,
Description:
MIPS: Reland "Initial switch to Chromium-style CHECK_* and DCHECK_*
macros.".
Port c65ae4f10c7273956e88db433f626b26a1377caf
BUG=
Please review this at https://codereview.chromi
lgtm
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py
File tools/release/create_release.py (right):
https://codereview.chromium.org/881683004/diff/20001/tools/release/create_release.py#newcode38
tools/release/create_release.py:38: print "Release revision %s"
Reviewers: Benedikt Meurer,
Message:
ptal
cq if you like
Description:
add maps and sets to zone containers
R=bmeu...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/889963002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+33, -12 line
lgtm
https://codereview.chromium.org/893573003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Just an update the we are in the process of contributing the code for the
port back to the google repos
There are still a number of steps to complete this but latest review is
here:
https://codereview.chromium.org/866843003/
It outlines some of the remaining steps
--
--
v8-dev mailing list
Patchset 3 (id:??) landed as
https://crrev.com/9355457b556586cfbbee8051aa186eee0eb0dae3
Cr-Commit-Position: refs/heads/master@{#26362}
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #3 (id:40001)
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Patchset 1 (id:??) landed as
https://crrev.com/3df0a9ae773f26f42689311de7728a60a3af58ef
Cr-Commit-Position: refs/heads/master@{#26361}
https://codereview.chromium.org/885333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/885333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: tandrii(chromium),
Message:
PTAL. Big parts of the new script are copied from the old
push_to_candidates. I
won't invest into code sharing as the old script is going to be deleted. I
marked the step classes that were copied to ease review.
https://codereview.chromium.org/881683004
Reviewers: Toon Verwaest,
Message:
PTAL
Description:
Use weak cells in CheckPropertyCell.
BUG=v8:3629
LOG=N
Please review this at https://codereview.chromium.org/815143002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+22, -23 lines):
M src/ic/arm/handler-co
Comment #25 on issue 3629 by bugdro...@chromium.org: Memory leak via
objects embedded in IC handlers.
https://code.google.com/p/v8/issues/detail?id=3629#c25
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/a113ce28bf9e9091054425797fe098cd314cc7f5
Patchset 2 (id:??) landed as
https://crrev.com/a113ce28bf9e9091054425797fe098cd314cc7f5
Cr-Commit-Position: refs/heads/master@{#26360}
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
LGTM, just one suggestion.
https://codereview.chromium.org/890903002/diff/20001/src/compiler/frame.h
File src/compiler/frame.h (right):
https://codereview.chromium.org/890903002/diff/20001/src/compiler/frame.h#newcode84
src/compiler/frame.h:84: int osr_stack_slots_;
nit: s/osr_stack_slots_/osr_
Reviewers: dcarney,
Message:
PTAL. Instead embedding the interceptor in handler, we can just fetch it in
runtime.
Description:
Do not embed interceptor in handler.
BUG=v8:3629
LOG=N
Please review this at https://codereview.chromium.org/893573003/
Base URL: https://chromium.googlesource.com/v8
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/885243002/40001
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Patchset 1 (id:??) landed as
https://crrev.com/da90aabc072e2321f5902252e51ce0afadd3d76a
Cr-Commit-Position: refs/heads/master@{#26359}
https://codereview.chromium.org/887023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/887023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 2 (id:??) landed as
https://crrev.com/3ea4ca9dbffdbd878ae5d2d2960875ab1acf0b44
Cr-Commit-Position: refs/heads/master@{#26358}
https://codereview.chromium.org/877243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/877243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Reviewers: jarin, titzer,
Message:
Note that this only implements local exceptional control-flow (as
in 'throw' in
the same function as the 'try'). Implicit exceptional control-flow from
calls is
not covered.
Also there is still one issue with bailout-ids I still need to address
before
be
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/885243002/20001
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/885333002/1
https://codereview.chromium.org/885333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
On 2015/01/30 14:22:24, marja wrote:
The description is a bit unintentionally funny now: "Implement parsing of
6
Rest
Parameters" :)
Crisis averted since the try jabs failed anyway :>
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups
Try jobs failed on following builders:
v8_linux_arm64_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/2470)
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
Y
The description is a bit unintentionally funny now: "Implement parsing of 6
Rest
Parameters" :)
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Go
lgtm
https://codereview.chromium.org/885333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/881783003/20001
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/887023003/1
https://codereview.chromium.org/887023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
LGTM!
https://codereview.chromium.org/887023003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Try jobs failed on following builders:
v8_android_arm_compile_rel on tryserver.v8
(http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/984)
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/grou
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/885243002/1
https://codereview.chromium.org/885243002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Reviewers: ulan,
Message:
Could you take a look, please?
Description:
Always emit bailout id for inlining property access (even for keyed access).
R=u...@chromium.org
BUG=chromium:453805
LOG=n
Please review this at https://codereview.chromium.org/887023003/
Base URL: https://chromium.googleso
https://codereview.chromium.org/772533003/diff/20001/src/builtins.cc
File src/builtins.cc (right):
https://codereview.chromium.org/772533003/diff/20001/src/builtins.cc#newcode606
src/builtins.cc:606: if (object->map() == sloppy_arguments_map &&
Ok, elements of the |aliased_arguments_map| is a sp
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/881783003/1
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
lgtm
https://codereview.chromium.org/881783003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/877243004/20001
https://codereview.chromium.org/877243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/877243004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
This needs a test
https://codereview.chromium.org/885043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving e
Patchset 1 (id:??) landed as
https://crrev.com/0cd991ebc01c3d32fd03e2abff340c31be3be668
Cr-Commit-Position: refs/heads/master@{#26357}
https://codereview.chromium.org/880233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #1 (id:1)
https://codereview.chromium.org/880233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: dcarney,
Message:
PTAL. Instead of embedding the callback and calling runtime, we embed the
accessor index and then fetch the callback in runtime.
Description:
Do not embedd store callback in handler.
BUG=v8:3629
LOG=N
Please review this at https://codereview.chromium.org/881783003/
Reviewers: jarin,
Message:
Hi Jaro,
Here is the fix we discussed, PTAL, thanks!
--Michael
Description:
CallIC used an invalid mechanism to detect if it was in optimized code.
BUG=453481
LOG=N
R=ja...@chromium.org
Please review this at https://codereview.chromium.org/885333002/
Base URL: https
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/880233002/1
https://codereview.chromium.org/880233002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed t
Updates:
Status: WorkingAsIntended
Cc: joc...@chromium.org
Comment #1 on issue 3855 by jkumme...@chromium.org: v8 directory builds fail
https://code.google.com/p/v8/issues/detail?id=3855
Building V8 standalone from inside a Chrome checkout is not supported any
more, because gcl
Patchset 2 (id:??) landed as
https://crrev.com/5d12b2855d14b9723eb77985d92bff6a1f203f8b
Cr-Commit-Position: refs/heads/master@{#26356}
https://codereview.chromium.org/892603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/892603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Updates:
Status: Fixed
Comment #7 on issue 3832 by ish...@chromium.org: Array variable suddenly
becomes number
https://code.google.com/p/v8/issues/detail?id=3832
Please let me know it the problem still persists after Chrome/41.0.2292.
--
You received this message because this project
On 2015/01/30 11:06:26, bnoordhuis wrote:
On 2015/01/30 10:14:59, Yang wrote:
> Not sure about this CL. The flags by themselves are fine. The problem
only
> happens if you multiply the flag values after reading them out when we
> initialize the heap. Can't we simply cast up before multiplying?
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892603002/20001
https://codereview.chromium.org/892603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
lgtm
https://codereview.chromium.org/892603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
https:/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/892603002/20001
https://codereview.chromium.org/892603002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscrib
Patchset 2 (id:??) landed as
https://crrev.com/e25a0f7e4ea567125a1cf8b7687b1a1d6b17fb5e
Cr-Commit-Position: refs/heads/master@{#26355}
https://codereview.chromium.org/892593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Committed patchset #2 (id:20001)
https://codereview.chromium.org/892593002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and s
Reviewers: dcarney,
Message:
PTAL
Description:
Load callback data from weak cell instead of embedding it in handler.
BUG=v8:3629
LOG=N
Please review this at https://codereview.chromium.org/877243004/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+107, -46 lines
Reviewers: Michael Starzinger,
Description:
[turbofan] Fix OSR into functions where the expression stack is not empty.
R=mstarzin...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/890903002/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (
Looking good. Merging some of the very similar tests would be nice
though... I
presume it can be reduced by quite a few lines of testcode, which improves
future maintainability.
https://codereview.chromium.org/888623002/diff/20001/src/objects.cc
File src/objects.cc (right):
https://codereview
1 - 100 of 173 matches
Mail list logo
