Comment #9 on issue 689 by jianghua...@alibaba-inc.com: v8 fails to compile
with icc Intel compilers
https://code.google.com/p/v8/issues/detail?id=689
is this issue sloved?
--
You received this message because this project is configured to send all
issue notifications to this address.
You
lgtm
https://codereview.chromium.org/1018043008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Updates:
Cc: paul.l...@imgtec.com
Comment #1 on issue 3984 by yang...@chromium.org: 3.25.28 jquery crash
https://code.google.com/p/v8/issues/detail?id=3984
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notif
Patchset 5 (id:??) landed as
https://crrev.com/aca7895353e4e4b46124a4873f8119a0a89c33a1
Cr-Commit-Position: refs/heads/master@{#27384}
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1019813004/80001
https://codereview.chromium.org/1019813004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
On 2015/03/23 23:19:35, michael_dawson wrote:
On 2015/03/23 23:12:38, michael_dawson wrote:
> Next PPC port
Now I'm blocked as the next change won't apply until we get these in.
change looks good to me, an owner should be able to lgtm this quickly
https://codereview.chromium.org/1018043008/
Committed patchset #1 (id:1) manually as
b0a290c40d88d13f32ea0e2370c62d2316ca8638.
https://codereview.chromium.org/1019353006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
On 2015/03/23 23:12:38, michael_dawson wrote:
Next PPC port
Now I'm blocked as the next change won't apply until we get these in.
https://codereview.chromium.org/1018043008/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message
Lgtm (rubberstamp)
https://codereview.chromium.org/1019393003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
Reviewers: arv, danno, Dmitry Lomov (chromium), Jakob, mtbrandyberry, Sven
Panne,
Message:
Next PPC port
Description:
PPC: [es6] generate rest parameters correctly for subclass constructors
commit bef80fcfd7e89cadc215f7d10a016a375e346490
Original commit message:
BUG=v8:3977
R=dslo...@chromiu
Reviewers: danno, dcarney, Jakob, mtbrandyberry, Sven Panne, Yang,
Message:
Next PPC port
Description:
PPC: [turbofan] Turn Math.clz32 into an inlinable builtin.
Port 3aa206b86560da94f895625186295bf07a0301d8
Original commit message:
R=dcar...@chromium.org, yang...@chromium.org
BUG=v8:3952
LOG=
Reviewers: danno, Dmitry Lomov (chromium), Jakob, mtbrandyberry, Sven Panne,
Message:
Next PPC port
Description:
PPC: [es6] implement Reflect.apply() & Reflect.construct()
Port d21fd15467e16f185e511dbfbaeef7caddfe804a
Original commit message:
BUG=v8:3900
LOG=N
R=mbra...@us.ibm.com, svenpa...@
Updates:
Labels: Priority-Low
Comment #2 on issue 3983 by rossb...@chromium.org: Incorrect restriction on
binding identifiers of function expressions
https://code.google.com/p/v8/issues/detail?id=3983
(No comment was entered for this change.)
--
You received this message because this
On 2015/03/23 22:29:07, michael_dawson wrote:
Next PPC ports
This one was later backed out, closing
https://codereview.chromium.org/83005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to t
Committed patchset #1 (id:1)
https://codereview.chromium.org/1025303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/fe0d860ba8e045080bef466d1611ec5ffdbf8498
Cr-Commit-Position: refs/heads/master@{#27383}
https://codereview.chromium.org/1025303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Reviewers: danno, Jakob, mtbrandyberry, Sven Panne,
Message:
Next PPC port
Description:
PPC: Serializer: serialize internal references via object visitor.
Port 7c149afb6c875b1c53723384459dc14a0e961927
Original commit message:
R=mbra...@us.ibm.com, svenpa...@chromium.org, da...@chromium.org,
j
Reviewers: danno, Jakob, mtbrandyberry, Sven Panne,
Message:
Next PPC port
Description:
PPC: Load from PropertyCells using PropertyCell::kValueOffset rather than
Cell::kValueOffset
Port dda2bd6f4f952c604ab836f04052684722480849
Original commit message:
R=mbra...@us.ibm.com, svenpa...@chromium.
Reviewers: danno, Jakob, mtbrandyberry, Sven Panne,
Message:
Next PPC ports
Description:
PPC: Merge old data and pointer space.
Port 257ff4893114854519530957c2eeb97c15cd359f
Original commit message:
R=mbra...@us.ibm.com, svenpa...@chromium.org, da...@chromium.org,
jkumme...@chromium.org
BUG=
On 2015/02/25 14:49:09, caitp wrote:
Thanks
https://codereview.chromium.org/938443002/diff/80001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/938443002/diff/80001/src/parser.cc#newcode5497
src/parser.cc:5497: int i = 0;
On 2015/02/25 14:28:18, rossberg wrote:
>
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1025303005/1
https://codereview.chromium.org/1025303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Status: New
Owner:
New issue 3984 by lmarcink...@opera.com: 3.25.28 jquery crash
https://code.google.com/p/v8/issues/detail?id=3984
Version: 3.25.28
OS: Linux
Architecture: mips
Crashed during long term testing (don't have any minimal test):
#0 0x75003810 in v8::internal::OS::Abort() ()
Patchset 1 (id:??) landed as
https://crrev.com/8d4c7fea0da916e50655bfbe0309e50b714b49c5
Cr-Commit-Position: refs/heads/master@{#27382}
https://codereview.chromium.org/1019843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1019843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/890c0eac21919a08ae10782ec3cc40d1381cbd8b
Cr-Commit-Position: refs/heads/master@{#27381}
https://codereview.chromium.org/1016333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1016333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/c277e7efad70f4c3ac512c0fcece223c2dc66cae
Cr-Commit-Position: refs/heads/master@{#27380}
https://codereview.chromium.org/1018333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1018333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Also LGTM. Thanks for the review & the mips32 port Michael!
https://codereview.chromium.org/1025303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsub
LGTM, thanks for the port!
https://codereview.chromium.org/1025303005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop r
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1019843003/1
https://codereview.chromium.org/1019843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1018333003/1
https://codereview.chromium.org/1018333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1016333002/1
https://codereview.chromium.org/1016333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: mvstanton, danno, paul.l..., gergely.kis.imgtec, balazs.kilvady,
dusmil.imgtec,
Message:
PTAL.
Description:
MIPS64: VectorICs: keyed element loads were kicking out non-smi keys
unnecessarily
Port 6689cc27ebe60685c025de9ae1f09919093f8213
Original commit message:
Handlers should be
Reviewers: arv,
Message:
PTAL --- this doesn't deal with bound functions, which apparently shouldn't
have
these properties either.
Unfortunately, it means adding a number (4) of additional maps, and I
couldn't
think of a better name for these than "unpoisoned" variants of other
function
Comment #3 on issue 3028 by lmarcink...@opera.com: d8 crash in GetTypeName
https://code.google.com/p/v8/issues/detail?id=3028
I fight with the same crash on 3.25.28 (mips)
Security context: 0x40d0e095 http://127.0.0.1:9090>
1: GetTypeName(aka GetTypeName) [native messages.js:796] (this=0x4ae080
On 2015/03/23 17:53:09, chunyang.dai wrote:
On 2015/03/23 17:42:49, Dmitry Lomov (chromium) wrote:
>
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc
> File src/x87/code-stubs-x87.cc (left):
>
>
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x
Comment #2 on issue 3982 by caitpott...@gmail.com: Forbidden Extensions on
function objects
https://code.google.com/p/v8/issues/detail?id=3982
I had started a patch for this/v8:3946, just fixing up existing tests atm
--
You received this message because this project is configured to send all
Issue 3946: All functions born of non-legacy function syntactic forms do
not have caller and arguments properties
https://code.google.com/p/v8/issues/detail?id=3946
This issue is now blocking issue v8:3982.
See https://code.google.com/p/v8/issues/detail?id=3982
--
You received this message bec
Updates:
Status: Accepted
Owner: a...@chromium.org
Cc: rossb...@chromium.org dslo...@chromium.org
Labels: Harmony Type-Bug
Blockedon: v8:3946
Comment #1 on issue 3982 by a...@chromium.org: Forbidden Extensions on
function objects
https://code.google.com/
Updates:
Status: Accepted
Owner: wi...@igalia.com
Cc: rossb...@chromium.org a...@chromium.org
Labels: Harmony Type-Bug
Comment #1 on issue 3983 by a...@chromium.org: Incorrect restriction on
binding identifiers of function expressions
https://code.google.com/p/v
lgtm
https://codereview.chromium.org/1018333003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1016333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1019843003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/1b16678f25823f0a2b46f9ca78ac50052198121f
Cr-Commit-Position: refs/heads/master@{#27379}
https://codereview.chromium.org/1017263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1017263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1029643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/11fb202f9637bf89bb40a17283686f6a0605f96c
Cr-Commit-Position: refs/heads/master@{#27378}
https://codereview.chromium.org/1029643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1029643002/1
https://codereview.chromium.org/1029643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1017263003/1
https://codereview.chromium.org/1017263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
It looks like this will be a bit fiddly to fix, so I'd like to revert it
now and unblock your patch.
https://codereview.chromium.org/1019393003/
Thanks,
Jacob
On Monday, 23 March 2015 15:52:33 UTC, vincent@arm.com wrote:
>
> We are looking at it.
>
> On Monday, 23 March 2015 14:17:26 UTC, T
lgtm
https://codereview.chromium.org/1017263003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
lgtm
https://codereview.chromium.org/1029643002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Toon Verwaest,
Description:
Revert "ARM64: use jssp for stack slots"
This reverts r21101. r21101 appears to be at fault for the ARM64
failures here: https://codereview.chromium.org/1023103003
BUG=
Please review this at https://codereview.chromium.org/1019393003/
Base URL: https://c
Reviewers: Igor Sheludko, ulan,
Message:
PTAL
Description:
Properly handle non-JSFunction constructors in CanRetainOtherContext
BUG=
Please review this at https://codereview.chromium.org/1017263003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+7, -9 lines):
Committed patchset #6 (id:120001)
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 6 (id:??) landed as
https://crrev.com/6689cc27ebe60685c025de9ae1f09919093f8213
Cr-Commit-Position: refs/heads/master@{#27377}
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/03/23 15:11:14, wingo wrote:
Some nits. Regarding the log, LOG=N I think as it's just a refactor, and
do
remove the bits about changes that aren't included. Remove the last para
too
as
it just restates the google c++ style guide.
Ack.
https://codereview.chromium.org/1024703004/
Reviewers: titzer,
Description:
Move CompilationInfo::this_has_uses to HGraph::this_has_uses.
R=tit...@chromium.org
Please review this at https://codereview.chromium.org/1029643002/
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_cleanup-compiler-12
Affected files (+26, -32 lin
Reviewers: titzer,
Description:
Remove CompilationInfoWithZone from public API.
This removes the CompilationInfoWithZone class from the header file
because it is more than a pure convenience class and shouldn't be used
outside of the compiler at all.
R=tit...@chromium.org
Please review this at
On 2015/03/23 17:42:49, Dmitry Lomov (chromium) wrote:
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc
File src/x87/code-stubs-x87.cc (left):
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc#oldcode4325
src/x87/code-stubs-x87.cc:4325: __
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1028093002/120001
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc
File src/x87/code-stubs-x87.cc (left):
https://codereview.chromium.org/1019353006/diff/1/src/x87/code-stubs-x87.cc#oldcode4325
src/x87/code-stubs-x87.cc:4325: __ cmp(edx, edi);
Why this comparison and branch got removed?
PTAL.
https://codereview.chromium.org/1019353006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Status: New
Owner:
New issue 3983 by m...@bocoup.com: Incorrect restriction on binding
identifiers of function expressions
https://code.google.com/p/v8/issues/detail?id=3983
Version: 22d62cea4d4d01d30286411cd11a6f3e15083cc0 (Thu Mar 19 08:04:47 2015
-0700)
OS: Ubuntu Linux
Architectur
Reviewers: Dmitry Lomov (chromium),
Description:
Version 4.2.77.12 (cherry-pick)
Merged a3773e4d29e97b912ef284ee62bd8011ef6884af
X87: Implement subclassing Arrays.
R=dslo...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1019353006/
Base URL: https://chromium.googles
Committed patchset #1 (id:1) manually as
fb672f6974fea1b0c5d372afc3b920bd0e2499f6.
https://codereview.chromium.org/1033463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1026513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
PTAL.
https://codereview.chromium.org/1033463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
PTAL.
https://codereview.chromium.org/1033463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Patchset 2 (id:??) landed as
https://crrev.com/7421c7f5989b6e6df98e47eeb3d499c3b9511cbe
Cr-Commit-Position: refs/heads/master@{#27376}
https://codereview.chromium.org/1026513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
lgtm
https://codereview.chromium.org/1033463002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: Dmitry Lomov (chromium),
Description:
Version 4.2.77.11 (cherry-pick)
Merged 8b33fa60691fe3d0d0e2ee6b751b89de6abec626
X87: Disallow subclassing Arrays.
R=dslo...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1033463002/
Base URL: https://chromium.googleso
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1026513004/20001
https://codereview.chromium.org/1026513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1026513004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Patchset 1 (id:??) landed as
https://crrev.com/f42e09aef25afa0ec7e83d006a987eeb44f6474f
Cr-Commit-Position: refs/heads/master@{#27375}
https://codereview.chromium.org/1025333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1025333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Status: New
Owner:
New issue 3982 by m...@bocoup.com: Forbidden Extensions on function objects
https://code.google.com/p/v8/issues/detail?id=3982
Version: 22d62cea4d4d01d30286411cd11a6f3e15083cc0 (Thu Mar 19 08:04:47 2015
-0700)
OS: Ubuntu Linux
Architecture: x64
Various function object
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc
File test/cctest/compiler/test-instruction.cc (right):
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc#newcode43
test/cctest/compiler/test-instruction.cc:43: Comp
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc
File test/cctest/compiler/test-instruction.cc (right):
https://codereview.chromium.org/1026513004/diff/1/test/cctest/compiler/test-instruction.cc#newcode43
test/cctest/compiler/test-instruction.cc:43: Comp
https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):
https://codereview.chromium.org/1030673002/diff/1/src/runtime/runtime-debug.cc#newcode2750
src/runtime/runtime-debug.cc:2750: return isolate->heap()->true_value();
Why can we
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1025333002/1
https://codereview.chromium.org/1025333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
lgtm
https://codereview.chromium.org/1025333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Reviewers: jochen (slow),
Message:
PTAL. This fixes the race for interrupt flags, but doesn't fix the benign
race
for climit.
Description:
Acquire a lock before checking for GC interrupt in JSON parser.
BUG=
Please review this at https://codereview.chromium.org/1025333002/
Base URL: https:
Reviewers: jochen (slow),
Message:
PTAL. This fixes the race for interrupt flags, but doesn't fix the benign
race
for climit.
Description:
Acquire a lock before checking for GC interrupt in JSON parser.
BUG=
Please review this at https://codereview.chromium.org/1025333002/
Base URL: https:
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1022333004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/b563ceac0f95551a128a1403cdbacc7aefcdabaf
Cr-Commit-Position: refs/heads/master@{#27374}
https://codereview.chromium.org/1022333004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1022333004/40001
https://codereview.chromium.org/1022333004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Reviewers: titzer,
Description:
Remove dangerous constructor from CompilationInfoWithZone.
This removes the stub-based constructor from CompilationInfoWithZone
as this class is more than a pure convenience class and only by chance
doesn't have an effect in the destructor.
R=tit...@chromium.org
Reviewers: Dmitry Lomov (chromium),
Message:
dslomov, could you have an early look at this "dynamic strong mode scoping
errors CL?
The approach here is that when binding a script to a context, we check the
free
variables we know of (so, not inside lazy functions) against the context.
This CL
On 2015/03/21 13:42:35, Jakob wrote:
Rubberstamp LGTM (in case you're not familiar with the term: that means
I'm
approving without actually reviewing) so you can land.
IIUC what commit-bot is trying to tell us is that we have to make you guys
committers in addition to being OWNERS.
Thanks
Try jobs failed on following builders:
v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1145)
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/
Committed patchset #11 (id:21)
https://codereview.chromium.org/1018853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group an
Patchset 11 (id:??) landed as
https://crrev.com/0a835afb29eedfc266ecb230cf27b8211b1d0b06
Cr-Commit-Position: refs/heads/master@{#27373}
https://codereview.chromium.org/1018853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messa
We are looking at it.
On Monday, 23 March 2015 14:17:26 UTC, Toon Verwaest wrote:
>
> As far as I can tell this is broken. See
>
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4101
>
> for a repro.
>
> The reason why it is failing is that GenerateCallFunction pus
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1028093002/11
https://codereview.chromium.org/1028093002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Thanks for the comments, Yang. I've uploaded a patch. Note an unrelated
change
in mips, the weakening of an assert that didn't make sense there
anyway...it's
simply that no one ever ran that code :p.
Submitting,
--Michael
https://codereview.chromium.org/1028093002/diff/40001/src/arm/code-stu
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1018853003/21
https://codereview.chromium.org/1018853003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subsc
Reviewers: kozyatinskiy, Yang,
Description:
Make debugger step into bound callbacks passed to Array.forEach.
BUG=chromium:450004
R=yang...@chromium.org, kozyatins...@chromium.org
LOG=N
Please review this at https://codereview.chromium.org/1030673002/
Base URL: https://chromium.googlesource.com
1 - 100 of 261 matches
Mail list logo
