Reviewers: mvstanton,
Message:
Hi Michael,
this patch got reverted yesterday due to a layout test failure. I found the
bug
and fixed it in the second patch set. Please take a look.
Yang
Description:
Reland "Migrate error messages, part 2."
Please review this at https://codereview.chromium.
Comment #11 on issue 3803 by machenb...@chromium.org: Generators-iterators
mjsunit test fails flaky in deoptimizer on gc stress bot
https://code.google.com/p/v8/issues/detail?id=3803
http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/10
ht
few small fixes
https://codereview.chromium.org/1061923005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving em
Reviewers: Weiliang,
Message:
PTAL
Description:
X87: Reland "Add basic crankshaft support for slow-mode for-in to avoid
disabling optimizations"
port 8098253562c7585405f435145e7acf74ff0123f8 (r27898)
original commit message:
BUG=
Please review this at https://codereview.chromium.org/10868130
Patchset 1 (id:??) landed as
https://crrev.com/2af87b3e7ab46ba47daaadc8f0d915e7513b64b6
Cr-Commit-Position: refs/heads/master@{#27903}
https://codereview.chromium.org/1098623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1098623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/tools/clang to 2afd19d64f7c67c73e2052e87fbe4e1bc2a671c9
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1098623002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1098623002/1
https://codereview.chromium.org/1098623002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Fix incorrect use of DCHECK
https://codereview.chromium.org/1061923005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: dcarney, titzer,
Description:
Introducing the LLVM greedy register allocator.
This change aims to introduce the separation of the RegisterAllocator model,
using the initial prototype for RegisterAllocatorGreedy as proof of concept.
Summary:
- new flag, turbo-greedy-regalloc, enabling
Comment #4 on issue 3996 by bugdro...@chromium.org: avoid externalizing
small typed arrays if possible
https://code.google.com/p/v8/issues/detail?id=3996#c4
The following revision refers to this bug:
https://chromium.googlesource.com/v8/v8.git/+/fd7d881e2be920cb1c020a5663bad400833770ee
Patchset 1 (id:??) landed as
https://crrev.com/fd7d881e2be920cb1c020a5663bad400833770ee
Cr-Commit-Position: refs/heads/master@{#27902}
https://codereview.chromium.org/1092783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc
File src/bootstrapper.cc (right):
https://codereview.chromium.org/1069883002/diff/1/src/bootstrapper.cc#newcode194
src/bootstrapper.cc:194: bool is_shared);
On 2015/04/16 14:55:28, jarin wrote:
Could you introduce an enum for
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1092783002/1
https://codereview.chromium.org/1092783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Committed patchset #1 (id:1)
https://codereview.chromium.org/1092783002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Hannes Payer,
Message:
Created Revert of Revert "Remove early bail-out in VisitWeakList to
investigate
chrasher."
Description:
Revert of Revert "Remove early bail-out in VisitWeakList to investigate
chrasher." (patchset #1 id:1 of https://codereview.chromium.org/1080303002/)
Reaso
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1092783002/ by joc...@chromium.org.
The reason for reverting is: Still doesn't work.
https://codereview.chromium.org/1080303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/
As discussed in person, we take dependencies on property cells if the code
depends either on it being a constant or just existing (i.e. not being
deleted).
We could separate the cases in the future.
I just ran across this name and found it confusing as hell.
AssumePropertyCellValid might be be
Patchset 1 (id:??) landed as
https://crrev.com/04b72aa09ffbe81a6fd91443fed91af62ca71292
Cr-Commit-Position: refs/heads/master@{#27901}
https://codereview.chromium.org/1081443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1081443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1081443006/1
https://codereview.chromium.org/1081443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 2 (id:??) landed as
https://crrev.com/db04a5ad6f34da95ad54cda97ca70d6805cc5978
Cr-Commit-Position: refs/heads/master@{#27900}
https://codereview.chromium.org/1052823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #2 (id:20001)
https://codereview.chromium.org/1052823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
lgtm
https://codereview.chromium.org/1081443006/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Committed patchset #1 (id:1)
https://codereview.chromium.org/1086403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/6b59e1f1556a524901aeaa75dc153df21f13f48c
Cr-Commit-Position: refs/heads/master@{#27899}
https://codereview.chromium.org/1086403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 5 (id:??) landed as
https://crrev.com/8098253562c7585405f435145e7acf74ff0123f8
Cr-Commit-Position: refs/heads/master@{#27898}
https://codereview.chromium.org/1086333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1086333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
Try jobs failed on following builders:
v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/1880)
https://codereview.chromium.org/1090813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1052823003/20001
https://codereview.chromium.org/1052823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
I'm working on a native addon for node js that utilizes v8 Promises for
async calls. I have everything wired up appropriately using uv_queue_work()
to queue and then later invoke Resolver::Resolve/Reject. But that's about
as far as the JS execution goes. From the tracing, I can see that the
res
On 2015/04/16 16:30:36, rossberg wrote:
I thought we concluded that it would be weird to allow expressions but not
declarations. And more importantly, that we don't want to encourage users
to
get
into the habit of abusing expressions to work around the limitation. I'd
really
prefer to keep
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1086403002/1
https://codereview.chromium.org/1086403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1086333002/80001
https://codereview.chromium.org/1086333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Thanks for fixing!
https://codereview.chromium.org/1086403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving
lgtm
https://codereview.chromium.org/1086403002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1090813003/40001
https://codereview.chromium.org/1090813003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
lgtm
https://codereview.chromium.org/1086333002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Dry run: CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/981203003/160001
https://codereview.chromium.org/981203003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you ar
LGTM. Only the CL description is off now.
https://codereview.chromium.org/1052823003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this g
https://codereview.chromium.org/1052823003/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1052823003/diff/1/src/deoptimizer.cc#newcode2784
src/deoptimizer.cc:2784: void
Deoptimizer::EnsureCodeForDeoptimizationEntry(Isolate* isolate,
On 2015/04/16 15:32
Patchset 4 (id:??) landed as
https://crrev.com/c96a2d3a742fe789af64387c4796d7aa0a5a494f
Cr-Commit-Position: refs/heads/master@{#27897}
https://codereview.chromium.org/1090963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1090963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
I thought we concluded that it would be weird to allow expressions but not
declarations. And more importantly, that we don't want to encourage users
to get
into the habit of abusing expressions to work around the limitation. I'd
really
prefer to keep it that way.
https://codereview.chromium.
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1090963002/60001
https://codereview.chromium.org/1090963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
Patchset 5 (id:??) landed as
https://crrev.com/8924a9e1b7bb313e854f77a532f48a4ac213e04f
Cr-Commit-Position: refs/heads/master@{#27896}
https://codereview.chromium.org/1094573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #5 (id:80001)
https://codereview.chromium.org/1094573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1094573002/80001
https://codereview.chromium.org/1094573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
... maybe it's not so bad. It's still unclear whether this caused
regression or
not... I couldn't see the graph :(
(Also, perf tryjobs for this might be relevant.)
https://codereview.chromium.org/1094653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-d
LGTM (rubberstamp)
Bummer.
https://codereview.chromium.org/1094653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Committed patchset #1 (id:1)
https://codereview.chromium.org/1089913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/cc01cd94ab39078e99808e2cbb2d78c89a139033
Cr-Commit-Position: refs/heads/master@{#27895}
https://codereview.chromium.org/1089913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1074123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 1 (id:??) landed as
https://crrev.com/e8fe70492102377a0aed8b18f760f839d00d52c9
Cr-Commit-Position: refs/heads/master@{#27894}
https://codereview.chromium.org/1074123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Patchset 1 (id:??) landed as
https://crrev.com/80f24f7a4c2037c677531db21643f20e4dffc789
Cr-Commit-Position: refs/heads/master@{#27893}
https://codereview.chromium.org/1083413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/04/16 15:56:39, mtbrandyberry wrote:
On 2015/04/08 12:38:55, rmcilroy wrote:
> Apologies for the delay - we were working out what we want to do with
the
> current OOL constant pool implementation.
>
> The high level feedback is that we don't want to have yet another
separate
> config
Reviewers: Dmitry Lomov (chromium), rossberg,
Message:
PTAL
Description:
[es6] Allow class expressions in sloppy mode
Class expressions are not dependent on lexical scope so there is no
good reason to not allow them in sloppy mode.
BUG=v8:3330
LOG=N
R=dslo...@chromium.org, rossb...@chromium.or
Committed patchset #1 (id:1)
https://codereview.chromium.org/1083413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Patchset 4 (id:??) landed as
https://crrev.com/b882479f1c84a48961b8aec81fa1bb1225034784
Cr-Commit-Position: refs/heads/master@{#27892}
https://codereview.chromium.org/1095433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #4 (id:60001)
https://codereview.chromium.org/1095433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and
On 2015/04/08 12:38:55, rmcilroy wrote:
Apologies for the delay - we were working out what we want to do with the
current OOL constant pool implementation.
The high level feedback is that we don't want to have yet another separate
configuration for constant pools, however we would be OK with s
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1089913002/1
https://codereview.chromium.org/1089913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
On 2015/04/16 14:44:46, I haz the power (commit-bot) wrote:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
LGTM
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h#newcode126
src/heap/gc-idle-time-handler.h:126: static const size_t
kMax
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1074123004/1
https://codereview.chromium.org/1074123004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1083413003/1
https://codereview.chromium.org/1083413003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
https://codereview.chromium.org/1052823003/diff/1/src/deoptimizer.cc
File src/deoptimizer.cc (right):
https://codereview.chromium.org/1052823003/diff/1/src/deoptimizer.cc#newcode2784
src/deoptimizer.cc:2784: void
Deoptimizer::EnsureCodeForDeoptimizationEntry(Isolate* isolate,
As mentioned offlin
On 2015/04/16 15:09:22, wingo wrote:
On 2015/04/16 15:04:19, wingo wrote:
> I can confirm that this reversion set improves CodeLoad performance.
Hmm, scratch that result. Reapplying the first two, I have the same
CodeLoad
perf. Still investigating.
CodeLoad has a lot of variability for m
On 2015/04/16 15:00:03, ulan wrote:
lgtm
lgtm, thanks.
https://codereview.chromium.org/1090963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubsc
https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc
File src/v8.cc (right):
https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc#newcode80
src/v8.cc:80: if (FLAG_turbo && strcmp(FLAG_turbo_filter, "~") == 0) {
On 2015/04/16 15:16:01, titzer wrote:
As discussed in person,
lgtm
https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc
File src/v8.cc (right):
https://codereview.chromium.org/1094573002/diff/40001/src/v8.cc#newcode80
src/v8.cc:80: if (FLAG_turbo && strcmp(FLAG_turbo_filter, "~") == 0) {
As discussed in person, '~~' for the new default.
http
On 2015/04/16 15:04:19, wingo wrote:
I can confirm that this reversion set improves CodeLoad performance.
Hmm, scratch that result. Reapplying the first two, I have the same
CodeLoad
perf. Still investigating.
https://codereview.chromium.org/1094653002/
--
--
v8-dev mailing list
v8-dev@g
Patchset 1 (id:??) landed as
https://crrev.com/cb08656b6df964b9312a5f73f61f1bdfed371cf0
Cr-Commit-Position: refs/heads/master@{#27891}
https://codereview.chromium.org/1095513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1095513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
I can confirm that this reversion set improves CodeLoad performance.
https://codereview.chromium.org/1094653002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
Hm, the argument in favor of this seems to be akin to goformat, which is
actually pretty good tool (but there is also goimport...). But, pyformat
actually isn't that good, at least I didn't really work for me on my pet
projects. I used autopep8 and it was so-so, but tweaking the rules (say 4
=>
lgtm
https://codereview.chromium.org/1090963002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
The overall direction looks good. Thanks for working on this!
I am not too happy about the duplication of the classes in the API, so I
have
added Jochen to comment on this.
Before this is landed, there should be some better test coverage of all
this.
What are your plans here?
(I am also a
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1086423003/1
https://codereview.chromium.org/1086423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: marja,
Description:
Revert "Factor formal argument parsing into ParserBase"
Revert https://codereview.chromium.org/1078093002/ and follow-on parser
patches due to a perf regression.
This reverts commit 53ddccfc33f7052429e3261e15a2bbabb05760b3.
This reverts commit 71d3213a3f9da3f2ade3
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1095433002/60001
https://codereview.chromium.org/1095433002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscr
fyi, i'm currently rewriting how we keep track of array buffers and views
the tl;dr version is that we'll get rid of all the weak pointers and stop
having
different maps for on-heap and external buffers
https://codereview.chromium.org/1069883002/
--
--
v8-dev mailing list
v8-dev@googlegroups
https://codereview.chromium.org/1095433002/diff/40001/src/dependencies.h
File src/dependencies.h (right):
https://codereview.chromium.org/1095433002/diff/40001/src/dependencies.h#newcode5
src/dependencies.h:5: #ifndef V8_DEPENDENCIES_H_
On 2015/04/16 14:36:42, Michael Starzinger wrote:
suggesti
lgtm
https://codereview.chromium.org/1089393004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from
Thanks for the comments, it's simpler now.
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h
File src/heap/gc-idle-time-handler.h (right):
https://codereview.chromium.org/1090963002/diff/20001/src/heap/gc-idle-time-handler.h#newcode126
src/heap/gc-idle-time-h
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1089913002/1
https://codereview.chromium.org/1089913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
https:/
Patchset 1 (id:??) landed as
https://crrev.com/a0e2dd23cea916eddc9c946f30966e73b217a4f5
Cr-Commit-Position: refs/heads/master@{#27890}
https://codereview.chromium.org/1086423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
On 2015/04/16 14:05:29, mtbrandyberry wrote:
Fix latest PPC breakage.
lgtm
https://codereview.chromium.org/1089913002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev
Reviewers: Igor Sheludko,
Message:
ptal
Description:
Reland "Add basic crankshaft support for slow-mode for-in to avoid disabling
optimizations"
BUG=chromium:476592
LOG=n
Please review this at https://codereview.chromium.org/1086333002/
Base URL: https://chromium.googlesource.com/v8/v8.git@ma
Committed patchset #1 (id:1)
https://codereview.chromium.org/1086423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
On 2015/04/16 14:40:05, Erik Corry Chromium.org wrote:
Lgtm
https://codereview.chromium.org/1086423003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsu
On 2015/04/16 14:18:02, Yang wrote:
On 2015/04/16 14:13:11, Yang wrote:
> On 2015/04/16 14:04:28, Hannes Payer wrote:
> > lgtm
>
> The serializer uses RootIndexMap for lookup. We cache an instance of it
on
the
> isolate. Only non-writable roots are included in the RootIndexMap, and
> test-hea
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1095513003/1
https://codereview.chromium.org/1095513003/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Hannes Payer,
Description:
Make test unthreaded so other tests don't interfere with heap size
R=hpa...@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=
Please review this at https://codereview.chromium.org/1086423003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affec
LGTM. I love it.
https://codereview.chromium.org/1095433002/diff/40001/src/dependencies.h
File src/dependencies.h (right):
https://codereview.chromium.org/1095433002/diff/40001/src/dependencies.h#newcode5
src/dependencies.h:5: #ifndef V8_DEPENDENCIES_H_
suggestion: What do you think about calli
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1095573002/1
https://codereview.chromium.org/1095573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Patchset 1 (id:??) landed as
https://crrev.com/d881baaced6fa4f7839a7678cd0eeb9a5075275d
Cr-Commit-Position: refs/heads/master@{#27889}
https://codereview.chromium.org/1095573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1095573002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: mvstanton, Yang,
Message:
Created Revert of Migrate error messages, part 2.
Description:
Revert of Migrate error messages, part 2. (patchset #1 id:1 of
https://codereview.chromium.org/1086313003/)
Reason for revert:
[Sheriff]: This changes layout test expectations e.g.
http://build.c
1 - 100 of 274 matches
Mail list logo
