lgtm if test fixed.
https://codereview.chromium.org/1136733002/diff/1/test/mjsunit/regress/regress-3960.js
File test/mjsunit/regress/regress-3960.js (right):
https://codereview.chromium.org/1136733002/diff/1/test/mjsunit/regress/regress-3960.js#newcode5
test/mjsunit/regress/regress-3960.js:5: /
I wonder whether it would make sense to move all the implementation to C++.
Getting line ends from a script object is implemented as executable
accessor,
which means we have to jump into runtime anyways. If we have one single
implementation to calculate line ends in C++, we could also save the
Thanks. LGTM
https://codereview.chromium.org/1137703002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving email
Feedback addressed. Please take another look
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc#newcode19
src/code-stubs.cc:19: using namespace v8::internal::compiler;
+Dima
вс, 10 мая 2015, 8:50, Dean McNamee :
> Just to put this specific issue to a close, maybe some of the analysis
> people could share their thoughts. Would hate to hang up this patch
> on a broader question about undefined behaviour in general, and try to
> only declare something wrong here
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc
File src/code-stubs.cc (right):
https://codereview.chromium.org/1137703002/diff/11/src/code-stubs.cc#newcode19
src/code-stubs.cc:19: using namespace v8::internal::compiler;
This violates the style guide. No toplevel usi
Patchset 1 (id:??) landed as
https://crrev.com/0baf67391e2021afe83d3ab0d56b0e6bdf45f284
Cr-Commit-Position: refs/heads/master@{#28329}
https://codereview.chromium.org/1136043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this messag
Committed patchset #1 (id:1)
https://codereview.chromium.org/1136043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
Reviewers: Dmitry Lomov (chromium),
Description:
Version 4.3.61.20 (cherry-pick)
Merged 5f047ff651a51a95f9625aab26c2a4a5f4f37587
X87: Handle the case when derived constructor is [[Call]]ed with 0 args.
R=dslo...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/113257300
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js
File src/promise.js (right):
https://codereview.chromium.org/1098663002/diff/60001/src/promise.js#newcode116
src/promise.js:116: try { deferred.reject(exception); } catch (e) { }
Is this not already handled by the enclosing try
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1136043002/1
https://codereview.chromium.org/1136043002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
Reviewers: Michael Achenbach,
Description:
Update V8 DEPS.
Rolling v8/tools/clang to 5bab78c6ced45a71a8e095a09697ca80492e57e1
TBR=machenb...@chromium.org
Please review this at https://codereview.chromium.org/1136043002/
Base URL: https://chromium.googlesource.com/v8/v8@master
Affected files
ping
https://codereview.chromium.org/1098663002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from i
Not sure if the new bots (running the tests under
the "--turbo_greedy_regalloc"
flag) are included. Added Michael.
https://codereview.chromium.org/1132753005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
Reviewers: Jakob,
Description:
Postpone counters triggered during GC, and use a HandleScope when calling
back.
R=jkumme...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1125383007/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+64, -
Unfortunately the crashes are still there and I can see why. This patch
does
not go far enough. Although we reserve some space already at startup we
unreserve it after each GC (in UncommitMarkingDeque) and then it can
potentially
fail at the next GC.
https://codereview.chromium.org/1134743
https://codereview.chromium.org/1132753005/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, sen
LGTM. Thanks so much for catching that Jakob.
https://codereview.chromium.org/1132113004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from th
Reviewers: jarin,
Message:
Updates to the greedy allocator. The main progress here is that the bots
testing
this should pass; I'm still chasing perf.
Description:
Greedy allocator: Considering conflicts when deciding where to split a
losing range. Some weight calculation tuning. Rudimentary a
Just to put this specific issue to a close, maybe some of the analysis
people could share their thoughts. Would hate to hang up this patch
on a broader question about undefined behaviour in general, and try to
only declare something wrong here if there is an articulable concern
about this specific
Updates:
Status: WontFix
Comment #1 on issue 4092 by a...@chromium.org: need browser wndows
https://code.google.com/p/v8/issues/detail?id=4092
(No comment was entered for this change.)
--
You received this message because this project is configured to send all
issue notifications to t
Reviewers: Yang,
Description:
Only record one in n line endings to save space.
R=yang...@chromium.org
BUG=
Please review this at https://codereview.chromium.org/1137683003/
Base URL: https://chromium.googlesource.com/v8/v8.git@master
Affected files (+357, -123 lines):
M src/debug.cc
M src
This is in Canary 2396
It is referenced from
https://code.google.com/p/chromium/issues/detail?id=486005
https://codereview.chromium.org/1105293004/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed
This is part of canary 2397
https://codereview.chromium.org/1134743002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
This is part of canary 2395
https://codereview.chromium.org/1124553007/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop
25 matches
Mail list logo
