[v8-dev] Re: WIP: Compute the heap growing factor based on mutator utilization. (issue 1163143009 by u...@chromium.org)

2015-06-14 Thread hpayer
lgtm https://codereview.chromium.org/1163143009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Add test for code caching API. (issue 1180113002 by yang...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/50be4425154a916d54b21b505aa35f77ccf6d8ba Cr-Commit-Position: refs/heads/master@{#29012} https://codereview.chromium.org/1180113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Add test for code caching API. (issue 1180113002 by yang...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1180113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Hello, Danno & Titizer. PTAL. thanks. https://codereview.chromium.org/1179763004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this gro

[v8-dev] Re: [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/f588b1c55030db751f6e9dde08b572a859149754 Cr-Commit-Position: refs/heads/master@{#29011} https://codereview.chromium.org/1182303003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1182303003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182303003/1 https://codereview.chromium.org/1182303003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread weiliang . lin
LGTM, but CL still needs LGTM from V8 team. @danno, @Titzer Thanks -Weiliang https://codereview.chromium.org/1179763004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev

[v8-dev] Re: [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread svenpanne
lgtm https://codereview.chromium.org/1182303003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Version 4.3.61.29 (cherry-pick) (issue 1186043002 by chunyang....@intel.com)

2015-06-14 Thread mvstanton
lgtm https://codereview.chromium.org/1186043002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread weiliang . lin
please run "git cl format" before uploading patch. https://codereview.chromium.org/1179763004/diff/11/src/compiler/x87/instruction-selector-x87.cc File src/compiler/x87/instruction-selector-x87.cc (right): https://codereview.chromium.org/1179763004/diff/11/src/compiler/x87/instruction-s

[v8-dev] Re: Add test for code caching API. (issue 1180113002 by yang...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1180113002/1 https://codereview.chromium.org/1180113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: [turbofan] Remove unused typedef VirtualRegisterSet. (issue 1179913003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/dc3712c87380ffa106e8a704ccafb753e1c7dd64 Cr-Commit-Position: refs/heads/master@{#29010} https://codereview.chromium.org/1179913003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [turbofan] Remove unused typedef VirtualRegisterSet. (issue 1179913003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1179913003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread bmeurer
Hey Sven, Some simple cleanup. Please take a look. Thanks, Benedikt https://codereview.chromium.org/1182303003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group.

[v8-dev] [turbofan] Remove unused typedef VirtualRegisterSet. (issue 1179913003 by bmeu...@chromium.org)

2015-06-14 Thread 'Benedikt Meurer' via codereview.chromium.org
Reviewers: Sven Panne, Description: [turbofan] Remove unused typedef VirtualRegisterSet. TBR=svenpa...@chromium.org Please review this at https://codereview.chromium.org/1179913003/ Base URL: https://chromium.googlesource.com/v8/v8.git@master Affected files (+0, -1 lines): M src/compiler/in

[v8-dev] Re: [turbofan] Remove unused typedef VirtualRegisterSet. (issue 1179913003 by bmeu...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1179913003/1 https://codereview.chromium.org/1179913003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] [turbofan] Mark MachineType as uint16_t. (issue 1182303003 by bmeu...@chromium.org)

2015-06-14 Thread 'Benedikt Meurer' via codereview.chromium.org
Reviewers: Sven Panne, Description: [turbofan] Mark MachineType as uint16_t. This fixes a few funky implicit conversions for the enum (that are inconsistent across compilers) and also helps to save space, i.e. for the representations_ vector in the InstructionSequence. R=svenpa...@chromium.org

[v8-dev] Re: MIPS: Implemented PC-relative instructions for R6. (issue 1144373003 by ilija.pavlovic.img...@gmail.com)

2015-06-14 Thread paul . lind
All the comments in test-assembler-mips64.cc likely also apply to test-assembler-mips.cc also. Sorry, I was somewhat in-accurate in my previous review comments on that file, and I may have misled you a bit about the runtime vs generation time issues. I think it is clear now. https://coderev

[v8-dev] X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Reviewers: Weiliang, Message: PTAL. Description: X87: enable the X87 turbofan support. This patch includes the following changes. 1, Enable the turbofan backend support for X87 platform. It depends on previous CL: 3fdfebd26. 2, Enable the test cases which are disabled because tu

[v8-dev] Re: Update V8 DEPS. (issue 1190473002 by v8-autor...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/4926) https://codereview.chromium.org/1190473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.g

[v8-dev] Update V8 DEPS. (issue 1190473002 by v8-autor...@chromium.org)

2015-06-14 Thread 'v8-autoroll' via codereview.chromium.org
Reviewers: Michael Achenbach, Description: Update V8 DEPS. Rolling v8/third_party/android_tools to ed3dde6470c39b196c70f0c20374894d169754ec Rolling v8/tools/clang to 4885e24a9781ff56a6722ff6e1e0267d6b60cc6c TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1

[v8-dev] Re: Update V8 DEPS. (issue 1190473002 by v8-autor...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1190473002/1 https://codereview.chromium.org/1190473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Version 4.3.61.29 (cherry-pick) (issue 1186043002 by chunyang....@intel.com)

2015-06-14 Thread chunyang . dai
Reviewers: mvstanton, Description: Version 4.3.61.29 (cherry-pick) Merged 9bf64f7e614d55766385c122a99c1e7070cd9d2b X87: Ensure object literal element boilerplates aren't modified. R=mvstan...@chromium.org BUG= Please review this at https://codereview.chromium.org/1186043002/ Base URL: https:

[v8-dev] 2015 high quality 4x4 accessories-from Guangzhou Unity 4WD

2015-06-14 Thread 'Nicole-Unity 4wd offroad' via v8-dev
Dear friend :) I am lynn from Unity 4wd accessories factory Unity 4WD Accessories Factory is a professional manufacturer of air lockers since 2007 , And Unity 4wd has specialized in manufacturing a large range of 4WD accessories from recovery equipment to 4-wheel driving touring accessories

[v8-dev] Re: Version 4.5.53.1 (cherry-pick) (issue 1179423004 by machenb...@chromium.org)

2015-06-14 Thread 'Michael Achenbach' via codereview.chromium.org
Committed patchset #1 (id:1) manually as 5105add58d12c5a2e4490fc9780b63be2117c3c4. https://codereview.chromium.org/1179423004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v

[v8-dev] Version 4.5.53.1 (cherry-pick) (issue 1179423004 by machenb...@chromium.org)

2015-06-14 Thread 'Michael Achenbach' via codereview.chromium.org
Reviewers: jochen, Description: Version 4.5.53.1 (cherry-pick) Merged a99fe1fd765d1302bec777ee36ebdb0d3216384e Revert of Reland "Keep track of array buffers in new space separately" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/) BUG=v8:3996 LOG=N R=joc...@chromium.org

[v8-dev] Re: Issue 3996 in v8: Improve typed array performance

2015-06-14 Thread codesite-noreply via v8-dev
Comment #36 on issue 3996 by bugdro...@chromium.org: Improve typed array performance https://code.google.com/p/v8/issues/detail?id=3996#c36 The following revision refers to this bug: https://chromium.googlesource.com/v8/v8.git/+/a99fe1fd765d1302bec777ee36ebdb0d3216384e commit a99fe1fd76

[v8-dev] Re: Revert of Reland "Keep track of array buffers in new space separately" (issue 1186613007 by joc...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/a99fe1fd765d1302bec777ee36ebdb0d3216384e Cr-Commit-Position: refs/heads/master@{#29009} https://codereview.chromium.org/1186613007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Reland "Keep track of array buffers in new space separately" (issue 1177083003 by joc...@chromium.org)

2015-06-14 Thread jochen
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1186613007/ by joc...@chromium.org. The reason for reverting is: Still broken. https://codereview.chromium.org/1177083003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/gr

[v8-dev] Revert of Reland "Keep track of array buffers in new space separately" (issue 1186613007 by joc...@chromium.org)

2015-06-14 Thread jochen
Reviewers: Hannes Payer, Message: Created Revert of Reland "Keep track of array buffers in new space separately" Description: Revert of Reland "Keep track of array buffers in new space separately" (patchset #2 id:20001 of https://codereview.chromium.org/1177083003/) Reason for revert: Sti

[v8-dev] Re: Revert of Reland "Keep track of array buffers in new space separately" (issue 1186613007 by joc...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1186613007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Revert of Reland "Keep track of array buffers in new space separately" (issue 1186613007 by joc...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1186613007/1 https://codereview.chromium.org/1186613007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed

[v8-dev] Re: Issue 2198 in v8: Implement block scoping

2015-06-14 Thread codesite-noreply via v8-dev
Comment #31 on issue 2198 by subsoni...@gmail.com: Implement block scoping https://code.google.com/p/v8/issues/detail?id=2198 Yes. In fact, Babel, Traceur and other transpilers already support `let` and `const` in sloppy mode, see https://kangax.github.io/compat-table/es6/. -- You received t

[v8-dev] Re: Issue 2198 in v8: Implement block scoping

2015-06-14 Thread codesite-noreply via v8-dev
Comment #30 on issue 2198 by manolova...@gmail.com: Implement block scoping https://code.google.com/p/v8/issues/detail?id=2198 Will this be ever available outside of strict mode? -- You received this message because this project is configured to send all issue notifications to this address.

[v8-dev] Re: Update V8 DEPS. (issue 1183753006 by v8-autor...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/4924) https://codereview.chromium.org/1183753006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.g

[v8-dev] Update V8 DEPS. (issue 1183753006 by v8-autor...@chromium.org)

2015-06-14 Thread 'v8-autoroll' via codereview.chromium.org
Reviewers: Michael Achenbach, Description: Update V8 DEPS. Rolling v8/third_party/android_tools to ed3dde6470c39b196c70f0c20374894d169754ec TBR=machenb...@chromium.org Please review this at https://codereview.chromium.org/1183753006/ Base URL: https://chromium.googlesource.com/v8/v8@master

[v8-dev] Re: Update V8 DEPS. (issue 1183753006 by v8-autor...@chromium.org)

2015-06-14 Thread 'commit-bot: I haz the power' via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1183753006/1 https://codereview.chromium.org/1183753006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed